[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

gkorepanov...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |gkorepanov...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

--- Comment #23 from gkorepanov...@gmail.com ---
Hi! I would like to assign myself for this bug, but now I'm quite stuck on
where may I find files containing code responsible for drawing page break lines
(I wanna complete the second part of the task by making the line dashed, since
now it is still hardly visible).

I'd be very grateful for giving some code pointers and probably some helpful
information.

Till I get any answer, I'm going to try to learn it by myself, but I'm not sure
it is gonna be effective.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

jan iversen  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

--- Comment #22 from jan iversen  ---
(In reply to V Stuart Foote from comment #21)
> @Jan, *
> 
> Colors are corrected, but adjusting the line styles for the manual page
> breaks to dashed remains to be done.  In closing this, were you going to
> spin that off as a new easyHack and link back to this issue?
> 
> Stuart

No I had no intention of that, I reviewed the patch and it looked solved, but
now we have a comment with what remains to be done, so open again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

--- Comment #21 from V Stuart Foote  ---
@Jan, *

Colors are corrected, but adjusting the line styles for the manual page breaks
to dashed remains to be done.  In closing this, were you going to spin that off
as a new easyHack and link back to this issue?

Stuart

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

jan iversen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 Whiteboard|ToBeReviewed|

--- Comment #20 from jan iversen  ---
Seems solved

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

jan iversen  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0 target:5.1.0.1 |ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

Akshay Deep  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|akshaydeepi...@gmail.com|libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

Akshay Deep  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |akshaydeepi...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|easyHack DifficultyBeginner |easyHack DifficultyBeginner
   |TopicUI SkillCpp|TopicUI SkillCpp
   ||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

--- Comment #10 from Commit Notification 
 ---
Aybuke Ozdemir committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=22d4b98da59c9821e72cc1d4f9d94d57b7a12d51

tdf#87933 easier visibility of automatic page breaks

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|easyHack DifficultyBeginner |easyHack DifficultyBeginner
   |TopicUI SkillCpp|TopicUI SkillCpp
   |target:5.2.0|target:5.2.0 target:5.1.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

--- Comment #11 from Commit Notification 
 ---
Aybuke Ozdemir committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=52ac1a717b1869cb7d2ee710f50a15e216ced76c=libreoffice-5-1

tdf#87933 easier visibility of automatic page breaks

It will be available in 5.1.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #7 from m.a.riosv  ---
Created attachment 121053
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121053=edit
Screenshot 5.0.4-5.1.0-5.2.0 side by side

Seems fixed from 5.1, maybe could be added to the 5.1 release notes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

--- Comment #8 from V Stuart Foote  ---
(In reply to m.a.riosv from comment #7)
> Created attachment 121053 [details]
> Screenshot 5.0.4-5.1.0-5.2.0 side by side
> 
> Seems fixed from 5.1, maybe could be added to the 5.1 release notes.

Sorry, but this has not been adjusted in source yet. 

Believe you are displaying manual page breaks (the #2300dc blue assigned to
CALCPAGEBREAKMANUAL), with some other color customizations in your 5.0.4 and
5.1.0 configuration in the screen clips.

This was adjusting the mix of base grid and the automatic page break lines,
your clips don't show enough of the sheet to include the automatic page break
lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

--- Comment #6 from V Stuart Foote  ---
I prefer not to have a Blue based automatic page break. Adjustment to color of
the solid lines is a good start.

So rather than COL_LIGHTGRAY (#c0c0c0) for the grids and COL_GRAY (#808080) for
the page break, lightening the calc grid to #cc  (standard.soc GRAY 3) and
the page break to the darker #66 (standard.soc GRAY 7) makes the UI more
readable.

https://gerrit.libreoffice.org/#/c/19706/ accomplishes just that. Half of Jay's
proposal 1a.

But, I do have some concern over adding single RGB hex values to colorcfg.cxx
for specific color needs piecemeal across the UI. 

Rather than assigning them in per attribute in colorcfg.cxx seems we should
define additional named colors in the
http://opengrok.libreoffice.org/xref/core/include/tools/color.hxx header file. 
And then assign those.

At least a COL_GRAY3 and a COL_GRAY7, but perhaps define the names for a full
set from the standard .soc?

That would probably be the better way to do this and similar color tweaks in
the future.

The work to convert the page breaks from solid lines to dashed lines could then
be done as a new EasyHack?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

--- Comment #9 from m.a.riosv  ---
There is not color customization for color scheme, only grid line color in
Menu/Tools/Options/LibreOffice calc/View - visual aids - color -> chart3 for
5.0.4 and 5.1.0

Anyway please forgive the misunderstood.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

Joel Madero  changed:

   What|Removed |Added

 CC||jmadero@gmail.com

--- Comment #5 from Joel Madero  ---
What's the status of this bug? I see a patch was committed and reviewed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

--- Comment #3 from aybuke  ---
Hi, I sent following patch for this bug:
https://gerrit.libreoffice.org/#/c/19706/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl,
   ||tietze.he...@gmail.com,
   ||vstuart.fo...@utsa.edu

--- Comment #4 from Yousuf (Jay) Philips  ---
@Heiko, @Stuart, @Cor: What is your take on this? Use a dark gray or a blue for
automatic page breaks?

It seems we have three colors for page breaks

0x80 (Dark Blue) - CALCPAGEBREAK
Used in Page Break View (View > Page Break)

0x2300dc (Blue) - CALCPAGEBREAKMANUAL
Used when manual page breaks are added to a sheet (Sheet > Insert Page Break)

0x808080 (Gray) - CALCPAGEBREAKAUTOMATIC
Automatically added to show the boundaries of pages when printed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

Katarina Behrens (CIB)  changed:

   What|Removed |Added

 Whiteboard|needsDevEval topicUI|easyHack DifficultyBeginner
   ||TopicUI SkillCpp

--- Comment #2 from Katarina Behrens (CIB)  ---
Easy hack indeed, very easy when it comes to changing the default colour
(relevant colours live here: include/svtools/colorcfg.hxx)

DifficultyInteresting for drawing the dashed line, it requires some code
reading/digging around so as how to actually do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 CC||bu...@bubli.org,
   ||er...@redhat.com
  Component|ux-advise   |Calc
 Whiteboard||needsDevEval topicUI

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87933] Easier visibility of automatic page breaks

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=87933

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
I agree the visibility could be improved.

I am still a little bit undecided, but currently I personally would as a
standard tend more to the proposal 1a to have not too much maybe irritating
colours in the normal view, although you can of course change the colour in the
TOOLS - OPTIONS menu, so that the colour can be changed easily.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs