[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||143781 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports and tasks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 --- Comment #50 from Sarrah --- (In reply to Łukasz Hryniuk from comment #30) > (In reply to jan iversen from comment #29) > > A polite ping, are you still working on this ? > > Yes. For now more than half of functions listed at the beginning are > improved and I've written unit and performance tests for few of the rest. I > have to implement one thing in mdds - way to work on two matrices at once - > and use it in remaining functions. I'll try to do it as soon as possible. Hey, just wondering if you were able to implement the way to work on two matrices at once using walk() method or iterator, as most of the functions reliant on that still use loops on rely on loops or use lcl_MatrixCalculation, which in turn also uses nested loops. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 --- Comment #49 from Buovjaga --- (In reply to Sarrah from comment #48) > Right, thanks! Had a vague idea based on the comments as I mentioned in > comment 44 too, however I couldn't find the CalculatePearsonCovar() and > CalculateSlopeIntercept() functions, (atleast in the same file as the > others) hence asked. On studying all commits that tag this issue, I have > found the last patch made for GCD and LCM functions, and then a few on > another issue to resolve a bug in strings caused by this patch. I'll be > trying to work on the ScInterpreter::CheckMatrix, as I see it still uses a > for loop to iterate, and try to keep patch 34110 as a reference. However, on > the off-chance that there is something different about this function I > should know to avoid the same bugs, do let me know. You can find the functions via git grep. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 --- Comment #48 from Sarrah --- (In reply to Buovjaga from comment #47) > (In reply to Sarrah from comment #46) > > (In reply to Buovjaga from comment #45) > > > (In reply to Sarrah from comment #44) > > > > Since the last patch (Comment 42), are the rest of the functions > > > > (ScInterpreter::CalculatePearsonCovar, > > > > ScInterpreter::CalculateSlopeIntercept, etc) still available to be > > > > worked > > > > on? If yes, I would like to work on them. > > > > > > You mean if anyone else is working on them? I'm not seeing any open patch > > > at > > > least: https://gerrit.libreoffice.org/q/message:89387+status:open > > > > Yeah, both if anybody is working on it and which, if any of the functions > > still need to be worked on, with a similar template as given in the > > description. > > Kinda doing your homework for you, but based on comment 37 and the commit in > comment 42, these are still left: > ScInterpreter::CalculatePearsonCovar > ScInterpreter::CalculateSlopeIntercept > lcl_MatrixCalculation in interpr5.cxx > ScInterpreter::CheckMatrix Right, thanks! Had a vague idea based on the comments as I mentioned in comment 44 too, however I couldn't find the CalculatePearsonCovar() and CalculateSlopeIntercept() functions, (atleast in the same file as the others) hence asked. On studying all commits that tag this issue, I have found the last patch made for GCD and LCM functions, and then a few on another issue to resolve a bug in strings caused by this patch. I'll be trying to work on the ScInterpreter::CheckMatrix, as I see it still uses a for loop to iterate, and try to keep patch 34110 as a reference. However, on the off-chance that there is something different about this function I should know to avoid the same bugs, do let me know. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 --- Comment #47 from Buovjaga --- (In reply to Sarrah from comment #46) > (In reply to Buovjaga from comment #45) > > (In reply to Sarrah from comment #44) > > > Since the last patch (Comment 42), are the rest of the functions > > > (ScInterpreter::CalculatePearsonCovar, > > > ScInterpreter::CalculateSlopeIntercept, etc) still available to be worked > > > on? If yes, I would like to work on them. > > > > You mean if anyone else is working on them? I'm not seeing any open patch at > > least: https://gerrit.libreoffice.org/q/message:89387+status:open > > Yeah, both if anybody is working on it and which, if any of the functions > still need to be worked on, with a similar template as given in the > description. Kinda doing your homework for you, but based on comment 37 and the commit in comment 42, these are still left: ScInterpreter::CalculatePearsonCovar ScInterpreter::CalculateSlopeIntercept lcl_MatrixCalculation in interpr5.cxx ScInterpreter::CheckMatrix -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 --- Comment #46 from Sarrah --- (In reply to Buovjaga from comment #45) > (In reply to Sarrah from comment #44) > > Since the last patch (Comment 42), are the rest of the functions > > (ScInterpreter::CalculatePearsonCovar, > > ScInterpreter::CalculateSlopeIntercept, etc) still available to be worked > > on? If yes, I would like to work on them. > > You mean if anyone else is working on them? I'm not seeing any open patch at > least: https://gerrit.libreoffice.org/q/message:89387+status:open Yeah, both if anybody is working on it and which, if any of the functions still need to be worked on, with a similar template as given in the description. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 --- Comment #45 from Buovjaga --- (In reply to Sarrah from comment #44) > Since the last patch (Comment 42), are the rest of the functions > (ScInterpreter::CalculatePearsonCovar, > ScInterpreter::CalculateSlopeIntercept, etc) still available to be worked > on? If yes, I would like to work on them. You mean if anyone else is working on them? I'm not seeing any open patch at least: https://gerrit.libreoffice.org/q/message:89387+status:open -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 Sarrah changed: What|Removed |Added CC||sabastawala_...@it.vjti.ac. ||in --- Comment #44 from Sarrah --- Since the last patch (Comment 42), are the rest of the functions (ScInterpreter::CalculatePearsonCovar, ScInterpreter::CalculateSlopeIntercept, etc) still available to be worked on? If yes, I would like to work on them. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 --- Comment #43 from ad...@shinnok.com --- A polite ping, still working on this issue? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 --- Comment #42 from Commit Notification --- giacco committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c995531d8a7c97f684f2e65707c7b3f87a0ba372 tdf#89387 improve performance for some matrix operations It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 Commit Notification changed: What|Removed |Added Whiteboard|target:4.5.0 target:5.1.0 |target:4.5.0 target:5.1.0 |target:5.0.2 target:5.0.1 |target:5.0.2 target:5.0.1 ||target:5.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 filippo changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|filippo.giac...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 filippo changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |filippo.giac...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 filippo changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|tamsaj...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #34 from filippo --- hi, I would work on this bug, 'cose I like matrix operation. I would like to know if the bug requires to optimize algorihtms of matrix operations (in terms of computational cost) or to speed them up on GPU.. furthermore,witch algorithms are still to be modified? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 Tamsil Amani changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |tamsaj...@gmail.com |desktop.org | --- Comment #33 from Tamsil Amani --- I'm starting to work on it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 Łukasz Hryniuk changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|lukasz.hryn...@wp.pl|libreoffice-b...@lists.free ||desktop.org --- Comment #32 from Łukasz Hryniuk --- (In reply to jan iversen from comment #31) > Lukasz@ Still working on this patch (otherwise please unsaying yourself) ? No, I didn't manage to finish a patch I've started. Sorry for keeping it assigned so long. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 Łukasz Hryniuk changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |lukasz.hryn...@wp.pl |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 Łukasz Hryniuk changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 Łukasz Hryniuk changed: What|Removed |Added Assignee|lukasz.hryn...@wp.pl|libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 Łukasz Hryniuk changed: What|Removed |Added CC||lukasz.hryn...@wp.pl Assignee|libreoffice-b...@lists.free |lukasz.hryn...@wp.pl |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 --- Comment #2 from Markus Mohrhard --- Some more functions that would benefit from that: ScInterpreter::CalculatePearsonCovar ScInterpreter::CalculateSlopeIntercept ScInterpreter::ScForecast ScInterpreter::ScTTest (at least for the fType == 1.0 case, others need to be checked) ScInterpreter::ScFTest ScInterpreter::ScChiTest ScInterpreter::ScGCD ScInterpreter:: ScLCM lcl_MatrixCalculation in interpr5.cxx ScInterpreter::ScAmpersand ScInterpreter::ScMul ScInterpreter::ScDiv ScInterpreter::ScPow ScInterpreter::CalculateSumX2MY2SumX2DY2 ScInterpreter::ScSumXMY2 ScInterpreter::CheckMatrix Please note that many of them may require some more work and may not be as easy as the ones above. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 Markus Mohrhard changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Whiteboard||EasyHack DifficultyBeginner ||SkillCpp TopicDebug --- Comment #1 from Markus Mohrhard --- Making it an easy hack. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs