[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 Julien Nabet changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |michael.me...@collabora.com |desktop.org | --- Comment #12 from Julien Nabet --- Considering Michael's patches, let's consider this one as FIXED. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 --- Comment #11 from Commit Notification --- Michael Meeks committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0fb49c071f8f6b1569a8cf20f7fc598b098b1eb5&h=libreoffice-5-0 tdf#91715: lock SolarMutex from dbaui::~ODatabaseAdministrationDialog() It will be available in 5.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 Commit Notification changed: What|Removed |Added Whiteboard|bibisected target:5.1.0 |bibisected target:5.1.0 ||target:5.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 Commit Notification changed: What|Removed |Added Whiteboard|bibisected |bibisected target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 --- Comment #10 from Commit Notification --- Michael Meeks committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a7375e372ee9583d31d44a7cc7b6a21e6197bf1 tdf#91715: lock SolarMutex from dbaui::~ODatabaseAdministrationDialog() It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 Michael Meeks changed: What|Removed |Added CC||mst...@redhat.com --- Comment #9 from Michael Meeks --- Michael - any thoughts of my banal but potentially correct patch to GenericUnoDialog ? =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 --- Comment #8 from Julien Nabet --- Michael: I gave a try to the patch you proposed, it seems it doesn't crash anymore with this! :) However, here's what I get on console after having clicked on Cancel button: warn:legacy.osl:3186:15:svtools/source/uno/genericunodialog.cxx:323: OGenericUnoDialog::OnDialogDying: where does this come from? warn:sal.osl:3186:13:sal/osl/unx/socket.cxx:1800: receive socket [0] failed: EOL warn:binaryurp:3186:13:binaryurp/source/reader.cxx:123: caught UNO exception 'acc_socket.cxx:SocketConnection::read: error - Success' warn:binaryurp:3186:13:binaryurp/source/bridge.cxx:846: undisposed bridge, potential deadlock ahead But perhaps it's normal (after all, they're just warnings). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715
Michael Meeks changed:
What|Removed |Added
Status|NEW |NEEDINFO
Blocks|91310 |
--- Comment #7 from Michael Meeks ---
Hmm; the error here is:
#2 0x7efe51a4cb86 in __assert_fail_base (fmt=0x7efe51b9d830 "%s%s%s:%u:
%s%sAssertion `%s' failed.\n%n",
assertion=assertion@entry=0x7efe4b9f1990
"ImplGetSVData()->mpDefInst->CheckYieldMutex() && \"SolarMutex not locked\"",
file=file@entry=0x7efe4b9f1948
That looks like a pretty normal UNO / threading issue that is unrelated to
VclPtr; and appears to be related to the new timer/idle work.
I guess we are simply not holding the SolarMutex while we're cleaning up all
this VCL stuff. Then again - UNO & threading is a horrendous tangled mess from
beginning to end.
To fix the assert; it would be worth trying the patch below - through 'make
check' and also your use-case.
diff --git a/svtools/source/uno/genericunodialog.cxx
b/svtools/source/uno/genericunodialog.cxx
index 4b7f82f..6cabb2b1 100644
--- a/svtools/source/uno/genericunodialog.cxx
+++ b/svtools/source/uno/genericunodialog.cxx
@@ -313,6 +313,7 @@ void SAL_CALL OGenericUnoDialog::initialize( const
Sequence< Any >& aArguments )
void OGenericUnoDialog::destroyDialog()
{
+SolarMutexGuard aSolarGuard;
m_pDialog.disposeAndClear();
}
Can you confirm that works ? if so, lets get it in.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 Julien Nabet changed: What|Removed |Added Blocks||91310 --- Comment #6 from Julien Nabet --- Noticing VclPtr part, I put this one as blocker for tdf#91310 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #5 from Julien Nabet --- Created attachment 116190 --> https://bugs.documentfoundation.org/attachment.cgi?id=116190&action=edit console+bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this. I attached console logs+bt Indeed, I noticed this: warn:vcl:15664:10:vcl/generic/app/geninst.cxx:119: CheckYieldMutex: 1!=10 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 --- Comment #4 from Matthew Francis --- Small error in the instructions in comment 1 - to get the correct pyuno installation with system python, the environment variables to set (from within your build directory) to run ./tdf91715.py are: PYTHONPATH=$PWD/instdir/program URE_BOOTSTRAP="vnd.sun.star.pathname:$PWD/instdir/program/fundamentalrc" -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 --- Comment #3 from Matthew Francis --- Created attachment 116122 --> https://bugs.documentfoundation.org/attachment.cgi?id=116122&action=edit Linux 5.1 master backtrace -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 Matthew Francis changed: What|Removed |Added Keywords||have-backtrace -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 Matthew Francis changed: What|Removed |Added Keywords||bisected, regression Status|UNCONFIRMED |NEW CC||tobias.madl@gmail.com Ever confirmed|0 |1 Whiteboard||bibisected --- Comment #2 from Matthew Francis --- Setting to NEW as a commit (range) has been identified: This began somewhere in the range 9e678c14e4fc8e58b1e0530744f648fa3958d338..d05a64df34fd143670cb939b72abfb32d6b714c7 which is the Timer/Idle work Adding Cc: to tobias.madl@gmail.com; Could you possibly take a look at this one? Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91715] Database wizard crashes when invoked through remote UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=91715 Matthew Francis changed: What|Removed |Added CC||fdb...@neosheffield.co.uk --- Comment #1 from Matthew Francis --- Created attachment 116121 --> https://bugs.documentfoundation.org/attachment.cgi?id=116121&action=edit Reproduction script Reproduction steps: With a master build, - In one terminal: instdir/program/soffice --accept="socket,host=localhost,port=2002;urp;" --invisible - In another terminal: UNO_PATH=$PWD/instdir ./tdf91715.py - Then, when the database wizard appears, either cancel it or finish it -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
