[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

ahmad_g  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |ganzour...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #26 from ahmad_g  ---
(In reply to Heiko Tietze from comment #25)
> (In reply to ahmad_g from comment #24)
> > Could it be done by changing this line to locked(true)?
> > 
> > Code pointer :
> > https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/
> > windowstateconfiguration.cxx?r=8c6ca694#156
> 
> Think it was Samuel's idea in comment 23

Yup, i saw the comment. i was just trying to apply it and build it to make sure
it's valid so i was asking to verify the line i was thinking of it's the one to
be changed but it made no change when i build it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #25 from Heiko Tietze  ---
(In reply to ahmad_g from comment #24)
> Could it be done by changing this line to locked(true)?
> 
> Code pointer :
> https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/
> windowstateconfiguration.cxx?r=8c6ca694#156

Think it was Samuel's idea in comment 23.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #24 from ahmad_g  ---
(In reply to Heiko Tietze from comment #22)
> Flagged my hesitation comments as obsolete. Toolbars should become locked by
> default and have to get unlocked manually. It requires to add the property
> Locked=true in *WindowState.xcu (and reset the profile).
> 
> For example,
> officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
> 
> 
> ... 
>   
> true
>   
> ...
> 
> 
> It's a lot of grunt work...
> 
> "find . -name *WindowState.xcu"
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterFormWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/ChartWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/MathWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbRelationWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/StartModuleWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.
> xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/BasicIDEWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbQueryWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterWebWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbTableWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterReportWindowState.
> xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbReportWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbBrowserWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/BaseWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbTableDataWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/CalcWindowState.xcu
> (and some other non-relevant files)
> 
> grep "private:resource/toolbar/"
> officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu
>   
>   
>oor:op="replace">
>   
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>   
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>   
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>   
>   
>oor:op="replace">
>   
>   
>   
>oor:op="replace">
>   
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>oor:op="replace">
>   
>oor:op="replace">


Could it be done by changing this line to locked(true)?

Code pointer :
https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/windowstateconfiguration.cxx?r=8c6ca694#156

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #23 from Samuel Mehrbrodt (CIB)  ---
Instead of changing every single file, it would probably make more sense to
just change the default to "Locked" just once.

https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/globalsettings.cxx?r=a457c7c6#173

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |momonas...@gmail.com,
   |.freedesktop.org|tietze.he...@gmail.com
   Keywords|needsUXEval |difficultyBeginner,
   ||easyHack, skillDesign,
   ||topicDesign

--- Comment #22 from Heiko Tietze  ---
Flagged my hesitation comments as obsolete. Toolbars should become locked by
default and have to get unlocked manually. It requires to add the property
Locked=true in *WindowState.xcu (and reset the profile).

For example,
officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu


... 
  
true
  
...


It's a lot of grunt work...

"find . -name *WindowState.xcu"
./officecfg/registry/data/org/openoffice/Office/UI/WriterFormWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/ChartWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/MathWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbRelationWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/StartModuleWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/BasicIDEWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbQueryWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/WriterWebWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbTableWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/WriterReportWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbReportWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbBrowserWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/BaseWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbTableDataWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/CalcWindowState.xcu
(and some other non-relevant files)

grep "private:resource/toolbar/"
officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #21 from Pedro  ---
Okay, we know that. However, Marek, Samuel, Andreas and me agree on locking the
toolbar by default while you disagree.

I guess this means that the toolbars should be locked by default any way?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #20 from Heiko Tietze  ---
(In reply to Pedro from comment #19)
> But we are not changing the familiar Standard interface. We are just locking
> the standard toolbar interface in place so that people don't accidentally
> move it around.
> 
> I don't understand your grievance?

The standard layout allows today undocking without the need to unlock and we
should keep that. The locked property should be changed only for Notebookbars
(or rater any non-standard UI).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #19 from Pedro  ---
But we are not changing the familiar Standard interface. We are just locking
the standard toolbar interface in place so that people don't accidentally move
it around.

I don't understand your grievance?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #18 from Heiko Tietze  ---
(In reply to andreas_k from comment #17)
> Confuse l thought its only for standard toolbars in NB there are no toolbars.

There are user interface variants with Notebookbars - and those can be docked.
But I don't see a reason to change the familiar standard interface. So I
recommend to do it optional with the UI definition.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #17 from andreas_k  ---
Confuse l thought its only for standard toolbars in NB there are no toolbars.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #16 from Heiko Tietze  ---
Please introduce this as an option so we can keep the familiar behavior for the
standard layout and NB designers decide whether toolbars are locked or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #15 from andreas_k  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #14 from Pedro  ---
So Samuel, Andreas do you agree about locking the toolbars by default?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #13 from Heiko Tietze  ---
(In reply to Pedro from comment #12)
> No, locked means right-clicking the toolbar and lock its position.
> Since we are offering default UIs like the Standard Toolbar, Single Toolbar
> and Sidebar. It doesn't make sense that the toolbars in these UIs are
> unlocked and the user can accidentally move the toolbars around.

If the majority thinks that is a good idea I'm not opposing. However, right
click and close is also not too far away.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #12 from Pedro  ---
No, locked means right-clicking the toolbar and lock its position.
Since we are offering default UIs like the Standard Toolbar, Single Toolbar and
Sidebar. It doesn't make sense that the toolbars in these UIs are unlocked and
the user can accidentally move the toolbars around.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #11 from Heiko Tietze  ---
(In reply to Samuel Mehrbrodt (CIB) from comment #9)
> Don't understand what you mean with jumping. How would that be any different
> to unlocked toolbars?

I read "locked" as "docked". A docked toolbar occupies space, either vertically
or horizontally. And when it shows up the other content adjusts its position.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

Pedro  changed:

   What|Removed |Added

 CC||vermelhusco1...@gmail.com

--- Comment #10 from Pedro  ---
I would also like to know why... Supposedly locking would prevent jumping?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #9 from Samuel Mehrbrodt (CIB)  ---
(In reply to Heiko Tietze from comment #8)
> Locked toolbars make the UI jumping.

Don't understand what you mean with jumping. How would that be any different to
unlocked toolbars?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #8 from Heiko Tietze  ---
Locked toolbars make the UI jumping. Unlocked and floating is a way to avoid
this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

--- Comment #7 from Pedro  ---
I fully agree with Marek Dolezel, Andreas and Samuel.
The toolbars should be locked by default in all available toolbars.Even as an
advanced user sometimes I accidentally move toolbars around. I can imagine how
confusing this must be to a less proefficient user.

Also unlocking a toolbar to move it around is something an advanced user easily
knows how to do.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WORKSFORME  |---

--- Comment #6 from Samuel Mehrbrodt (CIB)  ---
Agree with Andreas.
Moving toolbars around is an expert feature, and experts should be able to
unlock them.

Reopening this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #5 from andreas_k  ---
I would lock the toolbars by default, cause right click to unlock (and
configure) toolbars are not that difficult to recognize and the benefit would
be that you can't move them around accidentally.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Heiko Tietze  ---
Basically we want freedom for users and locking toolbars so that everyone needs
to disabled the lock first is the opposite. The response to this request was
low, so I close it as WFM.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Heiko Tietze  ---
You are talking about "Lock Toolbar Position" in general and not specifically
for the Standard or Formatting toolbar? Is there an issue or large number of
requests that boils down to undocked toolbars?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 CC||ba...@quipo.it
Version|5.1.0.0.alpha0+ Master  |3.3.0 release

--- Comment #1 from tommy27 ba...@quipo.it ---
enhancement request. status NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92484] UI: lock toolbar by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92484

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs