[Libreoffice-bugs] [Bug 92553] Web Wizard: Not open FTP Configure on Web Wizard Preview Setting.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92553

--- Comment #7 from Xisco Faulí  ---
Hi Julien,

Regarding the HIDMAIN values in fax and letter wizards, they're 41180 and 40820
respectively, which are used as an array position in wizards/common/HelpIds.py. 
Taking a look at that file, I see that WIZARDS_HID0_WEBWIZARD has HID:34200.
What happens if you use 34200 instead of 46000?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92553] Web Wizard: Not open FTP Configure on Web Wizard Preview Setting.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92553

--- Comment #5 from Javier Fernández  ---
(In reply to Julien Nabet from comment #4)
> Created attachment 118979 [details]
> dirty patch
> 
> Here's a dirty patch (magic values and other bad things...) but would like
> to know if I'm on the good way when I inherit FTPDialog from WizardDialog
> instead of UnoDialog2, UIConsts.
> 
> Anyway, with this, FTP dialog opens at last.
> 
> Javier/Xisco: Any thoughts?

I'm not really sure. I just ported the java code to python. I remember it
worked properly at that time, so perhaps something changed in the python Uno
bindings. There are other dialogs/windows inheriting from  UnoDialog2, like
StatusDialog; are they broken as well ? 

It's true that fax, letter, ... inherit from WizardDialog, so there is no
point, I guess, on keeping the Web dialogs different. Hence, I think your
approach is correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92553] Web Wizard: Not open FTP Configure on Web Wizard Preview Setting.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92553

--- Comment #8 from Julien Nabet  ---
Thank you Xisco for your feedback, I'll give it a try.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92553] Web Wizard: Not open FTP Configure on Web Wizard Preview Setting.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92553

--- Comment #6 from Julien Nabet  ---
Thank you for your feedback Javier.
Except a typo I fixed on 2015, UnoDialog2.py hasn't changed since the end of
2012.
So indeed since it's a dialog and the other dialogs inherit from WizardDialog,
let's inherit of it too.

The next thing is to understand how to use HIDMAIN to replace random value
"46000" (where to declare it, which value, etc...perhaps a new file
"FTPDialogConst.py" ?)
Then how to replace properly PushButtonType_OK_value, cancel and help.
I'll try to investigate (I think I could find soluce for PushButtonType in git
history of other dialogs).
However, if you have already hints in mind, I'd be very interested of course!
:-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92553] Web Wizard: Not open FTP Configure on Web Wizard Preview Setting.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92553

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |

--- Comment #9 from Julien Nabet  ---
I submitted a patch to gerrit:
https://gerrit.libreoffice.org/18831

It's far from perfect but at least, FTP dialog opens and I tried to use
existing constants.
As I indicated in the comment of the patch, there are still bugs to fix to make
FTP useable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92553] Web Wizard: Not open FTP Configure on Web Wizard Preview Setting.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92553

--- Comment #4 from Julien Nabet  ---
Created attachment 118979
  --> https://bugs.documentfoundation.org/attachment.cgi?id=118979=edit
dirty patch

Here's a dirty patch (magic values and other bad things...) but would like to
know if I'm on the good way when I inherit FTPDialog from WizardDialog instead
of UnoDialog2, UIConsts.

Anyway, with this, FTP dialog opens at last.

Javier/Xisco: Any thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92553] Web Wizard: Not open FTP Configure on Web Wizard Preview Setting.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92553

--- Comment #3 from Javier Fernández jfernan...@igalia.com ---
(In reply to Julien Nabet from comment #2)
 Xisco/Javier: 

 So it seems we've got something quite broken here.
 
 May one of you take a look or at least give some hint?
 Thank you in advance.

I can barely remember the code, actually, but I'd try to get it back and take a
look, at least, to give some hint.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92553] Web Wizard: Not open FTP Configure on Web Wizard Preview Setting.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92553

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet serval2...@yahoo.fr ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Traceback (most recent call last):
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_General.py,
line 88, in getFTPDialog
self.ftpDialog = FTPDialog(self.xMSF, pub, self.oWizardResource)
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/FTPDialog.py,
line 112, in __init__
self.resources = FTPDialogResources(oWizardResource)
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/FTPDialogResources.py,
line 24, in __init__
super(FTPDialogResources, self).__init__(xmsf, self.MODULE_NAME)
NameError: global name 'xmsf' is not defined
Traceback (most recent call last):
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py,
line 447, in showFTPDialog
return self.getFTPDialog(pub).execute(self) == 1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92553] Web Wizard: Not open FTP Configure on Web Wizard Preview Setting.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92553

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

   Priority|medium  |high
 CC||aniste...@gmail.com,
   ||jfernan...@igalia.com
   Severity|normal  |major

--- Comment #2 from Julien Nabet serval2...@yahoo.fr ---
Xisco/Javier: 
There are several pbs here.
1) 
I could fix the first one (see my previous comment) with this patch:
diff --git a/wizards/com/sun/star/wizards/web/FTPDialogResources.py
b/wizards/com/sun/star/wizards/web/FTPDialogResources.py
index 399913c..631b7af 100644
--- a/wizards/com/sun/star/wizards/web/FTPDialogResources.py
+++ b/wizards/com/sun/star/wizards/web/FTPDialogResources.py
@@ -21,7 +21,7 @@ class FTPDialogResources(object):
 RID_COMMON_START = 500

 def __init__(self, oWizardResource):
-super(FTPDialogResources, self).__init__(xmsf, self.MODULE_NAME)
+super(FTPDialogResources, self).__init__()

 self.resFTPDialog_title = oWizardResource.getResText(
 self.RID_FTPDIALOG_START + 0)

since FTPDialogResources.py inherits from object not from WizardDialog

2) Then I had:
Traceback (most recent call last):
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_General.py,
line 88, in getFTPDialog
self.ftpDialog = FTPDialog(self.xMSF, pub, self.oWizardResource)
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/FTPDialog.py,
line 116, in __init__
self.setDialogProperties( True, 160, HelpIds.getHelpIdString(HID_FTP),
AttributeError: 'FTPDialog' object has no attribute 'setDialogProperties'
Traceback (most recent call last):
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py,
line 447, in showFTPDialog
return self.getFTPDialog(pub).execute(self) == 1
AttributeError: 'NoneType' object has no attribute 'execute'

so disabled self.setDialogProperties line for the test.

3) Then I had:
Traceback (most recent call last):
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_General.py,
line 88, in getFTPDialog
self.ftpDialog = FTPDialog(self.xMSF, pub, self.oWizardResource)
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/FTPDialog.py,
line 120, in __init__
self.build()
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/FTPDialog.py,
line 177, in build
(14, HelpIds.getHelpIdString(HID_FTP_OK), self.resources.resbtnOK_value,
btnOK, 165, 142, PushButtonType_OK_value, 13, 50), self)
NameError: global name 'PushButtonType_OK_value' is not defined
Traceback (most recent call last):
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py,
line 447, in showFTPDialog
return self.getFTPDialog(pub).execute(self) == 1
AttributeError: 'NoneType' object has no attribute 'execute'

So I tried:
from com.sun.star.awt.PushButtonType import OK, CANCEL, HELP, STANDARD

but finally I had this:
Traceback (most recent call last):
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/ui/UnoDialog.py,
line 134, in insertControlModel
(sPropNames, oPropValues))
  File /home/julien/compile-libreoffice/libreoffice/instdir/program/uno.py,
line 256, in invoke
return pyuno.invoke( object, methodname, argTuple )
uno.com.sun.star.lang.IllegalArgumentException: Unable to convert the given
value for the property PushButtonType.
Expected type: short
Found type: com.sun.star.awt.PushButtonType
Traceback (most recent call last):
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/ui/UnoDialog.py,
line 134, in insertControlModel
(sPropNames, oPropValues))
  File /home/julien/compile-libreoffice/libreoffice/instdir/program/uno.py,
line 256, in invoke
return pyuno.invoke( object, methodname, argTuple )
uno.com.sun.star.lang.IllegalArgumentException: Unable to convert the given
value for the property PushButtonType.
Expected type: short
Found type: com.sun.star.awt.PushButtonType
Traceback (most recent call last):
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/ui/UnoDialog.py,
line 134, in insertControlModel
(sPropNames, oPropValues))
  File /home/julien/compile-libreoffice/libreoffice/instdir/program/uno.py,
line 256, in invoke
return pyuno.invoke( object, methodname, argTuple )
uno.com.sun.star.lang.IllegalArgumentException: Unable to convert the given
value for the property PushButtonType.
Expected type: short
Found type: com.sun.star.awt.PushButtonType
Traceback (most recent call last):
  File
/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_General.py,
line 88, in getFTPDialog