[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Andreas Heinisch changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 --- Comment #13 from Heiko Tietze --- (In reply to Mike Kaganski from comment #12) > proceed/abort options (using whatever wording you prefer) Descriptive labels on button are better since people tent to not read text, esp. when it's a long paragraph like here. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 --- Comment #12 from Mike Kaganski --- (In reply to Heiko Tietze from comment #11) I generally like this. > ... in versions older than v5.2 ... I am sorry for being inattentive, my fault: I should had written "5.0.3" instead of "5.2" in comment 10. Sorry, This doesn't change much here, only the version number :-) > [Save anyway] [Save without password] [Cancel] The "Save without password" is impossible option here, since the password is applied to a specific Basic library, not to the file as a whole. Or its behavior would need to be very convoluted. I suggest to keep only proceed/abort options (using whatever wording you prefer), and if user wants, they may always abort and remove the password themselves (the message could in theory include a hint how to do that - but it's going to be lengthy). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2405 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 --- Comment #11 from Heiko Tietze --- So another iteration: You are saving a password protected Basic library containing the module(s): \n$(ARG1)\n Storing those large module(s) in binary format, which is necessary for the password protection, make them unreadable in versions older than v5.2 or in Apache OpenOffice. If you want this please split the module into smaller pieces." [Save anyway] [Save without password] [Cancel] If we need to keep the Yes/No buttons: ... Press Yes to continue anyway or No if you want to split the module into smaller pieces. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 --- Comment #10 from Mike Kaganski --- (In reply to Heiko Tietze from comment #9) Let me clarify. The message is wrong in that it states that we "can't" do this. We actually can, and in fact *do* store the binary, and the size is not too large. The only problem is - it would not be readable by old program version. But in fact, *any* size of the module is written by LibreOffice in such a way that is incompatible with anything older than LO v.5.2, which is a separate issue (tdf#142391). So either the warning should be removed, or it should tell that the written binary image would be incompatible with old programs (and the message depends on tdf#142391 - when it's fixed, this message should talk about OOo 2.2). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Heiko Tietze changed: What|Removed |Added Keywords||difficultyBeginner, ||skillDesign, topicUI --- Comment #9 from Heiko Tietze --- uui/inc/ids.hrc RID_UUI_ERRHDL "You are about to save/export a password protected basic library containing module(s) \n$(ARG1)\nwhich are too large to store in binary format. If you wish users that don't have access to the library password to be able to run macros in those module(s) you must split those modules into a number of smaller modules. Do you wish to continue to save/export this library?" The message is pretty clear- and unclear at the same time. I understand that splitting is required since the library is too large but I don't get why. And it is absolutely unclear what continue means. How about this text: "You are saving a password protected Basic library containing the module(s): \n$(ARG1)\n We cannot store this large module(s) in binary format, which is necessary for the password protection. If you want to proceed with protection please split the module into smaller pieces." and [Save without password] [Cancel] (The button label might be tricky, see uui/source/iahndl.cxx) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2391 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Mike Kaganski changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org Hardware|x86-64 (AMD64) |All Keywords||easyHack OS|Windows (All) |All --- Comment #8 from Mike Kaganski --- The timeline of this issue: 1. In 2006 (during OOo 2.2 release cycle), in https://bz.apache.org/ooo/show_bug.cgi?id=64377, Noel Power had implemented a new binary image format (v.0x12 - see basic/source/inc/filefmt.hxx) that is able to store more than 64K data (there are 38 commits returned by 'git log --grep i64377'). At that time, it was decided that, although the new format can fix this problem, they will *not* store it to ODF because it would be backward-incompatible. The import code was made able to read the new format, though - to be compatible with *some* future OOo version that starts writing that format. The error message (warning) was implemented, as documented in http://specs.openoffice.org/scripting_framework/BasicImageSizeIncreaseWarning.odt. All OOo/LO/AOO versions since 2006 are thus able to read binary format 0x12. 2. In 2015 (during LO 5.1 release cycle), in tdf#94617, Laurent Godard had implemented yet another incompatible change to the binary format (v.0x13) that fixed a problem in previous format that procedures could only start in the first 64K of the binary image (https://git.libreoffice.org/core/+/ddb45261590939d884ac2bcb1fd258de7b2370da). That made the new image in LO incompatible with all older LO versions, as well as with all OOo/AOO versions. 3. In 2016 (during LO 5.2 release cycle), in tdf#87530, Michael Stahl made the *new* binary image format to actually write to ODF (https://git.libreoffice.org/core/+/6a351c5cf91d0f667168d834ba2eb5c04121c7d5). Possibly this was an unintended side effect. Since then, the warning displayed by LibreOffice (starting with "Error saving..."!) is in fact *wrong*, since confirming it (pressing OK) in fact saves the encrypted module and binary image, and all LO versions since LO 5.0.3 are able to run it. The problems here: 1. Clarify the warning, to make it clear that only *old* versions of LO would be unable to use the big module. 2. Possibly change the fix to tdf#94617, so that image version 0x13 is only written when needed (i.e., when there actually is a procedure starting at offset greater than 64K), and use version 0x12 otherwise, so that when possible, the encrypted library is usable in all OOo/AOO/LO versions starting from OOo 2.2 (this is a task for a separate report). This one (about clarification of the existing message) is an easy hack related to UI; I hope Heiko could mentor it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||530 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||617 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 --- Comment #7 from Mr.Crocodile --- These are the information from Help -> About Libreoffice Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win Locale: it-IT (it_IT); UI: it-IT Calc: threaded Just for information, the problem is present also using Win10 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Mr.Crocodile changed: What|Removed |Added Hardware|x86 (IA32) |x86-64 (AMD64) Version|4.4.3.2 release |Inherited From OOo --- Comment #6 from Mr.Crocodile --- Hi all and sorry for my late answer. I follow your advise and downloaded both version 3.3.0 and latest 7.1.3.2. I made the test with the document indicated in the comment by Buovjaga 2015-07-29 15:48:42 UTC. The error is still the same (as reported by Buovjaga 2015-07-29 15:48:42 UTC) with the latest version and with the oldest one. Hope this could help again. Have a nice evening. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Mike Kaganski changed: What|Removed |Added See Also||https://bz.apache.org/ooo/s ||how_bug.cgi?id=64377 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 --- Comment #5 from QA Administrators --- Dear Mr.Crocodile, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107659 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107659 [Bug 107659] [META] Macro bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Julien Nabet changed: What|Removed |Added Summary|Password protected Macro|Password protected Macro |lenght limited |length limited -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
