[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |sberg...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard| target:5.1.0 | target:5.1.0 target:5.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 --- Comment #7 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Stephan Bergmann committed a patch related to this issue. It has been pushed to libreoffice-5-0: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ff7410fe4bc7518787afef5bd8a43760cb3d633ch=libreoffice-5-0 tdf#93041: Resolve clashing SID_OFFER_IMPORT vs. SID_ATTR_CHAR_BACK_COLOR It will be available in 5.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 --- Comment #6 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Stephan Bergmann committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=4275056a90eb9e178062276cc104ac2b94db13ca tdf#93041: Resolve clashing SID_OFFER_IMPORT vs. SID_ATTR_CHAR_BACK_COLOR It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC||bu...@bubli.org --- Comment #5 from Stephan Bergmann sberg...@redhat.com --- The culprit is http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-5-0id=c0e07bc592b7fe270514ae392eacb6ebde3df879 tdf#88276: toolbar|sidebar button for text background colour adding #define SID_ATTR_CHAR_BACK_COLOR ( SID_SVX_START + 1143 ) whose value (11143) clashes with the existing SID_OFFER_IMPORT, and an SfxItemInfo mapping from SID_ATTR_CHAR_BACK_COLOR to EE_CHAR_BKGCOLOR is added to the pool, so SFX_ITEMSET_ARG(..., SID_OFFER_IMPORT, ...) now internally maps from 11143 to 4044 (EE_CHAR_BKGCOLOR) and fails. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 --- Comment #3 from Philippe Jung phil.j...@free.fr --- (In reply to V Stuart Foote from comment #2) Maybe Philippe J.'s work on tpbitmap.cxx and tparea.cxx? These changes were related to how dialogs are created / launched because of VclPtr conversion. So I would say probably not related. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 --- Comment #4 from Philippe Jung phil.j...@free.fr --- Search in progress. Not finished for the moment, so I leave a trace of what I found, if someone get a quick idea. In tparea.cxx, PageCreated, in the case where pOfferImportItem is null, if I set mbOfferImportButton to true, the button appears. Only way of setting this to true is from SFX_ITEMSET_ARG (aSet, pOfferImportItem, SfxBoolItem, SID_OFFER_IMPORT, false); When debugging, aSet contains SFX_ITEMS_NONE for nWhich = 11143 (SID_OFFER_IMPORT) #4 0x7fffaed943b3 in SvxAreaTabPage::PageCreated (this=0x4781000, aSet=...) at /home/philippe/src/lodev/master/cui/source/tabpages/tparea.cxx:2449 #5 0x7fffaf44ee82 in SwTemplateDlg::PageCreated (this=0x466cee0, nId=3, rPage=...) at /home/philippe/src/lodev/master/sw/source/ui/fmtui/tmpdlg.cxx:605 #6 0x74156c88 in SfxTabDialog::ActivatePageHdl (this=0x466cee0, pTabCtrl=0x477b820) at /home/philippe/src/lodev/master/sfx2/source/dialog/tabdlg.cxx:1182 #7 0x74154d4a in SfxTabDialog::Start_Impl (this=0x466cee0) at /home/philippe/src/lodev/master/sfx2/source/dialog/tabdlg.cxx:610 #8 0x741548c9 in SfxTabDialog::Execute (this=0x466cee0) at /home/philippe/src/lodev/master/sfx2/source/dialog/tabdlg.cxx:540 #9 0x7fffaf3b9dac in AbstractTabDialog_Impl::Execute (this=0x46e89b0) at /home/philippe/src/lodev/master/sw/source/ui/dialog/swdlgfact.cxx:104 #10 0x7fffb326a9d2 in SwDocShell::Edit (this=0x3c3b900, rName=..., rParent=..., nFamily=8, nMask=0, bNew=false, sPage=..., pActShell=0x41d0bc0, bBasic=false) at /home/philippe/src/lodev/master/sw/source/uibase/app/docst.cxx:800 #11 0x7fffb326c87d in SwDocShell::FormatPage (this=0x3c3b900, rPage=..., rPageId=..., rActShell=...) at /home/philippe/src/lodev/master/sw/source/uibase/app/docst.cxx:1319 #12 0x7fffb337c672 in SwBaseShell::ExecDlg (this=0x4375480, rReq=...) at /home/philippe/src/lodev/master/sw/source/uibase/shells/basesh.cxx:2395 In sw, SID_OFFER_IMPORT is mentioned only in http://opengrok.libreoffice.org/xref/core/sw/source/ui/frmdlg/frmdlg.cxx whereas code goes through /home/philippe/src/lodev/master/sw/source/ui/fmtui/tmpdlg.cxx -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote vstuart.fo...@utsa.edu --- Yep the Import Graphic dialog launch button went missing between 5.0.0beta2 and 5.0.0beta3. So in the range... http://cgit.freedesktop.org/libreoffice/core/log/?h=libreoffice-5-0qt=rangeq=0a16c3dda4150008d9be6f24cbd15ac198d116d3..900960d3e4220f7e04f45c9bf45a1cd92cd06a Maybe Philippe J.'s work on tpbitmap.cxx and tparea.cxx? =-Ref-= http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-5-0id=1379e2feaad6344999358bbfb271edbaea66ce2a -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||phil.j...@free.fr, ||sberg...@redhat.com Severity|critical|normal -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 MM plokk...@fastmail.fm changed: What|Removed |Added Version|5.0.0.4 rc |5.0.0.0.beta3 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93041] UI: missing import bitmap button
https://bugs.documentfoundation.org/show_bug.cgi?id=93041 MM plokk...@fastmail.fm changed: What|Removed |Added Keywords||regression Priority|medium |high Status|UNCONFIRMED |NEW Hardware|x86 (IA32) |All Ever confirmed|0 |1 OS|Windows (All) |All Severity|major |critical --- Comment #1 from MM plokk...@fastmail.fm --- Unconfirmed with v4.4.5.2 under mint 17.2 x64. Confirmed with v5.0.0.4 under mint 17.2 x64. Set to All, Regression. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
