[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

--- Comment #23 from claude84  ---
need more updates, contact me through https://cookie-clicker2.co if you have
uploaded the new updates

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

Aron Budea  changed:

   What|Removed |Added

 Status|VERIFIED|CLOSED
 CC||ba...@caesar.elte.hu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

--- Comment #22 from Nadya Kaur  ---
Commenting on a blog is an art. Good comments http://www.escortdehradun.com/
create relations. You’re doing great work. Keep it up.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Status|RESOLVED|VERIFIED

--- Comment #21 from BogdanB  ---
Great! I didn't know how easy easy with shortcut to insert and also to edit an
existing comment! Ctrl+Alt+C 

Now it's working!

Verified on
Version: 7.0.0.0.alpha1
Build ID: 6a03b2a54143a9bc0c6d4c7f1...
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

--- Comment #20 from Timur  ---
(In reply to Maxim Monastirsky from comment #15)
> (In reply to Timur from comment #13)
> > 1. Insert-Comment is not available in menu if comment exists, so Edit not
> > possible from menu (regression from Bug 84153 in LO 5.0);
> There is Sheet > Cell Comments > Edit Comment.
> 
> > 2. Ctrl+Alt+C shortcut to insert comment is visible in menu but doesn't work
> > for me in Windows
> Maybe related to Bug 118269 (was fixed only for Hungarian)?

Thanks for pointing out, there were also listed other bugs, my bad I didn't
search. 

I opened a documentation bug 131305 to improve help for edit and to say that 
Ctrl+Alt+C may not work on some Windows systems. 
I don't know why it doesn't work on my physical Windows in any LO and at the
same time works in virtual machine on the same system. 
Since I don't know the cause, I will not open a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||1305

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

--- Comment #19 from dan...@tamm-tamm.de ---
Great that this is finally fixed! Thank you @Maxim!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

--- Comment #17 from Commit Notification 
 ---
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/02cac3ee70760234db0fad44cb9095dfccc538a1

tdf#95854 Same shortcut for insert and edit comment

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #18 from Heiko Tietze  ---
(In reply to Maxim Monastirsky from comment #16)
> https://gerrit.libreoffice.org/c/core/+/90354

(In reply to Maxim Monastirsky from comment #15)
> There is Sheet > Cell Comments > Edit Comment.


=> fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

--- Comment #16 from Maxim Monastirsky  ---
(In reply to Yousuf Philips (jay) (retired) from comment #9)
> The same shortcut should work for both inserting and editing comments, as it
> used to in 4.4 and below, and as it does in writer, so users dont have to
> learn a new shortcut.
> 
> https://gerrit.libreoffice.org/#/c/31449/
^^^ Actually this was a brilliant idea: We can show the same shortcut for two
different commands, if only we define the first one in a global scope, and the
second one in a module-specific scope (Calc in our case). It is true that the
module-specific command is the one that will be always executed by pressing the
shortcut, but this isn't a problem here, as both commands share the same
execution code. The only remaining problem is that the edit command is disabled
when a cell doesn't have a comment, and so can't be executed. But fortunately
this can be solved by some sdi magic, so the edit command remains visually
disabled, but still can be executed via the api (and thus by a keyboard
shortcut).

An updated attempt is in gerrit:

https://gerrit.libreoffice.org/c/core/+/90354

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

--- Comment #15 from Maxim Monastirsky  ---
(In reply to Timur from comment #13)
> 1. Insert-Comment is not available in menu if comment exists, so Edit not
> possible from menu (regression from Bug 84153 in LO 5.0);
There is Sheet > Cell Comments > Edit Comment.

> 2. Ctrl+Alt+C shortcut to insert comment is visible in menu but doesn't work
> for me in Windows
Maybe related to Bug 118269 (was fixed only for Hungarian)?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

Heiko Tietze  changed:

   What|Removed |Added

 CC||momonas...@gmail.com,
   ||muhammet.k...@collabora.com

--- Comment #14 from Heiko Tietze  ---
(In reply to Timur from comment #13)
> 1. Insert-Comment is not available in menu if comment exists, so Edit not
> possible from menu (regression from Bug 84153 in LO 5.0);

6.3.5 allows to insert a comment and edit per context menu. The main menu has
Insert > Comment but no Edit > Comment.

> 2. Ctrl+Alt+C shortcut to insert comment is visible in menu but doesn't work
> for me in Windows, works just in Linux (implementation error from when it
> was added in LO 3.5);

No idea about this, Linux here.

> 3. Ctrl+Alt+C shortcut to also edit comment abandoned (from this bug).
> Bug 84153 was confirmed and fixed without UX i.e. taking all into account.
> Regression and duplicates, high. Synerzip not active, no dev in CC. 

I'm reading bug 84153 as if the shortcut should work as either insert or edit
depending on whether the cell has a comment, but it doesn't. Was it really
possible to overload a shortcut before 5.2? When I assign ctrl+alt+c to "edit
comment" it's not available for "insert comment". Would be nice, though no idea
about a sane customization.

Muhammet, Maxim: What's your opinion?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

Timur  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisectNotNeeded
   Priority|medium  |high
   Hardware|x86-64 (AMD64)  |All
Version|5.0.2.2 release |5.0.0.5 release

--- Comment #13 from Timur  ---
There are multiple problems here:
1. Insert-Comment is not available in menu if comment exists, so Edit not
possible from menu (regression from Bug 84153 in LO 5.0);
2. Ctrl+Alt+C shortcut to insert comment is visible in menu but doesn't work
for me in Windows, works just in Linux (implementation error from when it was
added in LO 3.5);
3. Ctrl+Alt+C shortcut to also edit comment abandoned (from this bug).

Bug 84153 was confirmed and fixed without UX i.e. taking all into account.
Regression and duplicates, high. Synerzip not active, no dev in CC. 

IMO, solution would be:
- set Insert-Comment back as also available to edit comment
- fix Ctrl+Alt+C in Windows (if really doesn't work just)
- add Ctrl+Alt+C to edit comment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

Timur  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=84
   ||153
 OS|Linux (All) |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

--- Comment #12 from Stanislav Horacek  ---
It is still not possible to use the same command for inserting and editing
comments.

Tested in master:
Version: 6.2.0.0.alpha0+
Build ID: c4fb70d1f70209e31936b9c488a044087f11c303

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

Xisco Faulí  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||xiscofa...@libreoffice.org
   Assignee|philip...@hotmail.com   |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #10 from Xisco Faulí  ---
Dear developer,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Keywords|needsUXEval |regression
 Status|NEW |ASSIGNED
 CC|libreoffice-ux-advise@lists |philip...@hotmail.com
   |.freedesktop.org|
   Assignee|libreoffice-b...@lists.free |philip...@hotmail.com
   |desktop.org |
Summary|Calc: Insert Comment|Insert comment shortcut
   |doesn't let me edit |doesn't let me edit
   |existing comment|existing comment

--- Comment #9 from Yousuf Philips (jay)  ---
The same shortcut should work for both inserting and editing comments, as it
used to in 4.4 and below, and as it does in writer, so users dont have to learn
a new shortcut.

https://gerrit.libreoffice.org/#/c/31449/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs