[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #20 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/820a5155973fef28891c7cc9f9547c21b0f2bf1a

tdf#80663, tdf#96067: move UItest to CppunitTest

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|haveValgrind target:5.2.0   |haveValgrind target:5.2.0
   |target:5.1.0 target:5.1.1   |target:5.1.0 target:5.1.1
   |target:5.4.0|target:5.4.0 target:7.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #19 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0089da5af5ab1e1cbbba76b4635e8472c2678c5f

tdf#96067 Add uitest

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|haveValgrind target:5.2.0   |haveValgrind target:5.2.0
   |target:5.1.0 target:5.1.1   |target:5.1.0 target:5.1.1
   ||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #18 from Yousuf (Jay) Philips  ---
Version: 5.2.0.0.alpha0+
Build ID: d95d9d7f908419f397941ef60ac6ced3261c9b87
CPU Threads: 2; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-01-19_00:40:21
Locale: en-US (en_US.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #16 from Terrence Enger  ---
I no longer see the crash in daily dbgutil bibisect version 2016-01-18
running in and environment chroot'd to debian-sid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Terrence Enger  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #17 from Terrence Enger  ---
I am setting status RESOLVED FIXED.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #14 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "libreoffice-5-1-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=151aba28ba46d6f0aae6ac69b70144e713d466e1=libreoffice-5-1-0

tdf#96067: fix crash in undo of table row insertion

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|haveValgrind target:5.2.0   |haveValgrind target:5.2.0
   ||target:5.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|haveValgrind target:5.2.0   |haveValgrind target:5.2.0
   |target:5.1.0|target:5.1.0 target:5.1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #15 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a4f133bc8b00ea2051e6979087b46fd0401e60f=libreoffice-5-1

tdf#96067: fix crash in undo of table row insertion

It will be available in 5.1.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|haveValgrind|haveValgrind target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #13 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=70d2673ba06878ee84c99d7877e4b71749ac06f0

tdf#96067: fix crash in undo of table row insertion

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Stephan Bergmann  changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #12 from Stephan Bergmann  ---
(In reply to Noel Grandin from comment #8)
> My guess is on fa91dd3

unfortunately, at least

"New loplugin:faileddyncast" in combination with

"Mark some classes as final" did not turn up any problems introduced with that
commit

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Noel Grandin  changed:

   What|Removed |Added

 CC||oliver.spe...@cib.de

--- Comment #11 from Noel Grandin  ---
I can confirm that the problem commit is 
  fa91dd3 5th step to remove tools/rtti.hxx

Adding Oliver to CC

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #7 from Noel Grandin  ---
Sorry, I can't see how that could be any of my commits.
This looks like a stale SwTableBox* pointer, but why that is arising here I
don't know.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #9 from Terrence Enger  ---
Created attachment 121536
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121536=edit
valgrind and gdb backtrace full

This time, running with parameter --valgrind, the LibreOffice of
comment 5 raised the STL assertion.  The failing task is pid 28204.
The following points may be of interest ...

line  what
  
 144  process starts
 352  invalid read
 488  STL error message
 499  stack printout
 575  process terminating, valgrind prints stack
 644  ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
 662  gdb starts
 699  backtrace full

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Terrence Enger  changed:

   What|Removed |Added

 Whiteboard||haveValgrind

--- Comment #10 from Terrence Enger  ---
Setting whiteboard haveValgrind.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #8 from Noel Grandin  ---
I had time to run some bisecting compiles and I narrowed it down to this range:

14c2b50 unused header
fa91dd3 5th step to remove tools/rtti.hxx
c21ddcd tdf#93243 replace boost::bind with c++11 lambdas in vcl/source tree
a31b4f4 Missing includes
3503873 loplugin:staticmethods

My guess is on fa91dd3

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Terrence Enger  changed:

   What|Removed |Added

 CC||gaurangar...@gmail.com

--- Comment #3 from Terrence Enger  ---
*** Bug 96680 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #4 from Gaurang  ---
also, undo insert columns are affected too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #5 from Terrence Enger  ---
Created attachment 121520
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121520=edit
`make debugrun` with backtrace

LibreOffice in the attached `make debugrun` is commit 30b8dbc, fetched
2015-12-22 00:55 UTC, configured ...

CC=ccache /usr/bin/gcc
CXX=ccache /usr/bin/g++
--enable-option-checking=fatal
--enable-dbgutil
--enable-debug
--enable-crashdump
--without-system-postgresql
--without-myspell-dicts
--with-extra-buildid
--without-doxygen
--with-external-tar=/home/terry/lo_hacking/git/src
# --disable-remote

..., build and running on debian-stretch.


My STR are ...

(1) Run Writer from the command line.  Program presents Writer window
"Untitled 1".

(2) Take menu option Table > "Insert Table...".  Program presents
dialog "Insert Table".

(3) In dialog "Insert Table" type "">.  Program closes the
dialog and returns focus to "Untitled 1", which now shows a table,
2-by-2; the caret is in the upper left cell.

(4) Move mouse cursor into the left margin beside the second row of
the table.  The mouse cursor changes to a bold righ-pointing
arrow.

(5) Right-click and from the popup menu select Insert > "Rows Above".
The table is now three rows by two columns, and the caret is in
the first cell of row three.

(5) Type "+Z".  SIGSEGV.

..., but note that in the same test on daily dbgutil bibisect repo
version 2015-12-23, running chroot-sid, the program failed with
SIGABRT ...

/usr/include/c++/4.8/debug/vector:353:error: attempt to subscript container 
with out-of-bounds index 2, but container only holds 2 elements.

Objects involved in the operation:
sequence "this" @ 0x0x2644820 {
  type = NSt7__debug6vectorIP11SwTableLineSaIS2_EEE;
}
Application Error

Fatal exception: Signal 6

( I am going off now to see what I have to do to get the STL debug
classes in my local build. )

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Terrence Enger  changed:

   What|Removed |Added

   Keywords||bibisected, have-backtrace
 CC||noelgran...@gmail.com

--- Comment #6 from Terrence Enger  ---
Working the the daily dbgutil bibisect repository, I have determined
that the bug came into LibreOffice between 2015-11-11 and 2015-11-12.
The corresponding source hashes are 591903a..4b91870, which covers 80
commits.

Considering the error thrown by the debug version of STL iterators,
the following commits jump out at me ...

2ff2fafff8fe455a2493d04e7da709588a691ddd
svx: boost::ptr_vector->std::vector
8978ce53e16de9a597015b0704f813dffa7da920
svx: boost::ptr_vector->std::vector
44d3577f4b5ec181219268826d2ec504e61541f3
linguistic: boost::ptr_vector->std::vector
5d892a3378dfd5c452ba106b002c7cef9a77a861
idl: boost::ptr_vector->std::vector
1459f127711ba11e0ce044d9fb70d1941b5c3209
framework: boost::ptr_vector->std::vector
aef8a59d51954f1858296ef23f70c8bd65c77c1c
framework: boost::ptr_vector->std::vector
ea2ae023cf0ca44b445aead93a47b8154f0cc818
framework: boost::ptr_vector->std::vector
2a2b9920c1ccd9cfb2ec474ceffed7c5d78ecb00
extensions: boost::ptr_vector->std::vector
d1bda375a077d0de31cc4f5e602b3e33fdde0d55
extensions: boost::ptr_vector->std::vector

Noel, do you want to take this bug on?

Adding Noel to cc; adding keywords bibisect, have-backtrace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Jacques Guilleron  changed:

   What|Removed |Added

 CC||reporter_of_b...@yahoo.com

--- Comment #2 from Jacques Guilleron  ---
*** Bug 96675 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl
 Ever confirmed|0   |1

--- Comment #1 from Cor Nouws  ---
confirmed in Version: 5.1.0.0.alpha1+
Build ID: f6bc5b79c31225c02e9500d0ced4bd26f998f82b
Threads 2; Ver: 4.2; Render: default; 

TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2015-11-24_01:06:34
Locale: nl-NL (nl_NL.UTF-8)

thanks for hunting this one, Jay ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs