[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

jan iversen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from jan iversen  ---
Look solved

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

--- Comment #7 from Commit Notification 
 ---
Tomofumi Yagi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6046732216279ff349f683cea6c2f6d151f41f17

tdf#96348 Get rid of unnecessary DLLPUBLIC decorations - VclEventListeners

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

--- Comment #6 from Tor Lillqvist  ---
"code pointer":

git log -p -1 e9e3124e00676194a10c52ca1a064c44cb668f98

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

David Tardon  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 CC||dtar...@redhat.com
 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

jan iversen  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #5 from jan iversen  ---
A couple of example code pointers, would make it more likely that this easy
hack get done. sample commits are good, but a relative high ladder for new
people

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

--- Comment #1 from Tor Lillqvist  ---
Alternatively, for extra points, write a Clang plug-in that automates this;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

Stephan Bergmann  changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #2 from Stephan Bergmann  ---
(In reply to Tor Lillqvist from comment #0)
> Don't submit such a change unless you have tested that the code still builds,

...and passes "make check", as some DLLPUBLICs might only be there for test
code to be able to access otherwise internal entities.  (In which case those
uses of DLLPUBLIC should arguably be commented accordingly.)

Also, note that there is different behaviour between GCC (as typically used on
Linux) and Clang (as typically used on Mac OS X, but also on Linux) whether to
treat non-exported RTTI of types with identical identifiers as identical.  This
can e.g. have consequences for uses of dynamic_cast, and can be relevant e.g.
when a class in vcl/inc/ has erroneously been marked VCL_DLLPUBLIC instead of
VCL_PLUGIN_PUBLIC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96348

Tor Lillqvist  changed:

   What|Removed |Added

 Whiteboard||EasyHack DifficultyBeginner
   ||SkillCpp

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs