[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

Thorsten Behrens (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||t...@libreoffice.org
 Resolution|--- |FIXED

--- Comment #15 from Thorsten Behrens (CIB)  ---
Reporter said this is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.2.0   | target:5.2.0
   |target:5.1.0.2  |target:5.1.0.2 target:5.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #14 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-5-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=107664a977c4893a0bc02f10cd20411c330b6d94=libreoffice-5-0

tdf#96479 workaround bookmark end pos handling...

It will be available in 5.0.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #13 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e781a8273eb2938f905485c00fbaf432e517d1dc=libreoffice-5-1

tdf#96479 workaround bookmark end pos handling...

It will be available in 5.1.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.2.0   | target:5.2.0
   ||target:5.1.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #12 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c91024891ff10c2ae01e11a28a9aecca2f36b6c3

tdf#96479 workaround bookmark end pos handling...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #11 from Jan-Marek Glogowski  ---
(In reply to Oliver Specht from comment #5)
>   cursor2 = newBm.Anchor.Text.createTextCursorByRange(newBm.Anchor)
> cursor2 includes newBm

If this were true, it would be very hard to replace the content of a bookmark
and it changes the behavior.
>From my POV the current behavior is broken, but probably there was a reason for
the new handling.

That's also the reason why the macro calls
bm.Anchor.Text.removeTextContent(bm)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #9 from Jan-Marek Glogowski  ---
Hmm - seems the overall conclusion is still wrong. I don't know how my
co-worker came to the conclusion, that removing the
"cursor.getText().insertString(cursor, ".", true)" call fixes the problem. But
probably he also just loaded the document without looking at the actual
bookmark in XML. Remember: we want to replace "bookmark" with "bookmark1" and
change the content to an input field. Here we go:

The original document to be modified by the macro contains:
  


  

I guess the bug also happens with a document without the first input field. It
contains the empty "bookmark" and no content after the first input field in the
paragraph.

Our test office versions are OOo 3.2.1, LO 4.1.6 and LO 4.2+ (current master) .
We run the unchanged macro of the document and a modified version of the macro
without the following line and check the resulting documents:
  cursor.getText().insertString(cursor, ".", true)

Generated document from macro with "." in OOo 3.2.1
  




  

Generated document from macro with_out_ "." in OOo 3.2.1
  




  

POV: both are identical and correct.

Generated document from macro with "." in LO 4.1.6
  




  

Generated document from macro with_out_ "." in LO 4.1.6
  



  

POV: now things start to break (quite probably much earlier then LO 4.1; I
didn't check, but we tested LO 3.6 for some time. The commit message just
states LO, no version). The empty bookmark isn't "expanded" when inserting /
replacing the content. The input field is actually appended after the bookmark.
Thanks to the "." workaround, we "force-expand" the bookmark before the insert
and still get the expected result.

Generated document from macro with "." in LO 4.2+
  



  

Generated document from macro with_out_ "." in LO 4.2+
  



  

POV: now it's really broken. Without the "." the macro actually generates an
invalid document (XML is correct, but there is no  in the document). I'm not sure we can find a workaround
for this in WollMux.

Since we always work with an empty bookmark, the original replacement problem
from i#101283 probably still hits us. At least the patch from
https://bz.apache.org/ooo/show_bug.cgi?id=101283 still applies and is included
in our 4.1 build. But that's another bug I need to verify.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #10 from Jan-Marek Glogowski  ---
Created attachment 121372
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121372=edit
Changed macro, which doesn't insertString the dot.

Also generates a different file: "/tmp/stripped_saved_no_dot.odt"

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

Oliver Specht  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #8 from Oliver Specht  ---
The bookmarks is saved but cannot be loaded where it is:



The bookmark is inside of the input field. It should have been moved outside of
the field before.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #7 from Jan-Marek Glogowski  ---
And just to make it clear: commenting the line

  cursor.getText().insertString(cursor, ".", true)

allows the save-load cycle to succeed!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

Jan-Marek Glogowski  changed:

   What|Removed |Added

   Keywords||bibisected

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Depends on||90816

--- Comment #1 from Jan-Marek Glogowski  ---
This is probably related to the same regression then bug 90816.
At least it looks the same.

Actually the code:

cursor.getText().insertString(cursor, ".", true)

is just a workaround for an other problem we found when switching from OOo
3.2.1 to LibreOffice 3.6. WollMux works again, if the workaround is removed.
In the end it's still a bug in LO and probably also AOO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #2 from Oliver Specht  ---
With range.Text.removeTextContent(bm) you remove the bookmark.
The bookmark newBm is never inserted. 
Seems o.k. to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #6 from Jan-Marek Glogowski  ---
(In reply to Oliver Specht from comment #5)
> This still seems o.k. to me:
>   cursor.getText().insertString(cursor, ".", true)
> cursor includes the '.'
>   cursor.getText().insertTextContent(cursor, newBm, true)
> newBm includes '.'
>   cursor2 = newBm.Anchor.Text.createTextCursorByRange(newBm.Anchor)
> cursor2 includes newBm
>   cursor2.Text.insertTextContent(cursor2, inputField, true)
> insertTextContent removes the selection - that removes newBm - and then
> inserts the field

If you run this code in LO 4.1, i.e. before the patch, it replaces "bookmark"
with "bookmark1" with the input field as content.

In versions after the patch, the code modifies the document - I assume
correctly, so it still replaces "bookmark" with "bookmark1" (I can see this
change in the navigator), but when saving the document the "bookmark1" is gone.

Now you claim that "bookmark1" is correctly removed, but this is contradicted
by the GUI and previous behavior, as the navigator for the original document,
not the saved and loaded one, shows "bookmark1" in the navigator. The loaded
document misses "bookmark1".

Whatever behavior is correct:
  1. the behavior has changed and
  2. the current state is inconsistent, as the navigator shows a "bookmark1",
which is lost on save 

Hope this helps to understand my point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #5 from Oliver Specht  ---
This still seems o.k. to me:
cursor.getText().insertString(cursor, ".", true)
cursor includes the '.'
cursor.getText().insertTextContent(cursor, newBm, true)
newBm includes '.'
cursor2 = newBm.Anchor.Text.createTextCursorByRange(newBm.Anchor)
cursor2 includes newBm
cursor2.Text.insertTextContent(cursor2, inputField, true)
insertTextContent removes the selection - that removes newBm - and then inserts
the field

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #4 from Jan-Marek Glogowski  ---
Hmm - I was told the insertString was the problem and didn't evaluate. And I
removed everything, and obviously the "bookmark1" is not in the target
document. Silly me.

The problem is, the original document contains a bookmark1 after the macro,
which is lost in the stripped document. Sorry for the confusion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Attachment #121292|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #3 from Jan-Marek Glogowski  ---
Created attachment 121294
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121294=edit
The orriginal error document without my strippings.

Seems my stripping actually destroyed the error case. This should be the
correct document.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

Jan-Marek Glogowski  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs