[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

Michael Stahl  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |dipankar1...@gmail.com
   |desktop.org |

--- Comment #35 from Michael Stahl  ---
i take it 04d4af8496c8fae5515c7f76e143310eb7098702 "ImplSVEvent::maDelData is
unused now" means this is fixed, thanks Dipankar!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #34 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9c09d4d0d36076d39926eeaf7774171df3b55e52

tdf#96888 - Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

Michael Meeks  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, skillCpp,
   ||topicCleanup
 Whiteboard|easyHack difficultyBeginner |
   |skillCpp topicCleanup   |
   |target:5.2.0|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #31 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a562c6f8075d55b92150ae70a595da69ab9fac8

tdf#96888 Kill internal vcl dog-tags ..

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #33 from Dipankar Niranjan  ---
Hi,
> > In  /core/vcl/source/window/winproc.cxx
> > In line 2001 before commit:
> > if ( pSVEvent->mbCall && !pSVEvent->maDelData.IsDead() )
> > I do not know how to remove usage of pSVEvent->maDelData.IsDead()
> 
>Oh ? so - what was associated with the maDelData ? - it rather depends on
> that really =) so I think we need to look at all of the calls that did an
> ImplAddDel on that member - and make sure we're checking them.
> 
> > pSVEvent->mpWindow and pSVEvent->mpInstanceRef both fail to build.
> 
> Oh ? why ? surely pSVEvent->mpWindow->IsDisposed() would work nicely.

pSVEvent->mpWindow->IsDisposed() doesn't build and the vcl_timer test fails.
We get a segmentation fault.
Running Valgrind gives:http://pastebin.com/HPqeGN0t
Also, I'm pretty sure we haven't called ImplAddDel on maDelData anywhere as can
be seen from grok.
So how do I proceed with this?
I don't think we've initialized or allocated mem for mpWindowImpl which
IsDisposed checks..

> > Provided these patches are correct, I would need some help with:
> > 1)Line 413 of window2.cxx as it involves inheritance if I'm not wrong.
> 
> Wow - that is horrible ! =) wow ... why do we bother casting to sal_uIntPtr
> there. So - in this case we need to update the methods to instead of using
> this awful sal_uIntPtr - instead passing a VclPtr<> around for the
> mpFocusWindow. Then we can rip out the ImplFocusDelData struct: another nice
> cleanup ! =)

This cleanup may take a little bit of time too.. 
By mpFocusWindow, I think you meant mpFocusWin
And should a new struct be created exclusively for mpFocusWin as we intend to
remove ImplFocusDelData which presently contains mpFocusWin?
Else, how do you propose to use mpFocusWin?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #32 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0f3a3c38bb4e7c4b4717e8dd7999fecba1288275

tdf#96888 Kill internal vcl dog-tags ..

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #23 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=269f953aaa46d7dce26d061ce487d2f76a16a34e

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #22 from Michael Meeks  ---
Hi Dipankar:

> https://gerrit.libreoffice.org/21280 is a cleanup of
> https://gerrit.libreoffice.org/21215

Ah - this is a bit of a pain to manage =) Luckily gerrit has a feature to make
this very, very easy - if you use it.

If you ensure that your new commit has the same 'Change-Id:' entry in the
commit message - then gerrit will just update the old patch, rather than
creating a new gerrit entry.

That -really- helps - it keeps the old comments together with the new patch,
and reduces the thrash of gerrit and so on.

Please can you ensure that new patches retain the old Change-IDs ? I appreciate
it's somewhat annoying having all these small patches ;-) but good practice for
dealing with eg. 'git rebase -i' which is a powerful tool for squashing changes
into patches =)

Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #25 from Michael Meeks  ---
Hi Dipankar

I reviewed a number of those changes; really keeping the Change-Id: the same
would save a lot of effort. Also - please do not refer to gerrit URLs in your
commit messages. git commit messages are part of the permanent record of the
code - once in they cannot be changed; but gerrit URLs are not really ;-) so
... better to add a comment into gerrit itself.

Thanks for the good work !

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #24 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=31bc9a228ed02dfa082e3a59c20b0ce106d5c75c

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #27 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=79af5b389b42284ddea3e486c17ace4776bd8e4c

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #26 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e02f5d421933a58b32dc8b9bb0a2027fb3914649

tdf#96888 Kill internal vcl dog-tags ..

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #29 from Michael Meeks  ---
by "abandon" I mean click the 'abandon' button in the gerrit web-ui for any
patches that are obsolete - so they don't show up there anymore ? =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #28 from Michael Meeks  ---
Nice to see you pushing updated with the same Change-Id: =)
Can you abandon any patches that are not current ? we're really starting to get
there ;-) I'm really looking forward to having these all killed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #30 from Dipankar Niranjan  ---
Hi,
I did not know that we could submit updates with the same Change-Id.
Made things a lot easier and cleaner..
Thanks for teaching that..!

Also I've abandoned the older commits.
So at present, the status of all inactive and old commits should be either
Merged or Abandoned.
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #20 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=47bac0de19fc4ca2c9d469b64fcbffe15bc4a0a3

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #21 from Dipankar Niranjan  ---
Hi,
Here are some cleanup patches.

https://gerrit.libreoffice.org/21280 is a cleanup of
https://gerrit.libreoffice.org/21215

https://gerrit.libreoffice.org/21275 is a cleanup of
https://gerrit.libreoffice.org/21221
https://gerrit.libreoffice.org/21223
https://gerrit.libreoffice.org/21224
https://gerrit.libreoffice.org/21226
https://gerrit.libreoffice.org/21227

https://gerrit.libreoffice.org/21276 is a cleanup of
https://gerrit.libreoffice.org/21230

https://gerrit.libreoffice.org/21279 is a cleanup of
https://gerrit.libreoffice.org/21233

https://gerrit.libreoffice.org/21236 looks fine

https://gerrit.libreoffice.org/21281 is a possible cleanup of
https://gerrit.libreoffice.org/21237

Thanks..

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #8 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=accc12efd1db250b7e3c22b6bd70a1e4393bae6b

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #11 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=07ce6f1192ad65ec63bf174b35298fa040207646

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #12 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=604a3bfbcf4515dd090949df57274d86cafaea21

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #13 from Michael Meeks  ---
Hi there,

> In  /core/vcl/source/window/winproc.cxx
> In line 2001 before commit:
> if ( pSVEvent->mbCall && !pSVEvent->maDelData.IsDead() )
> I do not know how to remove usage of pSVEvent->maDelData.IsDead()

   Oh ? so - what was associated with the maDelData ? - it rather depends on
that really =) so I think we need to look at all of the calls that did an
ImplAddDel on that member - and make sure we're checking them.

> pSVEvent->mpWindow and pSVEvent->mpInstanceRef both fail to build.

Oh ? why ? surely pSVEvent->mpWindow->IsDisposed() would work nicely.

> This is because ImplHandleUserEvent() is a static method.
> It is called in line 2574 in winproc.cxx

Hmm ? the above question is unrelated to static-ness AFAICS.

> Provided these patches are correct, I would need some help with:
> 1)Line 413 of window2.cxx as it involves inheritance if I'm not wrong.

Wow - that is horrible ! =) wow ... why do we bother casting to sal_uIntPtr
there. So - in this case we need to update the methods to instead of using this
awful sal_uIntPtr - instead passing a VclPtr<> around for the mpFocusWindow.
Then we can rip out the ImplFocusDelData struct: another nice cleanup ! =)

> 2)I've not touched svapp.cxx as it involves a constructor, a method and a
> destructor of ImplDelData.

When there are no other calls of ImplDelData - we will remove the class, and
kill all these methods, along with the notification code in window =)

You're getting there ... nice work ! =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|easyHack difficultyBeginner |easyHack difficultyBeginner
   |skillCpp topicCleanup   |skillCpp topicCleanup
   ||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #7 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6ac256da90d23d0b5483197543a1159fed827a41

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #9 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b1ad632c72e38973265ad0d3f31120108f120660

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #10 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f78ec21a800a5598a021ae76b5b5d72f03617a54

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #14 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8680813aa476eba172f078efddfd21ea99218cd8

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #15 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f2f1f52d8b84ac088496a4964d799bb84007fc45

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #16 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e2a0f007b106af2ad02e5244e13061e28878cba

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #19 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=da8f57d9c9b4c6efb211d1d69f7e240523d0bc43

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #17 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b65af458547264187f28301562db026ef187bec9

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #18 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=29cd6b92528b319c8248842d47256303b915e097

tdf#96888 Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #6 from Dipankar Niranjan  ---
Hi,
Thanks for the really helpful Code Review..
I hope I've learned from it while I was resubmitting the patches.
So here they are:
dndevis.cxx
https://gerrit.libreoffice.org/21211
dialog.cxx
https://gerrit.libreoffice.org/21212
https://gerrit.libreoffice.org/21215
event.cxx
https://gerrit.libreoffice.org/21216
https://gerrit.libreoffice.org/21219
https://gerrit.libreoffice.org/21220
winproc.cxx
https://gerrit.libreoffice.org/21221
https://gerrit.libreoffice.org/21223
https://gerrit.libreoffice.org/21224
https://gerrit.libreoffice.org/21226
https://gerrit.libreoffice.org/21227
https://gerrit.libreoffice.org/21228

In  /core/vcl/source/window/winproc.cxx
In line 2001 before commit:

if ( pSVEvent->mbCall && !pSVEvent->maDelData.IsDead() )

I do not know how to remove usage of pSVEvent->maDelData.IsDead()

pSVEvent->mpWindow and pSVEvent->mpInstanceRef both fail to build.

This is because ImplHandleUserEvent() is a static method.
It is called in line 2574 in winproc.cxx

I would need some help with the above like I had previously mentioned.

button.cxx
https://gerrit.libreoffice.org/21230
lstbox.cxx
https://gerrit.libreoffice.org/21231
dockwin.cxx
Noticed a couple of empty methods at line 716
https://gerrit.libreoffice.org/21232
menu.cxx
https://gerrit.libreoffice.org/21233
menufloatingwindow.cxx
https://gerrit.libreoffice.org/21234
syswin.cxx
https://gerrit.libreoffice.org/21235
toolbox.cxx
https://gerrit.libreoffice.org/21236
toolbox2.cxx
https://gerrit.libreoffice.org/21237

Provided these patches are correct, I would need some help with:
1)Line 413 of window2.cxx as it involves inheritance if I'm not wrong.
2)I've not touched svapp.cxx as it involves a constructor, a method and a
destructor of ImplDelData.
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #3 from Dipankar Niranjan  ---
Hi,
I've submitted the first patch with four files modified.
https://gerrit.libreoffice.org/#/c/21170/
Build, unit tests and make check were fine.
Please review when free.

But in  /core/vcl/source/window/winproc.cxx
In line 2001 before commit:

if ( pSVEvent->mbCall && !pSVEvent->maDelData.IsDead() )

I do not know how to remove usage of pSVEvent->maDelData.IsDead()

pSVEvent->mpWindow and pSVEvent->mpInstanceRef both fail to build.

This is because ImplHandleUserEvent() is a static method.
It is called in line 2574 in winproc.cxx

Please help with this.
I've tried to analyze this part but I've drawn blanks so far..
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #5 from Michael Meeks  ---
Hi there - I did some review on your first patch; looks nice - can you do some
tweaks & re-submit it ? =) I'll review your 2nd patch as/when that's merged -
but please feel free to adapt it based on the 1st one.

It is really good to split the work into lots of small commits that are merged
over time - -particularly- for this work: where it is quite possible that we
will get bisected issues later - and being able to isolate just a single patch
is extremely helpful.

Anyhow - thanks again for the great progress here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #4 from Dipankar Niranjan  ---
The second patch has been uploaded with eight files modified.
https://gerrit.libreoffice.org/#/c/21174/
Build, unit tests and make check were fine.
Please review when free.

You might want to look at line 413 of window2.cxx and tell me what to do as it
involves inheritance if I'm not wrong.
Also I've not touched svapp.cxx as it involves a constructor, a method and a
destructor of ImplDelData.
I would need help with these two files.
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #1 from Dipankar Niranjan  ---
Hi,
This is a method where deletion listener was being used.
It has been replaced by a VclPtr reference.
Please verify if I'm on the right track.

http://pastebin.com/aea0PSVf

Build and unit-tests are fine with the above code.

But build gives a unit-test failed if I use 
xWindow.disposeAndClear()
instead of
xWindow.clear()
xWindow.reset()
I might need some clarification on that.

Also vcl/README.lifecycle was a real help.
And do you have ScopedVclPtr in place of VclPtr in mind for the future?
I could also notice a lot of things left in the  "What remains to be done ?"
section of the doc.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #2 from Michael Meeks  ---
Hi there,

> This is a method where deletion listener was being used.
> It has been replaced by a VclPtr reference.
> Please verify if I'm on the right track.
> http://pastebin.com/aea0PSVf

Looks lovely =) Then again if we did xWindow.clear() there is no need for the
reset as well.

> Build and unit-tests are fine with the above code.

Did you try 'make check' ? well worth running that at the top level before and
after.

> But build gives a unit-test failed if I use 
> xWindow.disposeAndClear()

Sure - that forcibly destroys the window - we don't want to do that ;-)

> Also vcl/README.lifecycle was a real help.

Glad you like it; that's why I wrote it =)

> And do you have ScopedVclPtr in place of VclPtr in mind for the future?

Well; we have such a thing, but the templates generally could use a fair bit of
cleanup there.

> I could also notice a lot of things left in the  "What remains to be done ?" 
> section of the doc.

Sure - this is one of them; great to have you on it - I suspect there is scope
for a lot of nice, small patches in gerrit - separated by other commits - so we
can bisect to them nicely =)

Thanks !


Hi there,



+xWindow.clear();
+   xWindow.reset();

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

Michael Meeks  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=89
   ||382
 Ever confirmed|0   |1
 Whiteboard||easyHack difficultyBeginner
   ||skillCpp topicCleanup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs