[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

Winfried Donkers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |winfrieddonkers@libreoffice
   |desktop.org |.org

--- Comment #28 from Winfried Donkers  ---
MODE.SNGL is now compatible with Excel; MODE.MULT will follow shortly.
As MODE is essentially an ODFF function, I propose to leave that function as it
is and open separate bug report to add to the help for MODE something like
"MODE, being compliant with ODFF-standard, is not 100% percent compatible with
Excel's function MODE. For compatibilty with Excel, use MODE.SNGL of
MODE.MULT.".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

--- Comment #27 from Commit Notification 
 ---
Winfried Donkers committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c71e8df90b916f32a1d7d3a0849d0cdf14924475

tdf#97977 related : make MODE.SNGL comply with Excel.

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

--- Comment #26 from Winfried Donkers  ---
(In reply to Dennis Roczek from comment #23)
[...]
> > Upon exporting to
> > OOXML, it ought to be renamed to MODE.SNGL of MODE.MULT (haven't time to
> > figure out which, right now). Currently it isn't, it's saved as MODE in
> > OOXML.
> Well then we do have another problem. :-(
> 
> I just tested with Excel 2016 O365 (desktop app) version: all three variants
> of Mode (with the following numbers (9;1;5;1;9;5;6;6)) give as a result 9
> back.
> 
> LibreOffice Calc does calculate a 1 (as stated in our help).
>  

Currently, MODE and MODE.SNGL are identical in Calc. 
I can change that so that MODE.SNGL and MODE.MULT return 9 with
MODE.XX(9;1;5;1;9;5;6;6), i.e. the first value with the maximum occurences.
That way the OOXML-functions are fully compatible with Excel.
(Not assigning myself to this bug report as the fix for MODE.SNGL and MODE.MULT
are no fix for MODE.)

Mapping MODE to MODE.SNGL when exporting to OOXML has no effect; the results in
Calc stay different from those in Excel.

The difference for these special cases will probably remain unless either OOXML
specs of ODFF standard is changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

--- Comment #25 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/help/commit/?id=dd09149dfe0135a4abbd1abbcee15d115af0f982

tdf#97977 Mark MODE function as ODFF compliant

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

Dennis Roczek  changed:

   What|Removed |Added

 CC||olivier.hallot@documentfoun
   ||dation.org

--- Comment #24 from Dennis Roczek  ---
Hi Olivier,

I missed to add you in the last comment, see Comment 23.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

--- Comment #23 from Dennis Roczek  ---
(In reply to Winfried Donkers from comment #22)
> There are 3 MODE functions in Calc: MODE, MODE.SNGL and MODE.MULT.
> The first is should be fully ODF compliant, the other 2 are OOXML functions.
> The Excel function MODE (originating from Add-In function pack) has been
> declared obsolete by Microsoft and replaced with MODE.SNGL and MODE.MULT.
> The 'old' MODE function has retained for the time being.
> 
> So, if MODE fully complies with ODFF1.2, that is OK.
Hi Olivier, can you add a notice to the help that MODE is ODF-complaint? This
is missing in the help actually. (just noticed)

> Upon exporting to
> OOXML, it ought to be renamed to MODE.SNGL of MODE.MULT (haven't time to
> figure out which, right now). Currently it isn't, it's saved as MODE in
> OOXML.
Well then we do have another problem. :-(

I just tested with Excel 2016 O365 (desktop app) version: all three variants of
Mode (with the following numbers (9;1;5;1;9;5;6;6)) give as a result 9 back.

LibreOffice Calc does calculate a 1 (as stated in our help).

> Export to xls is more difficult. Creating a new function in Calc for an
> obsolete function and file type does seem to be the way to go.
Well, yes and no. The file format isn't open for extensions, this won't work
except mapping MODE.SNGL (or MODE.MULT) to MODE.

> (BTW, this is a general problem with Add-in functions that are being
> replaced by Microsoft with new versions.)
Depend if we have already a function integrated since ages. I wouldn't invent
new functions for such minimal differences...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

--- Comment #22 from Winfried Donkers  ---
There are 3 MODE functions in Calc: MODE, MODE.SNGL and MODE.MULT.
The first is should be fully ODF compliant, the other 2 are OOXML functions.
The Excel function MODE (originating from Add-In function pack) has been
declared obsolete by Microsoft and replaced with MODE.SNGL and MODE.MULT. The
'old' MODE function has retained for the time being.

So, if MODE fully complies with ODFF1.2, that is OK. Upon exporting to OOXML,
it ought to be renamed to MODE.SNGL of MODE.MULT (haven't time to figure out
which, right now). Currently it isn't, it's saved as MODE in OOXML.

Export to xls is more difficult. Creating a new function in Calc for an
obsolete function and file type does seem to be the way to go.
(BTW, this is a general problem with Add-in functions that are being replaced
by Microsoft with new versions.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

--- Comment #21 from Dennis Roczek  ---
Hi Manuj,

yes, that bug is still open.

See Comment 9 for steps to reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

Manuj Vashist  changed:

   What|Removed |Added

 CC||manujvash...@gmail.com

--- Comment #20 from Manuj Vashist  ---
Is this still open?
If yes then what has to be done here, as I can see MODE function 
follows the OOXML specs and MODE.SNGL follows ODF specs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

Shinnok  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||ad...@shinnok.com
   Assignee|abhilash300si...@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

abhilash300si...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |abhilash300si...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

--- Comment #9 from Dennis Roczek  ---
Hi Tamas,
for the example in the file:
=MODE(9;1;5;1;9;5;6;6)

ODF: 1 (smallest number in in the result set)
OOXML: 9 (first occurred number in the result set)

So basically we need a new "MODE" function, e.g. MODE.EXCEL or MODE_ADD or the
like.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

--- Comment #8 from Zolnai Tamás  ---
Hi guys,

What is the expected behavior here?
I see 1, 9 and 5 here in the cells which is the same as what MS EXCEL shows.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

jan iversen  changed:

   What|Removed |Added

   Assignee|manuel.defranceschi@studios |libreoffice-b...@lists.free
   |torti.com   |desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

manuel.defrances...@studiostorti.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |manuel.defranceschi@studios
   |desktop.org |torti.com

--- Comment #4 from manuel.defrances...@studiostorti.com ---
I assigned the easyHack to myself.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

Dennis Roczek  changed:

   What|Removed |Added

 Blocks||97334
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=97 |
   |334 |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

Dennis Roczek  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #3 from Dennis Roczek  ---
http://opengrok.libreoffice.org/xref/core/sc/source/core/tool/interpr3.cxx#3447

search for
ocModalValue
and
SC_OPCODE_MODAL_VALUE

to get an idea how a function is implemented, see
https://cgit.freedesktop.org/libreoffice/core/commit/?id=8539039e0c108da7d0306c37962415ce7e271c84

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

jan iversen  changed:

   What|Removed |Added

   Keywords||difficultyInteresting,
   ||easyHack, skillCpp
 Status|NEW |NEEDINFO

--- Comment #2 from jan iversen  ---
Missing code pointer (as noted in a email)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

Dennis Roczek  changed:

   What|Removed |Added

   Keywords||filter:ooxml
 CC||er...@redhat.com,
   ||winfrieddonkers@libreoffice
   ||.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

Dennis Roczek  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||334

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Beluga  ---
Yeah all are 1 after recalc.

Win 7 Pro 64-bit Version: 5.2.0.0.alpha0+
Build ID: ef02de2698d90fd874bddf3146165cbe85487bc5
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-02-19_23:40:50
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs