[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Yousuf Philips (jay) (retired)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |4858|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4858

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=35
   ||550

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5361

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5705

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #27 from Paul Oranje  ---
Calc in LO 6 maps Cmd+` to toggle view formulas; in Writer and other subapps
this key behaves in the normal platform expected mode: move to next open
window.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290
Bug 98290 depends on bug 114858, which changed state.

Bug 114858 Summary: Default keyboard mapping of Cmd+` (QUOTELEFT_MOD1) to 
uno:ToggleFormula not friendly to Apple HIG
https://bugs.documentfoundation.org/show_bug.cgi?id=114858

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||114858


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114858
[Bug 114858] Default keyboard mapping of Cmd+` (QUOTELEFT_MOD1) to
uno:ToggleFormula not friendly to Apple HIG
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #24 from Tor Lillqvist  ---
See https://gerrit.libreoffice.org/#/c/48796/ . It would be great if somebody
running OS X 10.9 or 10.10 could test this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||115284


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115284
[Bug 115284] Shortcut and behaviour of fullscreen mode on Mac
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #26 from Yousuf Philips (jay)  ---
Tor: I've opened bug 115284 to deal with mac fullscreen shortcut and behaviour,
so please add your comments about it there, so we can keep this bug focused on
all mac shortcuts. thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #19 from Tor Lillqvist  ---
Created attachment 139411
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139411=edit
Still in LO's own "full-screen" mode, with window resized even

Here I then also resized the document window a bit smaller. The button used to
exit LO's own full-screen mode is now floating happily by its own. Very silly
state.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #17 from Tor Lillqvist  ---
Created attachment 139409
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139409=edit
After pressing Cmd+Shift+F

LO's own "full-screen" mode, which is not at all implemented as the real macOS
full-screen mode, but still uses its shortcut. Note that the document title bar
("Untitled 1") with the three bubble buttons (of which the middle, yellow one,
is greyed out) at the left is still visible. The menu bar is hidden, sure.

I have taken the screenshots I am attaching using my phone camera as all
effects I want to point out were not visible when taking screenshots the normal
way;)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #23 from Tor Lillqvist  ---
The code in vcl/osx/salframeview.mm that handles dealing with the macOS
full-screen behaviour seems in the -(id)initWithSalFrame: (AquaSalFrame*)pFrame
instance method of the SalFrameWindow class seems a bit confused: It sets the
bool bAllowFullScreen to a value:

> bool bAllowFullScreen = (SalFrameStyleFlags::NONE == (mpFrame->mnStyle & 
> (SalFrameStyleFlags::DIALOG | SalFrameStyleFlags::TOOLTIP | 
> SalFrameStyleFlags::SYSTEMCHILD | SalFrameStyleFlags::FLOAT | 
> SalFrameStyleFlags::TOOLWINDOW | SalFrameStyleFlags::INTRO)));
> bAllowFullScreen &= (SalFrameStyleFlags::NONE == (~mpFrame->mnStyle & 
> SalFrameStyleFlags::SIZEABLE));
> bAllowFullScreen &= (mpFrame->mpParent == nullptr);

And then it checks that in an if statement:

>if( bAllowFullScreen && [pNSWindow respondsToSelector: 
> setCollectionBehavior])
>{

But inside that if block, where bAllowFullScreen clearly is true, it checks it
again:

> const int bMode= (bAllowFullScreen ? 
> NSWindowCollectionBehaviorFullScreenPrimary : 
> NSWindowCollectionBehaviorFullScreenAuxiliary);

Doesn't really increase one's confidence in this code (from 2012)...

Anyway, clearly it is by now pointless to do that respondsToSelector dance as
we only support macOS >= 10.9 by now. We can just use the collectionBehavior
property directly. (It as introduced in 10.7.)

Also, it seems that since 10.11 the default is for windows to be
full-screenable (in the macOS sense) by default, and to disallow that, one
needs to set the collectionBehavior property to
NSWindowCollectionBehaviorFullScreenNone . I tried that, and then the green
button turned into one with a plus sign in it, and clicking it
"maximises/unmaximises" the window (the same as double-clicking the title bar).
Probably this is better than having the green button invoke the macOS
full-screen behaviour that LO is not really prepared to handle sanely?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #21 from Tor Lillqvist  ---
Created attachment 139413
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139413=edit
Just FYI: Still in the macOS full-screen mode, but with cursor at top of screen

When in the macOS full-screen mode, moving the cursor to the top of the screen
shows the menu bar and title bar, that hide the top part of the app window and
whatever GUI widgets it might have there. That is OK and as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #18 from Tor Lillqvist  ---
Created attachment 139410
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139410=edit
Still in LO "full-screen" mode, but after moving (!) the window

Even while in LO's own "full-screen" mode, it is possible to drag the window
from the title bar. Of course, in a proper full-screen mode that should not be
possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #16 from Tor Lillqvist  ---
I find it somewhat sad that the change in comment #9 are implemented without
checking how confusing it ends up working in the end. Steve, you say
"Fullscreen (ctrl cmd F) is identical to fullscreen triggered via the green
bubble." It very obviously is not. Did not actually check? Did you not see any
difference in look or behaviour?

I really think making the Ctrl+Cmd+F shortcut toggle LO's own "full-screen"
mode was a mistake. That shortcut should mean the same as clicking the green
bubble on the title bar. It does not. We should have kept the old shortcut to
avoid confusing the two concepts.

(The green bubble toggles the macOS full-screen state, where the app window
being full-screened is on a desktop of its own and fills the screen completely,
with the title bar visible only if you move the cursor to the top. This is
completely different from LO's own "full-screen" mode, where the window stays
on the same desktop where it was. The title bar is somehow hidden sure, but the
window is actually not locked at full screen size. One can drag it smaller, and
then end up in a truly horrible and confusing state.)

I repeat, I think we should just remove the current hack to "support" macOS
full-screen mode from the code. I will do that when/if I can find inspiration.
Then just LO's own "full-screen" thing will remain.

Sure, that is far from ideal. What *should* be done, if somebody had the
inspiration and resources, would be to get rid of LO's own full-screen mode
completely on macOS, and just implement the macOS full-screen mode properly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #22 from Tor Lillqvist  ---
Created attachment 139414
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139414=edit
Frankenmode example

By mixing up sequential switch into and out of LO's full-screen mode, and in to
and out of the macOS full-screen mode, one can end up with beautiful states
like this, where the window is in macOS full-screen mode but actually is much
smaller than the screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #25 from Tor Lillqvist  ---
Re: comment #5:

Björn, a concept like "full-screen mode" most likely is present in some way on
all major desktop environments already. Does LibreOffice's home-grown
full-screen concept interact nicely and sanely with all those (except the macOS
one)? I doubt it. I doubt it is "normal" for apps to have a floating
single-button dialog to get out of full-screen mode in any desktop environment,
for instance. Instructions and especially video tutorials related to this will
always be platform-specific (and in danger of losing their relevance relatively
quickly, in a few years, as platforms evolve).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

--- Comment #20 from Tor Lillqvist  ---
Created attachment 139412
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139412=edit
After clicking the green bubble, in the macOS full-screen mode

Here I have clicked the green bubble in the title bar. The title bar and menu
bar are hidden, as they should be, but the app window does not fill the screen,
as can be seen from where the mouse cursor is. (In this state the window can
naturally not be moved or resized, it really is "full-screen" (except that it
leaves a black band at the top).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Yousuf Philips (jay)  changed:

   What|Removed |Added

URL||https://developer.apple.com
   ||/macos/human-interface-guid
   ||elines/user-interaction/key
   ||board/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Yousuf Philips (jay)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=98 |
   |259 |
  Alias||Shortcuts-Mac

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Xisco Faulí  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||xiscofa...@libreoffice.org
   Assignee|philip...@hotmail.com   |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #15 from Xisco Faulí  ---
Dear developer,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98290] Better shortcuts for the Mac OS X platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98290

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=98
   ||259
   Assignee|libreoffice-b...@lists.free |philip...@hotmail.com
   |desktop.org |
 Ever confirmed|0   |1
 OS|All |Mac OS X (All)

--- Comment #1 from Yousuf (Jay) Philips  ---
To get the ball rolling: https://gerrit.libreoffice.org/22794

Edit > Fullscreen - Cmd + Shift + J to Ctrl + Cmd + F
Tools > Spelling - F7 to Cmd + Colon
Tools > Options - None to Cmd + Semicolon

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs