[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=44
   ||029

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #37 from Justin L  ---
Fixed.  Look at comment 31 for information on how to reproduce the problem.

In terms of testing, the most likely place where a problem would show up would
be if the paragraph style contains BiDi information. If the existing code does
not properly query the style's setting then the end result might be wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

--- Comment #36 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/b524cab24b8f7c39104db7842e071599eb1d674f%5E%21

tdf#98620 filter\ww8 export: spam Jc if environment defines BiDi

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

--- Comment #35 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/08e78bc7705042d896f0d7c1eddff81d14c35d56%5E%21

tdf#98620 filter\ww8 export: spam bidi=LTR also

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

--- Comment #34 from Justin L  ---
Proposed fix in three parts:
-https://gerrit.libreoffice.org/66921 filter\ww8 export: don't spam RTL if
ParaStyle defined
-https://gerrit.libreoffice.org/66922 tdf#98620 filter\ww8 export: spam
bidi=LTR also
-https://gerrit.libreoffice.org/66923 tdf#98620 filter\ww8 export: spam Jc if
environment defines BiDi

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

Justin L  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #33 from Justin L  ---
*** Bug 122747 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

--- Comment #32 from Justin L  ---
Created attachment 145289
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145289=edit
inheritedTextDirection.odt: hard to determine paragraph style value from page
styles...

The reason it works for .ODT is because the LTR/RTL settings are stored in the
page style. The default paragraph style is set to inherit from the environment
(i.e. the page style).

The reason it does not export to .docx is because the export code says that if
the paragraph style is set to inherit from the environment, look at the locale
setting (since it doesn't know which page style to look at.)

This is the same thing I was saying in comment #28
> 2.) LO inherits RES_FRAMEDIR all the way back to the page style, but MSO
> effectively only inherits back to the parent-less paragraph styles. So, on
> export, every parentless page style needs to ensure that it writes a w:bidi
> value.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

--- Comment #31 from Justin L  ---
(In reply to Eyal Rozenberg from comment #29)
> So, can you provide clear reproduction instructions?

To reproduce this report's bug, download the .odt document from comment 0.
-start LO and set the locale to a RTL language (tools -> options -> Language
Settings -> Languages -> Locale Setting [I used Arabic - Saudi Arabia]).
-restart LO just for good measure
-open Wine Configration-1.odt. (notice that the alignment is typical LTR).
-save as .docx format.
-close and re-open the .docx file (notice that the alignment is now on the
right.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

--- Comment #30 from Justin L  ---
(In reply to Eyal Rozenberg from comment #29)
> > Note that .doc also has a problem.  The first round-trip looks OK, but then
> > it flip-flops back and forth on each round-trip.
> 
> So, can you provide clear reproduction instructions? I'm still confused and
> not able to reproduce. I'm using LO 6.2.0.0 alpha on Linux, with an Israeli
> locale but the UI language is English. What do I do _exactly_?
The off-topic tdf98620_rtlJustify.doc bug was fixed in LO 6.2 on August 22 due
to bug 106174.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

--- Comment #29 from Eyal Rozenberg  ---
(In reply to Justin L from comment #25)
> Confirming .docx problem in Linux (after first setting Locale as Arabic).
> Note that .doc also has a problem.  The first round-trip looks OK, but then
> it flip-flops back and forth on each round-trip.
> Tested with 6.2 alpha.

So, can you provide clear reproduction instructions? I'm still confused and not
able to reproduce. I'm using LO 6.2.0.0 alpha on Linux, with an Israeli locale
but the UI language is English. What do I do _exactly_?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

Lior Kaplan  changed:

   What|Removed |Added

 Blocks|112810  |43808


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
[Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues
(RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=112810
[Bug 112810] [META] Arabic language-specific RTL issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||6404

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

Justin L  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|jl...@mail.com  |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #28 from Justin L  ---
Things are way too complicated - getting out of here.

1.) A lot of things depend on RES_FRAMEDIR property existing, but none exist at
all on a brand new document.
2.) LO inherits RES_FRAMEDIR all the way back to the page style, but MSO
effectively only inherits back to the parent-less paragraph styles. So, on
export, every parentless page style needs to ensure that it writes a w:bidi
value.
3.) Because styles don't always provide a w:bidi, Paragraphs have been littered
with w:bidi settings. (See my patch - wrtw8nds). Something like that needs to
be done to the paragraph styles instead.

But don't necessarily believe anything here, because the more I think I
understand it, the more I find out how wrong I am.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

Justin L  changed:

   What|Removed |Added

 OS|Windows (All)   |All
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |
Version|5.1.1.3 release |Inherited From OOo
 Status|NEW |ASSIGNED

--- Comment #27 from Justin L  ---
The easy fix for this example document would be to set the default paragraph
style to a specific format instead of "use superordinate object settings".

For DOCX, I think the RTL problem is because it is taking the locale
(environment) setting and applying it to each paragraph:
>  If a given para is using the FRMDIR_ENVIRONMENT direction we
>  cannot export that, its its ltr then that's ok as thats word's
>  default. Otherwise we must add a RTL attribute to our export list
added pre-docx format in 2002.
https://cgit.freedesktop.org/libreoffice/core/commit/?id=2165e74081cd71d862b922546da8af96fc04b12c

Also, the ParaAdjust() function takes it's cue from the environment:
>   if ( nDir == FRMDIR_ENVIRONMENT )
>   nDir = GetExport( ).GetDefaultFrameDirection( );
from original 2010 commit "Some fixes for exporting OOXML docx files"
https://cgit.freedesktop.org/libreoffice/core/commit/?id=27b1a18b92366ace12bb54c3e21904e2eb380a18

and this detail-less 2007 commit also looks important:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=51099bf6493a7f24990da534c41f314c4624b0a8

So, a potential "fix" to make this act more like the .doc format is
https://gerrit.libreoffice.org/57356 tdf#98620 RTL: reduce environment effect
on loading docx/rtf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

--- Comment #26 from Justin L  ---
Created attachment 143489
  --> https://bugs.documentfoundation.org/attachment.cgi?id=143489=edit
tdf98620_rtlJustify.doc: flip-floping justify on each round-trip

(In reply to Justin L from comment #25)
> Note that .doc also has a problem.  The first round-trip looks OK, but then
> it flip-flops back and forth on each round-trip.

fix proposed https://gerrit.libreoffice.org/57294 related tdf#98620 ww8import:
swap justify when BiDi known

Note: to get it to flip-flop, I had set the Alignment to "Right" and the
Direction Right-To-Left

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

--- Comment #25 from Justin L  ---
Confirming .docx problem in Linux (after first setting Locale as Arabic).
Note that .doc also has a problem.  The first round-trip looks OK, but then it
flip-flops back and forth on each round-trip.
Tested with 6.2 alpha.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98620] FILESAVE: DOCX - Error in paragraph orientation after converting in a RTL user locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98620

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks|104520  |107830, 111942
Summary|Error in orientation after  |FILESAVE: DOCX - Error in
   |converting from ODT to docx |paragraph orientation after
   ||converting in a RTL user
   ||locale


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
[Bug 104520] [META] DOCX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=107830
[Bug 107830] [META] DOCX (OOXML) paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=111942
[Bug 111942] [META] User locale bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs