[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer: moving up and down with selection different objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

Yousuf (Jay) Philips  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1825

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer: moving up and down with selection different objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

--- Comment #10 from nahuel.burs...@outlook.com ---
Thank you so much for your support!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer: moving up and down with selection different objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Yousuf (Jay) Philips  ---
Confirmed fixed.

Version: 5.2.0.0.alpha1+
Build ID: 389d8db4d90d427f886d06c3f7304ad973f0d39c
CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-05-19_00:15:59
Locale: en-US (en_US)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer: moving up and down with selection different objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

--- Comment #8 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea2c3f47682b79319d5ccaade4226f45aeec7369=libreoffice-5-1

tdf#99383 vcl: don't dispatch events from SolarMutexReleaser

It will be available in 5.1.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer: moving up and down with selection different objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0|target:5.2.0 target:5.1.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer: moving up and down with selection different objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

--- Comment #7 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea3ce0b3073c72f474365e438ddabd19de915b76

tdf#99383 vcl: don't dispatch events from SolarMutexReleaser

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer: moving up and down with selection different objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer: moving up and down with selection different objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

Cor Nouws  changed:

   What|Removed |Added

Summary|Problem with toolbar in LO  |Problem with toolbar in LO
   |Writer  |Writer: moving up and down
   ||with selection different
   ||objects

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

--- Comment #6 from Michael Stahl  ---
Created attachment 124707
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124707=edit
stack trace of the premature idle invocation

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

--- Comment #5 from Michael Stahl  ---
the problem is apparently caused by TransferableHelper::CopyToSelection using
SolarMutexReleaser.

... [ the message being dispatched there is SAL_MSG_TIMER_CALLBACK ... actually
no the message isn't dispatched there usually only when the debugger messes up
the timing ]

... real problem is an Idle being dispatched - SfxDispatcher::EventHdl_Impl
- this pops a SwTextShell, SwNavigationShell off the stack and pushes
SwNavigationShell and then it calls SfxDispatcher::Update_Impl which apparently
updates the toolbar.

... this is happening inside SwView::SelectShell, here:

eShellMode = SHELL_MODE_DRAW;
m_pShell = new SwDrawShell( *this );
rDispatcher.Push( *m_pShell );

the SwDrawBaseShell constructor calls the CopyToSelection stuff...
clearly it's not intended that the SfxDispatcher idle handler runs before
the new shell is pushed onto the SfxDispatcher.

the SfxDispatcher::xImp->aIdle is started from SfxDispatcher::Pop().

so either we shouldn't run the idle handler via SolarMutexReleaser,
or something needs to prevent execution of the SfxDispatcher idle handler until
the stack manipulation is finished.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||mst...@redhat.com

--- Comment #4 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Michael Stahl; Could you possibly take a look at this one? Thanks

c8b0384eac2821548e6cf6d632f738441ff74dba is the first bad commit
commit c8b0384eac2821548e6cf6d632f738441ff74dba
Author: Norbert Thiebaud 
Date:   Wed Jul 22 19:39:47 2015 -0700

source sha:482c52e91fe41a52e68827e9bf64a9736427d517
authorMichael Stahl 2015-06-26 11:01:51 (GMT)
committerMichael Stahl 2015-06-26 21:14:46 (GMT)
commit482c52e91fe41a52e68827e9bf64a9736427d517 (patch)
treee71ffbc0d540833494e326f4bb03d10e21e97a14
parentc1e12b15e55a82f062960f40921e0c97afda2078 (diff)
vcl: fix Win32 deadlocks from SolarMutexReleaser

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

Yousuf (Jay) Philips  changed:

   What|Removed |Added

   Keywords|needsUXEval |bibisectRequest, regression
 CC|libreoffice-ux-advise@lists |momonas...@gmail.com,
   |.freedesktop.org|philip...@hotmail.com,
   ||tietze.he...@gmail.com,
   ||todven...@suomi24.fi
   Hardware|x86-64 (AMD64)  |All

--- Comment #3 from Yousuf (Jay) Philips  ---
This is a windows-only regression and it doesnt happen in 5.0.5.2.

Steps:
1) Open writer
2) Draw a shape
3) Click off the shape and the 'Formatting' toolbar appears without the 2nd
toolbar row disappearing
4) Click the shape and the 2nd toolbar row will disappear before the 'Drawing
Object Properties' toolbar appears.

(In reply to Heiko Tietze from comment #2)
> Devs POV is that you go into formula/chart/etc. edit mode, which is kind of
> a different application, and get the appropriate UI for that.

The problem shown in attachment 124480 isnt about the toolbar issue when
jumping into edit mode of OLE objects, but simply clicking on regular objects
within a document, which changes the contextual formatting toolbar row. I had
noticed this bug when you were screencasting on google hangouts from your
windows VM, but assumed it was something specific to your setup. :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

--- Comment #2 from Heiko Tietze  ---
This is one of the most often reported annoyances. Switching the context leads
to jumping UI.
Devs POV is that you go into formula/chart/etc. edit mode, which is kind of a
different application, and get the appropriate UI for that.  UX tries to
counteract this behavior by providing functions and properties from the
sidebar.
Meanwhile you could make the secondary toolbar floating, but I admit that this
isn't a good workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

raal  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|UNCONFIRMED |NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||r...@post.cz
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
I can confirm with LO 5.2, win10.  UX team - this is for sure known problem,
but I can not find duplicate, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs