[Libreoffice-bugs] [Bug 99809] Update documentation of BASIC's Rnd function and Randomize statement

2016-05-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99809

--- Comment #9 from Johnny_M  ---
(In reply to Johnny_M from comment #7)
> That has been fixed with the above commit (comment 6). The auto-removal of
> the  and  tags was the issue - see
> https://listarchives.libreoffice.org/global/documentation/msg18778.html for
> background info.

See related HelpAuthoring extension bug 94059.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99809] Update documentation of BASIC's Rnd function and Randomize statement

2016-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99809

--- Comment #8 from Johnny_M  ---
(In reply to Johnny_M from comment #7)
> > - The code example indentation is wrong throughout the BASIC help pages
> > (just two spaces, no sub-indentation for statements, etc.), i.e. also on
> > those which weren't updated
> 
> That had actually existed before the Rnd and Randomize update, which makes
> it a separate issue. Confirmed pre-existing with:
> Version: 5.2.0.0.alpha1+
> Build ID: db729f3b685fd832a3ec7387b339cf2bbeb4bd4d
> CPU Threads: 2; OS Version: Linux 4.3; UI Render: default; 
> TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-05-13_00:37:45
> Locale: en-US (en_US.UTF-8)

Submitted bug 99861 for that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99809] Update documentation of BASIC's Rnd function and Randomize statement

2016-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99809

--- Comment #7 from Johnny_M  ---
(In reply to Johnny_M from comment #4)
> And there seem to be following issues:
> - The syntax highlighting of BASIC code examples is missing on the updated
> pages (Rnd and Randomize)

That has been fixed with the above commit (comment 6). The auto-removal of the
 and  tags was the issue - see
https://listarchives.libreoffice.org/global/documentation/msg18778.html for
background info.

Confirmed fixed with:
Version: 5.2.0.0.alpha1+
Build ID: a3123cd0105c1feec3a06d071c97cb758b307bf8
CPU Threads: 2; OS Version: Linux 4.3; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-05-15_10:23:02
Locale: en-US (en_US.UTF-8)

> - The code example indentation is wrong throughout the BASIC help pages
> (just two spaces, no sub-indentation for statements, etc.), i.e. also on
> those which weren't updated

That had actually existed before the Rnd and Randomize update, which makes it a
separate issue. Confirmed pre-existing with:
Version: 5.2.0.0.alpha1+
Build ID: db729f3b685fd832a3ec7387b339cf2bbeb4bd4d
CPU Threads: 2; OS Version: Linux 4.3; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-05-13_00:37:45
Locale: en-US (en_US.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99809] Update documentation of BASIC's Rnd function and Randomize statement

2016-05-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99809

--- Comment #6 from Commit Notification 
 ---
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/help/commit/?id=ce76ee35c4ee0c5cd6e7b450df2d95b289461e2d

tdf#99809 Add back some syntax highlighting tagsā€¦

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99809] Update documentation of BASIC's Rnd function and Randomize statement

2016-05-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99809

--- Comment #5 from Adolfo Jayme  ---
> The code example indentation is wrong throughout the BASIC help pages

That should be reported separately, please.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99809] Update documentation of BASIC's Rnd function and Randomize statement

2016-05-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99809

Adolfo Jayme  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99809] Update documentation of BASIC's Rnd function and Randomize statement

2016-05-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99809

Johnny_M  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
   Assignee|kla...@partyheld.de |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99809] Update documentation of BASIC's Rnd function and Randomize statement

2016-05-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99809

--- Comment #4 from Johnny_M  ---
Created attachment 125044
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125044&action=edit
Schreenshot on current master after commit (missing code syntax highlighting,
wrong indentation)

I've just checked the result on 32-bit Debian Jessie, with:
Version: 5.2.0.0.alpha1+
Build ID: efc05c0a1ecac549c8340a8f9ec4e47556569adc
CPU Threads: 2; OS Version: Linux 4.3; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-05-13_23:40:27
Locale: en-US (en_US.UTF-8)

And there seem to be following issues:
- The syntax highlighting of BASIC code examples is missing on the updated
pages (Rnd and Randomize)

- The code example indentation is wrong throughout the BASIC help pages (just
two spaces, no sub-indentation for statements, etc.), i.e. also on those which
weren't updated

Does anyone know why that is?


P.S.: Some remarks:
- The pages were updated using the current "HelpAuthoring-3.1.4.oxt" extension
on LO 5.0.6, which automatically removed all  and  tags, in
case that matters.

- Before committing, I had checked the results with LO 5.0.6, as described in
https://wiki.documentfoundation.org/HelpContent#Without_the_LibreOffice_Core_Repo,
and BASIC code examples on all help pages (i.e. also the ones not modified)
were missing the highlighting, so that I assumed that it's something to be
fixed by an actual LO build process.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs