[Libreoffice-bugs] [Bug 99870] EDITING: "Delete Comment" in Comment drop-down menu sometimes deletes the commented text!

2016-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99870

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99870] EDITING: "Delete Comment" in Comment drop-down menu sometimes deletes the commented text!

2016-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99870

--- Comment #5 from Justin L  ---
Pushing and popping the SwWrtShell does MORE than just save and restore the
current state. This bug's "delete comment" action DEPENDS on the extra
side-effects of the pop routine to function, specifically
m_fnKillSel = &SwWrtShell::ResetSelect

proposed fix at https://gerrit.libreoffice.org/25216

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99870] EDITING: "Delete Comment" in Comment drop-down menu sometimes deletes the commented text!

2016-05-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99870

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=94
   ||679

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99870] EDITING: "Delete Comment" in Comment drop-down menu sometimes deletes the commented text!

2016-05-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99870

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||r...@post.cz

--- Comment #4 from raal  ---
d9f4bb0bec4f5c5b8485a6ba3b693f15480d2f08 is the first bad commit
commit d9f4bb0bec4f5c5b8485a6ba3b693f15480d2f08
Author: Norbert Thiebaud 
Date:   Fri Oct 9 19:25:20 2015 -0700

source sha:fb62052d5ac069d700a5410db35d6949a4c4008b

author  Justin Luth2015-10-03 06:35:26 (GMT)
committer   Caolán McNamara 2015-10-09 13:57:18
(GMT)
commit  fb62052d5ac069d700a5410db35d6949a4c4008b (patch)
treec1196bde7be30eb500296e3a475b2ea7a9766712
parent  4850edd31afa16401ac7c94d8bd1b02525fbe718 (diff)
tdf#94679 Writer: fix lost selection with Shift-PageDown

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99870] EDITING: "Delete Comment" in Comment drop-down menu sometimes deletes the commented text!

2016-05-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99870

--- Comment #3 from Luke Kendall  ---
I'd do more if I had time, but I'm absolutely flat out, trying to get this 2nd
book ready for the series launch on July 9th!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99870] EDITING: "Delete Comment" in Comment drop-down menu sometimes deletes the commented text!

2016-05-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99870

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
 OS|Linux (All) |All

--- Comment #2 from Buovjaga  ---
(In reply to Luke Kendall from comment #0)
> 1.
> Select the text in the body of the document which the comment highlights
> (being careful to select the text and using the extra Shift-(Right-arrow)
> key to make sure the comment itself is also selected
> 2.
> Without de-selecting the body text, bring up the comment's menu.
> 3.
> Click on the "Delete Comment" menu item.
> 
> Result:
> Comment *and body text selected* is deleted when you choose "Delete comment".

Repro.

No problem in 5.0.2.2

Luke: you might want to make a habit of testing with older versions :)
https://wiki.documentfoundation.org/Installing_in_parallel/Linux

Win 7 Pro 64-bit Version: 5.2.0.0.alpha1+
Build ID: f688acfdae00ebdd891737e533d54368810185e1
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-05-18_00:11:31
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99870] EDITING: "Delete Comment" in Comment drop-down menu sometimes deletes the commented text!

2016-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99870

--- Comment #1 from Luke Kendall  ---
I just watched very closely regarding the detail I reported, about LO sometimes
ignoring the first click into a document (and leaving the highlighted comment
text selected).

It definitely happens, but that itself is hard to reproduce.

I see that when the text that's commented is selected, you can tell because the
area gets a reddish colour wash (including a single pixel red outline).  But
just now, after copying the text and comment across, and spending a few minutes
working in the newer document, when I clicked back into the body of the older
document with the comment, the text was still selected; I waited 40 seconds but
the mouse click into that document never caused the selection to de-select.  I
had to click a second time to make it de-select.

But when I tried to reproduce this small aspect of the behaviour, I couldn't. 
I think this is the source of the randomness that made the problem not happen
all the time: now I see that usually, the selection in one document is
de-selected when you change focus to a 2nd document.  But occasionally, it
doesn't de-select: it remains selected in the 1st doc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99870] EDITING: "Delete Comment" in Comment drop-down menu sometimes deletes the commented text!

2016-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99870

Luke Kendall  changed:

   What|Removed |Added

Summary|EDIT: "Delete Comment" in   |EDITING: "Delete Comment"
   |Comment drop-down menu  |in Comment drop-down menu
   |sometimes deletes the   |sometimes deletes the
   |commented text! |commented text!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs