[Bug 158576] Improve macro signature confirmation dialog

2023-12-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158576

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #8 from Heiko Tietze  ---
The patch makes LibreOffice bypass the confirmation dialog and gives the
relevant feedback via infobar/s (like when "Disable Macros" has been pressed).
That works but is a bit odd since two if's are combined (macro, certificate)
and behave differently.

Anyway, feel free to close the dialog as resolved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158576] Improve macro signature confirmation dialog

2023-12-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158576

--- Comment #7 from Samuel Mehrbrodt (allotropia) 
 ---
(In reply to Heiko Tietze from comment #6)
> (In reply to Commit Notification from comment #5)
> > Samuel Mehrbrodt committed a patch related to this issue.
> 
> Guess you plan adding another patch later, right?

Probably... still some things can be improved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 130278] Line spacing "Fixed" not setable if the odt comes from doc

2023-12-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130278

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org

--- Comment #7 from V Stuart Foote  ---
(In reply to Dieter from comment #6)
> ... 
> and I'm a bit confused now
> 
> Help [1] says: "Line spacing - Specify the amount of space to leave between
> lines of text in a paragraph." but in fact it also sets the spacing between
> paragraphs. If this is intended, help should incude this information. And if
> it is intended, the bug description in comment 0 is correct.
> 

The 'Line Spacing' affects only the lines of text (i.e. external leading)
within a paragraph.

The 'Spacing' -> 'Above paragraph' and 'Below paragraph' affect the additional
leading between paragraphs. Those will apply to the 'aaa' style of the test
document.

So that is not issue here. However, there is something incorrect with the
source document's 'aaa' PS style and its 'Fixed' line spacing at ".13" --
confirming the mishandling by LO. Editing the line spacing of the style and
applying does not adjust. Also clearing Direct Formatting does not affect.

However, creating a new document with a new style and applying Fixed line
spacing behaves as expected.

So something in the original MS Word doc -- seems like the "P59" style and
"aaa" .321cm Line-height for the style got munged on conversion?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 130278] Line spacing "Fixed" not setable if the odt comes from doc

2023-12-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130278

Dieter  changed:

   What|Removed |Added

Summary|Line spacing not setable if |Line spacing "Fixed" not
   |the odt comes from doc  |setable if the odt comes
   ||from doc
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #6 from Dieter  ---
Retested with

Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (de_DE); UI: en-GB
Calc: CL threaded

and I'm a bit confused now

Help [1] says: "Line spacing - Specify the amount of space to leave between
lines of text in a paragraph." but in fact it also sets the spacing between
paragraphs. If this is intended, help should incude this information. And if it
is intended, the bug description in comment 0 is correct.

so I add design-team for double-check.


Steps
1. Open attachment 157520. Every paragraph has PS "aaa"
2. Edit PS "aaa" -> Tab Indents & Spacing -> Line Spacing -> Fixed
3. Change value to 10pt (or any other value) and click "Apply" button

Actual result
No change in spacing

Expected result
Change in spacing

4. Change value to double (Works as expected)


[1]
https://help.libreoffice.org/7.6/en-GB/text/shared/01/05030100.html?System=WIN=WRITER=cui/ui/paraindentspacing/ParaIndentSpacing#bm_id3145138

-- 
You are receiving this mail because:
You are on the CC list for the bug.