[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Assignee|libreoffice-b...@lists.free |heiko.tietze@documentfounda
   |desktop.org |tion.org
 Status|NEW |ASSIGNED

--- Comment #20 from Heiko Tietze  ---
We discussed the topic in the design meeting.

The summary in comment 15 got supported. We pondered over the need for UI
options, eg. Tools > Options > Calc > View, but should better strive for clean
dialogs. And if the default would be better, such an option might not be needed
anymore.

Since the calculation considers DPI*Zoom*6 plus and the base value 4, just one
number could be not enough. And two options sounds also not user-friendly. So
I'm going to change the default calculation from 6/4 (DPI/ZOOM 100/100 => 10,
100/50 => 7, 100/150 => 13) to 3/3 (DPI/ZOOM 100/100 => 6, 100/50 => 4, 100/150
=> 8) - this makes the indicator very small. I'll also use the grid color for
the border and move the triangle to the very edge. For the customization I'm
going to introduce an expert option that does the dynamic thing for a value <=0
and otherwise uses it as fix pixel size independent from zoom and DPI.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #19 from ady  ---
(In reply to Eyal Rozenberg from comment #18)
> The content should be excluded
> from the comment indicator area of the cell so that it doesn't overlap its
> area.

That's unacceptable. The limitation is on LO to resolve, instead of
limiting/affecting the user, just because of a problem that LO is causing.
Additionally, that would alter how the spreadsheet looks, especially when
comparing with opening the same spreadsheet with any other tool. Think about a
cell with centered alignment, for instance.

Are you suggesting that the cell should be altered (in content and/or size)
every time a comment is either added or deleted? Or when opening older
spreadsheets?

LO already altered the presentation of the comments themselves with the way the
author and date+time info was forcibly added on every comment, whether the user
needs/wants that or not. More than one report was started related to that.
Users asked to improve the indicator because it bothers, and instead of
improving the documentation about how to avoid such issue (especially for
inexperienced users), LO made the indicator even bigger. And now there is this
idea that the presentation of the cell (content and/or size) has to change
because of the indicator? How many users would be "pleased" with that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #18 from Eyal Rozenberg  ---
Didn't we discuss this issue last time the comment marker came up?

Anyway, I say it's not the size, it's the fact that the cell contents is
allowed to overlap so much of the marker. The content should be excluded from
the comment indicator area of the cell so that it doesn't overlap its area.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #17 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #15)
> +1 
> * expert options to control the dynamic size
> * option to disable the dynamic size
Looks best to me.
& thanks to all for patiently explaining the various ideas ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #16 from Stephane Quenson  ---
As a user of Calc and contributor to the forum https://ask.libreoffice.org/, I
support the idea to have an expert option that would allow to define the shape,
its size and color.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #15 from Heiko Tietze  ---
-1
* user-defined symbol
* revert the patch
* some default margin to make space for the symbol

-0.5
* UNO command to toggle the indicator on/off
* less obtrusive default color 

+0.5
* different position for the indicator

+1 
* expert options to control the dynamic size
* option to disable the dynamic size


In the end any solution will have shortcomings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #14 from ady  ---
(In reply to V Stuart Foote from comment #11)
> (In reply to ady from comment #9)
> 
> Yes it does make your objections invalid--UX decision was made for bug
> 153106 and a revert of the bug 91415 zoom responsive triangle marking for
> comments remains, and yes you have harped on it repeatedly with no traction
> for a revisit, frankly annoyingly so. 

Deciding something doesn't make facts and objective points to be false. You
still have such prerogative of deciding something, but, as this new report
shows, it doesn't invalidate anything. There were no reasons given for the
decision (in the reports themselves nor in the relevant mailing lists), just
that a decision was made. Since developers actually recognized that they didn't
care to read the points I made (but kept asking the same things repeatedly), it
couldn't be that annoying – they just ignored the posts. The questions I was
asked to repeatedly explain in absurd extreme detail the problem and the
proposed alternatives back then just show the clear difference between
developing code for Calc and being an actual user. The distortion and personal
trashing are much annoying.

Although re-purposing this ticket derails the matter in question (again), let's
see if at least something positive comes out; I'll mark this post as OT with
that hope.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #13 from inso...@yandex.ru ---
Yes, marker is drawn behind the cell's data values, the cells values are
visible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #12 from V Stuart Foote  ---
(In reply to insonus from comment #10)

Believe the current zoom responsive triangle marker is already drawn behind the
cell's data values. The cells values are visible and not obscured, though
contrast against the marker can be a bit low.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #11 from V Stuart Foote  ---
(In reply to ady from comment #9)

Yes it does make your objections invalid--UX decision was made for bug 153106
and a revert of the bug 91415 zoom responsive triangle marking for comments
remains, and yes you have harped on it repeatedly with no traction for a
revisit, frankly annoyingly so. 

What is needed as Heiko notes comment 6, and bug 153106#33, are UI controls of
display of the markers (so the Comment, and also data overflow, and formula
marks).  

For that I personally favor a single simple UNO for all 3 markers available to
assign for keyboard shortcut as well as Menu, and TB button use to toggle
visibility at the zoom appropriate size.

Calc sheet Zoom toggle noted in bug 91415 actually remains functional
(+MouseWheel) while the Zoom-in and Zoom-out shortcuts were reassigned
(now +) for cross module consistency.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #10 from inso...@yandex.ru ---
I think we should assume that the data is primary. The comment indicator should
in no case interfere with the data at any viewing scale. I think a better
option would be to give the user the ability to customize the appearance and
behavior of the comment indicator. I am not ready to explain exactly how this
indicator should look, but I believe that it should either not interfere with
the data at all, or be located behind the data. The data should be in the
foreground and clearly visible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #9 from ady  ---
(In reply to V Stuart Foote from comment #8)
> No, bug 153106 was closed => WF for the reversion of the marker, with
> expectation there would be an UNO enhancement ticket to control the Comment
> indicator (Tools -> Options -> Calc -> View) and "quickly switch this option
> on/off".
> 
> We could repurpose this to be that enhancement... UNO to toggle the comments
> (and Formula and extended content indicators) temporarily hidden.

I opened tdf#153106, because I was told that reopening the first one was not
the proper procedure. The main point I tried to convey back then was that the
changes that were made to the comment indicator were not as welcome as some
developers might had thought – to put it elegantly. I expressed not just a
subjective opinion, but rather a lot of objective points, multiple times.

The UNO toggle (which I agree with its need, convenience and goal, and which is
independent of the original report) was/is a secondary matter regarding the
discussion in tdf#153106. The fact that Heiko closed it as WF doesn't make my
objections invalid. I still claim that the changes to the comment indicator
were/are not an improvement, and that it should be smaller and not growing with
zoom-in factors. I am not going to mention yet again the many objective reasons
I raised back then.

This new report/request is mainly about the same: to (at least partially)
revert the changes to the (bigger) size and (growing) behavior of the comment
indicator. If QA wants to re-purpose this report, fine; but let's first be
clear about what the original reporter was asking, and about what the prior
reports were about.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3106

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org

--- Comment #8 from V Stuart Foote  ---
No, bug 153106 was closed => WF for the reversion of the marker, with
expectation there would be an UNO enhancement ticket to control the Comment
indicator (Tools -> Options -> Calc -> View) and "quickly switch this option
on/off".

We could repurpose this to be that enhancement... UNO to toggle the comments
(and Formula and extended content indicators) temporarily hidden.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

--- Comment #7 from ady  ---
(In reply to Heiko Tietze from comment #6)
> See my bug 91415 comment 6.

And don't forget about bug 153106. Carefully written words, never read with the
required attention. So, here we are. Am I surprised? Not at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158958] Comment marker makes it difficult to see the data in a cell

2024-01-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158958

Heiko Tietze  changed:

   What|Removed |Added

 Blocks||101216
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=91
   ||415
 CC|heiko.tietze@documentfounda |libreoffice-ux-advise@lists
   |tion.org|.freedesktop.org
 OS|Windows (All)   |All
   Keywords||needsUXEval

--- Comment #6 from Heiko Tietze  ---
How about an option to switch off the dynamic marker? The alternative is a fix
size covering much content when zoomed out, eg 50%, but less when zoomed in.
Otherwise, I'm open for suggestions. The solution was an attempt to solve
exactly the same problem. See my bug 91415 comment 6.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101216
[Bug 101216] [META] Calc comment bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.