[Libreoffice-ux-advise] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130719

--- Comment #8 from Cor Nouws  ---
(In reply to Dieter from comment #1)

> Version: 7.0.0.0.alpha0+ (x64)
> Build ID: c63148ba139bd6b9ae7a0f9e24e51f29e5370963
> CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL:
Can you maybe test 6.4.0 on Windows, Dieter?
thnx!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130719

--- Comment #7 from Cor Nouws  ---
I just tried in Versie: 6.4.0.3
Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU-threads: 8; Besturingssysteem: Linux 5.3; UI-render: standaard; VCL: gtk3; 
Locale: nl-NL (en_US.UTF-8); UI-taal: nl-NL
Calc: threaded

It works as expected. Existing styles are overwritten by styles in the selected
document/template.
Also Marginalia.

So maybe a bug on Windows only ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130719

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #6 from Cor Nouws  ---
Hi !

Only looking into this now. Sorry..


(In reply to Jamie Dimmel from comment #2)
> The way that I would understand:
> "Overwrite.
> Replaces styles in the current document that have the same name as the
> styles you are loading.
> Styles with identical names are automatically overwritten."
> 
> would be that any style in the current document, that has the same name as a
> style in the document (or template) that you are loading, would be
> automatically overwritten.
> 
> So if I changed the Marginalia paragraph style, it would automatically get
> overwritten by the Marginalia paragraph style in the importing template.
That is fully correct and how it always worked.

Pick any template/document to load styles from, and all style types that you
mark and of which the names are the same in active document and document to
load, are overwritten. That is how it is designed.

> If that's NOT the case, why would it be labeled as "overwrite" then? I just
> don't understand that.
If (will check) it's a bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130719

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||1347

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130719

--- Comment #5 from Jamie Dimmel  ---
Thank you for the explanation.

I wasn't thinking about styles being hardcoded and not appearing in a 'default'
template. I just assumed all styles were in the default templates, and thus
could overwrite any non-custom styles back to template (or program) defaults.

As an end user I do (or would) find it useful to be able to reset all styles in
a doc back to their original (whether program or template) defaults, rather
than saving a file to plain text, then save back to odt, since if you use the
latter method you lose the link between blocks of text and styling.

I guess this becomes an issue for the user interface or design group then. In
the meantime, I'll just create my own template with all standard styles so I
can use it to overwrite something if I need to.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130719

--- Comment #4 from Mike Kaganski  ---
So the problem is: a template shipped with LibreOffice (named "Default"?) does
not include an explicit definition of a standard style in it, thus any document
created from it has that style auto-generated from the hardcoded defaults; and
of course, overwriting styled of a specific document with styles of that
template does not affect any styles absent in the template definition?

Possibilities:

1. Make sure to define all the styles in shipped templates
   - maintenance burden: in case a default is changed in code, the templates
need to be edited to comply (it would be a shame if shipped templates don't do
what is considered good for a default case without a reason).
   - possible implementation problem (not checked): doesn't LO strips out a
definition that fully matches the default?

2. Make the Load Styles to always load full set of standard styles - from
defaults if absent
   + would not need maintenance of templates
   - would disallow the opposite need: if someone wants to not include some of
the standard style in the hope that it does *not* get updated (no idea if that
is a real case, just speculating)

2.1. Make it ("[x] Overwrite standard styles absent in the template with
defaults") optional in Load Styles dialog
   + keeps flexibility

3. NOTABUG/WONTFIX

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130719

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||jumbo4...@yahoo.fr,
   ||mikekagan...@hotmail.com

--- Comment #3 from Heiko Tietze  ---
(In reply to Jamie Dimmel from comment #0)
> Steps to Reproduce:
> 1. Change some paragraph styles...
> 4. Styles > Load Styles... (check) Overwrite

In fact the style Marginalia is not overridden likewise Text Body Indent. But
the function affects Default, Heading, and Text Body, for instance. 

If the template document has not defined the style it will consequently not
affect the current document. See also
https://opengrok.libreoffice.org/xref/core/extras/source/templates/styles/Default/styles.xml
(it contains Standard, Heading, Text body, List, Caption, Index, Quotations,
Title, Subtitle, Heading 1 .. Heading 7; and I'm pretty sure LBP took what was
defined before in the effort of solving bug 114749).

So the question boils down to "Can you expect the template 'Style > Default' to
reset the default"? Wouldn't say so as it is some "random" template and not
meant as a style reset tool. But opposite opinions are welcome and the solution
would be to define all internal styles in this template.


The immediate solution for your workflow is to create a template with all
styles you want to use and take this instead of the shipped.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130719

--- Comment #2 from Jamie Dimmel  ---
I'm afraid I am confused. Isn't that the opposite of what help says?

The way that I would understand:

"Overwrite.
Replaces styles in the current document that have the same name as the styles
you are loading.
Styles with identical names are automatically overwritten."

would be that any style in the current document, that has the same name as a
style in the document (or template) that you are loading, would be
automatically overwritten.

So if I changed the Marginalia paragraph style, it would automatically get
overwritten by the Marginalia paragraph style in the importing template.

If that's NOT the case, why would it be labeled as "overwrite" then? I just
don't understand that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130719

Dieter  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|
 Blocks||108380
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #1 from Dieter  ---
I can't confirm it with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: c63148ba139bd6b9ae7a0f9e24e51f29e5370963
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

None of the customised styles have been overwritten.

Regarding to help [1] I think that's the expected behaviour: "Load Styles-
Imports formatting styles from another document or template into the current
document ... Overwrite - Replaces styles in the current document that have the
same name as the styles you are loading. 

So for me NOTABUG. Do yu agree?

cc: Design-Team (perhaps I'm wrong with NOTABUG)


[1]
https://help.libreoffice.org/7.0/en-GB/text/swriter/01/0517.html?System=WIN=WRITER=sfx/ui/loadtemplatedialog/dialog-action_area1#@@nowidget@@


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108380
[Bug 108380] [META] Load styles bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise