[Libreoffice-ux-advise] [Bug 149047] Should .uno:ObjectMenue be shown in the Customize dialog?
https://bugs.documentfoundation.org/show_bug.cgi?id=149047 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk |desktop.org | Status|NEW |ASSIGNED CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #8 from Heiko Tietze --- (In reply to sdc.blanco from comment #7) > > However, the very same command is labelled "OLE Object" at the toolbar. > > No idea why. Was fooled by ...swreport/toolbar/..., which is different to the ordinary insertbar. > Instead of attempting to remove them from appearing in the Customize menu, > modify the labels of .uno:InsertObjCtrl and .uno:InsertObject so that they > are better differentiated, and easier to see what they are likely to be used > for. > > https://gerrit.libreoffice.org/c/core/+/134434 Sounds good to me. And probably safer than hiding. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 149047] Should .uno:ObjectMenue be shown in the Customize dialog?
https://bugs.documentfoundation.org/show_bug.cgi?id=149047 --- Comment #7 from sdc.bla...@youmail.dk --- (In reply to Heiko Tietze from comment #5) A few points of clarification... > (In reply to sdc.blanco from comment #4) > > 1. Maybe .uno:InsertObjCtrl should not be in the Customize menu? > This command has the label "Insert Object" and is used on the "Insert" > toolbar but hidden by default. Yes, but in only one insert toolbar -- sw/uiconfig/swreport/toolbar/insertbar.xml (among several), but could not find out where it is actually used. (A "report" from Base uses sw/uiconfig/sglobal/toolbar/insertbar.xml ) > However, the very same command is labelled "OLE Object" at the toolbar. > No idea why. To explain why: When you write "labelled", I think (hope) you mean the appearance of the icon on the toolbar (and not the tooltip, which is "Insert Object"). Right? The icon appearance can be explained quite simply. Both .uno:InsertObjCtrl (Insert Object) and .uno:InsertObject (OLE Object) have been assigned to same icon -- possibly as a confusion, when the label for the first is identical to the .uno name of the second. > Hiding an entry is not possible for one but all areas ---but good reasons > at least for ObjectMenu, I think .uno:ObjectMenu is already hidden. I could not find it in Customize. The motivation for the OP was primarily to improve the usability of the Customize dialog. Miklos in comment 6 introduces the important possibility that .uno:InsertObjCtrl and .uno:ObjectMenue could be part of the win32 API -- which could explain why they appear in officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu Conclusions: Instead of attempting to remove them from appearing in the Customize menu, modify the labels of .uno:InsertObjCtrl and .uno:InsertObject so that they are better differentiated, and easier to see what they are likely to be used for. https://gerrit.libreoffice.org/c/core/+/134434 This might come close enough to resolving (or at least improving) this issue. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 149047] Should .uno:ObjectMenue be shown in the Customize dialog?
https://bugs.documentfoundation.org/show_bug.cgi?id=149047 --- Comment #6 from Miklos Vajna --- (In reply to Heiko Tietze from comment #3) > The "Object" submenu is not a command (similar File > Recent Documents) but > a customizable menu structure. The command uno:ObjectMenue is filled with > content in ObjectMenuController::fillPopupMenu using > MS_VERBATTR_ONCONTAINERMENU. But no idea what that is, the command remains > disabled for me. Most of the OLE embedded object code only works on Windows, where it can do win32 API calls to actually embed an external app to edit some embedded document. So if you make changes there, be sure to test your changes on Windows. Other platforms only support the (somewhat corner-case) "common" embedded object (Writer in Calc, etc) or "dummy" embedded object (just an image with some data which is retained on save). -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 149047] Should .uno:ObjectMenue be shown in the Customize dialog?
https://bugs.documentfoundation.org/show_bug.cgi?id=149047 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #5 from Heiko Tietze --- (In reply to sdc.blanco from comment #4) > 1. Maybe .uno:InsertObjCtrl should not be in the Customize menu? This command has the label "Insert Object" and is used on the "Insert" toolbar but hidden by default. However, the very same command is labelled "OLE Object" at the toolbar. No idea why. > 2. Does the Customize dialog show "Label" or "Context Label"? If "Label", > then maybe Label should be "Insert Ole Object" and then Context Label "Ole > Object" (and tooltip can be improved). It's the label (with details in the text box below the list). Hiding an entry is not possible for one but all areas (see bug 147411 and bug 112620). But we have good reasons, at least for ObjectMenu, to hide and from my side it's all green do so generally- and bring back if users complain. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 149047] Should .uno:ObjectMenue be shown in the Customize dialog?
https://bugs.documentfoundation.org/show_bug.cgi?id=149047 --- Comment #4 from sdc.bla...@youmail.dk --- Will also ask here about .uno:InsertObjCtrl because same kind of issue, which can probably be handled in the same file (and move to new ticket if need be). Search on "object" in customize dialog. Note: Insert Object -- .uno:InsertObjCtrl and OLE Object -- .uno:InsertObject Note that icon for Insert Object appears the same as OLE Object when added to a toolbar. Both open the Insert Ole Object dialog. Both are active when an object is not selected, but .uno:InsertObjCtrl is also active when an OLE object is selected, while .uno:InsertObject is not active. .uno:InsertObjCtrl seems to provide a empty dropdown menu, and given that it has the same icon as appears in the Insert menu, I am guessing that it has the same kind of purpose as .uno:Objectmenue. Questions: 1. Maybe .uno:InsertObjCtrl should not be in the Customize menu? 2. Does the Customize dialog show "Label" or "Context Label"? If "Label", then maybe Label should be "Insert Ole Object" and then Context Label "Ole Object" (and tooltip can be improved). -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 149047] Should .uno:ObjectMenue be shown in the Customize dialog?
https://bugs.documentfoundation.org/show_bug.cgi?id=149047 Heiko Tietze changed: What|Removed |Added Keywords||needsDevAdvice CC||vmik...@collabora.com --- Comment #3 from Heiko Tietze --- The "Object" submenu is not a command (similar File > Recent Documents) but a customizable menu structure. The command uno:ObjectMenue is filled with content in ObjectMenuController::fillPopupMenu using MS_VERBATTR_ONCONTAINERMENU. But no idea what that is, the command remains disabled for me. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 149047] Should .uno:ObjectMenue be shown in the Customize dialog?
https://bugs.documentfoundation.org/show_bug.cgi?id=149047 --- Comment #2 from sdc.bla...@youmail.dk --- (In reply to Heiko Tietze from comment #1) > If you want to customize the menu this command is relevant, isn't it? Is it? Insert | Object is already provided as a submenu. Adding this command to the Insert menu simply gives an inactive command. Insert > Insert Submenu provides a way to add submenus. What am I missing? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 149047] Should .uno:ObjectMenue be shown in the Customize dialog?
https://bugs.documentfoundation.org/show_bug.cgi?id=149047 --- Comment #1 from Heiko Tietze --- If you want to customize the menu this command is relevant, isn't it? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 149047] Should .uno:ObjectMenue be shown in the Customize dialog?
https://bugs.documentfoundation.org/show_bug.cgi?id=149047 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||103238 CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103238 [Bug 103238] [META] Customize dialog bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
