[Libreoffice-ux-advise] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| --- Comment #55 from Heiko Tietze --- (In reply to Philip Rayment from comment #54) > The cycling ALREADY changes text outside the selection. That's the problem... Seems we agree on the required change. Cycle case should work on the selection and if there is none on the full sentence (as today). The consideration of automatically selection or doing nothing was misleading and might confuse users. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033 --- Comment #53 from Heiko Tietze --- (In reply to V Stuart Foote from comment #51) > Might be cleaner to explicitly do nothing unless there is a selection made. That would feel like a regression for people who are used to the function. (In reply to Philip Rayment from comment #52) > ... (maybe I missed one cycle) > I hesitate to suggest this, but one option may be to change the process to > be as follows: > ... > > Third keypress: Mary Jones met [JOE] Smith (sentence case reverted/undone > > before trying next option) Changing text outside the selection contradicts our effort. So I wouldn't touch "smith". -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033
--- Comment #52 from Philip Rayment ---
(In reply to Heiko Tietze from comment #50)
> How the transliteration works is another question to me. I would keep the
> status quo which means:
...
> ("Mary Jones met [joe] Smith" - "joe" is selected)
> TITLE_CASE: JOE
> SENTENCE_CASE: joe
> LOWERCASE_UPPERCASE: Joe
> UPPERCASE_LOWERCASE: joe
Only that's NOT the status quo, if by that you mean what happens now, and if
you're using Shift-F3 to cycle (perhaps you weren't referring to that??). What
happens now is:
> ("Mary Jones met [joe] Smith" - "joe" is selected)
> First keypress: Mary Jones met [Joe] Smith
> Second keypress: Mary jones met [joe] smith (sentence case applied; Jones and
> Smith decapitalised)
> Third keypress: Mary jones met [JOE] smith
> Fourth keypress: Mary jones met [joe] smith
I hesitate to suggest this, but one option may be to change the process to be
as follows:
> ("Mary Jones met [joe] Smith" - "joe" is selected)
> First keypress: Mary Jones met [Joe] Smith
> Second keypress: Mary jones met [joe] smith (sentence case applied; Jones and
> Smith decapitalised)
> Third keypress: Mary Jones met [JOE] Smith (sentence case reverted/undone
> before trying next option)
> Fourth keypress: Mary Jones met [joe] Smith
This would be regardless of whether a selection was made or not. The problem
is that if the cycling is also fixed to start from the beginning of the cycle
rather than the next step after the previous when a new bit of text is
selected, the user might move the cursor elsewhere after the second step and be
stuck with the unwanted sentence case. Although there's always the undo
button.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033
--- Comment #51 from V Stuart Foote ---
(In reply to Heiko Tietze from comment #50)
>
> Basically I agree with the selection on/off consideration. But how about to
> select the whole sentence first when nothing has been selected ("text cursor
> focus")? And to apply the function as it works today but always to the
> selection. It has the benefit of being more transparent to the user and
> simplifies workflow and code.
> ...
Might be cleaner to explicitly do nothing unless there is a selection made.
Making the expanded selection to sentence boundaries (from text cursor
position) would still be too late for the user to avoid an unintended action.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033
--- Comment #50 from Heiko Tietze ---
(In reply to V Stuart Foote from comment #45)
> To UX-Advise to move this forward...
Basically I agree with the selection on/off consideration. But how about to
select the whole sentence first when nothing has been selected ("text cursor
focus")? And to apply the function as it works today but always to the
selection. It has the benefit of being more transparent to the user and
simplifies workflow and code.
(In reply to Philip Rayment from comment #49)
> "Mary Jones met joe Smith"
How the transliteration works is another question to me. I would keep the
status quo which means:
(without selection)
TITLE_CASE: Mary Jones Met Joe Smith
SENTENCE_CASE: Mary jones met joe smith
LOWERCASE_UPPERCASE: MARY JONES MET JOE SMITH
UPPERCASE_LOWERCASE: mary jones met joe smith
("Mary Jones met [joe] Smith" - "joe" is selected)
TITLE_CASE: JOE
SENTENCE_CASE: joe
LOWERCASE_UPPERCASE: Joe
UPPERCASE_LOWERCASE: joe
("Mary Jones met [joe Smith]" - "joe Smith" is selected)
TITLE_CASE: Joe Smith
SENTENCE_CASE: Joe smith
LOWERCASE_UPPERCASE: JOE SMITH
UPPERCASE_LOWERCASE: joe smith
Any if-then condition complicates the procedure and makes it hard for users to
predict the result.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033 --- Comment #49 from Philip Rayment --- (In reply to V Stuart Foote from comment #47) > No! In fact the change in comment 45 of explicitly handling selection > state--would restore consistent and expected behavior to the UI Sorry, I must have misunderstood. But please explain how this works in more detail. If you have this sentence: "Mary Jones met joe Smith" and put the cursor in "joe", but didn't select it, and press Shift-F3 to capitalise "joe", but you're at the wrong step in the cycle, then sentence case is applied instead, changing "Jones" to "jones" and "Smith" to "smith". How does your proposal prevent that? (In reply to V Stuart Foote from comment #47) > ... Usage > notes in documentation is sufficient to warn users to make a selection for > cycling a single word. What documentation? Without trying an extensive search, I couldn't find any documentation on Shift-F3 beyond it being mentioned in the menus. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033 --- Comment #47 from V Stuart Foote --- (In reply to Philip Rayment from comment #46) > > I don't know what ICU means, but if I understand you, this would make any > use of cycling with Shift-F3 and no selection unusable. Suppose you want to > capitalise a single word, so place the cursor in that word but don't select > it. Instead of capitalising that word, you could end up applying sentence > capitalisation to the entire sentence, an unwanted and unexpected outcome. No! In fact the change in comment 45 of explicitly handling selection state--would restore consistent and expected behavior to the UI and there is only so much protection we can give to users without impacting function. If premise remains as for bug 116315, that SENTENCE_CASE belongs in the Cycle case list (Title Case, Sentence case, UPPERCASE, lowercase). Usage notes in documentation is sufficient to warn users to make a selection for cycling a single word. Besides, this is exactly the behavior now. No selection for the other transliterations applies just to the ICU word boundaries at text cursor position,- while SENTENCE_CASE expands from that position to the sentence boundaries so no regression involved. =-ref-= ICU -- https://en.wikipedia.org/wiki/International_Components_for_Unicode -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033 --- Comment #46 from Philip Rayment --- (In reply to V Stuart Foote from comment #45) I don't know what ICU means, but if I understand you, this would make any use of cycling with Shift-F3 and no selection unusable. Suppose you want to capitalise a single word, so place the cursor in that word but don't select it. Instead of capitalising that word, you could end up applying sentence capitalisation to the entire sentence, an unwanted and unexpected outcome. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033 V Stuart Foote changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #45 from V Stuart Foote --- To UX-Advise to move this forward... But my take remains that the original implementation applying the SENTENCE_CASE, via ICU transliteration, needs additional control logic. Believe we need to handle two cases for applying SENTENCE_CASE in edit engine [1]. 1) Case -- an active selection made: expand only to the ICU -word boundaries- that hold the selection and apply ICU transliteration. Treat that "temp" string as the sentence--and apply transliteration. Since the transliteration of the selection likely cross sentence boundaries, would need to break selection into multiple "temp" strings (an opening, middle(s), a closing)--but honor the selections at the word boundaries as the range. 2) Case -- only text cursor focus, no selection made: expand only to the ICU -sentence boundaries- that hold the text cursor and apply ICU transliteration. The current implementation for sentence case always performs the expansion when applying SENTENCE_CASE transliteration, with or without selection--that's the issue. Current implementation probably could/should be retained for a no selection case, but need to provide new code for the with selection handling. =-ref-= [1] https://opengrok.libreoffice.org/xref/core/editeng/source/editeng/impedit4.cxx?r=492ea7e0#2665 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
