[Libreoffice-ux-advise] [Bug 94553] WIKIHELP: converter does not support nested lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94553

Akash Deshpande  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 94553] WIKIHELP: converter does not support nested lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94553

--- Comment #9 from Commit Notification 
 ---
Akash Deshpande committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/help/commit/?id=2e141341684eb610834db92693d715f3fd01d0dd

tdf#94553 fix nested lists in wikihelp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 94553] WIKIHELP: converter does not support nested lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94553

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 94553] WIKIHELP: converter does not support nested lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94553

--- Comment #8 from Akash Deshpande  ---
I submitted a patch a couple of days ago:
https://gerrit.libreoffice.org/#/c/28107/

Regression looks good, just the one desired change (the extra '#' character)

$ help-to-wiki.py -n
$ diff -r wiki0 wiki # wiki0 is the run without my changes
diff -r wiki0/Impress/Using_Gluepoints/MAIN wiki/Impress/Using_Gluepoints/MAIN
9c9
< #Choose {{MenuItem|Edit - Glue Points}}.
---
> ##Choose {{MenuItem|Edit - Glue Points}}.

And all the 'Unhandled element' warnings have disappeared.

Please let me know!  I am eager to get my first patch approved.  Of course, if
there are any concerns or comments, I will do my best to address them.

I did not install MediaWiki as it has a lot of details and I will need to
install MySql etc. but I will be happy to get it done for future reference.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 94553] WIKIHELP: converter does not support nested lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94553

--- Comment #7 from Akash Deshpande  ---
(In reply to jan iversen from comment #6)
> A polite ping, still working on this patch ?

Hi Jan,

I just came back from a vacation, almost exactly at the time you sent the
email!  I will continue on my task and expect to have a lot of time in the next
few days.  I will send you all another update within a week.  If the approach I
mentioned in comment 4 works without any side effects, I expect to send a
commit.

Thank you all for the patience.

Akash

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 94553] WIKIHELP: converter does not support nested lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94553

--- Comment #6 from jan iversen  ---
A polite ping, still working on this patch ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 94553] WIKIHELP: converter does not support nested lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94553

--- Comment #5 from Andras Timar  ---
(In reply to Akash Deshpande from comment #4)
> 1) To be certain everything looks good, I would like to generate html files
> from the wiki files.  Can you please tell me how to do this?

Install MediaWiki, and try it locally. There is no better converter from wiki
syntax to html than MediaWiki itself.

> 2) I still need to thoroughly test everything.  I am also doing some
> traveling so I will need some more time.

OK.

> 3) There are other run time errors (unhandled element, key errors etc.) by
> help-to-wiki.py.  The file also has 'FIXME' comments.  I will be happy to
> look at them.
> 

Thanks!
As I wrote elsewhere, you can test your patches by generating wiki text from
help source with and without the patches. The diff should be only your intended
fixes, and if it is so, then your patches are good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 94553] WIKIHELP: converter does not support nested lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94553

--- Comment #4 from Akash Deshpande  ---
Hi, I have been looking at this. A quick summary and a question:
1) I removed the changes by cloph (it was mentioned to be a hack and it
introduced more 'unhandled element errors'
2) I added List as an element to be handled inside List (nesting) - all
'unhandled element' errors for gluepoints went away
  Inserted the following into List.start_element()
elif name == 'list':
self.parse_child(List(attrs, self, self.isInTable))

3) In the ListItem.get_all() method, added a re.sub to insert '#' for
additional items for the inside list.
  Inserted the following: (some more code and comments but just a one line
summary here)
  text = re.sub(r'\n\s*#', '\n##', text)

Now, I get an extra '#' for all inside List members (instead of just the first
one, which is the case currently).  As far as I can tell, this will fix the
html files.

Questions/comments:
1) To be certain everything looks good, I would like to generate html files
from the wiki files.  Can you please tell me how to do this?
2) I still need to thoroughly test everything.  I am also doing some traveling
so I will need some more time.
3) There are other run time errors (unhandled element, key errors etc.) by
help-to-wiki.py.  The file also has 'FIXME' comments.  I will be happy to look
at them.

Thank you!
Akash

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 94553] WIKIHELP: converter does not support nested lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94553

Akash Deshpande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 94553] WIKIHELP: converter does not support nested lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94553

jan iversen  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise