Re: [Libreoffice-ux-advise] Review asked of "Smooth Lines" dialog
On Sun, 2013-03-24 at 03:24 -0600, Adolfo Jayme Barrientos wrote: > Adding Caolán to CC, he may want to review it. jleigh wrote a lint tool to do some of the pony work on testing for some .ui consistently issues, you still have to do a manual inspection, but ./bin/lint-ui.py /path/to/file.ui will do some sanity testing (the smooth lines dialog now passes FWIW) C. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Re: [Libreoffice-ux-advise] Review asked of "Smooth Lines" dialog
Hellop Astron, About the ui for the stepped lines, I was thinking of adding icons as well. You know, a picture says more than 1000 words ;-) Eric On Sunday 24 March 2013 12:48:18 Stefan Knorr wrote: > Hi Eric, > > please have a look again at the attachments to my mail in the previous > thread. (Those were UI files already.) > > http://nabble.documentfoundation.org/Libreoffice-ux-advise-fdo-61135-Advise-> > wanted-on-changes-in-Chart-Wizard-td4041850.html#d1363212079000-867 > > Anyway, the reasons why I made the dialogue a bit more "verbose" was > * because we're not saving much space there anyway > * because it makes the hierarchy between the options much clearer > > I am pretty sure the right-aligning of text is not HIG-compliant, but it > just looked that much better (looks more like it is designed with a > grid) – so anyway, feel free to turn that off. > > I was not as sure about the options for stepping that I posted ... what > do you think? > > Astron. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Re: [Libreoffice-ux-advise] Review asked of "Smooth Lines" dialog
Hello Adolfo and Stefan, thanks for your input. I have reworked the dialog based on your feedback. Stefan, I like your idea to provide several sections. This makes things more clear. However, I'm not certain about the added complexity to the code. Therefore, I'm using a combo box for selecting the line types now. Especially because I'm having the feeling that other smooth line types will be added in the future. Also, the order of the buttons is matching the Gnome HIG now. Eric On Sunday 24 March 2013 03:24:53 Adolfo Jayme Barrientos wrote: > Adding Caolán to CC, he may want to review it. > > On Sun, Mar 24, 2013 at 1:46 AM, Eric Seynaeve > > wrote: > > I'm busy converting the "Smooth Lines" dialog from the chartwizard in Calc > > to glade. > > I checked the item's from Caolán's list and from me it looks fine. > > But a second opinion would be nice :-) > > By quickly opening the .ui in Glade3, I’d say there’s too much wasted > space for such a small dialog: the two radiobuttons and the spinboxes > are cramped to the top and there’s wasted space in the middle. (I’d > move the spinboxes below the radio buttons, in a separate section). > Also, OK/Cancel/Help are not aligned to the right. > > Sadly, I’m not well-versed in Glade, or otherwise I’d modify it... smoothlinesdlg.ui Description: application/designer ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Re: [Libreoffice-ux-advise] Review asked of "Smooth Lines" dialog
Hi Eric, please have a look again at the attachments to my mail in the previous thread. (Those were UI files already.) http://nabble.documentfoundation.org/Libreoffice-ux-advise-fdo-61135-Advise-wanted-on-changes-in-Chart-Wizard-td4041850.html#d1363212079000-867 Anyway, the reasons why I made the dialogue a bit more "verbose" was * because we're not saving much space there anyway * because it makes the hierarchy between the options much clearer I am pretty sure the right-aligning of text is not HIG-compliant, but it just looked that much better (looks more like it is designed with a grid) – so anyway, feel free to turn that off. I was not as sure about the options for stepping that I posted ... what do you think? Astron. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Re: [Libreoffice-ux-advise] Review asked of "Smooth Lines" dialog
Adding Caolán to CC, he may want to review it. On Sun, Mar 24, 2013 at 1:46 AM, Eric Seynaeve wrote: > I'm busy converting the "Smooth Lines" dialog from the chartwizard in Calc > to glade. > I checked the item's from Caolán's list and from me it looks fine. > But a second opinion would be nice :-) By quickly opening the .ui in Glade3, I’d say there’s too much wasted space for such a small dialog: the two radiobuttons and the spinboxes are cramped to the top and there’s wasted space in the middle. (I’d move the spinboxes below the radio buttons, in a separate section). Also, OK/Cancel/Help are not aligned to the right. Sadly, I’m not well-versed in Glade, or otherwise I’d modify it... -- Adolfo ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] Review asked of "Smooth Lines" dialog
Hello everyone, I'm busy converting the "Smooth Lines" dialog from the chartwizard in Calc to glade. I checked the item's from Caolán's list and from me it looks fine. But a second opinion would be nice :-) I also have a second question. The current dialog is located in chart2/source/controller/dialogs/tp_ChartType.cxx but I didn't succeed to get the dialog loaded. I created a chart2/UI_chart2.mk but no luck. Adding it to sc/uiconfig/scalc/ui/ did work out. Is this OK ? Thanks, Eric smoothlinesdlg.ui Description: application/designer ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
