[libssh2] [ libssh2-Bugs-1943976 ] Fix MSYS+MINGW

2008-09-30 Thread SourceForge.net
Bugs item #1943976, was opened at 2008-04-16 15:36
Message generated for change (Comment added) made by bagder
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1943976&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: misc
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Carlo Bramini (carlo_bramini)
Assigned to: Daniel Stenberg (bagder)
Summary: Fix MSYS+MINGW

Initial Comment:
Hello,
I fixed the compilation of libssh2 under MSYS+MINGW, now it works without 
problems.
The compilation under MSVC works too.
List of changes:

)configure.in
detect mingw32 (or mingw64) compiler, add some CFLAGS and detect the presence 
of W32API.
select() was not found at configure time because it is declared with PASCAL 
calling convention, so its name is decorated with "@". Normally such conditions 
must be fixed by declaring correct prototype, or including good include file 
(i.e. winsock2.h).

)scp_nonblock.c
)scp_write_nonblock.c
)sftp_RW_nonblock.c
)sftp_mkdir_nonblock.c
)sftp_nonblock.c
)sftp_write_nonblock.c
)sftpdir_nonblock.c
fixed nonblocking examples for Win32/Win64.

)libssh2_priv.h
Declare some useful stuff, mainly moved from libssh2_config.h under /win32 
directory

)libssh2_config.h
Removed some stuff for fixing compilation under MSVC

Sincerely,

Carlo Bramini.


--

>Comment By: Daniel Stenberg (bagder)
Date: 2008-09-30 10:58

Message:
Thanks, a few remarks though:

1) I committed the fixes for the examples just now

2) It seems you've reverted some win32 changes when you removed newly
fixed code from win32/libssh2_config.h and instead insert older-looking
code into src/libssh2_priv.h

3) Your configure changes make configure break for me on Linux that's
supposedly unreleated to mingw/msys.

--

Comment By: Carlo Bramini (carlo_bramini)
Date: 2008-09-30 10:38

Message:
I updated my patch to the lastest CVS revision.
I hope that it will be fine and I hope to see a new version with
mingw+msys support very soon!

Sincerely,

Carlo Bramini
File Added: libssh2.txt

--

Comment By: Daniel Stenberg (bagder)
Date: 2008-09-29 21:22

Message:
Thanks for your work, can you please update your patch against the current
CVS as some changes now makes your patch not apply cleanly any more?

--

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1943976&group_id=125852

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
libssh2-devel mailing list
libssh2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel


[libssh2] [ libssh2-Bugs-1923038 ] A way to get hostkey is needed

2008-09-30 Thread SourceForge.net
Bugs item #1923038, was opened at 2008-03-22 14:58
Message generated for change (Comment added) made by alamaison
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1923038&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: API
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: A way to get hostkey is needed

Initial Comment:
Exceprpt from Debian bug #467305.

Client applications may need to obtain server hostkey "as is", in addition to 
SHA1/MD5 hash returned by libssh2_hostkey_hash.


--

Comment By: alamaison (alamaison)
Date: 2008-09-30 17:42

Message:
I've been intending to work on a patch but haven't had any time.  

The best hope so far seems to be a patch discussed in this thread:
http://sourceforge.net/mailarchive/message.php?msg_id=Pine.LNX.4.64.0711290912170.7609%40yvahk3.pbagnpgbe.fr
I'm not sure what happened with this.  It wasn't committed.

--

Comment By: Daniel Stenberg (bagder)
Date: 2008-07-01 11:44

Message:
Logged In: YES 
user_id=1110
Originator: NO

We'll welcome patches to introduce the necessary APIs.

--

Comment By: alamaison (alamaison)
Date: 2008-07-01 11:39

Message:
Logged In: YES 
user_id=1251900
Originator: NO

We really need this to compare the key with the contents of a known_hosts
file.  
I see that _LIBSSH2_SESSION has a server_hostkey field but it is private
and can't be accessed via the API.  Also there is no information on what
format this is in.

--

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1923038&group_id=125852

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
libssh2-devel mailing list
libssh2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel


[libssh2] [ libssh2-Bugs-1943976 ] Fix MSYS+MINGW

2008-09-30 Thread SourceForge.net
Bugs item #1943976, was opened at 2008-04-16 15:36
Message generated for change (Comment added) made by bagder
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1943976&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: misc
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Carlo Bramini (carlo_bramini)
Assigned to: Daniel Stenberg (bagder)
Summary: Fix MSYS+MINGW

Initial Comment:
Hello,
I fixed the compilation of libssh2 under MSYS+MINGW, now it works without 
problems.
The compilation under MSVC works too.
List of changes:

)configure.in
detect mingw32 (or mingw64) compiler, add some CFLAGS and detect the presence 
of W32API.
select() was not found at configure time because it is declared with PASCAL 
calling convention, so its name is decorated with "@". Normally such conditions 
must be fixed by declaring correct prototype, or including good include file 
(i.e. winsock2.h).

)scp_nonblock.c
)scp_write_nonblock.c
)sftp_RW_nonblock.c
)sftp_mkdir_nonblock.c
)sftp_nonblock.c
)sftp_write_nonblock.c
)sftpdir_nonblock.c
fixed nonblocking examples for Win32/Win64.

)libssh2_priv.h
Declare some useful stuff, mainly moved from libssh2_config.h under /win32 
directory

)libssh2_config.h
Removed some stuff for fixing compilation under MSVC

Sincerely,

Carlo Bramini.


--

>Comment By: Daniel Stenberg (bagder)
Date: 2008-09-30 23:54

Message:
Thanks, this was applied and committed just now!

--

Comment By: Carlo Bramini (carlo_bramini)
Date: 2008-09-30 14:57

Message:
Hello,
1) thanks!
2) I'm very sorry, it looks like I did the update with too much speed and
without enough attention. In the new patch I did it correctly. I also added
a little comment into win32/libssh2_config.h about the reason of
WINSOCK_VERSION macro define.
3) I moved AC_CHECK_HEADERS macro from the *-mingw* case to the bottom
part with all other include checks. I do not know why it happened, but that
was the cause of the problem.
I also fixed the test on select() function into ws2_32 with
$ac_cv_func_select, now the test is not done if select() has been already
found.
Before making this new patch I configured and compiled libssh2 with mingw,
MSVC, cygwin and colinux (with Debian 4.0r3) and now everything has been
completed successfully.

Sorry for previous trouble...

Sincerely,

Carlo Bramini.
File Added: libssh2_2.txt

--

Comment By: Daniel Stenberg (bagder)
Date: 2008-09-30 10:58

Message:
Thanks, a few remarks though:

1) I committed the fixes for the examples just now

2) It seems you've reverted some win32 changes when you removed newly
fixed code from win32/libssh2_config.h and instead insert older-looking
code into src/libssh2_priv.h

3) Your configure changes make configure break for me on Linux that's
supposedly unreleated to mingw/msys.

--

Comment By: Carlo Bramini (carlo_bramini)
Date: 2008-09-30 10:38

Message:
I updated my patch to the lastest CVS revision.
I hope that it will be fine and I hope to see a new version with
mingw+msys support very soon!

Sincerely,

Carlo Bramini
File Added: libssh2.txt

--

Comment By: Daniel Stenberg (bagder)
Date: 2008-09-29 21:22

Message:
Thanks for your work, can you please update your patch against the current
CVS as some changes now makes your patch not apply cleanly any more?

--

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1943976&group_id=125852

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
libssh2-devel mailing list
libssh2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel


[libssh2] [ libssh2-Bugs-1923038 ] A way to get hostkey is needed

2008-09-30 Thread SourceForge.net
Bugs item #1923038, was opened at 2008-03-22 15:58
Message generated for change (Comment added) made by bagder
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1923038&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: API
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Daniel Stenberg (bagder)
Summary: A way to get hostkey is needed

Initial Comment:
Exceprpt from Debian bug #467305.

Client applications may need to obtain server hostkey "as is", in addition to 
SHA1/MD5 hash returned by libssh2_hostkey_hash.


--

>Comment By: Daniel Stenberg (bagder)
Date: 2008-09-30 23:56

Message:
does that patch work fine for you?

It wasn't committed because people haven't pushed for it.

--

Comment By: alamaison (alamaison)
Date: 2008-09-30 18:42

Message:
I've been intending to work on a patch but haven't had any time.  

The best hope so far seems to be a patch discussed in this thread:
http://sourceforge.net/mailarchive/message.php?msg_id=Pine.LNX.4.64.0711290912170.7609%40yvahk3.pbagnpgbe.fr
I'm not sure what happened with this.  It wasn't committed.

--

Comment By: Daniel Stenberg (bagder)
Date: 2008-07-01 12:44

Message:
Logged In: YES 
user_id=1110
Originator: NO

We'll welcome patches to introduce the necessary APIs.

--

Comment By: alamaison (alamaison)
Date: 2008-07-01 12:39

Message:
Logged In: YES 
user_id=1251900
Originator: NO

We really need this to compare the key with the contents of a known_hosts
file.  
I see that _LIBSSH2_SESSION has a server_hostkey field but it is private
and can't be accessed via the API.  Also there is no information on what
format this is in.

--

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1923038&group_id=125852

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
libssh2-devel mailing list
libssh2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel


[libssh2] [ libssh2-Bugs-2133354 ] libssh2_poll_channel_read doesn't work correctly

2008-09-30 Thread SourceForge.net
Bugs item #2133354, was opened at 2008-09-27 22:31
Message generated for change (Comment added) made by thomaspu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2133354&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Paul Thomas (thomaspu)
Assigned to: Nobody/Anonymous (nobody)
Summary: libssh2_poll_channel_read doesn't work correctly

Initial Comment:
The libssh2_poll_channel_read doesn't read both normal and extended data when 
called like so...

libssh2_poll_channel_read( , 1);

As taken from the wiki:
"...When set to a non-zero value, the extended data stream buffers will be 
scanned as well"

I read that as: if you set the 2nd item to a non-zero value, both normal and 
extended data is read. This isn't the case, it reads normal data or extended 
but Not both.

Attached is a patch to fix this issue.
Paul

--

>Comment By: Paul Thomas (thomaspu)
Date: 2008-09-30 20:34

Message:
I've commited the changes that were detailed in the previously attached
patch.

--

Comment By: Daniel Stenberg (bagder)
Date: 2008-09-29 08:29

Message:
Can you please remake the diff with -u?

--

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2133354&group_id=125852

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
libssh2-devel mailing list
libssh2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel