Re: support standalone libltdl [libtool--gary--1.0--patch-23]
Hi Gary,
* Gary V. Vaughan wrote on Fri, Aug 19, 2005 at 07:38:31PM CEST:
Ralf Wildenhues wrote:
* Gary V. Vaughan wrote on Tue, Apr 26, 2005 at 03:13:17PM CEST:
Thanks for the review... I've had a busy summer, so I hope you'll
forgive that it has taken me 3 months to respond :-(
Hehe, let's just hope your next response will take less long.
Attached patch is taken against HEAD.
OK, good.
*snip some unproblematic stuff*
`make clean' fails to remove libltdl/lt__strl.lo, but it removes
libltdl/.libs/lt__strl.o, causing build failure.
This is a bug in automake-1.9.x with subdir objects. As a workaround
I've added $(LIBOBJS) $(LTLIBOBJS) to CLEANFILES.
OK, good.
`make uninstall' fails to remove anything below $prefix/share/libtool
and below include/libltdl.
Oops. Forgot to match uninstall-hook against install-hook and
install-data-local. Now fixed.
Hmm. Comments inline, see attached.
*snip*
Your libtoolize tests all fail (1, 2, 3) because you changed `copying'
to `linking' (why not say `linking' only if that is what you do, i.e.
without `--copy'?)
They failed because of path changes. Now fixed. (`linking' is only for
ln -s -- also libtoolize -v gives source path instead of dest path).
OK.
Somehow the test suite was not automagically updated to include
`standalone'. I believe this might have been my fault.
Can't reproduce.
OK. Forget about it then.
There exists $top_builddir/.deps with files argz.Plo lt__dirent.Plo
lt__strl.Plo now. I don't know whether this is a bug (believe not).
Side effect of subdir-objects.
OK.
The files
libltdl/Makefile{,.am,.in}
configure{,.ac}
aclocal.m4
README
config-h.in
m4/lt~obsolete.m4
are not shipped in libtool-2.1.tar.gz, and a subsequent
configure
make
from the tarball does not create any of them (it should create Makefile,
and everything else should be shipped, right?).
Yep. All good. These files are all shipped correctly for me -- maybe
because of the other fixes I made on the way here?
Maybe.
I don't really like config and m4 below libltdl. It seems ugly.
But that is a minor issue.
Really? From libltdl's point of view, it owns config and m4 -- we
install copies of those directories to $prefix/share/libtool, and
libtoolize --ltdl puts them inside the libltdl it installs. Now that
I've moved them here, having them in $top_srcdir (where they are only
used during bootstrap) seems ugly to me.
OK, functionality is more important than looks.
But to tell you the truth, the move of libtool.m4 from top to m4/,
combined with the limitations of cvs/cvsweb, have cost me hours of
searching time already (while trying to hunt down why a particular
change was made).
When you eventually commit the reorganization, I will definitely want
this in two steps: 1) move files only, 2) change files.
I know this sucks, and is fault of CVS, but as long as that's what
savannah offers, there is no other sane way.
Ah, and also libltdl/Makefile.am needs to be removed from CVS if it's to
be generated. (It's good to see its diff now, though, made me find some
bugs in your patch.)
I stopped further testing after this. It would be nice if your
standalone tests could run a `make distcheck' so we can be reasonably
sure `libltdl/Makefile.am' has everything it needs. Once for
AC_LIBLTDL_CONVENIENCE and once for AC_LIBLTDL_INSTALLABLE.
The c++ template with subdir-objects autotest is failing for me right
now (I think this is because I need to backport another patch to my
local automake-1.9.6 installation -- any clue as to which one?), so I'd
like to address this in a separate patch once we have this one in HEAD
and branch-2-0...
Erm, tests/template.at does not use Automake.
Please run with -d -v, post testsuite output, to see what's happening.
It would also be nice (while I'm at the point of using old macro names)
to test whether using the old names works. That is exactly what all
upgraders will hit first when going to 2.0.
ACK.
As I am a fan of one change per patch, I'd have liked to have the
- use of auxdir, m4dir
- move files around
- update all dependents, simplify libtoolize
- change `copying' to `linking'
- build libltdl from $top_builddir/Makefile
as separate patches,
Me too. This started out as what I thought was going to be a relatively
simple 'standalone libltdl' patch, that grew big before I thought to
split it up. Sorry about that.
Peter Ekberg was much easier to convince, even after posting his monster
patch. ;-)
they would have been easier to verify (the first
two separated only because of CVS limitations -- it's almost impossible
to trace back using `cvs annotate' if you change a file while moving at
the same time).
Gah! I have been spoiled by arch. Sorry again.
See above.
By the way, have you ever tried `make installcheck' with the new
testsuite?
Not in libtool, though I've
Cope with weird AIX chmod behavior
This, on an AIX 5.1 below some /tmp-like directory: $ ls -ld .. . drwx--S--- 15 username sys1024 Aug 21 09:01 .. drwx--S--- 2 username sys 512 Aug 21 09:07 . $ chmod u+w . 0481-014 chmod: not all requested changes were made to . $ chmod u-w . $ ls -la dr-x-- 2 username sys 512 Aug 21 09:07 . leads to this in configure output: | checking if xlf supports -c -o file.o... chmod: not all requested changes were made to . | yes OK to apply this cleanup (all branches)? Does it hurt when we just kill the g+s (then we would be in more trouble, as there are other places which do this, too)? Cheers, Ralf * m4/libtool.m4 (_LT_COMPILER_C_O): Send chmod warning to log. Index: m4/libtool.m4 === RCS file: /cvsroot/libtool/libtool/m4/libtool.m4,v retrieving revision 1.212 diff -u -r1.212 libtool.m4 --- m4/libtool.m4 18 Aug 2005 17:07:17 - 1.212 +++ m4/libtool.m4 21 Aug 2005 14:18:59 - @@ -1678,7 +1678,7 @@ _LT_TAGVAR(lt_cv_prog_compiler_c_o, $1)=yes fi fi - chmod u+w . + chmod u+w . 2AS_MESSAGE_LOG_FD $RM conftest* # SGI C++ compiler will create directory out/ii_files/ for # template instantiation
Re: template test with subdirs failure for HEAD on darwin [WAS support standalone libltdl [libtool--gary--1.0--patch-23]]
Moin Ralf!
On 21 Aug 2005, at 08:21, Ralf Wildenhues wrote:
* Gary V. Vaughan wrote on Fri, Aug 19, 2005 at 07:38:31PM CEST:
The c++ template with subdir-objects autotest is failing for me right
now (I think this is because I need to backport another patch to my
local automake-1.9.6 installation -- any clue as to which one?),
so I'd
like to address this in a separate patch once we have this one in
HEAD
and branch-2-0...
Erm, tests/template.at does not use Automake.
That'll teach me to look before I jump to conclusions. D'oh!
Please run with -d -v, post testsuite output, to see what's happening.
Attached. Looks like the compiler isn't getting all the switches it
would like.
I don't know anything much about darwin compiler namespace stuff... I
treat my
Macs like linux machines that work out of the box, with a sexy gui :-)
Cheers,
Gary.
--
Gary V. Vaughan ())_. gary@
{lilith.warpmail.net,gnu.org},[EMAIL PROTECTED]
Research Scientist ( '/ http://www.tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/{libtool,m4}
Technical Author `(_~)_ http://sources.redhat.com/autobook
template-test-with-subdirs.log
Description: Binary data
PGP.sig
Description: This is a digitally signed message part
Re: template test with subdirs failure for HEAD on darwin [WAS support standalone libltdl [libtool--gary--1.0--patch-23]]
* Gary V. Vaughan wrote on Sun, Aug 21, 2005 at 04:59:14PM CEST: Moin Ralf! Good afternoon, Gary! On 21 Aug 2005, at 08:21, Ralf Wildenhues wrote: * Gary V. Vaughan wrote on Fri, Aug 19, 2005 at 07:38:31PM CEST: The c++ template with subdir-objects autotest is failing for me right now (I think this is because I need to backport another patch to my local automake-1.9.6 installation -- any clue as to which one?), Erm, tests/template.at does not use Automake. That'll teach me to look before I jump to conclusions. D'oh! :) Please run with -d -v, post testsuite output, to see what's happening. Attached. Looks like the compiler isn't getting all the switches it would like. I don't know anything much about darwin compiler namespace stuff... I treat my Macs like linux machines that work out of the box, with a sexy gui :-) Can you get a demangled name of the symbol __Z2a2c? I think this is a genuine failure with template libraries on darwin. IOW: I don't think this ever worked. Our test is doing the right thing and exposes the failure. I guess I'll leave that to our Darwin expert to fix, though. I'd have to probably read a lot in order to know how to do something along the lines of: - put template instantiations in shared C++ library - use instantiations from deplibs if possible - either use some working sort of weak symbols or one instantiation per object We have prelink_cmds as new variable in CVS HEAD to do work before linking a program, other outputs should be done in already-established variables. The linux/pgCC case serves as a good example. Thanks, Ralf
Re: template test with subdirs failure for HEAD on darwin [WAS support standalone libltdl [libtool--gary--1.0--patch-23]]
On Sun, 21 Aug 2005, Gary V. Vaughan wrote: I dunno. This is the kind of horror that makes me avoid C++ as if it were perl ;-) Does g++ come with a command line unmangler? Yes, it is called c++filt. Does come with OS-X. If libtool is using the native linker (vs linking via the compiler) maybe it should filter linker error output through c++filt before displaying it to the user. Bob == Bob Friesenhahn [EMAIL PROTECTED], http://www.simplesystems.org/users/bfriesen/ GraphicsMagick Maintainer,http://www.GraphicsMagick.org/
Re: template test with subdirs failure for HEAD on darwin [WAS support standalone libltdl [libtool--gary--1.0--patch-23]]
* Gary V. Vaughan wrote on Sun, Aug 21, 2005 at 05:44:05PM CEST: On 21 Aug 2005, at 16:16, Ralf Wildenhues wrote: Can you get a demangled name of the symbol __Z2a2c? I dunno. This is the kind of horror that makes me avoid C++ as if it were perl ;-) Bob answered this already, but if you have GNU binutils nm, you can compare the difference of `nm' and `nm --demangle' of the objects created in this test. I assume g++ uses the same mangling on darwin, so that would be: a2(char) This function is used in libb, and also in a template in the b.hh header which is instantiated in main(). I wrote the test with different link lines to find out what is portable and what is not. If you comment out the AT_CHECKs below the comments # lib convenience and # both installed (both of these do not link libb.la against liba.la), does the test succeed then? If so, could you commit a patch doing this for host_os darwin? (I would still like to test this for other systems, even if our link lines are not portable, it provides nice information. Maybe add a comment to this extent.) I think this is a genuine failure with template libraries on darwin. IOW: I don't think this ever worked. Our test is doing the right thing and exposes the failure. Quite possibly. It does mean that I can't run distcheck on HEAD though :-( Oh, if above does not work, I would not mind an AT_XFAIL_IF(test X$host_os = ...) in tests/template.at. Cheers, Ralf
Re: template test with subdirs failure for HEAD on darwin [WAS support standalone libltdl [libtool--gary--1.0--patch-23]]
Hi Bob, Hallo Ralf,
On 21 Aug 2005, at 17:16, Bob Friesenhahn wrote:
On Sun, 21 Aug 2005, Gary V. Vaughan wrote:
I dunno. This is the kind of horror that makes me avoid C++ as if it
were perl ;-)
Does g++ come with a command line unmangler?
Yes, it is called c++filt. Does come with OS-X.
Thanks Bob. I get this:
$ c++filt
__Z2a2c
a2(char)
HTH!
If libtool is using the native linker (vs linking via the compiler)
maybe it should filter linker error output through c++filt before
displaying it to the user.
Yes, that sounds like a good idea :-)
Cheers,
Gary.
--
Gary V. Vaughan ())_. gary@
{lilith.warpmail.net,gnu.org},[EMAIL PROTECTED]
Research Scientist ( '/ http://www.tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/{libtool,m4}
Technical Author `(_~)_ http://sources.redhat.com/autobook
PGP.sig
Description: This is a digitally signed message part
Re: template test with subdirs failure for HEAD on darwin [WAS support standalone libltdl [libtool--gary--1.0--patch-23]]
Hallo Ralf!
On 21 Aug 2005, at 17:35, Ralf Wildenhues wrote:
* Gary V. Vaughan wrote on Sun, Aug 21, 2005 at 05:44:05PM CEST:
On 21 Aug 2005, at 16:16, Ralf Wildenhues wrote:
Can you get a demangled name of the symbol __Z2a2c?
I dunno. This is the kind of horror that makes me avoid C++ as if it
were perl ;-)
Bob answered this already, but if you have GNU binutils nm, you can
compare the difference of `nm' and `nm --demangle' of the objects
created in this test. I assume g++ uses the same mangling on
darwin, so
that would be:
a2(char)
This function is used in libb, and also in a template in the b.hh
header
which is instantiated in main().
Argh! You're making my brain hurt :-( Bjarne Stroustrup is evil!!
I wrote the test with different link lines to find out what is
portable
and what is not. If you comment out the AT_CHECKs below the comments
# lib convenience
and
# both installed
(both of these do not link libb.la against liba.la), does the test
succeed then? If so, could you commit a patch doing this for host_os
darwin? (I would still like to test this for other systems, even
if our
link lines are not portable, it provides nice information. Maybe
add a
comment to this extent.)
Okay, done. I didn't add the comment, because I don't know whether
it is
inherent non-portability in what you are trying to do, or a stupidity in
darwin. When 2.0 is out, and HEAD gets some testing on more hosts and
compilers we'll soon find out...
Thanks for the pointers :-)
Cheers,
Gary.
--
Gary V. Vaughan ())_. gary@
{lilith.warpmail.net,gnu.org},[EMAIL PROTECTED]
Research Scientist ( '/ http://www.tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/{libtool,m4}
Technical Author `(_~)_ http://sources.redhat.com/autobook
PGP.sig
Description: This is a digitally signed message part
Re: Cope with weird AIX chmod behavior
On Sun, Aug 21, 2005 at 04:21:08PM +0200, Ralf Wildenhues wrote: This, on an AIX 5.1 below some /tmp-like directory: $ ls -ld .. . drwx--S--- 15 username sys1024 Aug 21 09:01 .. drwx--S--- 2 username sys 512 Aug 21 09:07 . $ chmod u+w . 0481-014 chmod: not all requested changes were made to . $ chmod u-w . $ ls -la dr-x-- 2 username sys 512 Aug 21 09:07 . Works fine on our AIX 5.1 system with v5.1.0.35 of bos.rte.commands (package containing /usr/bin/chmod). leads to this in configure output: | checking if xlf supports -c -o file.o... chmod: not all requested changes were made to . | yes OK to apply this cleanup (all branches)? Does it hurt when we just kill the g+s (then we would be in more trouble, as there are other places which do this, too)? Should be ok. Considering our chmod works, it means IBM fixed a bug in it. So, if it's decided that g+s is bad, we could ask the user to upgrade. -- albert chin ([EMAIL PROTECTED])
FYI: D'oh! [libtool--devo--1.0--patch-217]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Applied to HEAD. * looking for [EMAIL PROTECTED]/libtool--devo--1.0--patch-216 to compare with * comparing to [EMAIL PROTECTED]/libtool--devo--1.0--patch-216 M libltdl/Makefile.am M ChangeLog * modified files Index: Changelog from Gary V. Vaughan [EMAIL PROTECTED] * libltdl/Makefile.am: revert mistaken commit. --- orig/libltdl/Makefile.am +++ mod/libltdl/Makefile.am @@ -1,17 +1,13 @@ -## Makefile.am -- Process this file with automake to produce Makefile.in +## Process this file with automake to produce Makefile.in ## -## Copyright (C) 2003, 2004, 2005 Free Software Foundation, Inc. +## Copyright (C) 1998, 1999, 2000, 2001, 2003, 2004, 2005 +## Free Software Foundation, Inc. ## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by ## the Free Software Foundation; either version 2 of the License, or ## (at your option) any later version. ## -## As a special exception to the GNU Lesser General Public License, -## if you distribute this file as part of a program or library that -## is built using GNU libtool, you may include it under the same -## distribution terms that you use for the rest of that program. -## ## This program is distributed in the hope that it will be useful, ## but WITHOUT ANY WARRANTY; without even the implied warranty of ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the @@ -21,28 +17,25 @@ ## along with this program; see the file COPYING. If not, write to ## the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, ## Boston, MA 02110-1301, USA. -ACLOCAL_AMFLAGS = -I m4 -AUTOMAKE_OPTIONS = foreign -BUILT_SOURCES = -EXTRA_DIST = -CLEANFILES = -MOSTLYCLEANFILES = -# ### BEGIN Makefile.am + +BUILT_SOURCES= +MOSTLYCLEANFILES = +EXTRA_DIST = configure.ac + +AUTOMAKE_OPTIONS = foreign +ACLOCAL_AMFLAGS = -I m4 DEFS = -DHAVE_CONFIG_H=$(CONFIG_H) -DLTDL -AM_CPPFLAGS = -I. -Ilibltdl -I$(srcdir)/libltdl \ - -I$(srcdir)/libltdl +AM_CPPFLAGS = -I. -I$(srcdir) -I$(srcdir)/libltdl AM_LDFLAGS = -no-undefined VERSION_INFO = -version-info 6:0:0 noinst_LTLIBRARIES = $(LT_DLLOADERS) if INSTALL_LTDL -ltdlincludedir = $(includedir)/libltdl -ltdlinclude_HEADERS = libltdl/lt_system.h \ - libltdl/lt_error.h \ +nobase_include_HEADERS = ltdl.h \ + libltdl/lt_system.h libltdl/lt_error.h \ libltdl/lt_dlloader.h -include_HEADERS = ltdl.h lib_LTLIBRARIES = libltdl.la endif @@ -50,30 +43,30 @@ noinst_LTLIBRARIES += libltdlc.la endif -libltdl_la_SOURCES = libltdl/lt__alloc.h \ +## !!NOTE!! Be sure to update ../Makefile.am:ltdldatafiles if you +## make any changes here: +libltdl_la_SOURCES = libltdl/lt__alloc.h \ libltdl/lt__dirent.h \ libltdl/lt__glibc.h \ libltdl/lt__private.h \ - libltdl/lt__strl.h \ + libltdl/lt__strl.h \ libltdl/lt_dlloader.h \ libltdl/lt_error.h \ - libltdl/lt_system.h \ + libltdl/lt_system.h \ libltdl/slist.h \ loaders/preopen.c \ lt__alloc.c \ lt_dlloader.c \ lt_error.c \ - ltdl.c \ - ltdl.h \ + ltdl.c ltdl.h \ slist.c - -libltdl_la_CPPFLAGS = -DLTDLOPEN=libltdl $(AM_CPPFLAGS) +libltdl_la_CPPFLAGS = -DLTDLOPEN=$(LTDLOPEN) $(AM_CPPFLAGS) libltdl_la_LDFLAGS = $(AM_LDFLAGS) $(VERSION_INFO) $(LT_DLPREOPEN) libltdl_la_LIBADD= $(LTLIBOBJS) -libltdl_la_DEPENDENCIES = $(LT_DLLOADERS) $(LTLIBOBJS) +libltdl_la_DEPENDENCIES = $(LT_DLLOADERS) $(LTLIBOBJS) $(BUILT_SOURCES) libltdlc_la_SOURCES = $(libltdl_la_SOURCES) -libltdlc_la_CPPFLAGS = -DLTDLOPEN=libltdlc $(AM_CPPFLAGS) +libltdlc_la_CPPFLAGS = -DLTDLOPEN=$(LTDLOPEN)c $(AM_CPPFLAGS) libltdlc_la_LDFLAGS = $(AM_LDFLAGS) $(LT_DLPREOPEN) libltdlc_la_LIBADD = $(libltdl_la_LIBADD) libltdlc_la_DEPENDENCIES= $(libltdl_la_DEPENDENCIES) @@ -82,12 +75,8 @@ ## pic-objects (either as a shared library, or a convenience library), ## so the loaders themselves must be made from pic-objects too. We ## use convenience libraries for that purpose: -EXTRA_LTLIBRARIES= dlopen.la \ - dld_link.la \ -
FYI: skip failing template tests on darwin [libtool--devo--1.0--patch-216]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Applied to HEAD. * looking for [EMAIL PROTECTED]/libtool--devo--1.0--patch-215 to compare with * comparing to [EMAIL PROTECTED]/libtool--devo--1.0--patch-215 -- libltdl/Makefile.am M libltdl/Makefile.am M tests/template.at M ChangeLog * modified files Index: Changelog from Gary V. Vaughan [EMAIL PROTECTED] * tests/template.at [darwin]: Some of these tests result in unresolved symbols on darwin, so don't run those test on that host! --- orig/tests/template.at +++ mod/tests/template.at @@ -208,9 +208,13 @@ AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o sub/main sub/main.o lib2/libb.la lib/liba.la, [0], [ignore], [ignore]) LT_AT_EXEC_CHECK([./sub/main], [ignore]) # lib convenience -AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o lib2/libb.la lib2/b.lo -rpath /foo, [0], [ignore], [ignore]) -AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o sub/main sub/main.o lib2/libb.la lib/liba.la, [0], [ignore], [ignore]) -LT_AT_EXEC_CHECK([./sub/main]) +case $host in + *-*-darwin*) ;; + *) AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o lib2/libb.la lib2/b.lo -rpath /foo, [0], [ignore], [ignore]) + AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o sub/main sub/main.o lib2/libb.la lib/liba.la, [0], [ignore], [ignore]) + LT_AT_EXEC_CHECK([./sub/main]) + ;; +esac # both installed AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o lib/liba.la lib/a.lo -rpath /foo, [0], [ignore], [ignore]) AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o lib2/libb.la lib2/b.lo -rpath /bar, [0], [ignore], [ignore]) @@ -222,14 +226,21 @@ AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o sub/main sub/main.o lib2/libb.la, [0], [ignore], [ignore]) LT_AT_EXEC_CHECK([./sub/main]) # lib convenience -AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o lib2/libb.la lib2/b.lo lib/liba.la -rpath /foo, [0], [ignore], [ignore]) -AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o sub/main sub/main.o lib2/libb.la, [0], [ignore], [ignore]) -LT_AT_EXEC_CHECK([./sub/main]) +case $host in + *-*-darwin*) ;; + *) AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o lib2/libb.la lib2/b.lo lib/liba.la -rpath /foo, [0], [ignore], [ignore]) + AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o sub/main sub/main.o lib2/libb.la, [0], [ignore], [ignore]) + LT_AT_EXEC_CHECK([./sub/main]) + ;; +esac # both installed -AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o lib/liba.la lib/a.lo -rpath /foo, [0], [ignore], [ignore]) -AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o lib2/libb.la lib2/b.lo lib/liba.la -rpath /bar, [0], [ignore], [ignore]) -AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o sub/main sub/main.o lib2/libb.la, [0], [ignore], [ignore]) -LT_AT_EXEC_CHECK([./sub/main]) +case $host in + *-*-darwin*) ;; + *) AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o lib2/libb.la lib2/b.lo lib/liba.la -rpath /bar, [0], [ignore], [ignore]) + AT_CHECK($LIBTOOL --tag=CXX --mode=link $CXX $CXXFLAGS -o sub/main sub/main.o lib2/libb.la, [0], [ignore], [ignore]) + LT_AT_EXEC_CHECK([./sub/main]) + ;; +esac cd .. @@ -247,7 +258,7 @@ dnl AC_CONFIG_FILES([Makefile]) dnl AC_OUTPUT dnl ]]) -dnl +dnl dnl AT_DATA(src/Makefile.am, dnl [[ACLOCAL_AMFLAGS = -I m4 dnl INCLUDES = -I$(srcdir)/lib -I$(srcdir)/lib2 - -- Gary V. Vaughan ())_. [EMAIL PROTECTED],gnu.org} Research Scientist ( '/ http://tkd.kicks-ass.net GNU Hacker / )= http://www.gnu.org/software/libtool Technical Author `(_~)_ http://sources.redhat.com/autobook _ This patch notification generated by tlaapply version 0.9 http://tkd.kicks-ass.net/arch/[EMAIL PROTECTED]/cvs-utils--tla--1.0 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (Darwin) iD8DBQFDCM2/FRMICSmD1gYRAp+eAJwKh6rkPyUN5THt1bOJsf72eRcelQCdF2Sd 65isVx0Feuh5vPXFCbjKf18= =AmVl -END PGP SIGNATURE-
Re: FYI: skip failing template tests on darwin [libtool--devo--1.0--patch-216]
Hi Gary, * Gary V. Vaughan wrote on Sun, Aug 21, 2005 at 08:53:51PM CEST: Applied to HEAD. Thanks. I should note for for reference that at least the last case (both libraries installed, libb.la linked against liba.la) constitutes a setup necessary for template libraries to work. Cheers, Ralf * tests/template.at [darwin]: Some of these tests result in unresolved symbols on darwin, so don't run those test on that host!
Re: FYI: D'oh! [libtool--devo--1.0--patch-217]
On Sun, 21 Aug 2005, Gary V. Vaughan wrote: ## -## Copyright (C) 2003, 2004, 2005 Free Software Foundation, Inc. +## Copyright (C) 1998, 1999, 2000, 2001, 2003, 2004, 2005 +## Free Software Foundation, Inc. How did all the extra years end up in the copyright statement? The per-file copyright notice should only include years when significant changes occured. Bob == Bob Friesenhahn [EMAIL PROTECTED], http://www.simplesystems.org/users/bfriesen/ GraphicsMagick Maintainer,http://www.GraphicsMagick.org/
Re: FYI: D'oh! [libtool--devo--1.0--patch-217]
Hi Bob, On 21 Aug 2005, at 20:32, Bob Friesenhahn wrote: On Sun, 21 Aug 2005, Gary V. Vaughan wrote: ## -## Copyright (C) 2003, 2004, 2005 Free Software Foundation, Inc. +## Copyright (C) 1998, 1999, 2000, 2001, 2003, 2004, 2005 +## Free Software Foundation, Inc. How did all the extra years end up in the copyright statement? The per-file copyright notice should only include years when significant changes occured. copyright.el adds this year to any Copyright statement of a changed file in the save-file-hooks. Feel free to grep the ChangeLog.[12][09][09] [0-9] for libltdl/Makefile.am, and eliminate any years where the changes were not significant... I split them up by year for just this reason :-D BTW, Alias season 3 came out on DVD over here recently... it may have some impact on my hacking time ;-) I plan to blame you for getting me hooked on the show if anyone complains... Cheers, Gary. PGP.sig Description: This is a digitally signed message part
Re: FYI: skip failing template tests on darwin [libtool--devo--1.0--patch-216]
On 21 Aug 2005, at 20:01, Ralf Wildenhues wrote:
Hi Gary,
Hallo!
Thanks. I should note for for reference that at least the last case
(both libraries installed, libb.la linked against liba.la)
constitutes a setup necessary for template libraries to work.
Gesundheit! Template libraries? Have you gone all Bjarne on me? ;-b
Cheers,
Gary.
--
Gary V. Vaughan ())_. gary@
{lilith.warpmail.net,gnu.org},[EMAIL PROTECTED]
Research Scientist ( '/ http://www.tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/{libtool,m4}
Technical Author `(_~)_ http://sources.redhat.com/autobook
PGP.sig
Description: This is a digitally signed message part
Re: FYI: D'oh! [libtool--devo--1.0--patch-217]
On Sun, 21 Aug 2005, Gary V. Vaughan wrote: On 21 Aug 2005, at 20:32, Bob Friesenhahn wrote: On Sun, 21 Aug 2005, Gary V. Vaughan wrote: ## -## Copyright (C) 2003, 2004, 2005 Free Software Foundation, Inc. +## Copyright (C) 1998, 1999, 2000, 2001, 2003, 2004, 2005 +## Free Software Foundation, Inc. How did all the extra years end up in the copyright statement? The per-file copyright notice should only include years when significant changes occured. copyright.el adds this year to any Copyright statement of a changed file in the save-file-hooks. Feel free to grep the ChangeLog.[12][09][09][0-9] for libltdl/Makefile.am, and eliminate any years where the changes were not significant... I split them up by year for just this reason :-D I am sure that when you signed the FSF paperwork you agreed to ensure that copyrights were defensible. If the copyright notices are not correct (e.g. random years inserted), then it causes them to lose legal credibility. The purpose of the paperwork we signed was to ensure that FSF copyrights are fully defensible. BTW, Alias season 3 came out on DVD over here recently... it may have some impact on my hacking time ;-) I plan to blame you for getting me hooked on the show if anyone complains... My bad. Do you want to know how it ends? :-) Bob == Bob Friesenhahn [EMAIL PROTECTED], http://www.simplesystems.org/users/bfriesen/ GraphicsMagick Maintainer,http://www.GraphicsMagick.org/
Re: FYI: D'oh! [libtool--devo--1.0--patch-217]
Hi Bob,
On 21 Aug 2005, at 21:07, Bob Friesenhahn wrote:
On Sun, 21 Aug 2005, Gary V. Vaughan wrote:
On 21 Aug 2005, at 20:32, Bob Friesenhahn wrote:
On Sun, 21 Aug 2005, Gary V. Vaughan wrote:
##
-## Copyright (C) 2003, 2004, 2005 Free Software Foundation, Inc.
+## Copyright (C) 1998, 1999, 2000, 2001, 2003, 2004, 2005
+## Free Software Foundation, Inc.
How did all the extra years end up in the copyright statement?
The per-file copyright notice should only include years when
significant changes occured.
copyright.el adds this year to any Copyright statement of a
changed file in
the save-file-hooks. Feel free to grep the ChangeLog.[12][09][09]
[0-9] for
libltdl/Makefile.am, and eliminate any years where the changes
were not
significant... I split them up by year for just this reason :-D
I am sure that when you signed the FSF paperwork you agreed to
ensure that copyrights were defensible. If the copyright notices
are not correct (e.g. random years inserted), then it causes them
to lose legal credibility. The purpose of the paperwork we signed
was to ensure that FSF copyrights are fully defensible.
What constitutes a significant change? If a great deal of thought
and list
traffic resulted in a 1 line change, then surely that should
constitute an
addition to the file copyright year list?
I do turn down Emacs' option of adding this year to the copyright
list if the
edit was cosmetic.
Anyway, quick sanity check:
$ for file in ChangeLog*
- do
- echo $file: `fgrep libltdl/Makefile.am $file | wc -l`
- done
ChangeLog: 21
ChangeLog.1996: 0
ChangeLog.1997: 0
ChangeLog.1998: 7
ChangeLog.1999: 23
ChangeLog.2000: 3
ChangeLog.2001: 3
ChangeLog.2002: 0
ChangeLog.2003: 1
ChangeLog.2004: 24
Looks good to me! The single change in 2003 was done by me, so I'm
sure I
wouldn't have added it frivolously.
BTW, Alias season 3 came out on DVD over here recently... it may
have some
impact on my hacking time ;-) I plan to blame you for getting me
hooked
on the show if anyone complains...
My bad. Do you want to know how it ends? :-)
It ends? OMG... the wait between finishing watching season 2 and
being able
to buy season 3 was bad enough.
Cheers,
Gary.
--
Gary V. Vaughan ())_. gary@
{lilith.warpmail.net,gnu.org},[EMAIL PROTECTED]
Research Scientist ( '/ http://www.tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/{libtool,m4}
Technical Author `(_~)_ http://sources.redhat.com/autobook
PGP.sig
Description: This is a digitally signed message part
Re: template test with subdirs failure for HEAD on darwin [WAS support standalone libltdl [libtool--gary--1.0--patch-23]]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Gary V. Vaughan wrote: | I guess I'll leave that to our Darwin expert to fix, though. | | | Agreed. Hi Peter! | Hi, Still majorly jet-lagged (thus reading email at 5:45am :-p), but I believe that I noted this failure: http://lists.gnu.org/archive/html/libtool/2005-06/msg00144.html The bug (rdar://problem/4135857 for those of you who work at Apple) has been closed a few times, but appears to be currently open, so maybe they are working on it. As noted in my mail export MACOSX_DEPLOYMENT_TARGET=10.3 and watch the tests pass. Peter -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.0 (Darwin) iQCVAwUBQwjrULiDAg3OZTLPAQIcGQP/SHt5LOjDWd3QUijsc1XO1ndFf0qV/HKH Kj/caZ9qepU6a24CCmOXRthMszB/6thDgrmXZxf81FaFA388xHkbQMWHlr99yGJD Ba3OOXqRmZe3unmCjMoSu021GNkil9f0gw/s03AUXnBNaKlqI/+osPWx1iga0SxH LEzqeX9TzV8= =jmlf -END PGP SIGNATURE-
Re: template test with subdirs failure for HEAD on darwin [WAS support standalone libltdl [libtool--gary--1.0--patch-23]]
On 21 Aug 2005, at 22:11, Gary V. Vaughan wrote:
On 21 Aug 2005, at 22:00, Peter O'Gorman wrote:
Still majorly jet-lagged (thus reading email at 5:45am :-p), but I
believe
that I noted this failure:
http://lists.gnu.org/archive/html/libtool/2005-06/msg00144.html
Well remembered! I'd completely forgotten about that.
The bug (rdar://problem/4135857 for those of you who work at
Apple) has been
closed a few times, but appears to be currently open, so maybe
they are
working on it.
As noted in my mail export MACOSX_DEPLOYMENT_TARGET=10.3 and watch
the tests
pass.
So the better workaround is to add 'export
MACOSX_DEPLOYMENT_TARGET=10.3' to
those tests rather than skip them altogether?
P.S. Welcome back!
P.P.S. Getting gfortran and gcj up and running on 10.4.2 took an
age! Thank God
for darwinports... ;-D
Cheers,
Gary.
--
Gary V. Vaughan ())_. gary@
{lilith.warpmail.net,gnu.org},[EMAIL PROTECTED]
Research Scientist ( '/ http://www.tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/{libtool,m4}
Technical Author `(_~)_ http://sources.redhat.com/autobook
PGP.sig
Description: This is a digitally signed message part
Re: template test with subdirs failure for HEAD on darwin [WAS support standalone libltdl [libtool--gary--1.0--patch-23]]
Gary V. Vaughan wrote: So the better workaround is to add 'export MACOSX_DEPLOYMENT_TARGET=10.3' to those tests rather than skip them altogether? Hmm, no, you have to do it before you configure and build libtool. There are other workarounds to the ld bug, but they'd involve me adding a bunch more darwin specific bits to ltmain.m4sh and we'd probably all rather that I avoid that. The test is correct, the linker is broken, but in this case, if both liba and libb are shared, or both are static, then the test passes. It only fails for shared libb with static liba. This situation seems fairly unlikely in the real world, so skipping the test is probably appropriate. Peter
