[PATCH] Fix --verbose option and add new --no-silent option

[Charles Wilson]

* libltdl/config/ltmain.m4sh (usage): Document
new --no-silent/--no-quiet options. Spacing changes.
(func_enable_tag): Handle --no-silent/--no-quiet options.
Modified --verbose to actually activate opt_verbose.
New behavior: --silent disables both normal output and
func_verbose output.  --verbose enables both normal
output and func_verbose output. --no-silent enables
normal output, but does not affect func_verbose output.
---
The first of several smaller patches broken out of my 
original [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static one:
http://lists.gnu.org/archive/html/libtool-patches/2008-11/msg00019.html

Test suite results (cygwin):
Fails old test demo-exec after demo-shared (this is the failure my
larger patch in the referenced message fixed).
In the new testsuite, fails 25, 74 (which is not a regression on cygwin).

Okay to push?


 libltdl/config/ltmain.m4sh |   30 +++---
 1 files changed, 19 insertions(+), 11 deletions(-)

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index db0ea67..3b8f05b 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -33,17 +33,18 @@ m4_divert_push([SCRIPT])# @configure_input@
 #
 # Provide generalized library-building support services.
 #
-#   --config show all configuration variables
-#   --debug  enable verbose shell tracing
-#   -n, --dry-rundisplay commands without modifying any files
-#   --features   display basic configuration information and exit
-#   --mode=MODE  use operation mode MODE
-#   --preserve-dup-deps  don't remove duplicate dependency libraries
-#   --quiet, --silentdon't print informational messages
-#   --tag=TAGuse configuration variables from tag TAG
-#   -v, --verboseprint informational messages (default)
-#   --versionprint version information
-#   -h, --help, --help-all   print short, long, or detailed help message
+#   --config show all configuration variables
+#   --debug  enable verbose shell tracing
+#   -n, --dry-rundisplay commands without modifying any files
+#   --features   display basic configuration information, exit
+#   --mode=MODE  use operation mode MODE
+#   --preserve-dup-deps  don't remove duplicate dependency libraries
+#   --quiet, --silentdon't print informational messages
+#   --no-quiet, --no-silent  print informational messages (default)
+#   --tag=TAGuse configuration variables from tag TAG
+#   -v, --verboseprint more informational messages than default
+#   --versionprint version information
+#   -h, --help, --help-all   print short, long, or detailed help message
 #
 # MODE must be one of the following:
 #
@@ -319,10 +320,17 @@ func_enable_tag ()
 
   --quiet|--silent)preserve_args=$preserve_args $opt
opt_silent=:
+   opt_verbose=false
+   ;;
+
+  --no-quiet|--no-silent)
+   preserve_args=$preserve_args $opt
+   opt_silent=false
;;
 
   --verbose| -v)   preserve_args=$preserve_args $opt
opt_silent=false
+   opt_verbose=:
;;
 
   --tag)   test $# -eq 0  func_missing_arg $opt  break
-- 
1.6.0.2

[PATCH] Add func_win32_import_lib_p

[Charles Wilson]

* libltdl/config/ltmain.m4sh (func_win32_import_lib_p):
New function.
---
The second of several smaller patches broken out of, or arising from
discussion involving, my original
  [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static one:
http://lists.gnu.org/archive/html/libtool-patches/2008-11/msg00019.html

This one was pre-approved.  I bootstrapped and rebuilt, and manually 
exercised the function -- which verified no syntax errors, at least.
However, I did not run the entire test suite; I couldn't see the
need as ALL the patch does is add the new function. It is not actually
called by anything yet.

Pushed.



 libltdl/config/ltmain.m4sh |   11 +++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index db0ea67..91c1f47 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -3720,6 +3720,17 @@ EOF
 }
 # end: func_emit_cwrapperexe_src
 
+# func_win32_import_lib_p ARG
+# True if ARG is an import lib, as indicated by $file_magic_cmd
+func_win32_import_lib_p ()
+{
+$opt_debug
+case `eval $file_magic_cmd \\$1\ 2/dev/null | $SED -e 10q` in
+*import*) : ;;
+*) false ;;
+esac
+}
+
 # func_mode_link arg...
 func_mode_link ()
 {
-- 
1.6.0.2

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

[Charles Wilson]

Charles Wilson wrote:
 Of course, first I need to revise the dlltool patch and get it accepted;
 there have been some comments on the binutils list.

Done. Yay!
http://sourceware.org/ml/binutils/2008-11/msg00180.html

 Well, that, and it fixes a test that currently fails.
 Which one, and can you post output for failure as well as success with
 the patch, please?
 
 demo-exec after demo-shared, in the old test suite.
 
 I'll post the output(s) tonight or tomorrow.

Attached. The fixed output is from the original, unmodified patch that
started this thread.

--
Chuck



dlpreopen-failure.log.bz2
Description: Binary data


dlpreopen-fixed.log.bz2
Description: Binary data