[PATCH 22/25] syntax-check: enable sc_bindtextdomain.
* cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain list of disabled checks. (exclude_file_name_regexp--sc_program_name): Don't check demo programs for use of set_program_name. Signed-off-by: Gary V. Vaughan g...@gnu.org --- cfg.mk |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index f92039a..1d6ca3c 100644 --- a/cfg.mk +++ b/cfg.mk @@ -46,13 +46,11 @@ local-checks-to-fix = \ local-checks-to-skip = \ $(local-checks-to-fix) \ sc_GPL_version \ - sc_bindtextdomain \ sc_program_name \ sc_trailing_blank \ sc_unmarked_diagnostics # GPL_version: checks for GPLv3, which we don't use -# bindtextdomain: libtool isn't internationalized # program_name: libtool has no programs! # trailing_blank: flags valid rfc3676 separators # unmarked_diagnostics: libtool isn't internationalized @@ -63,6 +61,7 @@ sc_trailing_blank-non-rfc3676: $(_sc_search_regexp) # List syntax-check exempted files. +exclude_file_name_regexp--sc_bindtextdomain = ^tests/.*demo[0-9]*/.*\.c$$ exclude_file_name_regexp--sc_error_message_uppercase = \ ^$(_build-aux)/cvsu$$ exclude_file_name_regexp--sc_prohibit_strcmp = \ -- 1.7.7.3 Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)
Re: [PATCH 22/25] syntax-check: enable sc_bindtextdomain.
On Tuesday 15 November 2011, Gary V wrote: * cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain list of disabled checks. (exclude_file_name_regexp--sc_program_name): Don't check demo s|set_program_name|bindtextdomain| here? programs for use of set_program_name. And here as well? Regards, Stefano
Re: [PATCH 22/25] syntax-check: enable sc_bindtextdomain.
On Tuesday 15 November 2011, Gary V wrote: * cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain list of disabled checks. (exclude_file_name_regexp--sc_program_name): Don't check demo programs for use of set_program_name. Signed-off-by: Gary V. Vaughan g...@gnu.org --- cfg.mk |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index f92039a..1d6ca3c 100644 --- a/cfg.mk +++ b/cfg.mk @@ -46,13 +46,11 @@ local-checks-to-fix = \ local-checks-to-skip = \ $(local-checks-to-fix) \ sc_GPL_version \ - sc_bindtextdomain \ sc_program_name \ sc_trailing_blank \ sc_unmarked_diagnostics # GPL_version: checks for GPLv3, which we don't use -# bindtextdomain: libtool isn't internationalized But then again, if libtool isn't internationalized, what is the point of enabling the `sc_bindtextdomain' check? Regards, Stefano
Re: [PATCH 22/25] syntax-check: enable sc_bindtextdomain.
Hi Stefano, Thanks for the review. On Tuesday 15 November 2011, Gary V wrote: * cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain list of disabled checks. (exclude_file_name_regexp--sc_program_name): Don't check demo s|set_program_name|bindtextdomain| here? programs for use of set_program_name. And here as well? Oops. Fixed. Thanks. But then again, if libtool isn't internationalized, what is the point of enabling the `sc_bindtextdomain' check? We might add i18n to libtool someday, and I like having more checks even if they don't (yet) catch anything, rather than fewer checks. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)
