Re: tests: avoid empty AT_DATA contents, for zsh.
On 09/12/2010 09:30 AM, Ralf Wildenhues wrote: This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD. catfileEOF EOF produces an empty file with sh, but a file containing a newline with zsh, even after 'emulate sh'. autoconf.texi patch coming up too, I guess. Ouch - that's a nasty bug. Have you reported it to the zsh list yet? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org
Re: tests: avoid empty AT_DATA contents, for zsh.
On 09/13/2010 08:16 AM, Eric Blake wrote: On 09/12/2010 09:30 AM, Ralf Wildenhues wrote: This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD. catfileEOF EOF produces an empty file with sh, but a file containing a newline with zsh, even after 'emulate sh'. autoconf.texi patch coming up too, I guess. Ouch - that's a nasty bug. Have you reported it to the zsh list yet? Hmm, rather than fixing all _our_ uses of AT_DATA, but still having the problem for other clients, why not instead fix AT_DATA to special-case the empty argument to do the right thing for everyone? Don't apply this patch, and I'll help come up with an alternative. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org
Re: tests: avoid empty AT_DATA contents, for zsh.
[adding bug-autoconf] On 09/13/2010 08:18 AM, Eric Blake wrote: On 09/13/2010 08:16 AM, Eric Blake wrote: On 09/12/2010 09:30 AM, Ralf Wildenhues wrote: This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD. catfileEOF EOF produces an empty file with sh, but a file containing a newline with zsh, even after 'emulate sh'. autoconf.texi patch coming up too, I guess. Ouch - that's a nasty bug. Have you reported it to the zsh list yet? Hmm, rather than fixing all _our_ uses of AT_DATA, but still having the problem for other clients, why not instead fix AT_DATA to special-case the empty argument to do the right thing for everyone? Don't apply this patch, and I'll help come up with an alternative. Oops - I thought your patch was for autoconf when I asked you not to apply the patch. On re-reading this, I see that it is a libtool patch instead. Go ahead and apply the libtool patch, since you can't guarantee (or don't want to limit yourself to) a new enough autoconf. Meanwhile, in parallel, I will be patching autoconf to make AT_DATA explicitly allow empty files in 2.68. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org
tests: avoid empty AT_DATA contents, for zsh.
This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD. cat file EOF EOF produces an empty file with sh, but a file containing a newline with zsh, even after 'emulate sh'. autoconf.texi patch coming up too, I guess. Cheers, Ralf tests: avoid empty AT_DATA contents, for zsh. * tests/libtoolize.at (libtoolize macro serial update) (libtoolize config files serial update, LIBTOOLIZE_OPTIONS): Do not create empty files with AT_DATA, the latter is documented to require a final newline. Fixes testsuite failures with zsh 4.3.10. diff --git a/tests/libtoolize.at b/tests/libtoolize.at index fa229b9..541753b 100644 --- a/tests/libtoolize.at +++ b/tests/libtoolize.at @@ -155,7 +155,7 @@ LT_AT_CHECK_LIBTOOLIZE([--copy], 0, expout, experr) ## Next, a second update attempt with everything now updated. ## ## -- ## -AT_DATA(expout, [[]]) +: expout AT_DATA(experr, [[libtoolize: `build-aux/ltmain.sh' is newer: use `--force' to overwrite @@ -187,7 +187,7 @@ LT_AT_CHECK_LIBTOOLIZE([--copy --force], 0, expout) ## A final update attempt with everything previously force updated. ## ## ## -AT_DATA(expout, [[]]) +: expout LT_AT_CHECK_LIBTOOLIZE([--copy], 0, expout) @@ -232,7 +232,7 @@ LT_AT_CHECK_LIBTOOLIZE([--copy --install], 0, expout, experr) ## Next, a second update attempt with everything now updated. ## ## -- ## -AT_DATA(expout, [[]]) +: expout AT_DATA(experr, [[libtoolize: `build-aux/ltmain.sh' is newer: use `--force' to overwrite @@ -267,7 +267,7 @@ LT_AT_CHECK_LIBTOOLIZE([--copy --force --install], 0, expout) ## A final update attempt with everything previously force updated. ## ## ## -AT_DATA(expout, [[]]) +: expout LT_AT_CHECK_LIBTOOLIZE([--copy --install], 0, expout) @@ -978,7 +978,7 @@ LT_AT_CHECK_LIBTOOLIZE([--copy], 0, [ignore], experr) LIBTOOLIZE_OPTIONS=--no-warn,--no-such-option export LIBTOOLIZE_OPTIONS -AT_DATA(experr, [[]]) +: experr LT_AT_CHECK_LIBTOOLIZE([--copy], 0, [ignore], experr)
