Re: [Libva] [PATCH 2/3] H.265 main 10 encoder supports only 10bpp render targets

[Sean V Kelley]

On Thu, 2016-12-15 at 13:04 +, Mark Thompson wrote:
> On 05/12/16 17:54, Mark Thompson wrote:
> > Signed-off-by: Mark Thompson 
> > ---
> > The supported surface formats are already correct (i.e. only P010);
> > this makes the render target format right as well (before this, it
> > declares that it supports only YUV 4:2:0 8-bit).
> > 
> >  src/i965_drv_video.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
> > index d83427c..9e1c92a 100644
> > --- a/src/i965_drv_video.c
> > +++ b/src/i965_drv_video.c
> > @@ -880,6 +880,8 @@
> > i965_get_default_chroma_formats(VADriverContextP ctx, VAProfile
> > profile,
> >  break;
> >  
> >  case VAProfileHEVCMain10:
> > +if (HAS_HEVC10_ENCODING(i965) && entrypoint ==
> > VAEntrypointEncSlice)
> > +chroma_formats = VA_RT_FORMAT_YUV420_10BPP;
> >  if (HAS_HEVC10_DECODING(i965) && entrypoint ==
> > VAEntrypointVLD)
> >  chroma_formats |= i965->codec_info-
> > >hevc_dec_chroma_formats;
> >  break;
> > 
> 
> Ping.  (The other patches in this series have been considered
> separately.)

Yes this is a good catch.  It was overlooked with the addition of 10bit
support.  We may need to make further adjustment when we roll in new
encoder formats too.

lgtm.

applied.

Sean


> Thanks,
> 
> - Mark
> 
> ___
> Libva mailing list
> Libva@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libva

___
Libva mailing list
Libva@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libva

Re: [Libva] [PATCH 2/3] H.265 main 10 encoder supports only 10bpp render targets

[Mark Thompson]

On 05/12/16 17:54, Mark Thompson wrote:
> Signed-off-by: Mark Thompson 
> ---
> The supported surface formats are already correct (i.e. only P010); this 
> makes the render target format right as well (before this, it declares that 
> it supports only YUV 4:2:0 8-bit).
> 
>  src/i965_drv_video.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
> index d83427c..9e1c92a 100644
> --- a/src/i965_drv_video.c
> +++ b/src/i965_drv_video.c
> @@ -880,6 +880,8 @@ i965_get_default_chroma_formats(VADriverContextP ctx, 
> VAProfile profile,
>  break;
>  
>  case VAProfileHEVCMain10:
> +if (HAS_HEVC10_ENCODING(i965) && entrypoint == VAEntrypointEncSlice)
> +chroma_formats = VA_RT_FORMAT_YUV420_10BPP;
>  if (HAS_HEVC10_DECODING(i965) && entrypoint == VAEntrypointVLD)
>  chroma_formats |= i965->codec_info->hevc_dec_chroma_formats;
>  break;
> 

Ping.  (The other patches in this series have been considered separately.)

Thanks,

- Mark

___
Libva mailing list
Libva@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libva