Re: [libvirt] OSX Homebrew support note ;)

[Justin Clift]

On 24 Jan 2017, at 10:33, Daniel P. Berrange  wrote:
> So lets enable QEMU in libvirt and for OS-X and just let people file
> bugs if they find bits that don't work.

Just compiled Libvirt (3.0.0 release) on OSX, using "--with-qemu" on
the configure line.  QEMU 2.8.0 is installed (through Homebrew).

Trying to start libvirtd itself seems to barf:

*

$ sudo libvirtd
2017-01-24 18:35:16.272+: 18446744073709551615: info : libvirt version: 
3.0.0
2017-01-24 18:35:16.272+: 18446744073709551615: info : hostname: 
justinsmac.local
2017-01-24 18:35:16.272+: 18446744073709551615: warning : 
virProcessGetStartTime:1056 : Process start time of pid 56028 not available on 
this platform
2017-01-24 18:35:16.273+: 18446744073709551615: error : virSysinfoRead:1022 
: internal error: Failed to find path for dmidecode binary
2017-01-24 18:35:16.273+: 18446744073709551615: error : 
virFileFindHugeTLBFS:3550 : this function is not supported by the connection 
driver: virFileFindHugeTLBFS
2017-01-24 18:35:16.285+: 18446744073709551615: error : virExec:494 : 
Cannot find 'pm-is-supported' in path: No such file or directory
2017-01-24 18:35:16.285+: 18446744073709551615: warning : 
virQEMUCapsInit:1148 : Failed to get host power management capabilities
2017-01-24 18:35:16.285+: 18446744073709551615: error : virNumaGetPages:954 
: Operation not supported: page info is not supported on this platform
2017-01-24 18:35:16.285+: 18446744073709551615: warning : 
virQEMUCapsInit:1152 : Failed to get pages info
2017-01-24 18:35:16.370+: 18446744073709551615: error : 
qemuMonitorJSONCheckError:387 : internal error: unable to execute QEMU command 
'query-cpu-definitions': The command query-cpu-definitions has not been found
2017-01-24 18:35:16.370+: 18446744073709551615: error : 
virEventPollRunOnce:647 : Unable to poll on file handles: Bad file descriptor
2017-01-24 18:35:16.370+: 18446744073709551615: warning : 
virQEMUCapsLogProbeFailure:4624 : Failed to probe capabilities for 
/usr/local/bin/qemu-system-alpha: internal error: unable to execute QEMU 
command 'query-cpu-definitions': The command query-cpu-definitions has not been 
found
$

*

Do we need libvirtd to run on OSX properly first, for QEMU to be
reachable?  (as mentioned, it's been a few years ;>)

+ Justin

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] OSX Homebrew support note ;)

[Justin Clift]

On 23 Jan 2017, at 11:38, Daniel P. Berrange <berra...@redhat.com> wrote:
> On Wed, Dec 21, 2016 at 09:55:53AM +0000, Justin Clift wrote:

> 
> I'm looking at (what I hope is the correct) configuration file for the
> build:
> 
>  https://github.com/Homebrew/homebrew-core/blob/master/Formula/libvirt.rb

Yep, that's the right one.

> and see '--without-qemu' being passed - what is the reason for that ? It
> looks like you're building libvirtd, so enabling QEMU thereafter should
> not have any significantly difficulties. Certainly we expect the QEMU
> driver code to be platform agnostic - all the Linux specific bits are
> believed to be wrapped in conditionals.
> 
> IOW if you see build errors with QEMU on OS-X could you tell us what they
> are.

>From memory (it's been a few years!), it was because the QEMU that builds
in Homebrew wouldn't talk to Libvirt anyway.  So it was useless to add the
support in.

That being said, I do remember someone mentioning they should probably
worth together ok these days.  But, I'm not sure if anyone's checked
and/or really tried to make it work.


> We'd really want to see the QEMU driver enabled

Yep, it sounds like it'd be a useful combination.  As would xhyve, if
that could somehow use the bhyve support (I have no idea). :)

+ Justin

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] New website missing link to the News page?

[Justin Clift]

On 2016-12-21 10:31, Daniel P. Berrange wrote:

On Wed, Dec 21, 2016 at 10:25:34AM +, Justin Clift wrote:

Hi all,

With the new website, it still has the News page:

  https://libvirt.org/news.html

But there doesn't seem to be a link to it from anywhere.


Its linked from the front page and the download page


Thanks Daniel, I should have done View Source before asking. :)

The link text/font on the download page really isn't standing
out.  But, at least it's there. :D

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] New website missing link to the News page?

[Justin Clift]

Hi all,

With the new website, it still has the News page:

  https://libvirt.org/news.html

But there doesn't seem to be a link to it from anywhere.

Is that a bug?

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] OSX Homebrew support note ;)

[Justin Clift]

Hi all,

Compiling Libvirt directly from latest git master head is now supported 
on

OSX Homebrew.  It's as simple as:

  $ brew install --HEAD libvirt
  ...
  $ virsh -v
  3.0.0

This should make development of Libvirt and related virtualisation 
things

much easier on OSX. :)

The credit for this goes to Roman Bogorodskiy and Homebrew developer
"ilovezfs" (CC-d), for adding a functional rpcgen to Homebrew so we can
generate the needed RPC bindings during the build (previously missing).

Thanks heaps! :)

Regards and best wishes,

Justin Clift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Release of libvirt-2.1.0

[Justin Clift]

On 2 Aug 2016, at 09:57, Daniel Veillard  wrote:
>   Sorry I didn't push an rc2 on Friday, finishing my move, but not seeing any
> issue raised by rc1, I though it was better to push the final release now and 
> free
> up the tree for pending development. As a result 2.1.0 is tagged in git and I
> pushed signed tarbal and rpms to the usual place:
> 
>ftp://libvirt.org/libvirt/

It's working for OSX too. (whew!) :)

Libvirt 2.1.0 is now available through OSX Homebrew.

+ Justin

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3] util: systemd: Define MSG_NOSIGNAL if needed

[Justin Clift]

On 26 Jul 2016, at 08:26, Andrea Bolognani  wrote:
> On Tue, 2016-07-26 at 04:55 +0300, Roman Bogorodskiy wrote:
>> I pushed the patch to make sure it won't get lost and get into the
>> upcoming release.
> 
> I was away for a few days, thanks for taking care of this :)

Thanks guys. :)

+ Justin

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Schedule for next release

[Justin Clift]

On 25 Jul 2016, at 23:13, Daniel Veillard <veill...@redhat.com> wrote:
>  About time to roll that one.
> I think we need to enter freese on Wednesday, then I can make rc2 on Friday,
> and hopefully we can push 2.1.0 on Monday or Tuesday next week.
> 
>  Raise a flag if that doesn't work :-)

Hoping we get the OSX fix in by then (which has been ACK'd). :D

Regards and best wishes,

Justin Clift

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3] util: systemd: Define MSG_NOSIGNAL if needed

[Justin Clift]

On 22 Jul 2016, at 10:13, Daniel P. Berrange <berra...@redhat.com> wrote:
> On Wed, Jul 20, 2016 at 03:11:51PM +0100, Justin Clift wrote:
>> On 20 Jul 2016, at 14:46, Andrea Bolognani <abolo...@redhat.com> wrote:
>>> The symbol being missing has been reported as causing build
>>> failures on OS X. If it's not already defined, define it to
>>> zero so that it won't have any effect.
>>> ---
>>> Changes from v2:
>>> 
>>> * define MSG_NOSIGNAL to zero if not already defined
>>>   instead of conditionally compiling the code depending
>>>   on it
>>> 
>>> src/util/virsystemd.c | 4 
>>> 1 file changed, 4 insertions(+)
>>> 
>>> diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c
>>> index 969cd68..7d6985b 100644
>>> --- a/src/util/virsystemd.c
>>> +++ b/src/util/virsystemd.c
>>> @@ -41,6 +41,10 @@
>>> 
>>> VIR_LOG_INIT("util.systemd");
>>> 
>>> +#ifndef MSG_NOSIGNAL
>>> +# define MSG_NOSIGNAL 0
>>> +#endif
>>> +
>>> static void virSystemdEscapeName(virBufferPtr buf,
>>> const char *name)
>>> {
>>> -- 
>>> 2.7.4
>> 
>> This compiles fine on OSX too. :)
>> 
>> One niggle with it though... this is what is looks like in context:
>> 
>> ***
>> ...
>> #include "virerror.h"
>> #include "virfile.h"
>> 
>> #define VIR_FROM_THIS VIR_FROM_SYSTEMD
>> 
>> VIR_LOG_INIT("util.systemd");
>> 
>> #ifndef MSG_NOSIGNAL
>> # define MSG_NOSIGNAL 0
>> #endif
>> 
>> static void virSystemdEscapeName(virBufferPtr buf,
>> const char *name)
>> {
>>static const char hextable[16] = "0123456789abcdef";
>> 
>> #define ESCAPE(c)
>> ...
>> ***
>> 
>> Isn't it kind of crying out for a useful comment, so the next person
>> looking through this code has a good chance to understand why it's
>> there? ;)
>> 
>> Maybe something like:
>> 
>> /* OSX is missing MSG_NOSIGNAL, so we define it here to avoid
>> * failure during building.
>> */
> 
> Not really - it is pretty obvious what the code is doing so adding
> such a comment doesn't really add much value.

No worries at all. :)

+ Justin

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3] util: systemd: Define MSG_NOSIGNAL if needed

[Justin Clift]

On 20 Jul 2016, at 14:46, Andrea Bolognani  wrote:
> The symbol being missing has been reported as causing build
> failures on OS X. If it's not already defined, define it to
> zero so that it won't have any effect.
> ---
> Changes from v2:
> 
>  * define MSG_NOSIGNAL to zero if not already defined
>instead of conditionally compiling the code depending
>on it
> 
> src/util/virsystemd.c | 4 
> 1 file changed, 4 insertions(+)
> 
> diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c
> index 969cd68..7d6985b 100644
> --- a/src/util/virsystemd.c
> +++ b/src/util/virsystemd.c
> @@ -41,6 +41,10 @@
> 
> VIR_LOG_INIT("util.systemd");
> 
> +#ifndef MSG_NOSIGNAL
> +# define MSG_NOSIGNAL 0
> +#endif
> +
> static void virSystemdEscapeName(virBufferPtr buf,
>  const char *name)
> {
> -- 
> 2.7.4

This compiles fine on OSX too. :)

One niggle with it though... this is what is looks like in context:

***
...
#include "virerror.h"
#include "virfile.h"

#define VIR_FROM_THIS VIR_FROM_SYSTEMD

VIR_LOG_INIT("util.systemd");

#ifndef MSG_NOSIGNAL
# define MSG_NOSIGNAL 0
#endif

static void virSystemdEscapeName(virBufferPtr buf,
 const char *name)
{
static const char hextable[16] = "0123456789abcdef";

#define ESCAPE(c)
...
***

Isn't it kind of crying out for a useful comment, so the next person
looking through this code has a good chance to understand why it's
there? ;)

Maybe something like:

/* OSX is missing MSG_NOSIGNAL, so we define it here to avoid
 * failure during building.
 */

:)

+ Justin

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2] configure: Check for MSG_NOSIGNAL availability

[Justin Clift]

On 20 Jul 2016, at 14:38, Andrea Bolognani  wrote:
> On Wed, 2016-07-20 at 14:19 +0100, Daniel P. Berrange wrote:
>> On Wed, Jul 20, 2016 at 03:16:35PM +0200, Andrea Bolognani wrote:
>>>  
>>> The symbol being missing has been reported as causing build
>>> failures on OS X. Check for its availability before using it.
>>> ---
>>> Changes from v1:
>>>  
>>>* don't unnecessarily check for availability at configure
>>>  time (thanks Ján)
>>>  
>>>   src/util/virsystemd.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>  
>>> diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c
>>> index 969cd68..81ee538 100644
>>> --- a/src/util/virsystemd.c
>>> +++ b/src/util/virsystemd.c
>>> @@ -482,7 +482,7 @@ int virSystemdTerminateMachine(const char *name)
>>>   void
>>>   virSystemdNotifyStartup(void)
>>>   {
>>> -#ifdef HAVE_SYS_UN_H
>>> +#if defined(HAVE_SYS_UN_H) && defined(MSG_NOSIGNAL)
>>>   const char *path;
>>>   const char *msg = "READY=1";
>>>   int fd;
>>> @@ -526,7 +526,7 @@ virSystemdNotifyStartup(void)
>>>   VIR_WARN("Failed to notify systemd");
>>>   
>>>   VIR_FORCE_CLOSE(fd);
>>> -#endif /* HAVE_SYS_UN_H */
>>> +#endif /* defined(HAVE_SYS_UN_H) && defined(MSG_NOSIGNAL) */
>>  
>> IMHO it'd be nicer to just do
>>  
>>  
>> #ifndef MSG_NOSIGNAL
>> #define MSG_NOSIGNAL 0
>> #endif
>>  
>> as it avoids creating ever more compicated conditional blocks around the
>> code.
> 
> So pretty much the patch that was proposed initially, then ;)
> 
> v3 coming right up!

Trivial side thought... since this isn't a "configure" patch any more, should
the title for the patch be adjusted? ;)

+ Justin

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] configure: Check for MSG_NOSIGNAL availability

[Justin Clift]

On 19 Jul 2016, at 15:48, Andrea Bolognani  wrote:
> On Tue, 2016-07-19 at 16:23 +0200, Ján Tomko wrote:
>> On Tue, Jul 19, 2016 at 04:00:25PM +0200, Andrea Bolognani wrote:
>>>  
>>> The symbol being missing has been reported as causing build
>>> failures on OS X. Check for its availability before using it.
>>> ---
>>> See https://www.redhat.com/archives/libvir-list/2016-July/msg00613.html
>>>  
>>> configure.ac  | 4 
>>> src/util/virsystemd.c | 4 ++--
>>> 2 files changed, 6 insertions(+), 2 deletions(-)
>>>  
>>> diff --git a/configure.ac b/configure.ac
>>> index 2c81c95..af5d2f8 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -402,6 +402,10 @@ AC_CHECK_TYPE([struct sockpeercred],
>>>[], [[#include 
>>>]])
>>>  
>>> +AC_CHECK_DECLS([MSG_NOSIGNAL],
>>> +  [], [], [[#include 
>>> +  ]])
>>> +
>>> AC_CHECK_DECLS([ETH_FLAG_TXVLAN, ETH_FLAG_NTUPLE, ETH_FLAG_RXHASH, 
>>> ETH_FLAG_LRO,
>>>  ETHTOOL_GGSO, ETHTOOL_GGRO, ETHTOOL_GFLAGS, 
>>> ETHTOOL_GFEATURES],
>>>[], [], [[#include 
>>> diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c
>>> index 969cd68..d2f4bfb 100644
>>> --- a/src/util/virsystemd.c
>>> +++ b/src/util/virsystemd.c
>>> @@ -482,7 +482,7 @@ int virSystemdTerminateMachine(const char *name)
>>> void
>>> virSystemdNotifyStartup(void)
>>> {
>>> -#ifdef HAVE_SYS_UN_H
>>> +#if defined(HAVE_SYS_UN_H) && defined(HAVE_MSG_NOSIGNAL)
>>  
>> What are the benefits of checking this at configure-time?
>>  
>> Seems to me we could just as well use defined(MSG_NOSIGNAL) without
>> slowing configure down even more if we aren't going to base other
>> configure-time decisions on it.
> 
> You're of course right. I'm not quite sure what I was thinking
> when I added the configure check.

Heh Heh Heh

Guessing this means there'll be a new version of the patch I need
to test? ;)

+ Justin

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

[Justin Clift]

On 20 Jul 2016, at 13:57, Justin Clift <jus...@postgresql.org> wrote:
On 20 Jul 2016, at 13:43, Andrea Bolognani <abolo...@redhat.com> wrote:

>> If you post the error message you're getting we'll of course
>> try to help you out to the best of our possibilities :)
> 
> Sure.  Lets see if my 2nd attempt at regenerating patched archive
> file work first... :)

Good news, your patch works fine. :)

The config error on my end was indeed just due to forgetting to reset
the timestamps on the patched files.

After doing that, libvirt-2.0.0 (with your patch) compiled fine.  virsh
seems to run ok too, so from my point of view "good enough". :)

Regards and best wishes,

Justin Clift

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

[Justin Clift]

On 20 Jul 2016, at 13:43, Andrea Bolognani <abolo...@redhat.com> wrote:
> On Wed, 2016-07-20 at 13:28 +0100, Justin Clift wrote:
>> I'll put more time into investigating why the patch barfed for me.  I
>> think it'll just be something simple like forgetting to set the time/date
>> stamp of the patched file so make doesn't try to regenerate ./configure
>> again.  Will find out. ;)
> 
> Sounds to me like your build environment is kinda broken...
> You really shouldn't need to do anything like that, just 'git
> am' the commit and 'make' away. As a simple sanity check, can
> you compile libvirt 1.3.5 successfully?

Yeah, libvirt 1.3.5 is fine.

The problem here is that getting this tested in OSX has some pita
niggles that needing working around, and it's been a fair while since
I last needed to do them.  eg out of practise :)

In this instance, because this is intended for use in Homebrew
(an OSX packaging system) I need to test the patch with the already
generated libvirt-2.0.0.xz archive, not the latest git master.

Cue unpacking, applying patch, repacking, etc.

I'm on it now. ;)


> If you post the error message you're getting we'll of course
> try to help you out to the best of our possibilities :)

Sure.  Lets see if my 2nd attempt at regenerating patched archive
file work first... :)

+ Justin

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

[Justin Clift]

On 20 Jul 2016, at 12:21, Martin Kletzander <mklet...@redhat.com> wrote:
> On Tue, Jul 19, 2016 at 06:30:47PM +0100, Justin Clift wrote:
>> On 19 Jul 2016, at 17:58, Andrea Bolognani <abolo...@redhat.com> wrote:

>>> Did you manage to build and run libvirt succesfully with the
>>> patch I posted?
>> 
>> Not yet.  It barfed at me due to a system config problem which I need
>> to investigate and haven't done yet.  Probably get around to it later
>> today. :)
>> 
>> Thinking out loud... is the systemd code compiled for BSD?
>> 
>> Guessing not (without checking :>), so there's probably some kind of
>> #ifdef to automatically exclude it.  If that's how things are setup at
>> present, would the optimal approach be to adjust such an #ifdef to also
>> exclude OSX?
>> 
> 
> Unfortunately the systemd code is compiled everywhere.  We use no
> library or header file.  AFAIK the only way we communicate with systemd
> is DBus (and one socket maybe), anyway if that's not available we just
> fallback without an error, so the code is designed to work with or
> without systemd, no need to recompile anything.  OTOH it adds unused
> code for platforms where it won't be used at all.  At least for now ;)

Thanks Martin. :)

I'll put more time into investigating why the patch barfed for me.  I
think it'll just be something simple like forgetting to set the time/date
stamp of the patched file so make doesn't try to regenerate ./configure
again.  Will find out. ;)

Regards and best wishes,

Justin Clift

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi



signature.asc
Description: Message signed with OpenPGP using GPGMail
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

[Justin Clift]

On 19 Jul 2016, at 17:58, Andrea Bolognani <abolo...@redhat.com> wrote:
> On Tue, 2016-07-19 at 16:30 +0100, Justin Clift wrote:
>> On 19 Jul 2016, at 15:03, Andrea Bolognani <abolo...@redhat.com> wrote:
>> 
>>>  
>>>>  
>>>> It's outside the #endif for __VIR_SYSTEMD_H___ though, so I'm kind of
>>>> thinking it would need to be move inside the guard (which also compiles
>>>> ok), or is there a better place/file for it instead? :)
>>>  
>>> I have posted a tentative patch to fix your issue
>>>  
>>>https://www.redhat.com/archives/libvir-list/2016-July/msg00724.html
>>>  
>>> Can you please check it out and confirm whether it works or
>>> not? I don't have any OS X host where I can test it myself.
>>>  
>>> To be honest, I don't see why we're compiling the systemd
>>> support code on OS X at all. But I don't have the time to
>>> dig further right now :)
>>  
>> Oops, it didn't click for me that this is systemd code.  You're right,
>> there's no need for that to be compiled on OSX. :)
>>  
>> Looking at the output from ./configure, there doesn't seem to be a
>> switch for disabling systemd stuff.
>>  
>> Did I overlook something? :)
> 
> You didn't overlook anything: there's simply no way to compile
> the systemd support conditionally, at least at the moment :)
> 
> Did you manage to build and run libvirt succesfully with the
> patch I posted?

Not yet.  It barfed at me due to a system config problem which I need
to investigate and haven't done yet.  Probably get around to it later
today. :)

Thinking out loud... is the systemd code compiled for BSD?

Guessing not (without checking :>), so there's probably some kind of
#ifdef to automatically exclude it.  If that's how things are setup at
present, would the optimal approach be to adjust such an #ifdef to also
exclude OSX?

+ Justin

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

[Justin Clift]

On 19 Jul 2016, at 15:03, Andrea Bolognani <abolo...@redhat.com> wrote:

>> It's outside the #endif for __VIR_SYSTEMD_H___ though, so I'm kind of
>> thinking it would need to be move inside the guard (which also compiles
>> ok), or is there a better place/file for it instead? :)
> 
> I have posted a tentative patch to fix your issue
> 
>   https://www.redhat.com/archives/libvir-list/2016-July/msg00724.html
> 
> Can you please check it out and confirm whether it works or
> not? I don't have any OS X host where I can test it myself.
> 
> To be honest, I don't see why we're compiling the systemd
> support code on OS X at all. But I don't have the time to
> dig further right now :)

Oops, it didn't click for me that this is systemd code.  You're right,
there's no need for that to be compiled on OSX. :)

Looking at the output from ./configure, there doesn't seem to be a
switch for disabling systemd stuff.

Did I overlook something? :)

Regards and best wishes,

Justin Clift

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Minor compile failure on OSX for libvirt 2.0.0

[Justin Clift]

Hi all,

There's a minor compile failure on OSX with libvirt 2.0.0:

CC   util/libvirt_util_la-virtime.lo
CC   util/libvirt_util_la-virtpm.lo
  util/virsystemd.c:524:26: error: use of undeclared identifier 'MSG_NOSIGNAL'
  if (sendmsg(fd, , MSG_NOSIGNAL) < 0)
   ^
  1 error generated.
  make[3]: *** [util/libvirt_util_la-virsystemd.lo] Error 1
  make[3]: *** Waiting for unfinished jobs

Seems solvable by adding a stub declaration for MSG_NOSIGNAL on
systems that don't implement it.

An initial patch with the declaration, developed by Tomasz Pajor
(CC'd), is below:

  --- src/util/virsystemd.h.orig2016-07-03 21:40:12.0 +0200
  +++ src/util/virsystemd.h 2016-07-03 21:37:53.0 +0200
  @@ -57,3 +57,7 @@
   char *virSystemdGetMachineNameByPID(pid_t pid);
 
   #endif /* __VIR_SYSTEMD_H__ */
  +
  +#ifndef MSG_NOSIGNAL
  +#define MSG_NOSIGNAL 0x0 //Don't request NOSIGNAL on systems where this is 
not implemented.
  +#endif

It's outside the #endif for __VIR_SYSTEMD_H___ though, so I'm kind of
thinking it would need to be move inside the guard (which also compiles
ok), or is there a better place/file for it instead? :)

Regards and best wishes,

Justin Clift

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Libvirtd and OSX... with QEMU

[Justin Clift]

On 2016-02-18 10:43, Martin Kletzander wrote:

On Mon, Jan 18, 2016 at 05:04:44PM +, Justin Clift wrote:


But last night I had the realisation that libvirtd itself might work 
too

since it functions on the other BSD's.  So, took a few minutes to try
it out.  Without QEMU installed, libvirtd doesn't error out like the
above.  That only happens when QEMU is around.  So, it's related to 
that

somehow. :)


Sorry for not replying for a while.  Unfortunately I have no new info
about this and why it might be happening.  Did you get any further?


No.  My interests lie elsewhere these days (CAD/CAM, medical 
automation),
so this just didn't really peak my interest enough to spend more time 
on. ;)




Does it happen every single start?


Yeah, completely reliable.

One other weirdness showed up too, probably not related though.  
Without
QEMU installed, when starting up libvirtd with -l enabled (for 
listening),

it exists complaining about missing cert file.  That in itself is not
surprising... except it happens even when TLS is disabled is in 
libvirtd.conf.


According to the wiki, turning off listen_tls + turning on listen_tcp 
should

stop the need for cert files:

 http://wiki.libvirt.org/page/The_daemon_cannot_be_started

Does that sound like a bug too, or more like the wiki is out of date? 
:)


If you have no certificate installed and you have listen_tls=0 and
listen_tcp=1, it should not be a problem.


k, that's definitely a bug then.

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Libvirtd and OSX... with QEMU

[Justin Clift]

On 18 Jan 2016, at 14:00, Martin Kletzander <mklet...@redhat.com> wrote:
> On Sun, Jan 17, 2016 at 10:16:54PM +0000, Justin Clift wrote:

>>> With debug level logging, although more verbose there's nothing that
>>> seems smoking-gun like.  Except maybe this?
>>> 
>>> 2016-01-17 22:07:51.008+: 18446744073709551615: debug : 
>>> virEventPollRunOnce:644 : Poll got error event 9
>>> 2016-01-17 22:07:51.008+: 18446744073709551615: error : 
>>> virEventPollRunOnce:648 : Unable to poll on file handles: Bad file 
>>> descriptor
>>> 2016-01-17 22:07:51.008+: 18446744073709551615: debug : 
>>> virNetDaemonRun:703 : Loop iteration error, exiting
> 
> So we're passing invalid FDs to poll() function.  I can't think of
> anything else than bisection or pausing the process around
> vireventpoll.c:644 (the call to poll()) and checking what the FDs point
> to, which one is the invalid one and then going back to see how it got
> there, what is it, who forgot to delete it and so on.

Gah.  Sounds like I may need to go and relearn GDB.  Not quite sure I'm
motivated enough tbh.  We'll see... :)


> Did this not happen with the release candidates?

As far as I know, on OSX people mainly use virsh.  eg for connecting to
libvirt on Linux/BSD/whatever hosts.  So libvirtd support may or may
not have been working for a while.  I don't know, as I only tested
virsh when updating the recent Homebrew port. ;)

But last night I had the realisation that libvirtd itself might work too
since it functions on the other BSD's.  So, took a few minutes to try
it out.  Without QEMU installed, libvirtd doesn't error out like the
above.  That only happens when QEMU is around.  So, it's related to that
somehow. :)


> Does it happen every single start?

Yeah, completely reliable.

One other weirdness showed up too, probably not related though.  Without
QEMU installed, when starting up libvirtd with -l enabled (for listening),
it exists complaining about missing cert file.  That in itself is not
surprising... except it happens even when TLS is disabled is in libvirtd.conf.

According to the wiki, turning off listen_tls + turning on listen_tcp should
stop the need for cert files:

  http://wiki.libvirt.org/page/The_daemon_cannot_be_started

Does that sound like a bug too, or more like the wiki is out of date? :)

+ Justin


signature.asc
Description: Message signed with OpenPGP using GPGMail
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Libvirtd and OSX... with QEMU

[Justin Clift]

Heyas,

Interestingly on OSX, starting libvirtd (1.3.1) indicates it can see
the installed QEMU.  However, it crashes out shortly afterwards with
a weird error:

  2016-01-17 22:02:17.159+: 18446744073709551615: error : 
virEventPollRunOnce:648 : Unable to poll on file handles: Bad file descriptor

Does anyone know what that might be about, and/or how to capture more
meaningful info? :)

Regards and best wishes,

Justin Clift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Libvirtd and OSX... with QEMU

[Justin Clift]

On 17 Jan 2016, at 22:10, Justin Clift <jus...@postgresql.org> wrote:
> On 17 Jan 2016, at 22:04, Justin Clift <jus...@postgresql.org> wrote:
> 
>> Interestingly on OSX, starting libvirtd (1.3.1) indicates it can see
>> the installed QEMU.  However, it crashes out shortly afterwards with
>> a weird error:
>> 
>> 2016-01-17 22:02:17.159+: 18446744073709551615: error : 
>> virEventPollRunOnce:648 : Unable to poll on file handles: Bad file descriptor
>> 
>> Does anyone know what that might be about, and/or how to capture more
>> meaningful info? :)
> 
> 
> With debug level logging, although more verbose there's nothing that
> seems smoking-gun like.  Except maybe this?
> 
>  2016-01-17 22:07:51.008+: 18446744073709551615: debug : 
> virEventPollRunOnce:644 : Poll got error event 9
>  2016-01-17 22:07:51.008+: 18446744073709551615: error : 
> virEventPollRunOnce:648 : Unable to poll on file handles: Bad file descriptor
>  2016-01-17 22:07:51.008+: 18446744073709551615: debug : 
> virNetDaemonRun:703 : Loop iteration error, exiting
> 
> That's with sudo libvirtd -vl, with tls disabled, tcp enabled, and
> tcp auth set to none.
> 
> Can post the entire console log output somewhere if that would help, it's
> not stupidly long. :)

Debug log here, in case it's useful: :)

https://justinclift.fedorapeople.org/libvirt131/libvirtd131_osx_crash1.log

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Libvirtd and OSX... with QEMU

[Justin Clift]

On 17 Jan 2016, at 22:04, Justin Clift <jus...@postgresql.org> wrote:

> Interestingly on OSX, starting libvirtd (1.3.1) indicates it can see
> the installed QEMU.  However, it crashes out shortly afterwards with
> a weird error:
> 
>  2016-01-17 22:02:17.159+: 18446744073709551615: error : 
> virEventPollRunOnce:648 : Unable to poll on file handles: Bad file descriptor
> 
> Does anyone know what that might be about, and/or how to capture more
> meaningful info? :)


With debug level logging, although more verbose there's nothing that
seems smoking-gun like.  Except maybe this?

  2016-01-17 22:07:51.008+: 18446744073709551615: debug : 
virEventPollRunOnce:644 : Poll got error event 9
  2016-01-17 22:07:51.008+: 18446744073709551615: error : 
virEventPollRunOnce:648 : Unable to poll on file handles: Bad file descriptor
  2016-01-17 22:07:51.008+: 18446744073709551615: debug : 
virNetDaemonRun:703 : Loop iteration error, exiting

That's with sudo libvirtd -vl, with tls disabled, tcp enabled, and
tcp auth set to none.

Can post the entire console log output somewhere if that would help, it's
not stupidly long. :)

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Release of libvirt-1.3.1

[Justin Clift]

On 17 Jan 2016, at 03:00, Daniel Veillard  wrote:
>  As planned I just tagged the release in git and pushed signed tarball
> and rpms to the usual place:
> 
>  ftp://libvirt.org/libvirt/

It's in OSX Homebrew now too. :)

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] security: Do not restore kernel and initrd labels

[Justin Clift]

On 15 Jan 2016, at 10:31, Jiri Denemark  wrote:
> On Fri, Jan 15, 2016 at 10:23:03 +, Daniel P. Berrange wrote:
>> On Fri, Jan 15, 2016 at 11:11:18AM +0100, Jiri Denemark wrote:
>>> Kernel/initrd files are essentially read-only shareable images and thus
>>> should be handled in the same way. We already use the appropriate label
>>> for kernel/initrd files when starting a domain, but when a domain gets
>>> destroyed we would remove the labels which would make other running
>>> domains using the same files very unhappy.
>>> 
>>> https://bugzilla.redhat.com/show_bug.cgi?id=921135
>>> 
>>> Signed-off-by: Jiri Denemark 
>> 
>> ACK
> 
> Thanks, I pushed the patch.
> 
>> but I'm wondering if the nvram and dtb lines before & after would
>> potentially suffer the same problem
> 
> Yeah, I was wondering about that too, but I wasn't quite sure whether
> they are similar or not.

Could Rich's test be tweaked some way in order to find out?

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Release candidate 2 of libvirt-1.3.1

[Justin Clift]

On 15 Jan 2016, at 02:16, Roman Bogorodskiy  wrote:
> [trim libvirt-announce@]
> 
>  Daniel Veillard wrote:
> 
>>  Seems we don't have the fix for OSX/BSD in yet but I decided to
>> push the new release candidate out, signed tarball and rpms are at the
>> usual place, and it's tagged in git:
>> 
>>   ftp://libvirt.org/libvirt/
>> 
>> Seems to work for me but obviously more testing is better, I will also
>> wait for the OSX/BSD patch to make a final release, if it's commited by
>> this week-end I will push, otherwise this will have to wait Tuesday as
>> I will be travelling Monday.
>> 
>>  So try it more and let's get a BSD patch in,
> 
> Actually we do have this patch in now (bc451c4).
> 
> rc2 builds fine on my test OpenBSD install, I hope it does build on OS X
> also.
> 
> These platforms are still affected by the rpcgen issue though, but it
> only affects people trying to do development builds (i.e. from a git
> repo, not from a tarball).

Yep, rc2 is compiling fine on OSX now too.  Well, at least OSX 10.9.5
(my desktop).  Didn't bother trying other versions. ;)

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Quantifying libvirt errors in launching the libguestfs appliance

[Justin Clift]

On 2016-01-13 10:18, Richard W.M. Jones wrote:


I would be good if libvirt could routinely test the case of multiple
parallel launches of qemu:///session, since it still contains bugs
even after Cole's fixes.


Sounds like this testing script would be useful as a (weekly?) cronjob 
or similar. :)


+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Entering freeze for libvirt-1.3.1

[Justin Clift]

On 12 Jan 2016, at 03:05, Roman Bogorodskiy  wrote:

> Oops, it's my fault, I forgot to add the proper include for log
> protocol.
> 
> Could you please try the attached patch?
> 
> If you report it works I'll push it tomorrow as trivial if nobody has
> objections, it'd be good to have 1.3.1 working on OS X.

Still not quite there. ;)


Last 15 lines from /Users/jc/Library/Logs/Homebrew/libvirt/02.make:
  GEN  logging/log_protocol.h
  GEN  logging/log_daemon_dispatch_stubs.h
  GEN  libvirt_access.xml
  GEN  libvirt_access_qemu.xml
  GEN  libvirt_access.syms
  GEN  libvirt_access_qemu.syms
  GEN  libvirt_access_lxc.syms
unsigned hyper inode;

logging/log_protocol.x, line 28: expected ';'
cannot shutdown /usr/bin/rpcgen:  at ./rpc/genprotocol.pl line 139.
make[2]: *** [logging/log_protocol.h] Error 1
make[2]: *** Waiting for unfinished jobs
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2



+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Add missing virxdrdefs.h include to log_protocol

[Justin Clift]

On 12 Jan 2016, at 15:45, Roman Bogorodskiy  wrote:
>  Daniel P. Berrange wrote:
>> On Tue, Jan 12, 2016 at 06:16:17PM +0300, Roman Bogorodskiy wrote:
>>> Commit 2b6f6ad introduced the virxdrdefs.h header with
>>> common definitions to be included in the protocol files,
>>> but logging/log_protocol.x was missed, so add it there as well.
>>> 
>>> Hopefully this fixes build on OS X.
>>> ---
>>> src/logging/log_protocol.x | 1 +
>>> 1 file changed, 1 insertion(+)
>>> 
>>> diff --git a/src/logging/log_protocol.x b/src/logging/log_protocol.x
>>> index a07334f..b0ac31b 100644
>>> --- a/src/logging/log_protocol.x
>>> +++ b/src/logging/log_protocol.x
>>> @@ -2,6 +2,7 @@
>>>  */
>>> 
>>> %#include "internal.h"
>>> +%#include "virxdrdefs.h"
>>> 
>>> typedef opaque virLogManagerProtocolUUID[VIR_UUID_BUFLEN];
>>> 
>> 
>> ACK
> 
> Pushed, thanks!

Thanks Roman.  I'll be lazy and just wait for rc2 to be released,
then confirm it's all good then. :)

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Entering freeze for libvirt-1.3.1

[Justin Clift]

On 12 Jan 2016, at 01:32, Daniel Veillard <veill...@redhat.com> wrote:
>  As suggested this w.e., I just tagged the release candidate 1 in git
> and pushed signed tarball and rpms to the usual place:
> 
>   ftp://libvirt.org/libvirt/
> 
> This works fine with my limited testing, but obviously more people
> need to give it some trial especially on other platforms.
> The output from CentOS CI is mostly green which is a good sign
> with just libvirt-daemon-rpm and virt-manager-test in the red, someone
> probably need to have a look before we release.
> 
>  The rc2 should come in 2 days on Thursday, and unless there is
> some blocker I plan to push 1.3.1 over the week-end,

Weirdly, it fails on OSX with the same error:



  Last 15 lines from /Users/jc/Library/Logs/Homebrew/libvirt/02.make:
CCLD libvirt_driver_vbox.la
CCLD libvirt_driver_storage.la
  Undefined symbols for architecture x86_64:
"_xdr_uint64_t", referenced from:
_xdr_virLogManagerProtocolLogFilePosition in virtlogd-log_protocol.o
_xdr_virLogManagerProtocolDomainOpenLogFileRet in 
virtlogd-log_protocol.o
_xdr_virLogManagerProtocolDomainGetLogFilePositionRet in 
virtlogd-log_protocol.o
_xdr_virLogManagerProtocolDomainReadLogFileArgs in 
virtlogd-log_protocol.o
  ld: symbol(s) not found for architecture x86_64
  clang: error: linker command failed with exit code 1 (use -v to see 
invocation)
  make[3]: *** [virtlogd] Error 1
  make[3]: *** Waiting for unfinished jobs
  make[2]: *** [all] Error 2
  make[1]: *** [all-recursive] Error 1
  make: *** [all] Error 2



Was Roman's patch definitely pushed?

Regards and best wishes,

Justin Clift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

[Justin Clift]

Should this patch by itself be enough to fix the OSX compilation 
problem? :)


eg should I test it with just this?

+ Justin


On 2016-01-11 00:34, Roman Bogorodskiy wrote:

From: Jasper Lievisse Adriaanse 

Some of the protocol files already include handing of the missing int
types such as xdr_uint64_t, some don't. To fix it everywhere, move out
of the appropriate defines to the utils/virxdrdefs.h file and include
it where needed.

Signed-off-by: Roman Bogorodskiy 
---
 src/Makefile.am|  1 +
 src/admin/admin_protocol.x |  2 ++
 src/lxc/lxc_monitor_protocol.x | 19 +--
 src/remote/remote_protocol.x   | 20 +---
 src/rpc/virnetprotocol.x   | 20 +---
 src/util/virxdrdefs.h  | 43 
++

 6 files changed, 49 insertions(+), 56 deletions(-)
 create mode 100644 src/util/virxdrdefs.h

diff --git a/src/Makefile.am b/src/Makefile.am
index af22fc1..aa5ab69 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -171,6 +171,7 @@ UTIL_SOURCES =  
\
util/viruri.h util/viruri.c \
util/virutil.c util/virutil.h   \
util/viruuid.c util/viruuid.h   \
+   util/virxdrdefs.h   \
util/virxml.c util/virxml.h \
$(NULL)

diff --git a/src/admin/admin_protocol.x b/src/admin/admin_protocol.x
index 878983d..711201a 100644
--- a/src/admin/admin_protocol.x
+++ b/src/admin/admin_protocol.x
@@ -22,6 +22,8 @@
  * Author: Martin Kletzander 
  */

+%#include "virxdrdefs.h"
+
 /*- Data types. -*/

 /* Length of long, but not unbounded, strings.
diff --git a/src/lxc/lxc_monitor_protocol.x 
b/src/lxc/lxc_monitor_protocol.x

index 205d7c2..5e3d5d9 100644
--- a/src/lxc/lxc_monitor_protocol.x
+++ b/src/lxc/lxc_monitor_protocol.x
@@ -4,24 +4,7 @@
  * the libvirt_lxc helper program.
  */

-/* cygwin's xdr implementation defines xdr_u_int64_t instead of 
xdr_uint64_t

- * and lacks IXDR_PUT_INT32 and IXDR_GET_INT32
- */
-%#ifdef HAVE_XDR_U_INT64_T
-%# define xdr_uint64_t xdr_u_int64_t
-%#endif
-%#ifndef IXDR_PUT_INT32
-%# define IXDR_PUT_INT32 IXDR_PUT_LONG
-%#endif
-%#ifndef IXDR_GET_INT32
-%# define IXDR_GET_INT32 IXDR_GET_LONG
-%#endif
-%#ifndef IXDR_PUT_U_INT32
-%# define IXDR_PUT_U_INT32 IXDR_PUT_U_LONG
-%#endif
-%#ifndef IXDR_GET_U_INT32
-%# define IXDR_GET_U_INT32 IXDR_GET_U_LONG
-%#endif
+%#include "virxdrdefs.h"

 enum virLXCMonitorExitStatus {
 VIR_LXC_MONITOR_EXIT_STATUS_ERROR,
diff --git a/src/remote/remote_protocol.x 
b/src/remote/remote_protocol.x

index 80f4a8b..9f131f8 100644
--- a/src/remote/remote_protocol.x
+++ b/src/remote/remote_protocol.x
@@ -38,27 +38,9 @@

 %#include 
 %#include "internal.h"
+%#include "virxdrdefs.h"
 %#include 

-/* cygwin's xdr implementation defines xdr_u_int64_t instead of 
xdr_uint64_t

- * and lacks IXDR_PUT_INT32 and IXDR_GET_INT32
- */
-%#ifdef HAVE_XDR_U_INT64_T
-%# define xdr_uint64_t xdr_u_int64_t
-%#endif
-%#ifndef IXDR_PUT_INT32
-%# define IXDR_PUT_INT32 IXDR_PUT_LONG
-%#endif
-%#ifndef IXDR_GET_INT32
-%# define IXDR_GET_INT32 IXDR_GET_LONG
-%#endif
-%#ifndef IXDR_PUT_U_INT32
-%# define IXDR_PUT_U_INT32 IXDR_PUT_U_LONG
-%#endif
-%#ifndef IXDR_GET_U_INT32
-%# define IXDR_GET_U_INT32 IXDR_GET_U_LONG
-%#endif
-
 /*- Data types. -*/

 /* Length of long, but not unbounded, strings.
diff --git a/src/rpc/virnetprotocol.x b/src/rpc/virnetprotocol.x
index 7b6f753..327a334 100644
--- a/src/rpc/virnetprotocol.x
+++ b/src/rpc/virnetprotocol.x
@@ -21,27 +21,9 @@
  */

 %#include "internal.h"
+%#include "virxdrdefs.h"
 %#include 

-/* cygwin's xdr implementation defines xdr_u_int64_t instead of 
xdr_uint64_t

- * and lacks IXDR_PUT_INT32 and IXDR_GET_INT32
- */
-%#ifdef HAVE_XDR_U_INT64_T
-%# define xdr_uint64_t xdr_u_int64_t
-%#endif
-%#ifndef IXDR_PUT_INT32
-%# define IXDR_PUT_INT32 IXDR_PUT_LONG
-%#endif
-%#ifndef IXDR_GET_INT32
-%# define IXDR_GET_INT32 IXDR_GET_LONG
-%#endif
-%#ifndef IXDR_PUT_U_INT32
-%# define IXDR_PUT_U_INT32 IXDR_PUT_U_LONG
-%#endif
-%#ifndef IXDR_GET_U_INT32
-%# define IXDR_GET_U_INT32 IXDR_GET_U_LONG
-%#endif
-
 /*- Data types. -*/

 /* Initial message size.
diff --git a/src/util/virxdrdefs.h b/src/util/virxdrdefs.h
new file mode 100644
index 000..40074dd
--- /dev/null
+++ b/src/util/virxdrdefs.h
@@ -0,0 +1,43 @@
+/*
+ * virxdrdefs.h
+ *
+ * Copyright (C) 2016 Red Hat, Inc.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; 

Re: [libvirt] Libvirt 1.3.0 compilation failure on OSX 10.9.5

[Justin Clift]

On 8 Jan 2016, at 02:26, Roman Bogorodskiy  wrote:

> I'll prepare patches based on those from the OpenBSD libvirt port that
> address this problem and send them out for review soon, so, hopefully
> we'll get it fixed.

Thanks Roman.  When that's done, I'll be able to update the MacOS X
Libvirt port. :)

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Libvirt 1.3.0 compilation failure on OSX 10.9.5

[Justin Clift]

On 6 Jan 2016, at 18:03, Roman Bogorodskiy <bogorods...@gmail.com> wrote:
>  Roman Bogorodskiy wrote:
>>  Justin Clift wrote:
>>> Hiyas,
>>> 
>>> Just went to update the MacOS X Homebrew port/formula for
>>> Libvirt 1.3.0.  It's failing during compilation with:
>>> 
>>> ***
>>> 
>>>  Last 15 lines from /Users/jc/Library/Logs/Homebrew/libvirt/02.make:
>>>CCLD libvirt_driver_vbox.la
>>>CCLD libvirt_driver_storage.la
>>>  Undefined symbols for architecture x86_64:
>>>"_xdr_uint64_t", referenced from:
>>>_xdr_virLogManagerProtocolLogFilePosition in virtlogd-log_protocol.o
>>>_xdr_virLogManagerProtocolDomainOpenLogFileRet in 
>>> virtlogd-log_protocol.o
>>>_xdr_virLogManagerProtocolDomainGetLogFilePositionRet in 
>>> virtlogd-log_protocol.o
>>>_xdr_virLogManagerProtocolDomainReadLogFileArgs in 
>>> virtlogd-log_protocol.o
>>>  ld: symbol(s) not found for architecture x86_64
>>>  clang: error: linker command failed with exit code 1 (use -v to see 
>>> invocation)
>>>  make[3]: *** [virtlogd] Error 1
>>>  make[3]: *** Waiting for unfinished jobs
>>>  make[2]: *** [all] Error 2
>>>  make[1]: *** [all-recursive] Error 1
>>>  make: *** [all] Error 2
>>> 
>>> ***
>>> 
>>> Is this a known thing, or should I grab the rest of the failure logging for
>>> someone (not me) to look at? :)
>>> 
>> Hi Justin,
>> 
>> Could you check if this patche solves the problem for you:
>> 
>> http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/sysutils/libvirt/patches/patch-src_admin_admin_protocol_c?rev=1.2=text/x-cvsweb-markup
>> ?
> 
> Urgh, that's the wrong one. The right one is here:
> 
> http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/sysutils/libvirt/patches/patch-src_logging_log_protocol_c?rev=1.2=text/x-cvsweb-markup
> 
> But as they're identical, I'd assume you'll need the first one as well.

Interestingly, with just this one added in, libvirt now compiles fully and
installs fine.  Didn't need to touch admin_protocol.c at all.  Maybe that's
only conditionally compiled or something?

virsh seems to start up ok, but I didn't actually try doing anything with
it. ;)

Should we call this "good enough for now", or is there more to do? :)

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Libvirt 1.3.0 compilation failure on OSX 10.9.5

[Justin Clift]

Hiyas,

Just went to update the MacOS X Homebrew port/formula for
Libvirt 1.3.0.  It's failing during compilation with:

***

  Last 15 lines from /Users/jc/Library/Logs/Homebrew/libvirt/02.make:
CCLD libvirt_driver_vbox.la
CCLD libvirt_driver_storage.la
  Undefined symbols for architecture x86_64:
"_xdr_uint64_t", referenced from:
_xdr_virLogManagerProtocolLogFilePosition in virtlogd-log_protocol.o
_xdr_virLogManagerProtocolDomainOpenLogFileRet in 
virtlogd-log_protocol.o
_xdr_virLogManagerProtocolDomainGetLogFilePositionRet in 
virtlogd-log_protocol.o
_xdr_virLogManagerProtocolDomainReadLogFileArgs in 
virtlogd-log_protocol.o
  ld: symbol(s) not found for architecture x86_64
  clang: error: linker command failed with exit code 1 (use -v to see 
invocation)
  make[3]: *** [virtlogd] Error 1
  make[3]: *** Waiting for unfinished jobs
  make[2]: *** [all] Error 2
  make[1]: *** [all-recursive] Error 1
  make: *** [all] Error 2

***

Is this a known thing, or should I grab the rest of the failure logging for
someone (not me) to look at? :)

+ Justin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Fix minor typo in governance doc

[Justin Clift]

---
 docs/governance.html.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/governance.html.in b/docs/governance.html.in
index e649f08..2f04281 100644
--- a/docs/governance.html.in
+++ b/docs/governance.html.in
@@ -24,7 +24,7 @@
   project community taken as a whole, all members (whether users,
   contributors or committers) are expected to abide by the project's
   code of conduct. At a high level the code can be summarized as
-  embe excellant to each other/em. Expanding on this:
+  embe excellent to each other/em. Expanding on this:
 /p
 
 ul
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-1.1.3

[Justin Clift]

On 26/09/2013, at 7:16 PM, Doug Goldstein wrote:
 On Thu, Sep 26, 2013 at 1:13 PM, Doug Goldstein car...@gentoo.org wrote:
snip
 This was the error I brought up on the ML with the 1.1.2 release. I
 still haven't had a chance to get to the bottom of it. The issue stems
 from the fact that we're getting back bad socket credentials. I've
 submitted a patch to catch this case that needs review:
 
 I should also note that my patchset doesn't fix the whole issue. We
 are always failing when we look up the socket info on Mac OS X (we
 have for a really really really long time). But at least we detect the
 error instead of silently ignoring it and trying to look up bad data.

Cool.  At least it's a known thing then, not a new one.  I'll leave
this to you guys to sort out, as it's been *ages* since my head has
been in libvirt development mode. ;)

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-1.1.3

[Justin Clift]

On 26/09/2013, at 6:30 AM, Daniel Veillard wrote:
snip
 I will probably make rc2 during the w.e. and depending on news push on
 Tuesday next week or a bit later the final 1.1.3


Compiles ok on MacOS 10.7.  virsh starts ok too.

One weirdness noted from inside virsh (not connected to a
hypervisor):

  virsh # version
  error: failed to connect to the hypervisor
  error: no valid connection
  error: Failed to find user record for uid '32766'

Not sure what the 32766 comes from, since that's not the id of
my user:

  uid=501(jc) gid=20(staff) groups=20(staff)

Doesn't seem like a blocker though.

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-1.1.3

[Justin Clift]

On 26/09/2013, at 10:05 AM, Michal Privoznik wrote:
 On 26.09.2013 10:59, Justin Clift wrote:
 On 26/09/2013, at 6:30 AM, Daniel Veillard wrote:
 snip
 I will probably make rc2 during the w.e. and depending on news push on
 Tuesday next week or a bit later the final 1.1.3
 
 Compiles ok on MacOS 10.7.  virsh starts ok too.
 
 One weirdness noted from inside virsh (not connected to a
 hypervisor):
 
  virsh # version
  error: failed to connect to the hypervisor
  error: no valid connection
  error: Failed to find user record for uid '32766'
 
 Not sure what the 32766 comes from, since that's not the id of
 my user:
 
 Isn't it a PID of the virsh process? I think we fail to get identity for
 the virsh process and mislead users by wrong error message.

Doesn't seem like it.  Just started virsh again, but the pid of that
process doesn't match the # given this time (which did change though).

Terminal window 1:

  virsh # version
  error: failed to connect to the hypervisor
  error: no valid connection
  error: Failed to find user record for uid '32706'

Terminal window 2: (virsh still open in #1)

  $ ps -ef|grep -i virsh
501 35262 35252   0 10:38am ttys0000:00.03 virsh
  $ ps -ef|grep -i 32706
  $

Not seeing anything in the 327xx range, and new pid's
are (atm) in the 353xx range.

Not sure where it's picking up the uid value from, and haven't
really tried tracing it.  I wonder if it's just an OSX thing, or
if maybe *BSD is showing something similar...

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Availability of release candidate 2 of libvirt 1.1.2

[Justin Clift]

On 31/08/2013, at 3:34 PM, Daniel Veillard wrote:
 Oops I pushed on friday but forgot to finish sending the message !
 
  Thanks everybody for the feedback, I have now pushed rc2 to
 the usual place as tarball and rpms:
 
   ftp://libvirt.org/libvirt/
 
 and of course tagged it in git.
 Hopefully it will include the security fixes discussed earlier
 
 Works fine for my simple testing,

This one seems fine for simple compile testing on OSX 10.7
too. :)

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Entering freeze for libvirt-1.1.2

[Justin Clift]

On 29/08/2013, at 6:13 PM, Eric Blake wrote:
 [dropping libvirt-announce - aren't we setting reply-to on our
 announcements, so that replies are directed only to side lists?]

Not so far.  I'm neither for-nor-against doing so, so feel to
change if it needed. :)


 On 08/28/2013 11:31 AM, Doug Goldstein wrote:
 
 master presently fails on Mac OS X with the following:
 
 Making all in src
  GEN  locking/lock_daemon_dispatch_stubs.h
  GEN  lxc/lxc_monitor_protocol.c
unsigned hyper initpid;
 ^^
 lxc/lxc_monitor_protocol.x, line 18: expected ';'
 cannot shutdown /usr/bin/rpcgen:  at ./rpc/genprotocol.pl line 136.
 make[2]: *** [lxc/lxc_monitor_protocol.c] Error 1

For an OSX 10.8 VM here, it's working with Homebrew.

To make it work, I:

* downloaded the libvirt-1.1.2-rc1.tar.gz tarball to the Homebrew cache 
directory
* renamed it to libvirt-1.1.2.tar.gz
* Updated the Homebrew libvirt.rb file to look for libvirt-1.1.2.tar.gz
  instead of libvirt-1.1.1.tar.gz
 (and updated the sha256sum to match)

At that point, brew install libvirt works with the new
tarball.

So, definitely not a comprehensive test... but it does make
it past general compilation.

Doug, how are you compiling?

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-1.1.2

[Justin Clift]

On 28/08/2013, at 5:25 PM, Daniel Veillard wrote:
  I am a day late but I finally tagged the release candidate 1
 of 1.1.2 in git and push the tarball and rpms to the usual place:
 
  ftp://libvirt.org/libvirt/
 
 so the plan is to have an rc2 candidate on friday and if everything
 looks good push the final release 1.1.2 on Monday.
 
  Please give it a try especially for potential portability issues,

Passes a compile test on OSX 10.7. ;)

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release candidate 2 of libvirt-1.1.1

[Justin Clift]

On 29/07/2013, at 7:17 AM, Daniel Veillard wrote:
 On Wed, Jul 24, 2013 at 12:11:52PM +0800, Daniel Veillard wrote:
 As planned I tagged the release candidate 1 for libvirt 1.1.1 in git,
 I also made tarball and rpms available on the ftp:
 
  ftp://libvirt.org/libvirt/
 
  I just tagged rc2, it is available in git an at the above repository
 in both tarball and rpms forms.
 
  Still seems to work for me in my usual tests :-)
 I will probably push the final version tomorrow !

Seems ok on OSX 10.7.  Didn't try rc1, and haven't tried OSX 10.8, so
I'm just kind of assuming. ;)

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Candidate release 2 for libvirt-1.1.0

[Justin Clift]

On 27/06/2013, at 5:01 PM, Daniel Veillard wrote:
   I have just tagged the release candidate 2 in git and sent a tarball
 to the usual place (rpms are coming):
   ftp://libvirt.org/libvirt/

Sorry for the delay, only just now remembered to test this. :)

Compilation is failing on OSX 10.7 x64 with:

**
  CC libvirt_util_la-virnetdevveth.lo
  CC libvirt_util_la-virnetdevvlan.lo
  CC libvirt_util_la-virnetdevvportprofile.lo
  CC libvirt_util_la-virnetlink.lo
  CC libvirt_util_la-virnodesuspend.lo
  CC libvirt_util_la-virnuma.lo
util/virnetdevtap.c:315:26: error: use of undeclared identifier 'IF_MAXUNIT'
for (i = 0; i = IF_MAXUNIT; i++) {
 ^
1 error generated.
make[3]: *** [libvirt_util_la-virnetdevtap.lo] Error 1
make[3]: *** Waiting for unfinished jobs
[all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
**

There doesn't seem to be a definition for IF_MAXUNIT on OSX (10.7
anyway):

  $ grep -ri IF_MAXUNIT /usr/include/
  $

Interestingly, it's also not on a RHEL 6.4 box locally here
either:

  $ grep -ri IF_MAXUNIT /usr/include/
  $

Though, it's possible that box is missing required devel packages
for libvirt. (unsure)

Googling shows IF_MAXUNIT in context of FreeBSD stuff.  Not sure
of the right approach here.  eg exclude compiling this on OSX,
or alternatively make-it-work on OSX.

Hope that helps. :)

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Candidate release 2 for libvirt-1.1.0

[Justin Clift]

On 28/06/2013, at 3:05 PM, Daniel P. Berrange wrote:
 On Fri, Jun 28, 2013 at 03:01:58PM +0100, Justin Clift wrote:
snip
 Googling shows IF_MAXUNIT in context of FreeBSD stuff.  Not sure
 of the right approach here.  eg exclude compiling this on OSX,
 or alternatively make-it-work on OSX.
 
 Yes, this is from code that is only designed to work on FreeBSD. I
 guess the OS-X BSD base isn't close enough to support this properly.
 
 Try this patch
 
 diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
 index 265676c..4e2f32a 100644
 --- a/src/util/virnetdevtap.c
 +++ b/src/util/virnetdevtap.c
 @@ -275,7 +275,7 @@ cleanup:
 VIR_FORCE_CLOSE(fd);
 return ret;
 }
 -#elif defined(SIOCIFCREATE2)  defined(SIOCIFDESTROY)
 +#elif defined(SIOCIFCREATE2)  defined(SIOCIFDESTROY)  defined(IF_MAXUNIT)
 int virNetDevTapCreate(char **ifname,
int *tapfd,
int tapfdSize,


Thanks Dan, that works well.  Libvirt is now compiling, and virsh
seems to be working happily (with a minimal amount of testing
anyway). :)

Regards and best wishes,

Justin Clift

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Candidate release 2 for libvirt-1.0.6

[Justin Clift]

On 30/05/2013, at 10:57 AM, Daniel Veillard wrote:
  I have just tagged and pushed to FTP the second candidate release for
 libvirt-1.0.6, available at:
ftp://libvirt.org/libvirt/
 
  So far feedback on rc1 has been positive, and my own small testing of
 rc2 is okay too. So it seems there should be no problem for the final
 1.0.6 release on Monday,
 
  thanks in advance to any testing given to rc2 !


Compiles ok on OSX 10.7.  Haven't done _any_ real testing of it though.

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-1.0.6

[Justin Clift]

On 27/05/2013, at 11:44 PM, Daniel Veillard wrote:
  As planned, I just tagged the rc1 release in git and pushed
 tarball and rpms to the FTP repository:
  ftp://libvirt.org/
 
 So focuse should be given to bug fixes this week, and if everything
 goes well I will make the release on Monday 3, a week from now.
 I gave a bit of testing to the rc1 rpms, seems to work okay for KVM on
 Fedora but further testing would  be a good idea, on other
 distro/platforms and also other hypervisor, especially with VirtualBox
 as the driver was mdified to now rely on the daemon for support of
 that hypervisor.


Seems to compile fine on OSX.  Haven't tried to run it.

Sounds like VirtualBox won't work on OSX any more, as the libvirt
daemon doesn't compile there (last I heard).  It's possibly that's
changed am I'm just wrong though. ;)

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-1.0.5

[Justin Clift]

On 02/05/2013, at 11:39 AM, Daniel Veillard wrote:
  I forgot to make the rc2 release on tuesday, but looking at the
 git state it was looking like the problem reported on rc1 had been
 fixed, so I decided to go ahead and roll the release as scheduled
 today. It is tagged in git and the tarball is available as usual at:
 
  ftp://libvirt.org/libvirt/


Now in OSX Homebrew too.

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-1.0.5

[Justin Clift]

On 26/04/2013, at 9:09 AM, Daniel Veillard wrote:
  So as discussed earlier this week, I have tagged the release candidate 1
 of libvirt-1.0.5 in git and pushed the tarball and associated rpms to
 the FTP at:
   ftp://libvirt.org/libvirt/

Compiles ok on OSX.  Haven't tried anything in more depth with it.

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-1.0.4

[Justin Clift]

On 01/04/2013, at 11:02 AM, Ruben Kerkhof wrote:
snip
 Works on 10.8 as well.
 
 [ruben@odin ~]$ brew install libvirt
 == Installing libvirt dependency: cmake
 
 Huh, I know it's April 1st, but did we just switch away from autotools? ;-)
 
 Unrelated, but Justin, I noticed that your homebrew formula builds libvirt 
 --without-qemu,
 qemu is in homebrew too, and works reasonably well on OSX. I'd love to try it 
 with libvirt.

That's good news. :)

I'd really like to hear how it goes with libvirt.  If you edit
the libvirt formula so that --without-qemu is --with-qemu:

  /usr/local/Library/Formula/libvirt.rb

Then install it again (after brew install qemu), it *might*
just work.  Hopefully. :)

Maybe a 30% success chance, but worth a shot?

If it does work, then updating the formula for everyone is fairly
trivial.  If it doesn't... well, lets see if it comes to that.

Ok to give it a shot?

:)

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-1.0.4

[Justin Clift]

On 01/04/2013, at 6:42 PM, Ruben Kerkhof wrote:
snip
 Hey Justin, 
 
 Just tried that, but it has no effect, probably due to:
 
 if test $with_osx = yes; then
with_qemu=no
 fi
 
 in configure.ac
 
 I tried to build the latest libvirt HEAD from source, but I'm bumping into an 
 (unrelated) failure:
 
 Making all in src
   GEN  lxc/lxc_monitor_dispatch.h
   GEN  lxc/lxc_controller_dispatch.h
   GEN  remote/remote_protocol.h
 unsigned hyper cpu_time;
 ^^^
 remote/remote_protocol.x, line 338: expected ';'
 cannot shutdown /usr/bin/rpcgen:  at ./rpc/genprotocol.pl line 124.
 make[2]: *** [remote/remote_protocol.h] Error 1
 make[1]: *** [all-recursive] Error 1
 make: *** [all] Error 2

Ouch.  It looks like something is causing the LXC building code to
be run, even on OSX where there's no chance it would work. :(

For good measure, I just tried it with the 1.0.4 tarball and had
the same problem (when enabling qemu after modifying configure).

Someone (not me) would have to investigate why the LXC stuff is
trying to compile.  It's probably just something in the configure.ac
or maybe some ifdef statements needed in the right places in the
code. (no idea)

Don't suppose that's your kind of thing? :)

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Candidate release 2 of libvirt-1.0.4 available

[Justin Clift]

On 28/03/2013, at 3:08 AM, Daniel Veillard wrote:
  I tagged it in git and pushed the tarball to the usual area:
 
  ftp://libvirt.org/libvirt/
 
 the rpms are being pushed ATM.
 Based on my own limited testing this still looks like good to go,
 but more feedback (portability ?) would be nice.
 If all goes well this will go out very early on Monday as scheduled,
 
   thanks !


Tried this on OSX 10.7.5, with Osier's build breaker patch added, and
compilation succeeds.

No vm's handy at the moment to try it out against though. :/

Hope that helps at least a bit. :)

Regards and best wishes,

Justin Clift

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-1.0.4

[Justin Clift]

On 01/04/2013, at 5:10 AM, Daniel Veillard wrote:
  As planned I tagged the release in git and pushed the new version
 to the usual place as tarball and rpms:
   ftp://libvirt.org/libvirt/
 
  I hesited a bit in pushing the patchset from Peter fixing the
 memory corruption bug, but since it seems hard to reproduce and
 the amount of change was a bit too large to push just before a
 release, I prefered delaying it until after 1.0.4 .
  This release is a bit smaller than usual at around 200 patches
 but that's not surprizing considering the shrter timeframe since
 1.0.3. This includes an homogenous set of features, improvements
 and bug fixes, plus updates for localization of ukrainian (100%),
 japanese (100%), French (12%) and Gujarati (78%)


Libvirt 1.0.4 is now in Homebrew too.

  $ brew install libvirt

(how's that for quick turnaround? :)

Regards and best wishes,

Justin Clift

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release candidate 2 of 1.0.3 is available

[Justin Clift]

On 27/02/2013, at 11:20 AM, Daniel Veillard wrote:
   I have just tagged git and pushed the tarball. The rpms for F17
 are at the usual place too:
 ftp://libvirt.org/libvirt/
 
   I gave a try to the set of rpms and this seems to work fine for
 relatively simple tests.
   Please give it more testing and let's keep change to git to
 bug fixes to minimize risks for 1.0.3.
 If everything goes well I will push 1.0.3 on Friday,


Seems to compile ok on OSX 10.7, and some basic virsh stuff is
also working.  Not tested in any depth though. ;

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Candidate Release 2 of libvirt-1.0.2

[Justin Clift]

On 28/01/2013, at 12:22 PM, Daniel Veillard wrote:
  I have just tagged the rc2 in git and pushed the associated tarball
 and rpms for F17 to the FTP area:
ftp://libvirt.org/libvirt/

This seems ok on OSX 10.7 too. :)

+ Justin

--
Aeolus Cloud Evangelist
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-1.0.2

[Justin Clift]

On 24/01/2013, at 4:53 PM, Daniel Veillard wrote:
  As scheduled and to gte a release by the end of the month next
 week, I have just tagged a release candidate 1 version in git and
 pushed associated tarballs and rpms to the usual place:
   ftp://libvirt.org/libvirt/
 
 please give it a try and let's ocuse on fixing bugs untl the freeze
 end. I will probably make a release candidate 2 on Monday, and if
 everything goes well rol out the 1.0.2 release on Wednesday or Thursday.

Seems ok on OSX 10.7.

+ Justin

--
Aeolus Cloud Evangelist
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release candidate 2 of libvirt-1.0.1

[Justin Clift]

On 14/12/2012, at 3:14 PM, Daniel Veillard wrote:
 
  Okay rc2 is tagged in git and I made tarball and rpms available at
 ftp://libvirt.org/libvirt/
 
 this should fix the portability problem reported by Justin and
 hopefully we can push the final release on Monday, if there is no
 big problems reported with  rc2,

Compiles ok on OSX.  Seems to work ok too.

+ Justin

--
Aeolus Cloud Evangelist
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-1.0.1

[Justin Clift]

On 12/12/2012, at 3:55 AM, Daniel Veillard wrote:
  As planned I have just tagged the tree and pushed a release candidate
 1 tarball and assorted rpms to
  ftp://libvirt.org/libvirt/
 
  If everything goes well, I will push an rc2 on Friday incorporating
 the various fixes found in the meantime and plan to push the final
 release early Monday 17.
 
  Give it a try, report problems you may hit,

This is barfing on OSX Lion (10.7.5) with:


  CC libvirt_util_la-virkeycode.lo
  CC libvirt_util_la-virkeyfile.lo
util/virinitctl.c:104:1: error: bit-field '_gl_verify_error_if_negative' has 
negative width (-1)
verify(sizeof(struct virInitctlRequest) == 384);
^
../gnulib/lib/verify.h:241:20: note: expanded from macro 'verify'
# define verify(R) _GL_VERIFY (R, verify ( #R ))
   ^
../gnulib/lib/verify.h:201:9: note: expanded from macro '_GL_VERIFY'
   [_GL_VERIFY_TRUE (R, DIAGNOSTIC)]
^
../gnulib/lib/verify.h:166:16: note: expanded from macro '_GL_VERIFY_TRUE'
(!!sizeof (_GL_VERIFY_TYPE (R, DIAGNOSTIC)))
   ^
../gnulib/lib/verify.h:186:28: note: expanded from macro '_GL_VERIFY_TYPE'
 struct { unsigned int _gl_verify_error_if_negative: (R) ? 1 : -1; }
   ^
1 error generated.
make[3]: *** [libvirt_util_la-virinitctl.lo] Error 1
make[3]: *** Waiting for unfinished jobs




Using:



$ cc --version
Apple clang version 4.1 (tags/Apple/clang-421.11.66) (based on LLVM 3.1svn)
Target: x86_64-apple-darwin11.4.2
Thread model: posix



The 1.0.0 release of Libvirt compiles ok, so this is
definitely something new.

Anyone have ideas? :)

+ Justin


thanks !
 
 Daniel
 
 -- 
 Daniel Veillard  | Open Source and Standards, Red Hat
 veill...@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
 http://veillard.com/ | virtualization library  http://libvirt.org/
 
 ___
 Libvirt-announce mailing list
 libvirt-annou...@redhat.com
 https://www.redhat.com/mailman/listinfo/libvirt-announce

--
Aeolus Cloud Evangelist
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-1.0.1

[Justin Clift]

On 12/12/2012, at 7:50 PM, Eric Blake wrote:
 [dropping libvirt-announce]
 
 On 12/12/2012 11:44 AM, Justin Clift wrote:
 On 12/12/2012, at 3:55 AM, Daniel Veillard wrote:
 As planned I have just tagged the tree and pushed a release candidate
 1 tarball and assorted rpms to
 ftp://libvirt.org/libvirt/
 
 If everything goes well, I will push an rc2 on Friday incorporating
 the various fixes found in the meantime and plan to push the final
 release early Monday 17.
 
 Give it a try, report problems you may hit,
 
 This is barfing on OSX Lion (10.7.5) with:
 
 
  CC libvirt_util_la-virkeycode.lo
  CC libvirt_util_la-virkeyfile.lo
 util/virinitctl.c:104:1: error: bit-field '_gl_verify_error_if_negative' has 
 negative width (-1)
 verify(sizeof(struct virInitctlRequest) == 384);
 ^
 
 
 The 1.0.0 release of Libvirt compiles ok, so this is
 definitely something new.
 
 Anyone have ideas? :)
 
 Yes, and it should be fixed once Roman's patches go in:
 https://www.redhat.com/archives/libvir-list/2012-December/msg00697.html


Excellent. :)

Just took a look at those patches, and I'm kind of wondering if they
might be a lead in for libvirt to work with QEMU on OSX.

_Apparently_ QEMU does work in some fashion, though I've never
actually tried it.  Might give it a shot in a bit, see what happens.

One can hope. ;

+ Justin

--
Aeolus Cloud Evangelist
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Availability of Release Candidate 2 for 1.0.0

[Justin Clift]

On 29/10/2012, at 2:19 PM, Daniel Veillard wrote:
  The tree is now tagged (v1.0.0-rc2) and the tarball (and rpms) are
 available at the usual place:

Also works in OSX (using Xcode 4.1).

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-1.0.0 release

[Justin Clift]

On 24/10/2012, at 3:14 PM, Daniel Veillard wrote:
  As scheduled, we are entering freeze for 1.0.0, yay !
 I have tagged the git tree and pushed libvirt-1.0.0-rc1.tar.gz release
 candidate 1 to the ftp (along with rpms):
  ftp://libvirt.org/libvirt/
 
 Due to the slightly higher visibility of this release, we are giving
 a bit more time for testing of the candidates, and the plan is to push
 the final version at the end of next week, so expect an rc2 at the end
 of the week and probably an rc3 by mid next week.

Looks good on OSX 10.7. :)

+ Justin


 Give it a try and report,
 
  thanks !
 
 Daniel
 
 -- 
 Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
 dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
 http://veillard.com/ | virtualization library  http://libvirt.org/
 
 ___
 Libvirt-announce mailing list
 libvirt-annou...@redhat.com
 https://www.redhat.com/mailman/listinfo/libvirt-announce

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Need new maintainer for libvirt on MacPorts

[Justin Clift]

Hi all,

Is anyone up for being the new owner/maintainer for libvirt
on OSX MacPorts?

The MacPorts guys have pinged us, suggesting we update the
libvirt port there to something recent:

  https://trac.macports.org/ticket/36691

I'm still very engaged on the Homebrew side, but have next
to no interest in MacPorts so am looking to pass it on. :)

?

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] ANNOUNCE: libvirt 0.9.11.6 maintenance release

[Justin Clift]

On 10/10/2012, at 2:54 AM, Eric Blake wrote:
 On 10/08/2012 06:49 AM, Justin Clift wrote:
 On 08/10/2012, at 10:52 AM, Cole Robinson wrote:
 libvirt 0.9.11.6 maintenance release is now available. This is
 libvirt 0.9.11 with additional bugfixes that have accumulated
 upstream since the initial release.
 
 This release can be downloaded at:
 
 http://libvirt.org/sources/stable_updates/libvirt-0.9.11.6.tar.gz
 
 Compiling this one also fails on OSX:
 
CC   libvirt_util_la-virnetdev.lo
CC   libvirt_util_la-virnetdevbandwidth.lo
  util/virnetdev.c:932: error: expected ';', ',' or ')' before 'macaddr'
  util/virnetdev.c:1666: error: expected ';', ',' or ')' before 'macaddress'
CC   libvirt_util_la-virnetdevbridge.lo
  make[3]: *** [libvirt_util_la-virnetdev.lo] Error 1
  make[3]: *** Waiting for unfinished jobs
  make[2]: *** [all] Error 2
  make[1]: *** [all-recursive] Error 1
  make: *** [all] Error 2
 
 Hoping it's just a missing patch that also needs pulling across?
 
 On the contrary, it is actually one too many patches pulled across.
 This should fix your build, now pushed to v0.9.11-maint:

Thanks Eric, that got it going. :)

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] ANNOUNCE: libvirt 0.9.11.6 maintenance release

[Justin Clift]

On 08/10/2012, at 10:52 AM, Cole Robinson wrote:
 libvirt 0.9.11.6 maintenance release is now available. This is
 libvirt 0.9.11 with additional bugfixes that have accumulated
 upstream since the initial release.
 
 This release can be downloaded at:
 
 http://libvirt.org/sources/stable_updates/libvirt-0.9.11.6.tar.gz

Compiling this one also fails on OSX:

CC   libvirt_util_la-virnetdev.lo
CC   libvirt_util_la-virnetdevbandwidth.lo
  util/virnetdev.c:932: error: expected ';', ',' or ')' before 'macaddr'
  util/virnetdev.c:1666: error: expected ';', ',' or ')' before 'macaddress'
CC   libvirt_util_la-virnetdevbridge.lo
  make[3]: *** [libvirt_util_la-virnetdev.lo] Error 1
  make[3]: *** Waiting for unfinished jobs
  make[2]: *** [all] Error 2
  make[1]: *** [all-recursive] Error 1
  make: *** [all] Error 2

Hoping it's just a missing patch that also needs pulling across?

+ Justin

 Changes in this version:
 
 * remove dnsmasq command line parameter --filterwin2k
 * dnsmasq: avoid forwarding queries without a domain
 * security: Fix libvirtd crash possibility
 
 For info about past maintenance releases, see:
 
 http://wiki.libvirt.org/page/Maintenance_Releases
 
 Thanks,
 Cole
 
 ___
 Libvirt-announce mailing list
 libvirt-annou...@redhat.com
 https://www.redhat.com/mailman/listinfo/libvirt-announce

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release candidate 2 of 0.10.2 is available

[Justin Clift]

On 21/09/2012, at 3:24 PM, Daniel Veillard wrote:
  I have just tagged the release candidate 2 version and provided
 tarball and rpms at ftp://libvirt.org/libvirt/
 
  So far testing on rc1 is rather good, plus we fixed a number of
 small problems since them, so I'm rather positive about it, and
 unless there is last minute troubles I may push the release early
 on monday,
 
   as usual, feedback welcome :-) thanks everybody !


Looks good on OSX. :)

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for 0.10.2

[Justin Clift]

On 18/09/2012, at 9:25 PM, Daniel Veillard wrote:
  I have just tagged the release candidate 1 version and provided
 tarball and rpms at ftp://libvirt.org/libvirt/
 
  so we have now entered freeze, I hope we didn't forgot any feature
 except Dan's work for a locking daemon. maybe we can try to push that
 one for rc2 possibly Thursday or Friday. Then hopefully we can release
 next Monday or Tuesday.
 
  Give it a try, let's chase bugs :-) !


Seems ok on OSX.

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.10.1

[Justin Clift]

On 31/08/2012, at 10:49 PM, Daniel Veillard wrote:
  As promised there is a fixup release since 0.10.0 is catastrophic,
 and I should probably wear a brown paper bag ...


libvirt 0.10.1 is now in OSX Homebrew too.

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2

[Justin Clift]

On 28/08/2012, at 6:05 PM, Daniel Veillard wrote:
snip
 I would suggest a fix along those lines:
 
 Daniel
 
 diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
 index 19dd26b..352d4fe 100644
 --- a/daemon/libvirtd.c
 +++ b/daemon/libvirtd.c
 @@ -1312,17 +1312,21 @@ int main(int argc, char **argv) {
 goto cleanup;
 }
 
 +#if defined(__linux__)  defined(NETLINK_ROUTE)
 /* Register the netlink event service for NETLINK_ROUTE */
 if (virNetlinkEventServiceStart(NETLINK_ROUTE, 0)  0) {
 ret = VIR_DAEMON_ERR_NETWORK;
 goto cleanup;
 }
 +#endif
 
 +#if defined(__linux__)  defined(NETLINK_KOBJECT_UEVENT)
 /* Register the netlink event service for NETLINK_KOBJECT_UEVENT */
 if (virNetlinkEventServiceStart(NETLINK_KOBJECT_UEVENT, 1)  0) {
 ret = VIR_DAEMON_ERR_NETWORK;
 goto cleanup;
 }
 +#endif
 
 /* Run event loop. */
 virNetServerRun(srv);

Just tested this to be absolutely sure, and it definitely works too.
ie. as alternative approach to Doug's patch.

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2

[Justin Clift]

On 27/08/2012, at 1:00 PM, Daniel Veillard wrote:
  I tagged the rc2 in the git tree and pushed tarball and rpms to
 the usual place:
  ftp://libvirt.org/libvirt/
 
 it should include the various fixes that were made on top of rc1
 and fix the compilation problem exposed on OS-X, as well as picking
 libnl3 if available,
 
  please give it a try and report, I am still shooting for a final
 release this Wednesday,

Still a no go on OSX.  Different error this time:

  ...
  libvirtd.c: In function 'main':
  libvirtd.c:1316: error: 'NETLINK_ROUTE' undeclared (first use in this 
function)
  libvirtd.c:1316: error: (Each undeclared identifier is reported only once
  libvirtd.c:1316: error: for each function it appears in.)
  libvirtd.c:1322: error: 'NETLINK_KOBJECT_UEVENT' undeclared (first use in 
this function)
  make[3]: *** [libvirtd-libvirtd.o] Error 1
  make[3]: *** Waiting for unfinished jobs

Any ideas?

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2

[Justin Clift]

On 28/08/2012, at 2:32 AM, Doug Goldstein wrote:
snip
 You can try something like the following to get you a little farther
 and see if it fails farther on. Just trying to see if we can get Mac
 OS X built and see what changes need to happen before 0.10.0 goes out
 final, not necessary proper patches just yet.
 
 diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h
 index 1982dae..c3f3e81 100644
 --- a/src/util/virnetlink.h
 +++ b/src/util/virnetlink.h
 @@ -34,6 +34,9 @@ struct nl_msg;
 struct sockaddr_nl;
 struct nlattr;
 
 +#define NETLINK_ROUTE   0   /* Routing/device hook  */
 +#define NETLINK_KOBJECT_UEVENT  15  /* Kernel messages to userspace */
 +
 # endif /* __linux__ */
 
 int virNetlinkStartup(void);

Thanks Dough.  This worked, and seems to be the last of
the problems.  The whole compile worked after this. :)

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] ANNOUNCE: libvirt 0.9.11.5 maintenance release

[Justin Clift]

On 14/08/2012, at 8:37 AM, Cole Robinson wrote:
 libvirt 0.9.11.5 maintenance release is now available. This is
 libvirt 0.9.11 with additional bugfixes that have accumulated
 upstream since the initial release.
 
 This release can be downloaded at:
 
 http://libvirt.org/sources/stable_updates/libvirt-0.9.11.5.tar.gz

Just tried this on OSX too.

Compilation fails with:

  ...
CC   libvirt_util_la-virnetdevbandwidth.lo
CC   libvirt_util_la-virnetdevbridge.lo
CC   libvirt_util_la-virnetdevmacvlan.lo
  util/virnetdev.c:932: error: expected ';', ',' or ')' before 'macaddr'
  util/virnetdev.c:1666: error: expected ';', ',' or ')' before 'macaddress'
  make[3]: *** [libvirt_util_la-virnetdev.lo] Error 1

Maybe we should do rc's for the maintenance releases as well?

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-0.10.0

[Justin Clift]

On 22/08/2012, at 9:51 PM, Daniel Veillard wrote:
  As planned, I just tagged 0.10.0 release candidate 1 in git and
 pushed a tarball and rpms to the usual place:
   ftp://libvirt.org/libvirt/
 
 I gave it a try locally and things seems to work as expected, but
 that's far from an extensive testing :-)
 
  So please try it, try to compile it on various platforms and
 send feedback to the list.

Compilation is failing on OSX 10.7:

  ...
CC libvirt_util_la-viruri.lo
CC libvirt_conf_la-netdev_bandwidth_conf.lo
  util/virnetlink.c:819: error: conflicting types for 'virNetlinkEventAddClient'
  util/virnetlink.h:82: error: previous declaration of 
'virNetlinkEventAddClient' was here
  util/virnetlink.c: In function 'virNetlinkEventAddClient':
  util/virnetlink.c:819: error: expected ',' or ';' before ')' token
  util/virnetlink.c:830: error: expected '=', ',', ';', 'asm' or 
'__attribute__' before 'unsigned'
  util/virnetlink.c:834: error: old-style parameter declarations in prototyped 
function definition
  util/virnetlink.c:834: error: expected '{' at end of input
  make[3]: *** [libvirt_util_la-virnetlink.lo] Error 1

Any ideas?

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt-0.10.0

[Justin Clift]

On 23/08/2012, at 11:24 PM, Daniel P. Berrange wrote:
 On Thu, Aug 23, 2012 at 11:21:21PM +1000, Justin Clift wrote:
 On 22/08/2012, at 9:51 PM, Daniel Veillard wrote:
 As planned, I just tagged 0.10.0 release candidate 1 in git and
 pushed a tarball and rpms to the usual place:
  ftp://libvirt.org/libvirt/
 
 I gave it a try locally and things seems to work as expected, but
 that's far from an extensive testing :-)
 
 So please try it, try to compile it on various platforms and
 send feedback to the list.
 
 Compilation is failing on OSX 10.7:
 
  ...
CC libvirt_util_la-viruri.lo
CC libvirt_conf_la-netdev_bandwidth_conf.lo
  util/virnetlink.c:819: error: conflicting types for 
 'virNetlinkEventAddClient'
  util/virnetlink.h:82: error: previous declaration of 
 'virNetlinkEventAddClient' was here
  util/virnetlink.c: In function 'virNetlinkEventAddClient':
  util/virnetlink.c:819: error: expected ',' or ';' before ')' token
  util/virnetlink.c:830: error: expected '=', ',', ';', 'asm' or 
 '__attribute__' before 'unsigned'
  util/virnetlink.c:834: error: old-style parameter declarations in 
 prototyped function definition
  util/virnetlink.c:834: error: expected '{' at end of input
  make[3]: *** [libvirt_util_la-virnetlink.lo] Error 1
 
 Any ideas?
 
 Please try building from GIT instead - rc1 missed the fix for non-Linux
 platforms.
 
 commit 34b30de5f5812f367af362b602484fe105e4f88f
 Author: Daniel P. Berrange berra...@redhat.com
 Date:   Wed Aug 22 16:09:17 2012 +0100
 
Fix parameter list in virNetlinkEvent{Add,Remove}Client Win32 stubs
 
The virNetlinkEventAddClient / virNetlinkEventRemoveClient stub
impls had syntax errors in their parameter lists, using a ')'
after the second-to-last parameter instead of a ','
 
Signed-off-by: Daniel P. Berrange berra...@redhat.com


Thanks Daniel.  I'll try again with rc2 instead when it's ready. :)

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.13

[Justin Clift]

On 02/07/2012, at 3:10 PM, Daniel Veillard wrote:
 
  Okay the new release is out and available as uauls at
ftp://libvirt.org/libvirt/


Now in OSX Homebrew too. :)

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] FLOSS Weekly podcast for libvirt is online

[Justin Clift]

Hey all,

Eric Blake and Guido Gunther were on the FLOSS Weekly
podcast this week, covering libvirt:

  http://twit.tv/show/floss-weekly/213
  (also available in iTunes)

Good effort guys. :)

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.12

[Justin Clift]

On 14/05/2012, at 1:42 PM, Daniel Veillard wrote:
  So I made the release, it is now available on the FTP server (the rpms
 are slowly being uploaded too):
   ftp://libvirt.org/libvirt/


This, and the 0.9.11.3 stable release, are now available in Homebrew on
MacOS X.

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] ANNOUNCE: Stable release libvirt-0.9.11.1

[Justin Clift]

On 27/04/2012, at 5:45 AM, Cole Robinson wrote:
snip
 For a complete list of changes since libvirt-0.9.11 GA, please see:
 
 http://wiki.libvirt.org/page/Stable_Releases

* Just as a FYI, this Stable_Releases page needs some linkage.

  It's not referred to from the News section, there no link to it
  from the Downloads page, etc.  It's kind of invisible.

* The page needs dates for the releases.

  It turns out there's an unannounced 0.9.11.3 on there with
  a corresponding tarball on the ftp server.  Nothing about it
  on libvirt-announce though, and no datestamp on the releases.

:(

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] ANNOUNCE: Stable release libvirt-0.9.11.2

[Justin Clift]

On 27/04/2012, at 8:04 AM, Cole Robinson wrote:
 Okay, I screwed up the tarball for the first stable release, due to not
 building it from a fresh checkout :/ No changes for this one except a version
 bump and dist rebuild.
 
 This release can be downloaded at:
 
 http://libvirt.org/sources/libvirt-0.9.11.2.tar.gz

Should there be entries for 0.9.11.1 and 0.9.11.2 on the News page?

  http://libvirt.org/news.html

+ Justin


 
 Thanks,
 Cole
 
 ___
 Libvirt-announce mailing list
 libvirt-annou...@redhat.com
 https://www.redhat.com/mailman/listinfo/libvirt-announce

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Etsy uses Libvirt... :)

[Justin Clift]

On 11/04/2012, at 8:36 AM, Eric Blake wrote:
snip
 Thanks for the research.  Would you care to help write up a
 documentation patch that mentions this as yet another client project?
 If you don't have time, I will probably get around to it later in the week.
 
 Turns out it's an internal use, rather than a released open source
 project, so not really something to mention on our pages (yet).  But
 still fun to see others using our stuff.


Would you be up for pinging the blog author, asking him if there's
areas for improvement in libvirt they'd be keen on?

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Etsy uses Libvirt... :)

[Justin Clift]

Hey everyone,

Just noticed that Etsy uses libvirt:

  
http://codeascraft.etsy.com/2012/03/13/making-it-virtually-easy-to-deploy-on-day-one/

Of specific note, there's this bit:

  Libvirt supports live migrations across non-shared storage (in QEMU 0.12.2+) 
with
   zero downtime which makes it easy to allocate and balance VM’s across hosts 
if
   adjustments need to be made throughout the pool.

Seems like a win, eh? :)

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.11

[Justin Clift]

On 04/04/2012, at 3:28 PM, Jason Helfman wrote:
 On 03/04/2012, at 6:07 PM, Daniel Veillard wrote:
 So as stated last week I made the release today. It is available
 from the ftp:
  ftp://libvirt.org/libvirt/libvirt-0.9.11.tar.gz
 
 The OSX version is now available through Homebrew too. :)
 
 + Justin
 
 
 I just updated libvirt for FreeBSD, too.
 
 Justin - we should work together in getting things going in bsdland :)

Heh, it's a good thought in theory, but I'm probably not able to really
add much value. :(

Not a C coder any more, and it's been *years* since I last looked at
*BSD... Not really all that personally interested in picking it up
again any time soon. (sorry)

I like the feel of BSD in usage, it's just I'm kind of overloaded with
my existing stuff at the moment. ;)

Don't take this as discouragement btw, I reckon your work on getting the
BSD side of libvirt working well is a good, worthwhile effort. :)

Regards and best wishes,

Justin Clift

 -jgh

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.11

[Justin Clift]

On 03/04/2012, at 6:07 PM, Daniel Veillard wrote:
  So as stated last week I made the release today. It is available
 from the ftp:
   ftp://libvirt.org/libvirt/libvirt-0.9.11.tar.gz

The OSX version is now available through Homebrew too. :)

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.11 and availability of rc1

[Justin Clift]

On 31/03/2012, at 10:56 PM, Daniel Veillard wrote:
snip
 I juts made the second release candidate
 
  ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz
 
 along with the rpms and tagged the git tree.
 
 It seems to work okay in my limited testing. If all goes well I would
 probably push on Tuesday,
 
  thanks in advance !

This one seems fine on OSX too.

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.11 and availability of rc1

[Justin Clift]

On 26/03/2012, at 1:32 PM, Daniel Veillard wrote:
  As scheduled, we are entering the freeze for 0.9.11.
 I think most API additions are now commited to git upstream (please
 raise your voice quickly if you see something missing !)
 
 I have made a release candidate 1 tarball (and associated rpms) at
   ftp://libvirt.org/libvirt/libvirt-0.9.11-rc1.tar.gz
 and the git tree is tagged.
 
 I think I will make an release candidate 2 tarball on Wednesday, and
 I'm hoping for a final release on Friday, or maybe Monday if there are
 issues found.
 
 Please give it a try ! Stability and portability feedback are really
 welcome as we didn't had a release in Feb and the risk of having
 something messed up is slightly higher than usual !

Seems good on OSX 10.7.

+ Justin


  thanks in advance,
 
 Daniel
 
 
 -- 
 Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
 dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
 http://veillard.com/ | virtualization library  http://libvirt.org/
 
 ___
 Libvirt-announce mailing list
 libvirt-annou...@redhat.com
 https://www.redhat.com/mailman/listinfo/libvirt-announce

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.10

[Justin Clift]

On 20/02/2012, at 2:26 PM, Daniel Veillard wrote:
 On Tue, Feb 14, 2012 at 07:59:16PM +1100, Justin Clift wrote:
 On 14/02/2012, at 7:31 PM, Daniel Veillard wrote:
 On Tue, Feb 14, 2012 at 07:18:32PM +1100, Justin Clift wrote:
 On 14/02/2012, at 4:15 PM, Daniel Veillard wrote:
 As planned I made the release yesterday, it is tagged in git and
 available at:
 ftp://libvirt.org/libvirt/
 both as tarball and signed rpms for Fedora 16.
 
 Ouch.  This fails to compile on OSX (unlike rc1), with this:
 
   CCLD   libvirt_iohelper
   CCLD   libvirt_driver_remote.la
 ld: duplicate symbol _virFileWrapperFdFlags in 
 ./.libs/libvirt_util.a(libvirt_util_la-virfile.o) and 
 ./.libs/libvirt_util.a(libvirt_util_la-util.o) for architecture x86_64
 collect2: ld returned 1 exit status
 
 I just went to download the rc's for this again, to verify rc1 still 
 compiles ok, just in case it's my system that's gone wrong.
 
  Someone reported the bug as
 
 https://bugzilla.redhat.com/show_bug.cgi?id=795076
 
 and provied a patch for it, it makes sense, so I'm pushing it under
 the build breaker rule.

Thanks guys.  Tested, and that lets compilation work on the system here.

Used it to create a libvirt 0.9.10 pull request for Homebrew on OSX.

  https://github.com/mxcl/homebrew/pull/10347

Should be available to people in under 24 hours. :)

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Anyone up for a libvirt webcast on FLOSS Weekly Podcasts

[Justin Clift]

Hi all,

Looking for someone to do a webcast about Libvirt, for the FLOSS Weekly podcast:

  http://twit.tv/show/floss-weekly

Preferably someone pretty well known in the Libvirt Community (commit access 
maybe?).

Said person must have decent bandwidth for the webcast connection, and be
comfortable using Skype.

Already asked DV who would, except he's very bandwidth limited, and the timezone
(US/Los Angeles) is a pita for him. :(  So, need an alternative person. :)

The existing schedule is online:

  http://xrl.us/flossweeklyguests

Anyone interested?

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.10

[Justin Clift]

On 14/02/2012, at 4:15 PM, Daniel Veillard wrote:
  As planned I made the release yesterday, it is tagged in git and
 available at:
   ftp://libvirt.org/libvirt/
 both as tarball and signed rpms for Fedora 16.

Ouch.  This fails to compile on OSX (unlike rc1), with this:

CCLD   libvirt_iohelper
CCLD   libvirt_driver_remote.la
  ld: duplicate symbol _virFileWrapperFdFlags in 
./.libs/libvirt_util.a(libvirt_util_la-virfile.o) and 
./.libs/libvirt_util.a(libvirt_util_la-util.o) for architecture x86_64
  collect2: ld returned 1 exit status

I just went to download the rc's for this again, to verify rc1 still compiles 
ok, just in case it's my system that's gone wrong.

Looks like the rc's have been nuked from the download site though. :(

Regards and best wishes,

Justin Clift

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.10

[Justin Clift]

On 14/02/2012, at 7:31 PM, Daniel Veillard wrote:
 On Tue, Feb 14, 2012 at 07:18:32PM +1100, Justin Clift wrote:
 On 14/02/2012, at 4:15 PM, Daniel Veillard wrote:
 As planned I made the release yesterday, it is tagged in git and
 available at:
  ftp://libvirt.org/libvirt/
 both as tarball and signed rpms for Fedora 16.
 
 Ouch.  This fails to compile on OSX (unlike rc1), with this:
 
CCLD   libvirt_iohelper
CCLD   libvirt_driver_remote.la
  ld: duplicate symbol _virFileWrapperFdFlags in 
 ./.libs/libvirt_util.a(libvirt_util_la-virfile.o) and 
 ./.libs/libvirt_util.a(libvirt_util_la-util.o) for architecture x86_64
  collect2: ld returned 1 exit status
 
 I just went to download the rc's for this again, to verify rc1 still 
 compiles ok, just in case it's my system that's gone wrong.
 
 Looks like the rc's have been nuked from the download site though. :(
 
  Ah, right, I removed them, there was like 20 old rc tarballs and
 rpms floating around, I should probably have kept the last ones,

Probably yeah (in hindsight).  I theory I should be able to build them
again anyway by running up a VM with F16 in it + git from the right
commit.

If I get time to today, I'll try and figure out what's going on with
this. ;)

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] availability of rc2 for 0.9.10

[Justin Clift]

On 08/02/2012, at 5:59 PM, Daniel Veillard wrote:
 On Mon, Feb 06, 2012 at 03:21:21PM +0800, Daniel Veillard wrote:
  We are now entering the freeze for libvirt-0.9.10
 Hopefully all the API changes needed for that version are
 already commited to git head.
 
  Okay I made an rc2 release with the python bindings fix (thanks !)
 
ftp://libvirt.org/libvirt/libvirt-0.9.10-rc2.tar.gz
 the rpms are available too and the git tree is tagged.
 
  Hopefully that one is more usable, and I'm still hoping for a
 release on Monday,

RC2 also compiles/runs ok on OSX 10.7.

+ Justin


  thanks !
 
 Daniel
 
 -- 
 Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
 dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
 http://veillard.com/ | virtualization library  http://libvirt.org/
 
 ___
 Libvirt-announce mailing list
 libvirt-annou...@redhat.com
 https://www.redhat.com/mailman/listinfo/libvirt-announce

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] The weird '@' in bind address on OSX

[Justin Clift]

Hi all,

As a general thought, would anyone be interested in getting this weird '@'
thing in the bind address on OSX fixed?

It shows up in both libvirtd and virsh:

  $ libvirtd 
  2012-02-08 08:39:53.211+: -1: info : libvirt version: 0.9.10
  2012-02-08 08:39:53.211+: -1: error : virNetSocketNewListenUNIX:346 : 
Failed to bind socket to '@/Users/jc/.libvirt/libvirt-sock': No such file or 
directory

and

  $ virsh
  Welcome to virsh, the virtualization interactive terminal.

  Type:  'help' for help with commands
 'quit' to quit

  virsh # version
  error: Failed to reconnect to the hypervisor
  error: no valid connection
  error: Failed to connect socket to '@/Users/jc/.libvirt/libvirt-sock': No 
such file or directory

Matthias mentioned it's due to using anonymous unix sockets, which
are only present on Linux:

  https://www.redhat.com/archives/libvirt-users/2011-November/msg00018.html

Guess that means libvirtd doesn't work on *BSD either?

Perhaps gnulib has a cross platform way to take care of this?

(Note, I could have sworn eblake started looking into this ages ago,
but then I moved on to the Aeolus team.  Unsure if there was useful
progress back then. ?)

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.10 and availability of rc1

[Justin Clift]

On 06/02/2012, at 6:21 PM, Daniel Veillard wrote:
  We are now entering the freeze for libvirt-0.9.10
 Hopefully all the API changes needed for that version are
 already commited to git head.
 
 I have made a release candidate 1 tarball (and associated rpms) at
   ftp://libvirt.org/libvirt/libvirt-0.9.10-rc1.tar.gz
 and the git tree is tagged.
 
 I think I will make an release candidate 2 tarball on Wednesday, and
 I'm hoping for a final release next Monday the 13th.
 
 Please give it a try !

Compiles ok on Mac OS X 10.7. (64-bit)

Haven't tried the regression tests, nor earlier versions of OSX though. ;)

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Fwd: [MacPorts] #32523: libvirt: update to 0.9.8

[Justin Clift]

Hi all,

Just an FYI.  Libvirt is now available through the Mac MacPorts package 
system, as well as HomeBrew.

Hope that's useful. :)

Regards and best wishes,

Justin Clift


Begin forwarded message:
 From: MacPorts nore...@macports.org
 Subject: Re: [MacPorts] #32523: libvirt: update to 0.9.8
 Date: 14 December 2011 3:39:10 PM AEDT
 To: ryandes...@macports.org, jcl...@redhat.com
 Cc: macports-tick...@lists.macosforge.org
 Reply-To: macports-...@lists.macosforge.org
 
 #32523: libvirt: update to 0.9.8
 --+-
  Reporter:  ryandesign@… |   Owner:  jclift@… 
  Type:  defect   |  Status:  closed   
  Priority:  Normal   |   Milestone:   
 Component:  ports| Version:  2.0.3
 Resolution:  fixed|Keywords:  haspatch 
  Port:  libvirt  |  
 --+-
 Changes (by ryandesign@…):
 
  * status:  new = closed
  * resolution:  = fixed
 
 
 Comment:
 
 r87956.
 
 -- 
 Ticket URL: https://trac.macports.org/ticket/32523#comment:4
 MacPorts http://www.macports.org/
 Ports system for Mac OS

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

[Justin Clift]

On 15/11/2011, at 10:34 PM, Stefan Berger wrote:
 +/* strchr work-around for gcc 4.3  4.4 bug with -Wlogical-op
 + * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36513
 + */

Cool, that's good investigation Stefan. :)

+ Justin

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

[Justin Clift]

On 12/11/2011, at 8:06 AM, Eric Blake wrote:
 On 11/08/2011 11:46 PM, Justin Clift wrote:
 Hi guys,
 
 Just checking 0.9.7 on RHEL 6.1 x86_64.  Noticed this when compiling
 with make -j 3:
 
CC libvirt_lxc-command.o
  util/buf.c: In function 'virBufferEscape':
  util/buf.c:469: warning: logical '' with non-zero constant will always 
 evaluate as true [-Wlogical-op]
 
 Obviously not fatal, but it figured someone might want to keep things 
 warning free. :)
 
 This is a bug in gcc, although I'm not sure if anyone has raised a bug
 report against the gcc folks yet:
 https://www.redhat.com/archives/libvir-list/2011-October/msg00837.html
 
 I'm open to suggestions on how to work around it; perhaps we just need
 to disable -Wlogical-op if glibc's headers are turning on the optimized
 strchr (is that -D_FORTIFY_SOURCE that does it?) :(

H, we might as well report it, so it gets looked at.

Next question is where?  Upstream gcc, or on the RG BZ as a Fedora15(+?)/RHEL6
specific gcc bug?

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] make rpm failing with git head on RHEL6

[Justin Clift]

On 09/11/2011, at 6:22 PM, Wen Congyang wrote:
snip
 To clarify, systemtap-sdt-devel is already installed.  Doing a brand new 
 autogen.sh, then
 compiling normally with:
 
 I find the following messages from autogen.sh's output:
 running CONFIG_SHELL=/bin/sh /bin/sh ./configure --with-dtrace=no --no-create 
 --no-recursion
 checking for a BSD-compatible install... /usr/bin/install -c
 
 You have disabled dtrace, so make -j 3 does not fail.
 
 Please run ./configure again, and check whether dtrace is enabled.

Thanks, well spotted! :)

Looks like I needed to run make distclean first, to get rid of old 
preferences.

Things worked fine after that (both normal make, and make rpm).

On another note, Eric, do you reckon it's possible to add the XHTML1 DTDs to 
maintainer
requirements?

Without them, generation of the html docs fails at the validation stage.

i.e. for make rpm:

  ...
  missing XHTML1 DTD
  missing XHTML1 DTD
  cp: cannot stat `./api.html': No such file or directory
  make[2]: *** [distdir] Error 1
  rm news.html.tmp goals.html.tmp archnetwork.html.tmp formatsecret.html.tmp 
drvopenvz.html.tmp windows.html.tmp testtck.html.tmp drvlxc.html.tmp 
apps.html.tmp docs.html.tmp formatstorageencryption.html.tmp drvvbox.html.tmp 
formatdomain.html.tmp php.html.tmp drvhyperv.html.tmp errors.html.tmp 
hacking.html.tmp format.html.tmp hooks.html.tmp api.html.tmp storage.html.tmp 
formatcaps.html.tmp relatedlinks.html.tmp compiling.html.tmp index.html.tmp 
archdomain.html.tmp downloads.html.tmp auth.html.tmp archnode.html.tmp 
hvsupport.html.tmp bugs.html.tmp java.html.tmp locking.html.tmp 
logging.html.tmp testapi.html.tmp formatnetwork.html.tmp bindings.html.tmp 
uri.html.tmp drvtest.html.tmp sitemap.html.tmp drvqemu.html.tmp 
contact.html.tmp formatnwfilter.html.tmp intro.html.tmp drvxen.html.tmp 
drvesx.html.tmp drvvmware.html.tmp testsuites.html.tmp devguide.html.tmp 
firewall.html.tmp architecture.html.tmp migration.html.tmp todo.html.tmp 
formatsnapshot.html.tmp formatstorage.html.tmp in!
 ternals.html.tmp deployment.html.tmp api_extension.html.tmp drvuml.html.tmp 
virshcmdref.html.tmp csharp.html.tmp python.html.tmp drvremote.html.tmp 
archstorage.html.tmp remote.html.tmp drivers.html.tmp formatnode.html.tmp
  make[2]: Leaving directory `/home/jc/git_repos/libvirt/docs'
  make[1]: *** [distdir] Error 1
  make[1]: Leaving directory `/home/jc/git_repos/libvirt'
  make: *** [rpm] Error 2

In Fedora/RHEL it's the xhtml1-dtds (noarch) package.

Regards and best wishes,

Justin Clift


 Thanks
 Wen Congyang

--
Aeolus Community Manager
http://www.aeolusproject.org



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] make rpm failing with git head on RHEL6

[Justin Clift]

On 08/11/2011, at 8:19 PM, Wen Congyang wrote:
snip
 I seems that NEWS is not included in dist on your machine.
 
 Here is my Makefile:
 
 DIST_COMMON = README $(am__configure_deps) $(srcdir)/Makefile.am \
$(srcdir)/Makefile.in $(srcdir)/config.h.in \
$(srcdir)/libvirt.pc.in $(srcdir)/libvirt.spec.in \
$(srcdir)/mingw32-libvirt.spec.in $(top_srcdir)/configure \
ABOUT-NLS AUTHORS COPYING COPYING.LIB ChangeLog INSTALL NEWS \
TODO build-aux/compile build-aux/config.guess \
build-aux/config.rpath build-aux/config.sub build-aux/depcomp \
build-aux/install-sh build-aux/ltmain.sh build-aux/mdate-sh \
build-aux/missing build-aux/mkinstalldirs \
build-aux/texinfo.tex
 
 The DIST_COMMON contains NEWS.
 
 Does DIST_COMMON contain NEWS in your Makefile?

Thanks. :)

Found the problem with the NEWS file.  It's because libxslt wasn't installed.

Turns out the NEWS makefile target silently fails if it's missing.
i.e. even make NEWS doesn't report an error

Still haven't found out the problem with probes.h though.  Now looking at
that again.

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

[Justin Clift]

Hi guys,

Just checking 0.9.7 on RHEL 6.1 x86_64.  Noticed this when compiling
with make -j 3:

  make[3]: Entering directory `/home/jc/git_repos/libvirt/src'
CC libvirt_util_la-bitmap.lo
CC libvirt_util_la-authhelper.lo
CC libvirt_util_la-bridge.lo
CC libvirt_util_la-buf.lo
CC libvirt_util_la-command.lo
  util/buf.c: In function 'virBufferEscape':
  util/buf.c:469: warning: logical '' with non-zero constant will always 
evaluate as true [-Wlogical-op]

  ...

CC libvirt_lxc-command.o
  util/buf.c: In function 'virBufferEscape':
  util/buf.c:469: warning: logical '' with non-zero constant will always 
evaluate as true [-Wlogical-op]

Obviously not fatal, but it figured someone might want to keep things warning 
free. :)

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] make rpm failing with git head on RHEL6

[Justin Clift]

Hi guys,

Just tried make rpm with git head, on RHEL 6.x.

It gave the following failure:

  make[1]: Leaving directory `/home/jc/git_repos/libvirt'
  make[1]: Entering directory `/home/jc/git_repos/libvirt'
  { test ! -d libvirt-0.9.6 || { find libvirt-0.9.6 -type d ! -perm -200 
-exec chmod u+w {} ';'  rm -fr libvirt-0.9.6; }; }
  test -d libvirt-0.9.6 || mkdir libvirt-0.9.6
  cp: cannot stat `./NEWS': No such file or directory
  make[1]: *** [distdir] Error 1
  make[1]: Leaving directory `/home/jc/git_repos/libvirt'
  make: *** [rpm] Error 2

Anyone want to fix it prior to 0.9.7? :)

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] make rpm failing with git head on RHEL6

[Justin Clift]

On 08/11/2011, at 5:17 PM, Justin Clift wrote:
 Hi guys,
 
 Just tried make rpm with git head, on RHEL 6.x.
 
 It gave the following failure:
 
  make[1]: Leaving directory `/home/jc/git_repos/libvirt'
  make[1]: Entering directory `/home/jc/git_repos/libvirt'
  { test ! -d libvirt-0.9.6 || { find libvirt-0.9.6 -type d ! -perm -200 
 -exec chmod u+w {} ';'  rm -fr libvirt-0.9.6; }; }
  test -d libvirt-0.9.6 || mkdir libvirt-0.9.6
  cp: cannot stat `./NEWS': No such file or directory
  make[1]: *** [distdir] Error 1
  make[1]: Leaving directory `/home/jc/git_repos/libvirt'
  make: *** [rpm] Error 2
 
 Anyone want to fix it prior to 0.9.7? :)

As additional info, after doing a touch NEWS just to get it
past this point, it then fails with:

  make[2]: Leaving directory `/home/jc/git_repos/libvirt/include'
  (cd src  make  top_distdir=../libvirt-0.9.6 distdir=../libvirt-0.9.6/src \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
  make[2]: Entering directory `/home/jc/git_repos/libvirt/src'
  make[2]: *** No rule to make target `probes.h', needed by `distdir'.  Stop.
  make[2]: Leaving directory `/home/jc/git_repos/libvirt/src'
  make[1]: *** [distdir] Error 1
  make[1]: Leaving directory `/home/jc/git_repos/libvirt'
  make: *** [rpm] Error 2

This is a newly setup RHEL 6.1 x64 VM, with the Development Tools yum
package group installed, plus minimal -devel packages to let configure
succeed.

Any ideas?

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.7 and availability of rc1

[Justin Clift]

On 31/10/2011, at 8:51 PM, Daniel Veillard wrote:
  We are now entering the freeze for libvirt-0.9.7 .
 We may make an exception for patch set which got a few round of reviews
 though, like Stefan's ones (v4 IIRC), and anything which we know may
 need fixing in the API before the release.
 
 I have made a release candidate 1 tarball (and associated rpms) at
   ftp://libvirt.org/libvirt/libvirt-0.9.7-rc1.tar.gz
 
 I think I will make an rc2 on Wed or Thu and then try to
 make the release around Friday of the end of the week if things
 looks good.
 
  Please give it a try !

Fails on OSX 10.6.8, with this:

  make  all-am
CC libvirt_util_la-authhelper.lo
CC libvirt_util_la-bitmap.lo
CC libvirt_util_la-bridge.lo
  ...
CCLD   libvirt_driver_storage.la
CCLD   libvirt_iohelper
CCLD   libvirt_driver_remote.la
  Undefined symbols:
_ptsname_r, referenced from:
_virFileOpenTty in libvirt_util.a(libvirt_util_la-util.o)
  ld: symbol(s) not found
  collect2: ld returned 1 exit status
  make[3]: *** [libvirt_iohelper] Error 1
  make[3]: *** Waiting for unfinished jobs
  make[2]: *** [all] Error 2
  make[1]: *** [all-recursive] Error 1
  make: *** [all] Error 2

Anyone feel like investigating? :)

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Libvirt-announce] libvirt-0.9.5 availability of rc3

[Justin Clift]

On 18/09/2011, at 8:55 PM, Daniel Veillard wrote:
 I have made a third release candidate tarball (and associated rpms) at
ftp://libvirt.org/libvirt/libvirt-0.9.5-rc2.tar.gz
 and tagged in git for it.
 This one should fis the MacOS-X/BSD portability problem thanks to Peter
 and Eric, and if everything goes well I will probably release 0.9.5 on
 Monday or more likely on Tuesday to give people a bit more time to test that
 latest candidate
 
  So give it a try, thanks !

Yep, seems ok on OSX 10.7.1 64-bit now.

Regards and best wishes,

Justin Clift

--
Aeolus Community Manager
http://www.aeolusproject.org


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list