Re: [Libvir] [PATCH] qemu_conf.h: Avoid dubious signed one-bit bitfield

[Daniel Veillard]

On Thu, Nov 15, 2007 at 03:32:21AM -0500, Jim Paris wrote:
 Signed one-bit bitfields are odd (values are 0 and -1?).  The code
 doesn't test for == 1, so it's not currently broken, but it's fragile.
 (Noticed by Sparse).

  Okay both changes makes sense, thanks for raising those and sending
patches ! Applied and commited to CVS,

   thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard  | virtualization library  http://libvirt.org/
[EMAIL PROTECTED]  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[Libvir] [PATCH] qemu_conf.h: Avoid dubious signed one-bit bitfield

[Jim Paris]

Signed one-bit bitfields are odd (values are 0 and -1?).  The code
doesn't test for == 1, so it's not currently broken, but it's fragile.
(Noticed by Sparse).
---
 src/qemu_conf.h |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu_conf.h b/src/qemu_conf.h
index 72e582d..6a59744 100644
--- a/src/qemu_conf.h
+++ b/src/qemu_conf.h
@@ -305,8 +305,8 @@ struct qemud_driver {
 char *networkConfigDir;
 char *networkAutostartDir;
 char logDir[PATH_MAX];
-int vncTLS : 1;
-int vncTLSx509verify : 1;
+unsigned int vncTLS : 1;
+unsigned int vncTLSx509verify : 1;
 char *vncTLSx509certdir;
 char vncListen[BR_INET_ADDR_MAXLEN];
 };
-- 
1.5.3.4

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list