Re: [PATCH] doc/python: Update to Python 3

[Daniel P . Berrangé]

On Mon, Apr 20, 2020 at 08:01:54AM +0200, Philipp Hahn wrote:
> Convert the simple example to Python 3 syntax:
> - print() is a function
> - do not use bare except
> - libvirt.open*() does not return None but raises an exception
> 
> The referenced source for the example was removed with
> 5bb2a245abbde4c0a407f631660e2f2c81bc4c02
> ---
>  docs/python.html.in | 18 +-
>  1 file changed, 9 insertions(+), 9 deletions(-)

The patch looks ok, but is missing the Signed-off-by to indicate
acceptance of the DCO described in https://libvirt.org/hacking.html
Could you reply to your patch to add the S-o-b and then i'll merge
it.

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

[PATCH] doc/python: Update to Python 3

[Philipp Hahn]

Convert the simple example to Python 3 syntax:
- print() is a function
- do not use bare except
- libvirt.open*() does not return None but raises an exception

The referenced source for the example was removed with
5bb2a245abbde4c0a407f631660e2f2c81bc4c02
---
 docs/python.html.in | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/docs/python.html.in b/docs/python.html.in
index e6e8cfade9..0f804da8c3 100644
--- a/docs/python.html.in
+++ b/docs/python.html.in
@@ -38,24 +38,24 @@ specificities in their argument conversions:
 is replaced by virDomain::info() which returns a list of
 state: one of the state values (virDomainState)maxMemory: 
the maximum memory used by the domainmemory: the current amount of 
memory used by the domainnbVirtCPU: the number of virtual 
CPUcpuTime: the time used by the domain in nanoseconds
 
-So let's look at a simple example inspired from the 
basic.py
-test found in python/tests/ in the source tree:
+So let's look at a simple example:
 import libvirt
 import sys
 
-conn = libvirt.openReadOnly(None)
-if conn == None:
-print 'Failed to open connection to the hypervisor'
+try:
+conn = libvirt.openReadOnly(None)
+except libvirt.libvirtError:
+print('Failed to open connection to the hypervisor')
 sys.exit(1)
 
 try:
 dom0 = conn.lookupByName("Domain-0")
-except:
-print 'Failed to find the main domain'
+except libvirt.libvirtError:
+print('Failed to find the main domain')
 sys.exit(1)
 
-print "Domain 0: id %d running %s" % (dom0.ID(), dom0.OSType())
-print dom0.info()
+print("Domain 0: id %d running %s" % (dom0.ID(), dom0.OSType()))
+print(dom0.info())
 There is not much to comment about it, it really is a straight mapping
 from the C API, the only points to notice are:
 
-- 
2.20.1