Re: [PATCH] tests: qemublocktest: fix crashing with SIGBUS

2020-08-04 Thread Ján Tomko 

On a Tuesday in 2020, Roman Bogorodskiy wrote:

Commit bcbb026993 converted qemublocktest to use
g_autoptr for virQEMUCaps. To prevent it from crashing,
don't explicitly call virObjectUnref() on this object.



Oops, thanks for catching that.


Signed-off-by: Roman Bogorodskiy 
---
tests/qemublocktest.c | 1 -
1 file changed, 1 deletion(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature

Re: [PATCH] tests: qemublocktest: fix crashing with SIGBUS

2020-08-04 Thread Daniel P . Berrangé 
On Tue, Aug 04, 2020 at 08:10:00PM +0400, Roman Bogorodskiy wrote:
> Commit bcbb026993 converted qemublocktest to use
> g_autoptr for virQEMUCaps. To prevent it from crashing,
> don't explicitly call virObjectUnref() on this object.
> 
> Signed-off-by: Roman Bogorodskiy 
> ---
>  tests/qemublocktest.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Daniel P. Berrangé 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

[PATCH] tests: qemublocktest: fix crashing with SIGBUS

2020-08-04 Thread Roman Bogorodskiy 
Commit bcbb026993 converted qemublocktest to use
g_autoptr for virQEMUCaps. To prevent it from crashing,
don't explicitly call virObjectUnref() on this object.

Signed-off-by: Roman Bogorodskiy 
---
 tests/qemublocktest.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c
index fb5319d7bd..0685b703a1 100644
--- a/tests/qemublocktest.c
+++ b/tests/qemublocktest.c
@@ -1394,7 +1394,6 @@ mymain(void)
  cleanup:
 qemuTestDriverFree(&driver);
 VIR_FREE(capslatest_x86_64);
-virObjectUnref(caps_x86_64);
 
 return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
 }
-- 
2.27.0