Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-25 Thread Michal Prívozník
On 4/25/22 16:49, Peter Krempa wrote:
> On Mon, Apr 25, 2022 at 16:40:17 +0200, Michal Prívozník wrote:
>> On 4/25/22 16:36, Peter Krempa wrote:
>>> On Wed, Apr 20, 2022 at 13:02:12 +0200, Peter Krempa wrote:
 Few minor changes in qemu since the last update:
 - PIIX4_PM gained 'x-not-migrate-acpi-index' property
>>>
>>> Based on the discussion I can drop this line.
>>>
 - 'cocoa' display and corresponding props (not present in this build)

 Changes in build:
 - dbus display driver re-enabled
 - gtk display support re-disabled
 - xen support re-disabled

 Signed-off-by: Peter Krempa 
 ---
  .../caps_7.0.0.x86_64.replies | 583 --
  .../caps_7.0.0.x86_64.xml |  10 +-
  2 files changed, 257 insertions(+), 336 deletions(-)
>>>
>>> The rest is still open for review ;)
>>>
>>
>> Is it? I though you push this kind of patches. I mean, what's there to
>> review? It's basically a generated file.
> 
> Hmm, I didn't really want to get a rule instantiated for this kind of
> stuff, but yeah, in most cases there's nothing to do.
> 
> I actually do review them:
> 
> 1) For new additions on x86 I'm looking for new stuff which might be
> interesting for us, thus the "changelog" above, but I do that also when
> I'm sending patches
> 
> 2) It's important to look that the capabilities don't regress and also
> potential stuff which might have test fallout.
> 
> In case when I'm sending those I make sure that doesn't happen so I'll
> be okay just to push these without review, but generally I'd like to be
> reviewing other submissions.
> 

Alright then.

Reviewed-by: Michal Privoznik 

Michal



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-25 Thread Peter Krempa
On Mon, Apr 25, 2022 at 16:40:17 +0200, Michal Prívozník wrote:
> On 4/25/22 16:36, Peter Krempa wrote:
> > On Wed, Apr 20, 2022 at 13:02:12 +0200, Peter Krempa wrote:
> >> Few minor changes in qemu since the last update:
> >> - PIIX4_PM gained 'x-not-migrate-acpi-index' property
> > 
> > Based on the discussion I can drop this line.
> > 
> >> - 'cocoa' display and corresponding props (not present in this build)
> >>
> >> Changes in build:
> >> - dbus display driver re-enabled
> >> - gtk display support re-disabled
> >> - xen support re-disabled
> >>
> >> Signed-off-by: Peter Krempa 
> >> ---
> >>  .../caps_7.0.0.x86_64.replies | 583 --
> >>  .../caps_7.0.0.x86_64.xml |  10 +-
> >>  2 files changed, 257 insertions(+), 336 deletions(-)
> > 
> > The rest is still open for review ;)
> > 
> 
> Is it? I though you push this kind of patches. I mean, what's there to
> review? It's basically a generated file.

Hmm, I didn't really want to get a rule instantiated for this kind of
stuff, but yeah, in most cases there's nothing to do.

I actually do review them:

1) For new additions on x86 I'm looking for new stuff which might be
interesting for us, thus the "changelog" above, but I do that also when
I'm sending patches

2) It's important to look that the capabilities don't regress and also
potential stuff which might have test fallout.

In case when I'm sending those I make sure that doesn't happen so I'll
be okay just to push these without review, but generally I'd like to be
reviewing other submissions.



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-25 Thread Michal Prívozník
On 4/25/22 16:36, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 13:02:12 +0200, Peter Krempa wrote:
>> Few minor changes in qemu since the last update:
>> - PIIX4_PM gained 'x-not-migrate-acpi-index' property
> 
> Based on the discussion I can drop this line.
> 
>> - 'cocoa' display and corresponding props (not present in this build)
>>
>> Changes in build:
>> - dbus display driver re-enabled
>> - gtk display support re-disabled
>> - xen support re-disabled
>>
>> Signed-off-by: Peter Krempa 
>> ---
>>  .../caps_7.0.0.x86_64.replies | 583 --
>>  .../caps_7.0.0.x86_64.xml |  10 +-
>>  2 files changed, 257 insertions(+), 336 deletions(-)
> 
> The rest is still open for review ;)
> 

Is it? I though you push this kind of patches. I mean, what's there to
review? It's basically a generated file.

Michal



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-25 Thread Peter Krempa
On Wed, Apr 20, 2022 at 13:02:12 +0200, Peter Krempa wrote:
> Few minor changes in qemu since the last update:
> - PIIX4_PM gained 'x-not-migrate-acpi-index' property

Based on the discussion I can drop this line.

> - 'cocoa' display and corresponding props (not present in this build)
> 
> Changes in build:
> - dbus display driver re-enabled
> - gtk display support re-disabled
> - xen support re-disabled
> 
> Signed-off-by: Peter Krempa 
> ---
>  .../caps_7.0.0.x86_64.replies | 583 --
>  .../caps_7.0.0.x86_64.xml |  10 +-
>  2 files changed, 257 insertions(+), 336 deletions(-)

The rest is still open for review ;)



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Igor Mammedov
On Wed, 20 Apr 2022 14:13:00 +0200
Peter Krempa  wrote:

> On Wed, Apr 20, 2022 at 14:00:52 +0200, Igor Mammedov wrote:
> > On Wed, 20 Apr 2022 12:21:03 +0100
> > Daniel P. Berrangé  wrote:
> >   
> > > On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:  
> > > > On Wed, 20 Apr 2022 13:02:12 +0200
> > > > Peter Krempa  wrote:
> > > > 
> > > > > Few minor changes in qemu since the last update:
> > > > > - PIIX4_PM gained 'x-not-migrate-acpi-index' property
> > > > 
> > > > do you do this for just for every new property?
> > > > (nothing outside of QEMU needs to know about x-not-migrate-acpi-index,
> > > > unless one is interested in whether it works or not)
> > > 
> > > This is simply a record of what QEMU reports when you query properties
> > > for the devices libvirt cares about.  
> > 
> > I was just curious why libvirt does it.
> >   
> > > If nothing outside is supposed to
> > > know about x-not-migrate-acpi-index then QEMU shouldn't tell us about
> > > it when asked for properties :-)  
> > 
> > Does livirt uses/exposes x- prefixed property anywhere?
> > (i.e. can QEMU hide them?)  
> 
> I don't think it's needed to hide them. In fact we have strong rules
> against using them.
> 
> With one notable exception:
> 
> -object memory-backend-file,x-use-canonical-path-for-ramblock-id=
> 
> But this was discussed extensively on the qemu list and qemu pledges
> that this specific property is considered stable.

ok lets leave it as is.



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Daniel P . Berrangé
On Wed, Apr 20, 2022 at 02:00:52PM +0200, Igor Mammedov wrote:
> On Wed, 20 Apr 2022 12:21:03 +0100
> Daniel P. Berrangé  wrote:
> 
> > On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:
> > > On Wed, 20 Apr 2022 13:02:12 +0200
> > > Peter Krempa  wrote:
> > >   
> > > > Few minor changes in qemu since the last update:
> > > > - PIIX4_PM gained 'x-not-migrate-acpi-index' property  
> > > 
> > > do you do this for just for every new property?
> > > (nothing outside of QEMU needs to know about x-not-migrate-acpi-index,
> > > unless one is interested in whether it works or not)  
> > 
> > This is simply a record of what QEMU reports when you query properties
> > for the devices libvirt cares about.
> 
> I was just curious why libvirt does it.
> 
> > If nothing outside is supposed to
> > know about x-not-migrate-acpi-index then QEMU shouldn't tell us about
> > it when asked for properties :-)
> 
> Does livirt uses/exposes x- prefixed property anywhere?
> (i.e. can QEMU hide them?)

No, as a policy libvirt won't touch x- properties from QEMU at all.

Note, these data files are just used for unit tests to validate
certain parts of libvirt rather than require the actual QEMU
binaries to exist during unit tests.


With regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Peter Krempa
On Wed, Apr 20, 2022 at 14:00:52 +0200, Igor Mammedov wrote:
> On Wed, 20 Apr 2022 12:21:03 +0100
> Daniel P. Berrangé  wrote:
> 
> > On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:
> > > On Wed, 20 Apr 2022 13:02:12 +0200
> > > Peter Krempa  wrote:
> > >   
> > > > Few minor changes in qemu since the last update:
> > > > - PIIX4_PM gained 'x-not-migrate-acpi-index' property  
> > > 
> > > do you do this for just for every new property?
> > > (nothing outside of QEMU needs to know about x-not-migrate-acpi-index,
> > > unless one is interested in whether it works or not)  
> > 
> > This is simply a record of what QEMU reports when you query properties
> > for the devices libvirt cares about.
> 
> I was just curious why libvirt does it.
> 
> > If nothing outside is supposed to
> > know about x-not-migrate-acpi-index then QEMU shouldn't tell us about
> > it when asked for properties :-)
> 
> Does livirt uses/exposes x- prefixed property anywhere?
> (i.e. can QEMU hide them?)

I don't think it's needed to hide them. In fact we have strong rules
against using them.

With one notable exception:

-object memory-backend-file,x-use-canonical-path-for-ramblock-id=

But this was discussed extensively on the qemu list and qemu pledges
that this specific property is considered stable.



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Igor Mammedov
On Wed, 20 Apr 2022 12:21:03 +0100
Daniel P. Berrangé  wrote:

> On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:
> > On Wed, 20 Apr 2022 13:02:12 +0200
> > Peter Krempa  wrote:
> >   
> > > Few minor changes in qemu since the last update:
> > > - PIIX4_PM gained 'x-not-migrate-acpi-index' property  
> > 
> > do you do this for just for every new property?
> > (nothing outside of QEMU needs to know about x-not-migrate-acpi-index,
> > unless one is interested in whether it works or not)  
> 
> This is simply a record of what QEMU reports when you query properties
> for the devices libvirt cares about.

I was just curious why libvirt does it.

> If nothing outside is supposed to
> know about x-not-migrate-acpi-index then QEMU shouldn't tell us about
> it when asked for properties :-)

Does livirt uses/exposes x- prefixed property anywhere?
(i.e. can QEMU hide them?)
 
> With regards,
> Daniel



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Peter Krempa
On Wed, Apr 20, 2022 at 16:52:14 +0530, Ani Sinha wrote:
> On Wed, Apr 20, 2022 at 4:46 PM Igor Mammedov  wrote:
> >
> > On Wed, 20 Apr 2022 13:02:12 +0200
> > Peter Krempa  wrote:
> >
> > > Few minor changes in qemu since the last update:
> > > - PIIX4_PM gained 'x-not-migrate-acpi-index' property
> >
> > do you do this for just for every new property?
> > (nothing outside of QEMU needs to know about x-not-migrate-acpi-index,
> > unless one is interested in whether it works or not)
> 
> Any new property that is prefixed with "x-" should not be exposed
> through libvirt. They are experimental, unstable and can change any
> time in the future.

We don't expose it. I'm just simply noting what changed between the caps
dumps. Since the difference between rc2 and GA hadn't much to happen I
also noted this.



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Peter Krempa
On Wed, Apr 20, 2022 at 13:15:43 +0200, Igor Mammedov wrote:
> On Wed, 20 Apr 2022 13:02:12 +0200
> Peter Krempa  wrote:
> 
> > Few minor changes in qemu since the last update:
> > - PIIX4_PM gained 'x-not-migrate-acpi-index' property
> 
> do you do this for just for every new property?
> (nothing outside of QEMU needs to know about x-not-migrate-acpi-index,
> unless one is interested in whether it works or not)

I generally go through the diff of things that change and note what's
changed. In most cases it's just the interesting stuff, but between rc2
and GA there wasn't much interesting going on.



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Ani Sinha
On Wed, Apr 20, 2022 at 4:46 PM Igor Mammedov  wrote:
>
> On Wed, 20 Apr 2022 13:02:12 +0200
> Peter Krempa  wrote:
>
> > Few minor changes in qemu since the last update:
> > - PIIX4_PM gained 'x-not-migrate-acpi-index' property
>
> do you do this for just for every new property?
> (nothing outside of QEMU needs to know about x-not-migrate-acpi-index,
> unless one is interested in whether it works or not)

Any new property that is prefixed with "x-" should not be exposed
through libvirt. They are experimental, unstable and can change any
time in the future.

>
> > - 'cocoa' display and corresponding props (not present in this build)
> >
> > Changes in build:
> > - dbus display driver re-enabled
> > - gtk display support re-disabled
> > - xen support re-disabled
> >
> > Signed-off-by: Peter Krempa 
> > ---
> >  .../caps_7.0.0.x86_64.replies | 583 --
> >  .../caps_7.0.0.x86_64.xml |  10 +-
> >  2 files changed, 257 insertions(+), 336 deletions(-)
> >
> > diff --git a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies 
> > b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies
> > index d1f453dcca..620442704a 100644
> > --- a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies
> > +++ b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies
> > @@ -17,11 +17,11 @@
> >  {
> >"return": {
> >  "qemu": {
> > -  "micro": 92,
> > -  "minor": 2,
> > -  "major": 6
> > +  "micro": 0,
> > +  "minor": 0,
> > +  "major": 7
> >  },
> > -"package": "v7.0.0-rc2"
> > +"package": "v7.0.0"
> >},
> >"id": "libvirt-2"
> >  }
> > @@ -5119,10 +5119,6 @@
> >"name": "135",
> >"tag": "type",
> >"variants": [
> > -{
> > -  "case": "gtk",
> > -  "type": "358"
> > -},
> >  {
> >"case": "curses",
> >"type": "360"
> > @@ -5131,6 +5127,10 @@
> >"case": "egl-headless",
> >"type": "361"
> >  },
> > +{
> > +  "case": "dbus",
> > +  "type": "362"
> > +},
> >  {
> >"case": "default",
> >"type": "0"
> > @@ -10498,6 +10498,10 @@
> >"case": "qemu-vdagent",
> >"type": "518"
> >  },
> > +{
> > +  "case": "dbus",
> > +  "type": "519"
> > +},
> >  {
> >"case": "vc",
> >"type": "520"
> > @@ -11756,9 +11760,6 @@
> >  {
> >"name": "none"
> >  },
> > -{
> > -  "name": "gtk"
> > -},
> >  {
> >"name": "sdl"
> >  },
> > @@ -11770,17 +11771,20 @@
> >  },
> >  {
> >"name": "spice-app"
> > +},
> > +{
> > +  "name": "dbus"
> >  }
> >],
> >"meta-type": "enum",
> >"values": [
> >  "default",
> >  "none",
> > -"gtk",
> >  "sdl",
> >  "egl-headless",
> >  "curses",
> > -"spice-app"
> > +"spice-app",
> > +"dbus"
> >]
> >  },
> >  {
> > @@ -16067,6 +16071,9 @@
> >  {
> >"name": "qemu-vdagent"
> >  },
> > +{
> > +  "name": "dbus"
> > +},
> >  {
> >"name": "vc"
> >  },
> > @@ -16097,6 +16104,7 @@
> >  "spicevmc",
> >  "spiceport",
> >  "qemu-vdagent",
> > +"dbus",
> >  "vc",
> >  "ringbuf",
> >  "memory"
> > @@ -16202,6 +16210,16 @@
> >],
> >"meta-type": "object"
> >  },
> > +{
> > +  "name": "519",
> > +  "members": [
> > +{
> > +  "name": "data",
> > +  "type": "618"
> > +}
> > +  ],
> > +  "meta-type": "object"
> > +},
> >  {
> >"name": "520",
> >"members": [
> > @@ -18460,6 +18478,26 @@
> >],
> >"meta-type": "object"
> >  },
> > +{
> > +  "name": "618",
> > +  "members": [
> > +{
> > +  "name": "logfile",
> > +  "default": null,
> > +  "type": "str"
> > +},
> > +{
> > +  "name": "logappend",
> > +  "default": null,
> > +  "type": "bool"
> > +},
> > +{
> > +  "name": "name",
> > +  "type": "str"
> > +}
> > +  ],
> > +  "meta-type": "object"
> > +},
> >  {
> >"name": "619",
> >"members": [
> > @@ -20363,10 +20401,6 @@
> >"name": "acpi-erst",
> >"parent": "pci-device"
> >  },
> > -{
> > -  "name": "virtio-crypto-device",
> > -  "parent": "virtio-device"
> > -},
> >  {
> >"name": "isa-applesmc",
> >"parent": "isa-device"
> > @@ -20379,49 +20413,53 @@
> >"name": "vhost-user-input-pci",
> >"parent": "vhost-user-input-pci-base-type"
> >  },
> > +{
> 

Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Daniel P . Berrangé
On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:
> On Wed, 20 Apr 2022 13:02:12 +0200
> Peter Krempa  wrote:
> 
> > Few minor changes in qemu since the last update:
> > - PIIX4_PM gained 'x-not-migrate-acpi-index' property
> 
> do you do this for just for every new property?
> (nothing outside of QEMU needs to know about x-not-migrate-acpi-index,
> unless one is interested in whether it works or not)

This is simply a record of what QEMU reports when you query properties
for the devices libvirt cares about. If nothing outside is supposed to
know about x-not-migrate-acpi-index then QEMU shouldn't tell us about
it when asked for properties :-)


With regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|



Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Igor Mammedov
On Wed, 20 Apr 2022 13:02:12 +0200
Peter Krempa  wrote:

> Few minor changes in qemu since the last update:
> - PIIX4_PM gained 'x-not-migrate-acpi-index' property

do you do this for just for every new property?
(nothing outside of QEMU needs to know about x-not-migrate-acpi-index,
unless one is interested in whether it works or not)

> - 'cocoa' display and corresponding props (not present in this build)
> 
> Changes in build:
> - dbus display driver re-enabled
> - gtk display support re-disabled
> - xen support re-disabled
> 
> Signed-off-by: Peter Krempa 
> ---
>  .../caps_7.0.0.x86_64.replies | 583 --
>  .../caps_7.0.0.x86_64.xml |  10 +-
>  2 files changed, 257 insertions(+), 336 deletions(-)
> 
> diff --git a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies 
> b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies
> index d1f453dcca..620442704a 100644
> --- a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies
> +++ b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies
> @@ -17,11 +17,11 @@
>  {
>"return": {
>  "qemu": {
> -  "micro": 92,
> -  "minor": 2,
> -  "major": 6
> +  "micro": 0,
> +  "minor": 0,
> +  "major": 7
>  },
> -"package": "v7.0.0-rc2"
> +"package": "v7.0.0"
>},
>"id": "libvirt-2"
>  }
> @@ -5119,10 +5119,6 @@
>"name": "135",
>"tag": "type",
>"variants": [
> -{
> -  "case": "gtk",
> -  "type": "358"
> -},
>  {
>"case": "curses",
>"type": "360"
> @@ -5131,6 +5127,10 @@
>"case": "egl-headless",
>"type": "361"
>  },
> +{
> +  "case": "dbus",
> +  "type": "362"
> +},
>  {
>"case": "default",
>"type": "0"
> @@ -10498,6 +10498,10 @@
>"case": "qemu-vdagent",
>"type": "518"
>  },
> +{
> +  "case": "dbus",
> +  "type": "519"
> +},
>  {
>"case": "vc",
>"type": "520"
> @@ -11756,9 +11760,6 @@
>  {
>"name": "none"
>  },
> -{
> -  "name": "gtk"
> -},
>  {
>"name": "sdl"
>  },
> @@ -11770,17 +11771,20 @@
>  },
>  {
>"name": "spice-app"
> +},
> +{
> +  "name": "dbus"
>  }
>],
>"meta-type": "enum",
>"values": [
>  "default",
>  "none",
> -"gtk",
>  "sdl",
>  "egl-headless",
>  "curses",
> -"spice-app"
> +"spice-app",
> +"dbus"
>]
>  },
>  {
> @@ -16067,6 +16071,9 @@
>  {
>"name": "qemu-vdagent"
>  },
> +{
> +  "name": "dbus"
> +},
>  {
>"name": "vc"
>  },
> @@ -16097,6 +16104,7 @@
>  "spicevmc",
>  "spiceport",
>  "qemu-vdagent",
> +"dbus",
>  "vc",
>  "ringbuf",
>  "memory"
> @@ -16202,6 +16210,16 @@
>],
>"meta-type": "object"
>  },
> +{
> +  "name": "519",
> +  "members": [
> +{
> +  "name": "data",
> +  "type": "618"
> +}
> +  ],
> +  "meta-type": "object"
> +},
>  {
>"name": "520",
>"members": [
> @@ -18460,6 +18478,26 @@
>],
>"meta-type": "object"
>  },
> +{
> +  "name": "618",
> +  "members": [
> +{
> +  "name": "logfile",
> +  "default": null,
> +  "type": "str"
> +},
> +{
> +  "name": "logappend",
> +  "default": null,
> +  "type": "bool"
> +},
> +{
> +  "name": "name",
> +  "type": "str"
> +}
> +  ],
> +  "meta-type": "object"
> +},
>  {
>"name": "619",
>"members": [
> @@ -20363,10 +20401,6 @@
>"name": "acpi-erst",
>"parent": "pci-device"
>  },
> -{
> -  "name": "virtio-crypto-device",
> -  "parent": "virtio-device"
> -},
>  {
>"name": "isa-applesmc",
>"parent": "isa-device"
> @@ -20379,49 +20413,53 @@
>"name": "vhost-user-input-pci",
>"parent": "vhost-user-input-pci-base-type"
>  },
> +{
> +  "name": "usb-redir",
> +  "parent": "usb-device"
> +},
>  {
>"name": "floppy-bus",
>"parent": "bus"
>  },
>  {
> -  "name": "Denverton-x86_64-cpu",
> -  "parent": "x86_64-cpu"
> +  "name": "virtio-crypto-device",
> +  "parent": "virtio-device"
>  },
>  {
>"name": "chardev-testdev",
>"parent": "chardev"
>  },
>  {
> -  "name": "usb-wacom-tablet",
> -  "parent": "usb-device"
> +  "name": "Denverton-x86_64-cpu",
> +  "parent": "x86_64-cpu"
>  },
>  {
> -  

[PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Peter Krempa
Few minor changes in qemu since the last update:
- PIIX4_PM gained 'x-not-migrate-acpi-index' property
- 'cocoa' display and corresponding props (not present in this build)

Changes in build:
- dbus display driver re-enabled
- gtk display support re-disabled
- xen support re-disabled

Signed-off-by: Peter Krempa 
---
 .../caps_7.0.0.x86_64.replies | 583 --
 .../caps_7.0.0.x86_64.xml |  10 +-
 2 files changed, 257 insertions(+), 336 deletions(-)

diff --git a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies 
b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies
index d1f453dcca..620442704a 100644
--- a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies
+++ b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies
@@ -17,11 +17,11 @@
 {
   "return": {
 "qemu": {
-  "micro": 92,
-  "minor": 2,
-  "major": 6
+  "micro": 0,
+  "minor": 0,
+  "major": 7
 },
-"package": "v7.0.0-rc2"
+"package": "v7.0.0"
   },
   "id": "libvirt-2"
 }
@@ -5119,10 +5119,6 @@
   "name": "135",
   "tag": "type",
   "variants": [
-{
-  "case": "gtk",
-  "type": "358"
-},
 {
   "case": "curses",
   "type": "360"
@@ -5131,6 +5127,10 @@
   "case": "egl-headless",
   "type": "361"
 },
+{
+  "case": "dbus",
+  "type": "362"
+},
 {
   "case": "default",
   "type": "0"
@@ -10498,6 +10498,10 @@
   "case": "qemu-vdagent",
   "type": "518"
 },
+{
+  "case": "dbus",
+  "type": "519"
+},
 {
   "case": "vc",
   "type": "520"
@@ -11756,9 +11760,6 @@
 {
   "name": "none"
 },
-{
-  "name": "gtk"
-},
 {
   "name": "sdl"
 },
@@ -11770,17 +11771,20 @@
 },
 {
   "name": "spice-app"
+},
+{
+  "name": "dbus"
 }
   ],
   "meta-type": "enum",
   "values": [
 "default",
 "none",
-"gtk",
 "sdl",
 "egl-headless",
 "curses",
-"spice-app"
+"spice-app",
+"dbus"
   ]
 },
 {
@@ -16067,6 +16071,9 @@
 {
   "name": "qemu-vdagent"
 },
+{
+  "name": "dbus"
+},
 {
   "name": "vc"
 },
@@ -16097,6 +16104,7 @@
 "spicevmc",
 "spiceport",
 "qemu-vdagent",
+"dbus",
 "vc",
 "ringbuf",
 "memory"
@@ -16202,6 +16210,16 @@
   ],
   "meta-type": "object"
 },
+{
+  "name": "519",
+  "members": [
+{
+  "name": "data",
+  "type": "618"
+}
+  ],
+  "meta-type": "object"
+},
 {
   "name": "520",
   "members": [
@@ -18460,6 +18478,26 @@
   ],
   "meta-type": "object"
 },
+{
+  "name": "618",
+  "members": [
+{
+  "name": "logfile",
+  "default": null,
+  "type": "str"
+},
+{
+  "name": "logappend",
+  "default": null,
+  "type": "bool"
+},
+{
+  "name": "name",
+  "type": "str"
+}
+  ],
+  "meta-type": "object"
+},
 {
   "name": "619",
   "members": [
@@ -20363,10 +20401,6 @@
   "name": "acpi-erst",
   "parent": "pci-device"
 },
-{
-  "name": "virtio-crypto-device",
-  "parent": "virtio-device"
-},
 {
   "name": "isa-applesmc",
   "parent": "isa-device"
@@ -20379,49 +20413,53 @@
   "name": "vhost-user-input-pci",
   "parent": "vhost-user-input-pci-base-type"
 },
+{
+  "name": "usb-redir",
+  "parent": "usb-device"
+},
 {
   "name": "floppy-bus",
   "parent": "bus"
 },
 {
-  "name": "Denverton-x86_64-cpu",
-  "parent": "x86_64-cpu"
+  "name": "virtio-crypto-device",
+  "parent": "virtio-device"
 },
 {
   "name": "chardev-testdev",
   "parent": "chardev"
 },
 {
-  "name": "usb-wacom-tablet",
-  "parent": "usb-device"
+  "name": "Denverton-x86_64-cpu",
+  "parent": "x86_64-cpu"
 },
 {
-  "name": "Icelake-Server-v1-x86_64-cpu",
-  "parent": "x86_64-cpu"
+  "name": "pci-ipmi-bt",
+  "parent": "pci-device"
 },
 {
   "name": "chardev-stdio",
   "parent": "chardev-fd"
 },
 {
-  "name": "pci-ipmi-bt",
-  "parent": "pci-device"
+  "name": "usb-wacom-tablet",
+  "parent": "usb-device"
 },
 {
   "name": "filter-buffer",
   "parent": "netfilter"
 },
 {
-  "name": "secondary-vga",
-  "parent": "pci-vga"
+  "name": "Icelake-Server-v1-x86_64-cpu",
+  "parent": "x86_64-cpu"
 },
 {
   "name": "ich9-usb-uhci6",
   "parent":