Re: [PATCH 1/2] rpm: Simplify expression of supported platforms

[Jiri Denemark]

On Thu, Jan 07, 2021 at 09:58:08 -0500, Neal Gompa wrote:
> Stanzas like "0%{?fedora} && 0%{?fedora} >= %{min_fedora}" contain
> redundant definitions, as "0%{?fedora} >= %{min_fedora}" implies that
> "%fedora" is defined and has a value. Thus, we can simplify this.
> 
> Signed-off-by: Neal Gompa 
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index ce1a8d7078..0a8b0ebad4 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -6,7 +6,7 @@
>  %define min_rhel 7
>  %define min_fedora 31
>  
> -%if (0%{?fedora} && 0%{?fedora} >= %{min_fedora}) || (0%{?rhel} && 0%{?rhel} 
> >= %{min_rhel})
> +%if 0%{?fedora} >= %{min_fedora} || 0%{?rhel} >= %{min_rhel}
>  %define supported_platform 1
>  %else
>  %define supported_platform 0

Reviewed-by: Jiri Denemark 

[PATCH 1/2] rpm: Simplify expression of supported platforms

[Neal Gompa]

Stanzas like "0%{?fedora} && 0%{?fedora} >= %{min_fedora}" contain
redundant definitions, as "0%{?fedora} >= %{min_fedora}" implies that
"%fedora" is defined and has a value. Thus, we can simplify this.

Signed-off-by: Neal Gompa 
---
 libvirt.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index ce1a8d7078..0a8b0ebad4 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -6,7 +6,7 @@
 %define min_rhel 7
 %define min_fedora 31
 
-%if (0%{?fedora} && 0%{?fedora} >= %{min_fedora}) || (0%{?rhel} && 0%{?rhel} 
>= %{min_rhel})
+%if 0%{?fedora} >= %{min_fedora} || 0%{?rhel} >= %{min_rhel}
 %define supported_platform 1
 %else
 %define supported_platform 0
-- 
2.29.2