Re: [PATCH 1/3] qemuxml2(argv|xml)data: x86-kvm-32-on-64: Add machine type

2022-01-14 Thread Ján Tomko 

On a Friday in 2022, Peter Krempa wrote:

The machine type doesn't change the test result and prevents tests being
changed every time we are about to update real capabilities to a new
qemu.

Signed-off-by: Peter Krempa 
---


You should've truncated this patch too, for consistency ;)

Jano


tests/qemuxml2argvdata/x86-kvm-32-on-64.x86_64-latest.args  | 2 +-
tests/qemuxml2argvdata/x86-kvm-32-on-64.xml | 2 +-
tests/qemuxml2xmloutdata/x86-kvm-32-on-64.x86_64-latest.xml | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)


signature.asc
Description: PGP signature

[PATCH 1/3] qemuxml2(argv|xml)data: x86-kvm-32-on-64: Add machine type

2022-01-14 Thread Peter Krempa 
The machine type doesn't change the test result and prevents tests being
changed every time we are about to update real capabilities to a new
qemu.

Signed-off-by: Peter Krempa 
---
 tests/qemuxml2argvdata/x86-kvm-32-on-64.x86_64-latest.args  | 2 +-
 tests/qemuxml2argvdata/x86-kvm-32-on-64.xml | 2 +-
 tests/qemuxml2xmloutdata/x86-kvm-32-on-64.x86_64-latest.xml | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/qemuxml2argvdata/x86-kvm-32-on-64.x86_64-latest.args 
b/tests/qemuxml2argvdata/x86-kvm-32-on-64.x86_64-latest.args
index fe326b6943..cfe1abab60 100644
--- a/tests/qemuxml2argvdata/x86-kvm-32-on-64.x86_64-latest.args
+++ b/tests/qemuxml2argvdata/x86-kvm-32-on-64.x86_64-latest.args
@@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/tmp/lib/domain--1-kvm/.config \
 -name guest=kvm,debug-threads=on \
 -S \
 -object 
'{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/tmp/lib/domain--1-kvm/master-key.aes"}'
 \
--machine pc-i440fx-6.2,usb=off,dump-guest-core=off,memory-backend=pc.ram \
+-machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram \
 -accel kvm \
 -cpu qemu64 \
 -m 4096 \
diff --git a/tests/qemuxml2argvdata/x86-kvm-32-on-64.xml 
b/tests/qemuxml2argvdata/x86-kvm-32-on-64.xml
index 37f53bf2af..35ddbd0630 100644
--- a/tests/qemuxml2argvdata/x86-kvm-32-on-64.xml
+++ b/tests/qemuxml2argvdata/x86-kvm-32-on-64.xml
@@ -3,7 +3,7 @@
   d091ea82-29e6-2e34-3005-f02617b36e87
   4194304
   
-hvm
+hvm
   
   
 /usr/bin/qemu-system-x86_64
diff --git a/tests/qemuxml2xmloutdata/x86-kvm-32-on-64.x86_64-latest.xml 
b/tests/qemuxml2xmloutdata/x86-kvm-32-on-64.x86_64-latest.xml
index b51fb18788..c5e9c4fe22 100644
--- a/tests/qemuxml2xmloutdata/x86-kvm-32-on-64.x86_64-latest.xml
+++ b/tests/qemuxml2xmloutdata/x86-kvm-32-on-64.x86_64-latest.xml
@@ -5,7 +5,7 @@
   4194304
   1
   
-hvm
+hvm
 
   
   
-- 
2.34.1