Re: [PATCH 10/10] virDomainSetBlockThreshold: Mention that the event can be registered for

2020-07-20 Thread Eric Blake

On 7/15/20 8:10 AM, Peter Krempa wrote:

The infrastructure supports setting the threshold also for the .
Mention it in the docs.

https://bugzilla.redhat.com/show_bug.cgi?id=1807741

Signed-off-by: Peter Krempa 
---
  src/libvirt-domain.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 6c5ff5b0db..a4e73d5480 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -12381,6 +12381,9 @@ int virDomainGetGuestInfo(virDomainPtr domain,
   * live VM XML for 'backingStore' or 'source' elements of a disk. If index is
   * given the threshold is set for the corresponding image.
   *
+ * Note that the threshold event can be registered also for destinations of a
+ * 'virDomainBlockCopy' destination by using the 'index' of the 'mirror' 
source.
+ *
   * Hypervisors report the last written sector of an image in the bulk stats 
API


Reviewed-by: Eric Blake 


   * (virConnectGetAllDomainStats/virDomainListGetStats) as
   * "block..allocation" in the VIR_DOMAIN_STATS_BLOCK group. The current



--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



[PATCH 10/10] virDomainSetBlockThreshold: Mention that the event can be registered for

2020-07-15 Thread Peter Krempa
The infrastructure supports setting the threshold also for the .
Mention it in the docs.

https://bugzilla.redhat.com/show_bug.cgi?id=1807741

Signed-off-by: Peter Krempa 
---
 src/libvirt-domain.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 6c5ff5b0db..a4e73d5480 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -12381,6 +12381,9 @@ int virDomainGetGuestInfo(virDomainPtr domain,
  * live VM XML for 'backingStore' or 'source' elements of a disk. If index is
  * given the threshold is set for the corresponding image.
  *
+ * Note that the threshold event can be registered also for destinations of a
+ * 'virDomainBlockCopy' destination by using the 'index' of the 'mirror' 
source.
+ *
  * Hypervisors report the last written sector of an image in the bulk stats API
  * (virConnectGetAllDomainStats/virDomainListGetStats) as
  * "block..allocation" in the VIR_DOMAIN_STATS_BLOCK group. The current
-- 
2.26.2