Re: [PATCH 11/23] test driver: remove iotune max checks

[Peter Krempa]

On Mon, Jan 11, 2021 at 12:50:04 +0300, Nikolay Shirokovskiy wrote:
> These checks are now in the above call to virDomainBlockIoTuneValidate.
> 
> Signed-off-by: Nikolay Shirokovskiy 
> ---
>  src/test/test_driver.c | 19 ---
>  1 file changed, 19 deletions(-)

Under same conditions as on 10/23:

Reviewed-by: Peter Krempa 

[PATCH 11/23] test driver: remove iotune max checks

[Nikolay Shirokovskiy]

These checks are now in the above call to virDomainBlockIoTuneValidate.

Signed-off-by: Nikolay Shirokovskiy 
---
 src/test/test_driver.c | 19 ---
 1 file changed, 19 deletions(-)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 4eb04d6..299be2a 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -3783,25 +3783,6 @@ testDomainSetBlockIoTune(virDomainPtr dom,
 if (virDomainBlockIoTuneValidate() < 0)
 goto cleanup;
 
-#define TEST_BLOCK_IOTUNE_MAX_CHECK(FIELD, FIELD_MAX) \
-do { \
-if (info.FIELD > info.FIELD_MAX) { \
-virReportError(VIR_ERR_INVALID_ARG, \
-   _("%s cannot be set higher than %s "), \
- #FIELD, #FIELD_MAX); \
-goto cleanup; \
-} \
-} while (0);
-
-TEST_BLOCK_IOTUNE_MAX_CHECK(total_bytes_sec, total_bytes_sec_max);
-TEST_BLOCK_IOTUNE_MAX_CHECK(read_bytes_sec, read_bytes_sec_max);
-TEST_BLOCK_IOTUNE_MAX_CHECK(write_bytes_sec, write_bytes_sec_max);
-TEST_BLOCK_IOTUNE_MAX_CHECK(total_iops_sec, total_iops_sec_max);
-TEST_BLOCK_IOTUNE_MAX_CHECK(read_iops_sec, read_iops_sec_max);
-TEST_BLOCK_IOTUNE_MAX_CHECK(write_iops_sec, write_iops_sec_max);
-
-#undef TEST_BLOCK_IOTUNE_MAX_CHECK
-
 virDomainDiskSetBlockIOTune(conf_disk, );
 info.group_name = NULL;
 
-- 
1.8.3.1