Re: [PATCH 12/18] qemumonitorjsontest: Drop 'schema-meta' case

2023-06-02 Thread Ján Tomko

On a Thursday in 2023, Peter Krempa wrote:

The test case is validating the QMP schema against itself. This was
useful when I was developing the validator but at this point it's no
longer needed.

Additionally the QMP schema has few deprecated members now, which our
validator doesn't catch yet, so this test would start failing once I fix
the validator.

Signed-off-by: Peter Krempa 
---
tests/qemumonitorjsontest.c | 13 -
1 file changed, 13 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature


[PATCH 12/18] qemumonitorjsontest: Drop 'schema-meta' case

2023-05-25 Thread Peter Krempa
The test case is validating the QMP schema against itself. This was
useful when I was developing the validator but at this point it's no
longer needed.

Additionally the QMP schema has few deprecated members now, which our
validator doesn't catch yet, so this test would start failing once I fix
the validator.

Signed-off-by: Peter Krempa 
---
 tests/qemumonitorjsontest.c | 13 -
 1 file changed, 13 deletions(-)

diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index d9323d94c3..c3963050de 100644
--- a/tests/qemumonitorjsontest.c
+++ b/tests/qemumonitorjsontest.c
@@ -2825,8 +2825,6 @@ mymain(void)
 g_autoptr(GHashTable) qapischema_x86_64 = NULL;
 g_autoptr(GHashTable) qapischema_s390x = NULL;
 struct testQAPISchemaData qapiData;
-g_autoptr(virJSONValue) metaschema = NULL;
-g_autofree char *metaschemastr = NULL;

 if (qemuTestDriverInit(&driver) < 0)
 return EXIT_FAILURE;
@@ -3047,17 +3045,6 @@ mymain(void)
 DO_TEST_QAPI_VALIDATE("alternate 2", "blockdev-add/arg-type", false,
   "{\"driver\":\"qcow2\",\"file\": 1234}");

-if (!(metaschema = testQEMUSchemaGetLatest("x86_64")) ||
-!(metaschemastr = virJSONValueToString(metaschema, false))) {
-VIR_TEST_VERBOSE("failed to load latest qapi schema");
-ret = -1;
-goto cleanup;
-}
-
-DO_TEST_QAPI_VALIDATE("schema-meta", "query-qmp-schema/ret-type", true,
-metaschemastr);
-
-
 #undef DO_TEST_QAPI_VALIDATE

 if (virTestRun("validate that object-add and device_add don't have schema",
-- 
2.40.1