Re: [PATCH 3/3] NEWS: Add the stats VIR_DOMAIN_STATS_VM of virConnectGetAllDomainStats

2022-11-01 Thread Peter Krempa
On Tue, Nov 01, 2022 at 13:49:12 +0800, Han Han wrote:
> Signed-off-by: Han Han 
> ---
>  NEWS.rst | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index 7b856f4d3f..06fd4fa84f 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -41,6 +41,12 @@ v8.9.0 (unreleased)
>  
>  * **Improvements**
>  
> +  * qemu: Add the stats of VM for virConnectGetAllDomainStats
> +
> +The stats ``VIR_DOMAIN_STATS_VM`` of virConnectGetAllDomainStats is to
> +get the fd-based KVM statistics for the target VM. It could be used by
> +the command line ``virsh domstats --vm``
> +

I'll word this as:

+  * qemu: Add hypervisor-specific statistics to ``virConnectGetAllDomainStats``
+
+The new stats group ``VIR_DOMAIN_STATS_VM`` of
+``virConnectGetAllDomainStats``, also exposed as ``virsh domstats --vm``,
+returns hypervisor-specific stats fields for given VM.
+

once my patch adding the docs for the new group is applied.



Re: [PATCH 3/3] NEWS: Add the stats VIR_DOMAIN_STATS_VM of virConnectGetAllDomainStats

2022-11-01 Thread Peter Krempa
On Tue, Nov 01, 2022 at 13:49:12 +0800, Han Han wrote:
> Signed-off-by: Han Han 
> ---
>  NEWS.rst | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index 7b856f4d3f..06fd4fa84f 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -41,6 +41,12 @@ v8.9.0 (unreleased)
>  
>  * **Improvements**
>  
> +  * qemu: Add the stats of VM for virConnectGetAllDomainStats
> +
> +The stats ``VIR_DOMAIN_STATS_VM`` of virConnectGetAllDomainStats is to
> +get the fd-based KVM statistics for the target VM. It could be used by
> +the command line ``virsh domstats --vm``

The stats reported in this group are totally undocumented. It doesn't
make much sense until that is addressed to advertise it's presence as
users simply won't be able to use them properly.

I'll see whether adding docs before the release is feasible or not.

In the meanwhile I'll push the 1/3 and 2/3



[PATCH 3/3] NEWS: Add the stats VIR_DOMAIN_STATS_VM of virConnectGetAllDomainStats

2022-10-31 Thread Han Han
Signed-off-by: Han Han 
---
 NEWS.rst | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index 7b856f4d3f..06fd4fa84f 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -41,6 +41,12 @@ v8.9.0 (unreleased)
 
 * **Improvements**
 
+  * qemu: Add the stats of VM for virConnectGetAllDomainStats
+
+The stats ``VIR_DOMAIN_STATS_VM`` of virConnectGetAllDomainStats is to
+get the fd-based KVM statistics for the target VM. It could be used by
+the command line ``virsh domstats --vm``
+
   * Add ``vendor`` attribute for CPU models in domain capabilities
 
 Users can now see the vendor of each CPU model in domain capabilities and
-- 
2.38.1