Re: [PATCH v2 06/29] qemu_validate.c: enhance 'machine type not supported' message

[Ján Tomko]

On a Tuesday in 2022, Daniel Henrique Barboza wrote:

Add 'virt type' to allow for an easier time debugging.

Reviewed-by: Peter Krempa 
Signed-off-by: Daniel Henrique Barboza 
---
src/qemu/qemu_validate.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature

[PATCH v2 06/29] qemu_validate.c: enhance 'machine type not supported' message

[Daniel Henrique Barboza]

Add 'virt type' to allow for an easier time debugging.

Reviewed-by: Peter Krempa 
Signed-off-by: Daniel Henrique Barboza 
---
 src/qemu/qemu_validate.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 8453413b3c..aa686246f5 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -1101,8 +1101,9 @@ qemuValidateDomainDef(const virDomainDef *def,
 
 if (!virQEMUCapsIsMachineSupported(qemuCaps, def->virtType, 
def->os.machine)) {
 virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-   _("Emulator '%s' does not support machine type '%s'"),
-   def->emulator, def->os.machine);
+   _("Emulator '%s' does not support machine type '%s' for 
virt type '%s'"),
+   def->emulator, def->os.machine,
+   virDomainVirtTypeToString(def->virtType));
 return -1;
 }
 
-- 
2.34.1