Re: [PATCH v3 09/30] docstring: macros: admin: Add 'Since version' metadata

2022-04-21 Thread Victor Toso
Hi,

On Thu, Apr 21, 2022 at 03:14:05PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:58 +0200, Victor Toso wrote:
> > Either create or append to existing docstring, the version (git tag)
> > that a given macro was introduced in the format:
> > 
> > Since: v1.2.3
> > 
> > Signed-off-by: Victor Toso 
> > ---
> >  include/libvirt/libvirt-admin.h | 60 +
> >  1 file changed, 60 insertions(+)
> 
> Same comment as with the enum definition patch. I'll hold off pushing
> this for a while.
> 
> Reviewed-by: Peter Krempa 

All of them are 1.3.4 or 1.3.5 but I'll move to 2.0.0 as it was
the first public version with it.

Got it. I'll fix it.

Cheers,
Victor


signature.asc
Description: PGP signature


Re: [PATCH v3 09/30] docstring: macros: admin: Add 'Since version' metadata

2022-04-21 Thread Peter Krempa
On Wed, Apr 20, 2022 at 21:07:58 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given macro was introduced in the format:
> 
> Since: v1.2.3
> 
> Signed-off-by: Victor Toso 
> ---
>  include/libvirt/libvirt-admin.h | 60 +
>  1 file changed, 60 insertions(+)

Same comment as with the enum definition patch. I'll hold off pushing
this for a while.

Reviewed-by: Peter Krempa 



[PATCH v3 09/30] docstring: macros: admin: Add 'Since version' metadata

2022-04-20 Thread Victor Toso
Either create or append to existing docstring, the version (git tag)
that a given macro was introduced in the format:

Since: v1.2.3

Signed-off-by: Victor Toso 
---
 include/libvirt/libvirt-admin.h | 60 +
 1 file changed, 60 insertions(+)

diff --git a/include/libvirt/libvirt-admin.h b/include/libvirt/libvirt-admin.h
index f65886f20d..defca505f8 100644
--- a/include/libvirt/libvirt-admin.h
+++ b/include/libvirt/libvirt-admin.h
@@ -132,6 +132,9 @@ virAdmServerPtr virAdmConnectLookupServer(virAdmConnectPtr 
conn,
  * VIR_THREADPOOL_WORKERS_MIN:
  * Macro for the threadpool minWorkers limit: represents the bottom limit to
  * number of active workers in threadpool, as VIR_TYPED_PARAM_UINT.
+ *
+ * Since: v1.3.4
+ *
  */
 
 # define VIR_THREADPOOL_WORKERS_MIN "minWorkers"
@@ -142,6 +145,9 @@ virAdmServerPtr virAdmConnectLookupServer(virAdmConnectPtr 
conn,
  * number of active workers in threadpool, as VIR_TYPED_PARAM_UINT.
  * The value of this limit has to be greater than VIR_THREADPOOL_WORKERS_MIN
  * at all times.
+ *
+ * Since: v1.3.4
+ *
  */
 
 # define VIR_THREADPOOL_WORKERS_MAX "maxWorkers"
@@ -150,6 +156,9 @@ virAdmServerPtr virAdmConnectLookupServer(virAdmConnectPtr 
conn,
  * VIR_THREADPOOL_WORKERS_PRIORITY:
  * Macro for the threadpool nPrioWorkers attribute: represents the current 
number
  * of active priority workers in threadpool, as VIR_TYPED_PARAM_UINT.
+ *
+ * Since: v1.3.4
+ *
  */
 
 # define VIR_THREADPOOL_WORKERS_PRIORITY "prioWorkers"
@@ -161,6 +170,9 @@ virAdmServerPtr virAdmConnectLookupServer(virAdmConnectPtr 
conn,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.4
+ *
  */
 
 # define VIR_THREADPOOL_WORKERS_FREE "freeWorkers"
@@ -172,6 +184,9 @@ virAdmServerPtr virAdmConnectLookupServer(virAdmConnectPtr 
conn,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.4
+ *
  */
 
 # define VIR_THREADPOOL_WORKERS_CURRENT "nWorkers"
@@ -183,6 +198,9 @@ virAdmServerPtr virAdmConnectLookupServer(virAdmConnectPtr 
conn,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.4
+ *
  */
 
 # define VIR_THREADPOOL_JOB_QUEUE_DEPTH "jobQueueDepth"
@@ -233,6 +251,9 @@ virAdmServerLookupClient(virAdmServerPtr srv,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.5
+ *
  */
 
 # define VIR_CLIENT_INFO_READONLY "readonly"
@@ -244,6 +265,9 @@ virAdmServerLookupClient(virAdmServerPtr srv,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.5
+ *
  */
 
 # define VIR_CLIENT_INFO_SOCKET_ADDR "sock_addr"
@@ -255,6 +279,9 @@ virAdmServerLookupClient(virAdmServerPtr srv,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.5
+ *
  */
 
 # define VIR_CLIENT_INFO_SASL_USER_NAME "sasl_user_name"
@@ -267,6 +294,9 @@ virAdmServerLookupClient(virAdmServerPtr srv,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.5
+ *
  */
 
 # define VIR_CLIENT_INFO_X509_DISTINGUISHED_NAME "tls_x509_dname"
@@ -279,6 +309,9 @@ virAdmServerLookupClient(virAdmServerPtr srv,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.5
+ *
  */
 
 # define VIR_CLIENT_INFO_UNIX_USER_ID "unix_user_id"
@@ -291,6 +324,9 @@ virAdmServerLookupClient(virAdmServerPtr srv,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.5
+ *
  */
 
 # define VIR_CLIENT_INFO_UNIX_USER_NAME "unix_user_name"
@@ -303,6 +339,9 @@ virAdmServerLookupClient(virAdmServerPtr srv,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.5
+ *
  */
 
 # define VIR_CLIENT_INFO_UNIX_GROUP_ID "unix_group_id"
@@ -315,6 +354,9 @@ virAdmServerLookupClient(virAdmServerPtr srv,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.5
+ *
  */
 
 # define VIR_CLIENT_INFO_UNIX_GROUP_NAME "unix_group_name"
@@ -327,6 +369,9 @@ virAdmServerLookupClient(virAdmServerPtr srv,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.5
+ *
  */
 
 # define VIR_CLIENT_INFO_UNIX_PROCESS_ID "unix_process_id"
@@ -339,6 +384,9 @@ virAdmServerLookupClient(virAdmServerPtr srv,
  *
  * NOTE: This attribute is read-only and any attempt to set it will be denied
  * by daemon
+ *
+ * Since: v1.3.5
+ *
  */
 
 # define VIR_CLIENT_INFO_SELINUX_CONTEXT "selinux_context"
@@ -356,6 +404,9 @@ int virAdmClientClose(virAdmClientPtr client, unsigned int 
flags);
  * VIR_SERVER_CLIENTS_MAX:
  * Macro for per-server