Re: [PATCH v3 14/30] docstring: function: qemu: Add 'Since version' metadata

2022-04-21 Thread Peter Krempa
On Wed, Apr 20, 2022 at 21:08:03 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given function was introduced in the format:
> 
> Since: v1.2.3
> 
> Signed-off-by: Victor Toso 
> ---
>  include/libvirt/libvirt-qemu.h |  3 +++
>  src/libvirt-qemu.c | 18 ++
>  2 files changed, 21 insertions(+)

Reviewed-by: Peter Krempa 



[PATCH v3 14/30] docstring: function: qemu: Add 'Since version' metadata

2022-04-20 Thread Victor Toso
Either create or append to existing docstring, the version (git tag)
that a given function was introduced in the format:

Since: v1.2.3

Signed-off-by: Victor Toso 
---
 include/libvirt/libvirt-qemu.h |  3 +++
 src/libvirt-qemu.c | 18 ++
 2 files changed, 21 insertions(+)

diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h
index 9697b54158..fb422a3a21 100644
--- a/include/libvirt/libvirt-qemu.h
+++ b/include/libvirt/libvirt-qemu.h
@@ -86,6 +86,9 @@ char *virDomainQemuAgentCommand(virDomainPtr domain, const 
char *cmd,
  *
  * The callback signature to use when registering for a qemu monitor
  * event with virConnectDomainQemuMonitorEventRegister().
+ *
+ * Since: v1.2.3
+ *
  */
 typedef void (*virConnectDomainQemuMonitorEventCallback)(virConnectPtr conn,
  virDomainPtr dom,
diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c
index 896aba2f0b..b80cd2b7ff 100644
--- a/src/libvirt-qemu.c
+++ b/src/libvirt-qemu.c
@@ -61,6 +61,9 @@ VIR_LOG_INIT("libvirt-qemu");
  *
  * Returns 0 in case of success, -1 in case of failure
  *
+ * Since: v0.8.3
+ *
+ *
  */
 int
 virDomainQemuMonitorCommand(virDomainPtr domain, const char *cmd,
@@ -131,6 +134,9 @@ virDomainQemuMonitorCommand(virDomainPtr domain, const char 
*cmd,
  * @cmd, and the caller must free this string.
  *
  * Returns 0 in case of success, -1 in case of failure
+ *
+ * Since: v8.2.0
+ *
  */
 int
 virDomainQemuMonitorCommandWithFiles(virDomainPtr domain,
@@ -216,6 +222,9 @@ virDomainQemuMonitorCommandWithFiles(virDomainPtr domain,
  * normally (provided the above requirements were honored).
  *
  * Returns a new domain object on success, NULL otherwise
+ *
+ * Since: v0.9.4
+ *
  */
 virDomainPtr
 virDomainQemuAttach(virConnectPtr conn,
@@ -272,6 +281,9 @@ virDomainQemuAttach(virConnectPtr conn,
  * positive value: wait for @timeout seconds
  *
  * Returns strings if success, NULL in failure.
+ *
+ * Since: v0.10.0
+ *
  */
 char *
 virDomainQemuAgentCommand(virDomainPtr domain,
@@ -350,6 +362,9 @@ virDomainQemuAgentCommand(virDomainPtr domain,
  * be passed to the virConnectDomainQemuMonitorEventDeregister() method.
  *
  * Returns a callback identifier on success, -1 on failure
+ *
+ * Since: v1.2.3
+ *
  */
 int
 virConnectDomainQemuMonitorEventRegister(virConnectPtr conn,
@@ -404,6 +419,9 @@ virConnectDomainQemuMonitorEventRegister(virConnectPtr conn,
  * method.
  *
  * Returns 0 on success, -1 on failure
+ *
+ * Since: v1.2.3
+ *
  */
 int
 virConnectDomainQemuMonitorEventDeregister(virConnectPtr conn,
-- 
2.35.1