Re: [libvirt] [PATCH] Fix common misspellings
On 03/23/2015 04:46 AM, Martin Kletzander wrote: > On Fri, Mar 20, 2015 at 09:51:23AM -0600, Eric Blake wrote: >> On 03/20/2015 06:21 AM, Martin Kletzander wrote: +++ >> b/docs/schemas/interface.rng >>> @@ -4,7 +4,7 @@ >>> xmlns:v="http://netcf.org/xml/version/1.0"; >>> datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes";> >>> >> >> Hmm - we aren't really bumping the version when we change the .rng; is >> that a bug in our process, or a stale comment worth deleting instead of >> spell-checking? But doesn't stop us from taking this hunk now. >> > > Well, this has something to do with netcf, I guess. Probably Laine > (Cc'd) would be the one to answer that. That schema is likely copied directly from netcf. I vaguely recall that the first time after initial public release that lutter added something to the schema (to support ipv6 I think), he updated the version, but wondered at the time just how necessary that was. Since that time it has never been updated, and I don't really see an upside to doing so. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix common misspellings
On Wed, Mar 25, 2015 at 10:44:53AM -0600, Eric Blake wrote: On 03/23/2015 02:46 AM, Martin Kletzander wrote: - In exceptional circumstances longer initial embargos may be + In exceptional circumstances longer initial embargoes may be This one is ambiguous (I've seen both spellings; zeros/zeroes is another such word), but Thunderbird's US spell-check dictionary prefers embargoes, so go for it. My en_GB.utf8 ispell only allows "embargoes". What is your opinion on "dependant" and similar words I've left out? dependant is flagged as wrong in US dictionary (only valid in UK dictionary, and even then, it has only the financial sense and not the inter-relatedness sense that we are more prone to be wanting throughout code). There is no word 'independant' in either variant. So another patch to s/\(\(in\)\?depen\)dant/\1dent/ would be correct. Thanks for the explanation. I used it in the commit message for such patch. And s/dependan/dependen/ was enough, plus it revelaed 'dependancies' as well. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org pgpvrP7Bt7MP2.pgp Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix common misspellings
On 03/23/2015 02:46 AM, Martin Kletzander wrote: >>> - In exceptional circumstances longer initial embargos may be >>> + In exceptional circumstances longer initial embargoes may be >> >> This one is ambiguous (I've seen both spellings; zeros/zeroes is another >> such word), but Thunderbird's US spell-check dictionary prefers >> embargoes, so go for it. >> > > My en_GB.utf8 ispell only allows "embargoes". What is your opinion on > "dependant" and similar words I've left out? dependant is flagged as wrong in US dictionary (only valid in UK dictionary, and even then, it has only the financial sense and not the inter-relatedness sense that we are more prone to be wanting throughout code). There is no word 'independant' in either variant. So another patch to s/\(\(in\)\?depen\)dant/\1dent/ would be correct. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix common misspellings
On Mon, Mar 23, 2015 at 09:58:40AM +0100, Ján Tomko wrote: On Fri, Mar 20, 2015 at 02:40:05PM +0100, Martin Kletzander wrote: I've left out "ok" (which should be OK, but it looks like nobody cares and there were *so many* false positives in the code), and there's "(in)dependant" where it suggests s/dant/dent/ and I couldn't find anywhere that the version with 'a' is wrong, but I see a lot of consistent usage of that and even my spell-checker doesn't mark it as wrong. Dependant is the UK spelling of that person that financially depends on you, all other uses should use 'dent'. Is that something that's just well known and I don't know that or do you have that from some particular place/page/person? I'd like to know more about some details. And to know whether I should send another version for some other words (when there's time, as this is not something we need). Just out of curiosity. Thanks Martin pgp5A5B1dkjmb.pgp Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix common misspellings
On Fri, Mar 20, 2015 at 02:40:05PM +0100, Martin Kletzander wrote: > > I've left out "ok" (which should be OK, but it looks like nobody cares > and there were *so many* false positives in the code), and there's > "(in)dependant" where it suggests s/dant/dent/ and I couldn't find > anywhere that the version with 'a' is wrong, but I see a lot of > consistent usage of that and even my spell-checker doesn't mark it as > wrong. Dependant is the UK spelling of that person that financially depends on you, all other uses should use 'dent'. Jan signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix common misspellings
On Fri, Mar 20, 2015 at 09:51:23AM -0600, Eric Blake wrote: On 03/20/2015 06:21 AM, Martin Kletzander wrote: Wikipedia's list of common misspellings [1] has a machine-readable version. This patch fixes those misspellings mentioned in the list which don't have multiple right variants (as e.g. "accension", which can be both "accession" and "ascension"), such misspellings are left untouched. The list of changes was manually re-checked for false positives. [1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines Signed-off-by: Martin Kletzander --- This is in no way automated, it's merely a check on whether this makes sense. Also I left out three words and two files which I thought might not be what we want. Quite the list! As a native speaker... +++ b/docs/bugs.html.in @@ -11,7 +11,7 @@ If you think that an issue with libvirt may have security - implications, please do not publically + implications, please do not publicly Correct. +++ b/docs/schemas/basictypes.rng @@ -115,7 +115,7 @@ - + Alignment is now off. +++ b/docs/schemas/interface.rng @@ -4,7 +4,7 @@ xmlns:v="http://netcf.org/xml/version/1.0"; datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes";> Hmm - we aren't really bumping the version when we change the .rng; is that a bug in our process, or a stale comment worth deleting instead of spell-checking? But doesn't stop us from taking this hunk now. Well, this has something to do with netcf, I guess. Probably Laine (Cc'd) would be the one to answer that. @@ -77,7 +77,7 @@ are two weeks or less in duration. If a problem is identified with a proposed patch for a security issue, requiring further investigation and bug fixing, the embargo clock may be restarted. - In exceptional circumstances longer initial embargos may be + In exceptional circumstances longer initial embargoes may be This one is ambiguous (I've seen both spellings; zeros/zeroes is another such word), but Thunderbird's US spell-check dictionary prefers embargoes, so go for it. My en_GB.utf8 ispell only allows "embargoes". What is your opinion on "dependant" and similar words I've left out? ACK to all these changes (modulo the alignment fix). I pushed the patch with the alignment fixed and "publicly" kept, thanks for the reviews. Martin pgpWNDBFrN_jW.pgp Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix common misspellings
On 03/20/2015 07:40 AM, Martin Kletzander wrote: > That was just a example (see that "e.g."), there are 206 of those. > You made me to go through those as well, all except one were false > positives (e.g. '"$@" -Wc,+Maked'), so I squashed this in: > > diff --git i/src/util/virhostdev.c w/src/util/virhostdev.c > index 9678e2b..23365a3 100644 > --- i/src/util/virhostdev.c > +++ w/src/util/virhostdev.c > @@ -569,7 +569,7 @@ virHostdevPreparePCIDevices(virHostdevManagerPtr > hostdev_mgr, > > /* The device is in use by other active domain if > * the dev is in list activePCIHostdevs. VFIO devices > - * belonging to same iommu group cant be shared > + * belonging to same iommu group can't be shared > * across guests. ACK (Many times, typos are obvious when flagged by spell-checkers; other times, like here, the misspelling is still a valid word so it is easier to overlook when it doesn't have the UI squiggle underline to point out the potential typo. But I seldom hear 'cant' in a real sentence, and it's true that iommu groups don't intone chants :) > > I'll leave out the public+ally if someone strongly disagrees. No, keep your changes to 'publicly'. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix common misspellings
On 03/20/2015 06:21 AM, Martin Kletzander wrote: > Wikipedia's list of common misspellings [1] has a machine-readable > version. This patch fixes those misspellings mentioned in the list > which don't have multiple right variants (as e.g. "accension", which can > be both "accession" and "ascension"), such misspellings are left > untouched. The list of changes was manually re-checked for false > positives. > > [1] > https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines > > Signed-off-by: Martin Kletzander > --- > This is in no way automated, it's merely a check on whether this makes > sense. Also I left out three words and two files which I thought > might not be what we want. Quite the list! As a native speaker... > +++ b/docs/bugs.html.in > @@ -11,7 +11,7 @@ > > >If you think that an issue with libvirt may have security > - implications, please do not publically > + implications, please do not publicly Correct. > +++ b/docs/schemas/basictypes.rng > @@ -115,7 +115,7 @@ > > > > - > + > Alignment is now off. > +++ b/docs/schemas/interface.rng > @@ -4,7 +4,7 @@ > xmlns:v="http://netcf.org/xml/version/1.0"; > datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes";> > Hmm - we aren't really bumping the version when we change the .rng; is that a bug in our process, or a stale comment worth deleting instead of spell-checking? But doesn't stop us from taking this hunk now. > @@ -77,7 +77,7 @@ >are two weeks or less in duration. If a problem is identified >with a proposed patch for a security issue, requiring further >investigation and bug fixing, the embargo clock may be restarted. > - In exceptional circumstances longer initial embargos may be > + In exceptional circumstances longer initial embargoes may be This one is ambiguous (I've seen both spellings; zeros/zeroes is another such word), but Thunderbird's US spell-check dictionary prefers embargoes, so go for it. ACK to all these changes (modulo the alignment fix). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix common misspellings
On Fri, Mar 20, 2015 at 01:47:01PM +0100, Ján Tomko wrote:
On Fri, Mar 20, 2015 at 01:21:06PM +0100, Martin Kletzander wrote:
Wikipedia's list of common misspellings [1] has a machine-readable
version. This patch fixes those misspellings mentioned in the list
which don't have multiple right variants (as e.g. "accension", which can
be both "accession" and "ascension"), such misspellings are left
Thankfully, none of the three spellings are present in the git.
That was just a example (see that "e.g."), there are 206 of those.
You made me to go through those as well, all except one were false
positives (e.g. '"$@" -Wc,+Maked'), so I squashed this in:
diff --git i/src/util/virhostdev.c w/src/util/virhostdev.c
index 9678e2b..23365a3 100644
--- i/src/util/virhostdev.c
+++ w/src/util/virhostdev.c
@@ -569,7 +569,7 @@ virHostdevPreparePCIDevices(virHostdevManagerPtr
hostdev_mgr,
/* The device is in use by other active domain if
* the dev is in list activePCIHostdevs. VFIO devices
- * belonging to same iommu group cant be shared
+ * belonging to same iommu group can't be shared
* across guests.
*/
if (STREQ(virPCIDeviceGetStubDriver(dev), "vfio-pci")) {
--
untouched. The list of changes was manually re-checked for false
positives.
[1]
https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines
Signed-off-by: Martin Kletzander
---
This is in no way automated, it's merely a check on whether this makes
sense. Also I left out three words and two files which I thought
might not be what we want.
docs/bugs.html.in | 2 +-
docs/contact.html.in| 2 +-
docs/schemas/basictypes.rng | 2 +-
docs/schemas/interface.rng | 2 +-
docs/securityprocess.html.in| 6 +++---
examples/systemtap/lock-debug.stp | 2 +-
include/libvirt/libvirt-host.h | 2 +-
include/libvirt/virterror.h | 2 +-
src/bhyve/bhyve_driver.c| 6 +++---
src/cpu/cpu_powerpc.c | 2 +-
src/datatypes.c | 4 ++--
src/network/bridge_driver_linux.c | 2 +-
src/qemu/THREADS.txt| 2 +-
src/qemu/qemu_capabilities.c| 2 +-
src/qemu/qemu_driver.c | 2 +-
src/util/virfirewall.c | 2 +-
src/util/virprocess.c | 2 +-
src/vbox/vbox_common.c | 2 +-
src/vbox/vbox_common.h | 2 +-
src/xen/xend_internal.c | 2 +-
src/xenconfig/xen_xm.c | 2 +-
tools/wireshark/samples/libvirt-sample.pdml | 2 +-
22 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/docs/bugs.html.in b/docs/bugs.html.in
index 140d1b4..55ceb60 100644
--- a/docs/bugs.html.in
+++ b/docs/bugs.html.in
@@ -11,7 +11,7 @@
If you think that an issue with libvirt may have security
- implications, please do not publically
+ implications, please do not publicly
report it in the bug tracker, mailing lists, or irc. Libvirt
has a dedicated process for handling
(potential) security issues
that should be used instead. So if your issue has security
I'm not convinced 'publically' is wrong, but 'publicly' is much more
common.
"publically" looks/sounds very weird to me, but I can't say for sure
whether it's "just plain wrong" or if the rules are just old. But
there were worse ones than that.
I've left out "ok" (which should be OK, but it looks like nobody cares
and there were *so many* false positives in the code), and there's
"(in)dependant" where it suggests s/dant/dent/ and I couldn't find
anywhere that the version with 'a' is wrong, but I see a lot of
consistent usage of that and even my spell-checker doesn't mark it as
wrong.
I'll leave out the public+ally if someone strongly disagrees.
ACK
Thanks for the review. I was thinking some more native speaker will
have a look as well, so I'll wait for a while if there are any
oppositions to this.
Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
pgpCW8bNRUSGj.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix common misspellings
On Fri, Mar 20, 2015 at 01:21:06PM +0100, Martin Kletzander wrote: > Wikipedia's list of common misspellings [1] has a machine-readable > version. This patch fixes those misspellings mentioned in the list > which don't have multiple right variants (as e.g. "accension", which can > be both "accession" and "ascension"), such misspellings are left Thankfully, none of the three spellings are present in the git. > untouched. The list of changes was manually re-checked for false > positives. > > [1] > https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines > > Signed-off-by: Martin Kletzander > --- > This is in no way automated, it's merely a check on whether this makes > sense. Also I left out three words and two files which I thought > might not be what we want. > > docs/bugs.html.in | 2 +- > docs/contact.html.in| 2 +- > docs/schemas/basictypes.rng | 2 +- > docs/schemas/interface.rng | 2 +- > docs/securityprocess.html.in| 6 +++--- > examples/systemtap/lock-debug.stp | 2 +- > include/libvirt/libvirt-host.h | 2 +- > include/libvirt/virterror.h | 2 +- > src/bhyve/bhyve_driver.c| 6 +++--- > src/cpu/cpu_powerpc.c | 2 +- > src/datatypes.c | 4 ++-- > src/network/bridge_driver_linux.c | 2 +- > src/qemu/THREADS.txt| 2 +- > src/qemu/qemu_capabilities.c| 2 +- > src/qemu/qemu_driver.c | 2 +- > src/util/virfirewall.c | 2 +- > src/util/virprocess.c | 2 +- > src/vbox/vbox_common.c | 2 +- > src/vbox/vbox_common.h | 2 +- > src/xen/xend_internal.c | 2 +- > src/xenconfig/xen_xm.c | 2 +- > tools/wireshark/samples/libvirt-sample.pdml | 2 +- > 22 files changed, 27 insertions(+), 27 deletions(-) > > diff --git a/docs/bugs.html.in b/docs/bugs.html.in > index 140d1b4..55ceb60 100644 > --- a/docs/bugs.html.in > +++ b/docs/bugs.html.in > @@ -11,7 +11,7 @@ > > >If you think that an issue with libvirt may have security > - implications, please do not publically > + implications, please do not publicly >report it in the bug tracker, mailing lists, or irc. Libvirt >has a dedicated process for handling > (potential) security issues >that should be used instead. So if your issue has security I'm not convinced 'publically' is wrong, but 'publicly' is much more common. ACK Jan signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] Fix common misspellings
Wikipedia's list of common misspellings [1] has a machine-readable version. This patch fixes those misspellings mentioned in the list which don't have multiple right variants (as e.g. "accension", which can be both "accession" and "ascension"), such misspellings are left untouched. The list of changes was manually re-checked for false positives. [1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines Signed-off-by: Martin Kletzander --- This is in no way automated, it's merely a check on whether this makes sense. Also I left out three words and two files which I thought might not be what we want. docs/bugs.html.in | 2 +- docs/contact.html.in| 2 +- docs/schemas/basictypes.rng | 2 +- docs/schemas/interface.rng | 2 +- docs/securityprocess.html.in| 6 +++--- examples/systemtap/lock-debug.stp | 2 +- include/libvirt/libvirt-host.h | 2 +- include/libvirt/virterror.h | 2 +- src/bhyve/bhyve_driver.c| 6 +++--- src/cpu/cpu_powerpc.c | 2 +- src/datatypes.c | 4 ++-- src/network/bridge_driver_linux.c | 2 +- src/qemu/THREADS.txt| 2 +- src/qemu/qemu_capabilities.c| 2 +- src/qemu/qemu_driver.c | 2 +- src/util/virfirewall.c | 2 +- src/util/virprocess.c | 2 +- src/vbox/vbox_common.c | 2 +- src/vbox/vbox_common.h | 2 +- src/xen/xend_internal.c | 2 +- src/xenconfig/xen_xm.c | 2 +- tools/wireshark/samples/libvirt-sample.pdml | 2 +- 22 files changed, 27 insertions(+), 27 deletions(-) diff --git a/docs/bugs.html.in b/docs/bugs.html.in index 140d1b4..55ceb60 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -11,7 +11,7 @@ If you think that an issue with libvirt may have security - implications, please do not publically + implications, please do not publicly report it in the bug tracker, mailing lists, or irc. Libvirt has a dedicated process for handling (potential) security issues that should be used instead. So if your issue has security diff --git a/docs/contact.html.in b/docs/contact.html.in index 51cc775..9ab0ab9 100644 --- a/docs/contact.html.in +++ b/docs/contact.html.in @@ -10,7 +10,7 @@ If you think that an issue with libvirt may have security - implications, please do not publically + implications, please do not publicly report it in the bug tracker, mailing lists, or irc. Libvirt has a dedicated process for handling (potential) security issues that should be used instead. So if your issue has security diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng index 3e1841c..8b49a27 100644 --- a/docs/schemas/basictypes.rng +++ b/docs/schemas/basictypes.rng @@ -115,7 +115,7 @@ - + diff --git a/docs/schemas/interface.rng b/docs/schemas/interface.rng index d78f877..bf0346c 100644 --- a/docs/schemas/interface.rng +++ b/docs/schemas/interface.rng @@ -4,7 +4,7 @@ xmlns:v="http://netcf.org/xml/version/1.0"; datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes";> diff --git a/docs/securityprocess.html.in b/docs/securityprocess.html.in index 3efd687..bdef1e9 100644 --- a/docs/securityprocess.html.in +++ b/docs/securityprocess.html.in @@ -66,9 +66,9 @@ The libvirt security team operates a policy of http://en.wikipedia.org/wiki/Responsible_disclosure";>responsible disclosure. - As such any security issue reported, that is not already publically disclosed + As such any security issue reported, that is not already publicly disclosed elsewhere, will have an embargo date assigned. Members of the security team agree - not to publically disclose any details of the security issue until the embargo + not to publicly disclose any details of the security issue until the embargo date expires. @@ -77,7 +77,7 @@ are two weeks or less in duration. If a problem is identified with a proposed patch for a security issue, requiring further investigation and bug fixing, the embargo clock may be restarted. - In exceptional circumstances longer initial embargos may be + In exceptional circumstances longer initial embargoes may be negotiated by mutual agreement between members of the security team and other relevant parties to the problem. Any such extended embargoes will aim to be at most one month in duration. diff --git a/examples/systemtap/lock-debug.stp b/examples/systemtap/lock-debug.stp index 8f06340..78e94ba 100644 --- a/examples/systemtap/lock-debug.stp +++ b/examples/systemtap/lock-debug.stp @@ -49,7 +4
