Re: [libvirt] [PATCH] Fix link_addr detection
Martin Kletzander wrote: > On 07/24/2013 03:02 PM, Roman Bogorodskiy wrote: > > link_addr detection in configure always reports that > > link_addr is missing because it uses link_addr(NULL, NULL) in > > AC_LINK_IFELSE check with limited set of headers that doesn't > > s/doesn't/don't/ "doesn't" was related to "set", not "headers", but probably that's not the best wording, I'm not native speaker :-) > > define NULL. > > > > Fix by replacing 'NULL' with just '0'. > > --- > > configure.ac | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure.ac b/configure.ac > > index 27531a1..cc9942a 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -2401,7 +2401,7 @@ AC_LINK_IFELSE([AC_LANG_PROGRAM( > > #include > > ]], > > [[ > > -link_addr(NULL, NULL)]])], > > +link_addr(0, 0)]])], > > [AC_DEFINE([HAVE_DECL_LINK_ADDR], > > [1], > > [whether link_addr is available])]) > > > > ACK, fixed and pushed. > > Martin Roman Bogorodskiy pgpYsNh_Qxmof.pgp Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix link_addr detection
On 07/24/2013 03:02 PM, Roman Bogorodskiy wrote: > link_addr detection in configure always reports that > link_addr is missing because it uses link_addr(NULL, NULL) in > AC_LINK_IFELSE check with limited set of headers that doesn't s/doesn't/don't/ > define NULL. > > Fix by replacing 'NULL' with just '0'. > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 27531a1..cc9942a 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2401,7 +2401,7 @@ AC_LINK_IFELSE([AC_LANG_PROGRAM( > #include > ]], > [[ > -link_addr(NULL, NULL)]])], > +link_addr(0, 0)]])], > [AC_DEFINE([HAVE_DECL_LINK_ADDR], > [1], > [whether link_addr is available])]) > ACK, fixed and pushed. Martin -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] Fix link_addr detection
link_addr detection in configure always reports that link_addr is missing because it uses link_addr(NULL, NULL) in AC_LINK_IFELSE check with limited set of headers that doesn't define NULL. Fix by replacing 'NULL' with just '0'. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 27531a1..cc9942a 100644 --- a/configure.ac +++ b/configure.ac @@ -2401,7 +2401,7 @@ AC_LINK_IFELSE([AC_LANG_PROGRAM( #include ]], [[ -link_addr(NULL, NULL)]])], +link_addr(0, 0)]])], [AC_DEFINE([HAVE_DECL_LINK_ADDR], [1], [whether link_addr is available])]) -- 1.7.11.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list