Re: [libvirt] [PATCH] conf: escape string for disk driver name attribute

2015-09-23 Thread lhuang 


On 09/23/2015 05:54 PM, Martin Kletzander wrote:

On Tue, Sep 22, 2015 at 04:13:53PM +0800, Luyao Huang wrote:

Just like e92e5ba1, this attribute was missed.

Signed-off-by: Luyao Huang 
---
src/conf/domain_conf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)



ACK && Pushed.


Thanks your review, Martin :)

Luyao

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: escape string for disk driver name attribute

2015-09-23 Thread Martin Kletzander 

On Tue, Sep 22, 2015 at 04:13:53PM +0800, Luyao Huang wrote:

Just like e92e5ba1, this attribute was missed.

Signed-off-by: Luyao Huang 
---
src/conf/domain_conf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)



ACK && Pushed.


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] conf: escape string for disk driver name attribute

2015-09-22 Thread Luyao Huang 
Just like e92e5ba1, this attribute was missed.

Signed-off-by: Luyao Huang 
---
 src/conf/domain_conf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a3b3ccb..85c2d0d 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -18867,8 +18867,7 @@ virDomainDiskDefFormat(virBufferPtr buf,
 def->ioeventfd || def->event_idx || def->copy_on_read ||
 def->discard || def->iothread) {
 virBufferAddLit(buf, "src->driverName)
-virBufferAsprintf(buf, " name='%s'", def->src->driverName);
+virBufferEscapeString(buf, " name='%s'", def->src->driverName);
 if (def->src->format > 0)
 virBufferAsprintf(buf, " type='%s'",
   
virStorageFileFormatTypeToString(def->src->format));
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list