[libvirt] [PATCH] maint: update to latest gnulib

[Ján Tomko]

Update to:

commit 7d069378921bfa0d7c7198ea177aac0a2440016f
Author: Pádraig Brady 
CommitDate: 2020-01-01 22:00:28 +

   md5, sha1, sha256, sha512: support --with-openssl=auto-gpl-compat

Signed-off-by: Ján Tomko 
---
 .gnulib   | 2 +-
 bootstrap | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Pushed.

diff --git a/.gnulib b/.gnulib
index 1f6fb368c0..7d06937892 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 1f6fb368c04919243e2c70f2aa514a5f88e95309
+Subproject commit 7d069378921bfa0d7c7198ea177aac0a2440016f
diff --git a/bootstrap b/bootstrap
index 5b08e7e2d4..70fd73cc74 100755
--- a/bootstrap
+++ b/bootstrap
@@ -4,7 +4,7 @@ scriptversion=2019-01-04.17; # UTC
 
 # Bootstrap this package from checked-out sources.
 
-# Copyright (C) 2003-2019 Free Software Foundation, Inc.
+# Copyright (C) 2003-2020 Free Software Foundation, Inc.
 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -166,7 +166,7 @@ bootstrap_epilogue() { :; }
 # specified directory.  Fill in the first %s with the destination
 # directory and the second with the domain name.
 po_download_command_format=\
-"wget --mirror --level=1 -nd -q -A.po -P '%s' \
+"wget --mirror --level=1 -nd -nv -A.po -P '%s' \
  https://translationproject.org/latest/%s/;
 
 # Prefer a non-empty tarname (4th argument of AC_INIT if given), else
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Andrea Bolognani]

On Tue, 2018-07-17 at 10:29 +0100, Daniel P. Berrangé wrote:
> On Tue, Jul 17, 2018 at 10:14:18AM +0200, Andrea Bolognani wrote:
> > It looks like gnulib commit 2afc250c6fae changed the ffs()
> > detection code, and now when compiling with MinGW I get HAVE_FFS=1
> > instead of HAVE_FFS=0 and the failure above. Curiously, HAVE_FFS
> > only shows up in Makefiles after the commit, whereas before I had
> > the classic '#undef HAVE_FFS' in config.h as well.
> > 
> > CC'ing bug-gnulib and the patch author so they can take a look.
> 
> No need - I reported this yesterday & Bruno has already provided a fix which
> I've confirmed fixes the ffs() problem, so I've pushed that for libvirt.

Darn, I should have double-checked bug-gnulib again today before
sending the message. Sorry for the noise :(

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Daniel P . Berrangé]

On Tue, Jul 17, 2018 at 10:14:18AM +0200, Andrea Bolognani wrote:
> On Sat, 2018-07-14 at 09:20 +0200, Michal Privoznik wrote:
> > The changelog is quite long because we haven't updated gnulib in
> > a while. Anyway, among the new changes you'll find GCC 8 support,
> > faster build time, mingw fixes and many others.
> 
> Ironically, this makes building on MinGW *worse* :)

[snip]

> and after[2] it fails with
> 
>   ../../src/util/virrandom.c: In function 'virRandomInt':
>   ../../src/util/virrandom.c:102:30: error: implicit declaration of function 
> 'ffs' [-Werror=implicit-function-declaration]
>return virRandomBits(ffs(max) - 1);
> ^~~
> 
> If you tweak the code to get rid of the ffs() call, you'll see
> that the strncpy() error is not resolved - it's merely being swept
> under the rug by the new one.
> 
> It looks like gnulib commit 2afc250c6fae changed the ffs()
> detection code, and now when compiling with MinGW I get HAVE_FFS=1
> instead of HAVE_FFS=0 and the failure above. Curiously, HAVE_FFS
> only shows up in Makefiles after the commit, whereas before I had
> the classic '#undef HAVE_FFS' in config.h as well.
> 
> CC'ing bug-gnulib and the patch author so they can take a look.

No need - I reported this yesterday & Bruno has already provided a fix which
I've confirmed fixes the ffs() problem, so I've pushed that for libvirt.

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Andrea Bolognani]

On Sat, 2018-07-14 at 09:20 +0200, Michal Privoznik wrote:
> The changelog is quite long because we haven't updated gnulib in
> a while. Anyway, among the new changes you'll find GCC 8 support,
> faster build time, mingw fixes and many others.

Ironically, this makes building on MinGW *worse* :)

Looking at the CentOS CI, you can see that before[1] updating
gnulib the build failed with

  In function 'virStrncpy',
  inlined from 'virStrcpy' at ../../src/util/virstring.c:811:12:
  ../../src/util/virstring.c:789:11: error: 'strncpy' output truncated before 
terminating nul copying as many bytes from a string as its length 
[-Werror=stringop-truncation]
   ret = strncpy(dest, src, n);
 ^
  ../../src/util/virstring.c: In function 'virStrcpy':
  ../../src/util/virstring.c:811:12: note: length computed here
   return virStrncpy(dest, src, strlen(src), destbytes);
  ^

and after[2] it fails with

  ../../src/util/virrandom.c: In function 'virRandomInt':
  ../../src/util/virrandom.c:102:30: error: implicit declaration of function 
'ffs' [-Werror=implicit-function-declaration]
   return virRandomBits(ffs(max) - 1);
^~~

If you tweak the code to get rid of the ffs() call, you'll see
that the strncpy() error is not resolved - it's merely being swept
under the rug by the new one.

It looks like gnulib commit 2afc250c6fae changed the ffs()
detection code, and now when compiling with MinGW I get HAVE_FFS=1
instead of HAVE_FFS=0 and the failure above. Curiously, HAVE_FFS
only shows up in Makefiles after the commit, whereas before I had
the classic '#undef HAVE_FFS' in config.h as well.

CC'ing bug-gnulib and the patch author so they can take a look.

As for the strncpy() issue, it looks like the latest MinGW in
Rawhide introduced more strict diagnostics that are being mistakenly
triggered in this scenario. I'm looking into it.


[1] https://ci.centos.org/view/libvirt/job/libvirt-master-build-mingw32/238/
[2] https://ci.centos.org/view/libvirt/job/libvirt-master-build-mingw32/239/
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Michal Privoznik]

The changelog is quite long because we haven't updated gnulib in
a while. Anyway, among the new changes you'll find GCC 8 support,
faster build time, mingw fixes and many others.

Signed-off-by: Michal Privoznik 
---

Pushed under "gnulib update" rule.

 .gnulib   |   2 +-
 bootstrap | 266 --
 2 files changed, 155 insertions(+), 113 deletions(-)

diff --git a/.gnulib b/.gnulib
index d6397dde2e..5b78831df0 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit d6397dde2e127e246e3eeb5254a21f42cac783c8
+Subproject commit 5b78831df03b49408676227604cf16f90dee07ac
diff --git a/bootstrap b/bootstrap
index 92be11439a..ed3b0a4b70 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2018-03-07.03; # UTC
+scriptversion=2018-07-01.02; # UTC
 
 # Bootstrap this package from checked-out sources.
 
@@ -47,6 +47,8 @@ PERL="${PERL-perl}"
 
 me=$0
 
+default_gnulib_url=git://git.sv.gnu.org/gnulib
+
 usage() {
   cat &1 | grep -- --depth > /dev/null && shallow='--depth 2'
-git clone $shallow git://git.sv.gnu.org/gnulib "$gnulib_path" ||
-  cleanup_gnulib
-
-trap - 1 2 13 15
+if $use_gnulib; then
+  if $use_git; then
+gnulib_path=$(git_modules_config submodule.gnulib.path)
+test -z "$gnulib_path" && gnulib_path=gnulib
   fi
-  GNULIB_SRCDIR=$gnulib_path
-  ;;
-*)
-  # Use GNULIB_SRCDIR directly or as a reference.
-  if $use_git && test -d "$GNULIB_SRCDIR"/.git && \
-git_modules_config submodule.gnulib.url >/dev/null; then
-echo "$0: getting gnulib files..."
-if git submodule -h|grep -- --reference > /dev/null; then
-  # Prefer the one-liner available in git 1.6.4 or newer.
-  git submodule update --init --reference "$GNULIB_SRCDIR" \
-"$gnulib_path" || exit $?
-else
-  # This fallback allows at least git 1.5.5.
-  if test -f "$gnulib_path"/gnulib-tool; then
-# Since file already exists, assume submodule init already complete.
-git submodule update -- "$gnulib_path" || exit $?
-  else
-# Older git can't clone into an empty directory.
-rmdir "$gnulib_path" 2>/dev/null
-git clone --reference "$GNULIB_SRCDIR" \
-  "$(git_modules_config submodule.gnulib.url)" "$gnulib_path" \
-  && git submodule init -- "$gnulib_path" \
-  && git submodule update -- "$gnulib_path" \
-  || exit $?
+
+  # Get gnulib files.  Populate $GNULIB_SRCDIR, possibly updating a
+  # submodule, for use in the rest of the script.
+
+  case ${GNULIB_SRCDIR--} in
+  -)
+# Note that $use_git is necessarily true in this case.
+if git_modules_config submodule.gnulib.url >/dev/null; then
+  echo "$0: getting gnulib files..."
+  git submodule init -- "$gnulib_path" || exit $?
+  git submodule update -- "$gnulib_path" || exit $?
+
+elif [ ! -d "$gnulib_path" ]; then
+  echo "$0: getting gnulib files..."
+
+  trap cleanup_gnulib 1 2 13 15
+
+  shallow=
+  if test -z "$GNULIB_REVISION"; then
+git clone -h 2>&1 | grep -- --depth > /dev/null && shallow='--depth 2'
   fi
+  git clone $shallow ${GNULIB_URL:-$default_gnulib_url} "$gnulib_path" \
+|| cleanup_gnulib
+
+  trap - 1 2 13 15
 fi
 GNULIB_SRCDIR=$gnulib_path
+;;
+  *)
+# Use GNULIB_SRCDIR directly or as a reference.
+if $use_git && test -d "$GNULIB_SRCDIR"/.git && \
+  git_modules_config submodule.gnulib.url >/dev/null; then
+  echo "$0: getting gnulib files..."
+  if git submodule -h|grep -- --reference > /dev/null; then
+# Prefer the one-liner available in git 1.6.4 or newer.
+git submodule update --init --reference "$GNULIB_SRCDIR" \
+  "$gnulib_path" || exit $?
+  else
+# This fallback allows at least git 1.5.5.
+if test -f "$gnulib_path"/gnulib-tool; then
+  # Since file already exists, assume submodule init already complete.
+  git submodule update -- "$gnulib_path" || exit $?
+else
+  # Older git can't clone into an empty directory.
+  rmdir "$gnulib_path" 2>/dev/null
+  git clone --reference "$GNULIB_SRCDIR" \
+"$(git_modules_config submodule.gnulib.url)" "$gnulib_path" \
+&& git submodule init -- "$gnulib_path" \
+&& git submodule update -- "$gnulib_path" \
+|| exit $?
+fi
+  fi
+  GNULIB_SRCDIR=$gnulib_path
+fi
+;;
+  esac
+
+  if test -d "$GNULIB_SRCDIR"/.git && test -n "$GNULIB_REVISION" \
+ && ! git_modules_config submodule.gnulib.url >/dev/null; then
+(cd 

Re: [libvirt] [PATCH] maint: Update to latest gnulib

[Eric Blake]

On 01/03/2018 08:46 AM, Peter Krempa wrote:

>>
>> No bright ideas on this other than perhaps only including changes just
>> prior to the particular one that breaks things or somehow revert just
>> that one in our local copy.
> 
> How about just killing that stupid syntax check in our local copy?

As in, tweaking local-checks-to-skip to exclude the copyright date
check? I'd be okay with that idea, so that we don't hit this problem in
future years.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: Update to latest gnulib

[Michal Privoznik]

On 01/03/2018 03:46 PM, Peter Krempa wrote:
> On Tue, Jan 02, 2018 at 08:09:37 -0500, John Ferlan wrote:
>>
>>
>> On 01/02/2018 04:28 AM, Michal Privoznik wrote:
>>> Unfortunately, since gnulib's commit of 2c5d558745 there's an
>>> unused parameter to stat_time_normalize() function which gnulib
>>> developers don't want to fix [1]. Therefore, we have to work
>>> around it by temporarily suspending -Wunused-parameter.
>>>
>>> 1: http://lists.gnu.org/archive/html/bug-gnulib/2018-01/msg0.html
>>>
>>> Signed-off-by: Michal Privoznik 
>>> ---
>>>
>>> While we have 'gnulib update free' push rule, this one is not trivial at
>>> all and thus I have not pushed it. It's ugly and I don't like it. So any
>>> ideas are welcome.
>>>
>>>  .gnulib| 2 +-
>>>  bootstrap  | 4 ++--
>>>  src/storage/storage_util.c | 3 +++
>>>  3 files changed, 6 insertions(+), 3 deletions(-)
>>>
>>
>>
>> No bright ideas on this other than perhaps only including changes just
>> prior to the particular one that breaks things or somehow revert just
>> that one in our local copy.
> 
> How about just killing that stupid syntax check in our local copy?
> 

That wouldn't help either. We could not upgrade to newer gnulib unless
it's fixed. But fortunately, it looks like we're close to an agreement
how to fix gnulib so we can update it in our repo too.

michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: Update to latest gnulib

[Peter Krempa]

On Tue, Jan 02, 2018 at 08:09:37 -0500, John Ferlan wrote:
> 
> 
> On 01/02/2018 04:28 AM, Michal Privoznik wrote:
> > Unfortunately, since gnulib's commit of 2c5d558745 there's an
> > unused parameter to stat_time_normalize() function which gnulib
> > developers don't want to fix [1]. Therefore, we have to work
> > around it by temporarily suspending -Wunused-parameter.
> > 
> > 1: http://lists.gnu.org/archive/html/bug-gnulib/2018-01/msg0.html
> > 
> > Signed-off-by: Michal Privoznik 
> > ---
> > 
> > While we have 'gnulib update free' push rule, this one is not trivial at
> > all and thus I have not pushed it. It's ugly and I don't like it. So any
> > ideas are welcome.
> > 
> >  .gnulib| 2 +-
> >  bootstrap  | 4 ++--
> >  src/storage/storage_util.c | 3 +++
> >  3 files changed, 6 insertions(+), 3 deletions(-)
> > 
> 
> 
> No bright ideas on this other than perhaps only including changes just
> prior to the particular one that breaks things or somehow revert just
> that one in our local copy.

How about just killing that stupid syntax check in our local copy?


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: Update to latest gnulib

[Eric Blake]

On 01/02/2018 07:09 AM, John Ferlan wrote:
> 
> 
> On 01/02/2018 04:28 AM, Michal Privoznik wrote:
>> Unfortunately, since gnulib's commit of 2c5d558745 there's an
>> unused parameter to stat_time_normalize() function which gnulib
>> developers don't want to fix [1]. Therefore, we have to work
>> around it by temporarily suspending -Wunused-parameter.
>>
>> 1: http://lists.gnu.org/archive/html/bug-gnulib/2018-01/msg0.html
>>
>> Signed-off-by: Michal Privoznik 
>> ---
>>
>> While we have 'gnulib update free' push rule, this one is not trivial at
>> all and thus I have not pushed it. It's ugly and I don't like it. So any
>> ideas are welcome.
>>
>>  .gnulib| 2 +-
>>  bootstrap  | 4 ++--
>>  src/storage/storage_util.c | 3 +++
>>  3 files changed, 6 insertions(+), 3 deletions(-)
>>
> 
> 
> No bright ideas on this other than perhaps only including changes just
> prior to the particular one that breaks things or somehow revert just
> that one in our local copy.

We can provide a downstream-only patch against the gnulib file that adds
the attribute unused marker in our builds, since upstream didn't like
the patch. I'll work up something like that in a moment...

> 
> Other thoughts require additional local changes just to "work around"
> the broken definition.  Such as grabbing the "old" stat-time.h, rename
> it, save it in libvirt sources, then use that new name instead of the
> new .gnulib file. That's probably worse than what you've done though.
> 
> At this point, I think your solution to minimize the impact to one
> include file is perhaps the easiest/best solution albeit not perfect.

Yes, the #pragma usage is more concise than carrying a downstream gnulib
patch, but the two approaches are not that much different in
maintenance, so it will be a matter of taste which variant of the patch
to use.

> 
> It's interesting that there is no desire to fix this problem in .gnulib
> especially since there are already 2 patches proposed and in reality the
> change fundamentally breaks on every platform other than __sun when
> STAT_TIMESPEC is defined just because it's possible (or more desirable
> in the reviewers feedback) to compile with ignore unused-parameter.

I'm also going to reply in the upstream gnulib thread.  When the warning
is in a .c file, they are justified in not caring.  But when it is in a
.h file, it really does seem like something worth cleaning up in gnulib.

> Wonder what would happen if someone posted a patch to .gnulib to revert
> the change for the reason that it breaks other platforms that don't
> desire to configure in that manner. Perhaps Eric Blake would have some
> thoughts or additional muscle with the .gnulib maintainers.
> 


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: Update to latest gnulib

[Michal Privoznik]

On 01/02/2018 02:09 PM, John Ferlan wrote:
> 
> 
> On 01/02/2018 04:28 AM, Michal Privoznik wrote:
>> Unfortunately, since gnulib's commit of 2c5d558745 there's an
>> unused parameter to stat_time_normalize() function which gnulib
>> developers don't want to fix [1]. Therefore, we have to work
>> around it by temporarily suspending -Wunused-parameter.
>>
>> 1: http://lists.gnu.org/archive/html/bug-gnulib/2018-01/msg0.html
>>
>> Signed-off-by: Michal Privoznik 
>> ---
>>
>> While we have 'gnulib update free' push rule, this one is not trivial at
>> all and thus I have not pushed it. It's ugly and I don't like it. So any
>> ideas are welcome.
>>
>>  .gnulib| 2 +-
>>  bootstrap  | 4 ++--
>>  src/storage/storage_util.c | 3 +++
>>  3 files changed, 6 insertions(+), 3 deletions(-)
>>
> 
> 
> No bright ideas on this other than perhaps only including changes just
> prior to the particular one that breaks things

Unfortunately, that is not possible. The gnulib's commit that breaks
things was merged 23rd of November and we need the most recent commit
which fixes the stupid year check.

> or somehow revert just
> that one in our local copy.

I'm worried that in the end this would make us diverge from the gnulib's
upstream too much.

>
> Other thoughts require additional local changes just to "work around"
> the broken definition.  Such as grabbing the "old" stat-time.h, rename
> it, save it in libvirt sources, then use that new name instead of the
> new .gnulib file. That's probably worse than what you've done though.

Agreed.

> 
> At this point, I think your solution to minimize the impact to one
> include file is perhaps the easiest/best solution albeit not perfect.
> 
> It's interesting that there is no desire to fix this problem in .gnulib
> especially since there are already 2 patches proposed and in reality the
> change fundamentally breaks on every platform other than __sun when
> STAT_TIMESPEC is defined just because it's possible (or more desirable
> in the reviewers feedback) to compile with ignore unused-parameter.
> Wonder what would happen if someone posted a patch to .gnulib to revert
> the change for the reason that it breaks other platforms that don't
> desire to configure in that manner. Perhaps Eric Blake would have some
> thoughts or additional muscle with the .gnulib maintainers.

That's what I hope for. Since the problem lies in a header file I think
it's impossible to require all projects that use gnulib to compile
without -Wunused-parameter.

Another solution might be to move the function that causes troubles into
.c since it's purely internal function and nobody outside gnulib
calls/should call it. At least then we could use different sets of
CFLAGS for libvirt and gnulib (not that I'd fancy it or know how to do
it).

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: Update to latest gnulib

[John Ferlan]

On 01/02/2018 04:28 AM, Michal Privoznik wrote:
> Unfortunately, since gnulib's commit of 2c5d558745 there's an
> unused parameter to stat_time_normalize() function which gnulib
> developers don't want to fix [1]. Therefore, we have to work
> around it by temporarily suspending -Wunused-parameter.
> 
> 1: http://lists.gnu.org/archive/html/bug-gnulib/2018-01/msg0.html
> 
> Signed-off-by: Michal Privoznik 
> ---
> 
> While we have 'gnulib update free' push rule, this one is not trivial at
> all and thus I have not pushed it. It's ugly and I don't like it. So any
> ideas are welcome.
> 
>  .gnulib| 2 +-
>  bootstrap  | 4 ++--
>  src/storage/storage_util.c | 3 +++
>  3 files changed, 6 insertions(+), 3 deletions(-)
> 


No bright ideas on this other than perhaps only including changes just
prior to the particular one that breaks things or somehow revert just
that one in our local copy.

Other thoughts require additional local changes just to "work around"
the broken definition.  Such as grabbing the "old" stat-time.h, rename
it, save it in libvirt sources, then use that new name instead of the
new .gnulib file. That's probably worse than what you've done though.

At this point, I think your solution to minimize the impact to one
include file is perhaps the easiest/best solution albeit not perfect.

It's interesting that there is no desire to fix this problem in .gnulib
especially since there are already 2 patches proposed and in reality the
change fundamentally breaks on every platform other than __sun when
STAT_TIMESPEC is defined just because it's possible (or more desirable
in the reviewers feedback) to compile with ignore unused-parameter.
Wonder what would happen if someone posted a patch to .gnulib to revert
the change for the reason that it breaks other platforms that don't
desire to configure in that manner. Perhaps Eric Blake would have some
thoughts or additional muscle with the .gnulib maintainers.

John


> diff --git a/.gnulib b/.gnulib
> index 5e9abf871..c2cb55b34 16
> --- a/.gnulib
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit 5e9abf87163ad4aeaefef0b02961f8674b0a4879
> +Subproject commit c2cb55b34e76546479f195c14202dfcc870c4914
> diff --git a/bootstrap b/bootstrap
> index 85b85c530..25920e991 100755
> --- a/bootstrap
> +++ b/bootstrap
> @@ -4,7 +4,7 @@ scriptversion=2017-09-19.08; # UTC
>  
>  # Bootstrap this package from checked-out sources.
>  
> -# Copyright (C) 2003-2017 Free Software Foundation, Inc.
> +# Copyright (C) 2003-2018 Free Software Foundation, Inc.
>  
>  # This program is free software: you can redistribute it and/or modify
>  # it under the terms of the GNU General Public License as published by
> @@ -792,7 +792,7 @@ symlink_to_dir()
># aren't confused into doing unnecessary builds.  Conversely, if the
># existing symlink's timestamp is older than the source, make it 
> afresh,
># so that broken tools aren't confused into skipping needed builds.  
> See
> -  # 
> .
> +  # .
>test -h "$dst" &&
>src_ls=$(ls -diL "$src" 2>/dev/null) && set $src_ls && src_i=$1 &&
>dst_ls=$(ls -diL "$dst" 2>/dev/null) && set $dst_ls && dst_i=$1 &&
> diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
> index 899a55758..da6381f52 100644
> --- a/src/storage/storage_util.c
> +++ b/src/storage/storage_util.c
> @@ -64,7 +64,10 @@
>  #include "virfile.h"
>  #include "virjson.h"
>  #include "virqemu.h"
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wunused-parameter"
>  #include "stat-time.h"
> +#pragma GCC diagnostic pop
>  #include "virstring.h"
>  #include "virxml.h"
>  #include "virfdstream.h"
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: Update to latest gnulib

[Michal Privoznik]

Unfortunately, since gnulib's commit of 2c5d558745 there's an
unused parameter to stat_time_normalize() function which gnulib
developers don't want to fix [1]. Therefore, we have to work
around it by temporarily suspending -Wunused-parameter.

1: http://lists.gnu.org/archive/html/bug-gnulib/2018-01/msg0.html

Signed-off-by: Michal Privoznik 
---

While we have 'gnulib update free' push rule, this one is not trivial at
all and thus I have not pushed it. It's ugly and I don't like it. So any
ideas are welcome.

 .gnulib| 2 +-
 bootstrap  | 4 ++--
 src/storage/storage_util.c | 3 +++
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/.gnulib b/.gnulib
index 5e9abf871..c2cb55b34 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 5e9abf87163ad4aeaefef0b02961f8674b0a4879
+Subproject commit c2cb55b34e76546479f195c14202dfcc870c4914
diff --git a/bootstrap b/bootstrap
index 85b85c530..25920e991 100755
--- a/bootstrap
+++ b/bootstrap
@@ -4,7 +4,7 @@ scriptversion=2017-09-19.08; # UTC
 
 # Bootstrap this package from checked-out sources.
 
-# Copyright (C) 2003-2017 Free Software Foundation, Inc.
+# Copyright (C) 2003-2018 Free Software Foundation, Inc.
 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -792,7 +792,7 @@ symlink_to_dir()
   # aren't confused into doing unnecessary builds.  Conversely, if the
   # existing symlink's timestamp is older than the source, make it afresh,
   # so that broken tools aren't confused into skipping needed builds.  See
-  # .
+  # .
   test -h "$dst" &&
   src_ls=$(ls -diL "$src" 2>/dev/null) && set $src_ls && src_i=$1 &&
   dst_ls=$(ls -diL "$dst" 2>/dev/null) && set $dst_ls && dst_i=$1 &&
diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
index 899a55758..da6381f52 100644
--- a/src/storage/storage_util.c
+++ b/src/storage/storage_util.c
@@ -64,7 +64,10 @@
 #include "virfile.h"
 #include "virjson.h"
 #include "virqemu.h"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
 #include "stat-time.h"
+#pragma GCC diagnostic pop
 #include "virstring.h"
 #include "virxml.h"
 #include "virfdstream.h"
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Michal Privoznik]

On 10/10/2017 02:15 AM, Daniel P. Berrange wrote:
> This pulls in the fix for getopt tests on Fedora >= 28 / glibc > 2.26.0
> 
> Signed-off-by: Daniel P. Berrange 
> ---
>  .gnulib | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gnulib b/.gnulib
> index 8d116e3f65..5e9abf8716 16
> --- a/.gnulib
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit 8d116e3f657cb120f79efbbb675fa3cc9d21f53e
> +Subproject commit 5e9abf87163ad4aeaefef0b02961f8674b0a4879
> 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Daniel P. Berrange]

This pulls in the fix for getopt tests on Fedora >= 28 / glibc > 2.26.0

Signed-off-by: Daniel P. Berrange 
---
 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 8d116e3f65..5e9abf8716 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 8d116e3f657cb120f79efbbb675fa3cc9d21f53e
+Subproject commit 5e9abf87163ad4aeaefef0b02961f8674b0a4879
-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: Update to latest gnulib

[Erik Skultety]

This pulls in, among other new things, vc-list-files fix to make
syntax-check work with git worktrees.

Signed-off-by: Erik Skultety 
---

As per http://lists.gnu.org/archive/html/bug-gnulib/2017-08/msg00171.html which
fixes the build with old autoconf, pushing this patch under the gnulib
maintenance rule. Again, thanks a lot for fixing it so fast Eric :).


 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index ce4ee4cbb..8d116e3f6 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit ce4ee4cbb596a9d7de2786cf8c48cf62a4edede7
+Subproject commit 8d116e3f657cb120f79efbbb675fa3cc9d21f53e
--
2.13.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: Update to latest gnulib

[Erik Skultety]

On Thu, Aug 24, 2017 at 11:14:57AM +0200, Peter Krempa wrote:
> On Thu, Aug 24, 2017 at 10:50:29 +0200, Erik Skultety wrote:
> > This pulls in, among other new things, vc-list-files fix to make
> > syntax-check work with git worktrees.
> >
> > Signed-off-by: Erik Skultety 
> > ---
> >  .gnulib | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Did you push this under the "gnulib update rule"? If not, ACK

No, I did not. This was the first time I made any adjustments to gnulib, so I
wanted to be sure I didn't miss anything. Saying that, before sending the patch
I also checked whether the bootstrap version needed to be updated as well, but
it turned out that we're already using the current version.

Thanks for review, I pushed the patch.

Erik


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: Update to latest gnulib

[Peter Krempa]

On Thu, Aug 24, 2017 at 10:50:29 +0200, Erik Skultety wrote:
> This pulls in, among other new things, vc-list-files fix to make
> syntax-check work with git worktrees.
> 
> Signed-off-by: Erik Skultety 
> ---
>  .gnulib | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Did you push this under the "gnulib update rule"? If not, ACK


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: Update to latest gnulib

[Erik Skultety]

This pulls in, among other new things, vc-list-files fix to make
syntax-check work with git worktrees.

Signed-off-by: Erik Skultety 
---
 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index ce4ee4cbb..47c634c05 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit ce4ee4cbb596a9d7de2786cf8c48cf62a4edede7
+Subproject commit 47c634c05a946651e2834dcf0cd7cd0dc7a21d3c
-- 
2.13.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Daniel P. Berrange]

On Thu, Jun 15, 2017 at 05:39:00PM +0200, Martin Kletzander wrote:
> On Wed, Jun 14, 2017 at 03:35:39PM +0100, Daniel P. Berrange wrote:
> > On Wed, Jun 14, 2017 at 04:30:49PM +0200, Martin Kletzander wrote:
> > > On Wed, Jun 14, 2017 at 02:32:41PM +0100, Daniel P. Berrange wrote:
> > > > On Wed, Jun 14, 2017 at 03:27:25PM +0200, Martin Kletzander wrote:
> > > > > On Wed, Jun 14, 2017 at 11:20:44AM +0100, Daniel P. Berrange wrote:
> > > > > > This fixes an incompatibility with glibc 2.25.90
> > > > > >
> > > > > > Signed-off-by: Daniel P. Berrange 
> > > > > > ---
> > > > > >
> > > > > > Pushed as a broken build fix to get CI back online
> > > > > >
> > > > >
> > > > > After this update the build fails for me with gcc-7.1.0 with the
> > > > > following error:
> > > > >
> > > > > In file included from util/virobject.c:28:0:
> > > > > util/virobject.c: In function 'virClassNew':
> > > > > util/viratomic.h:176:46: error: this condition has identical branches 
> > > > > [-Werror=duplicated-branches]
> > > > > (void)(0 ? *(atomic) ^ *(atomic) : 0);
> > > > >   \
> > > > >  ^
> > > > > util/virobject.c:144:20: note: in expansion of macro 'virAtomicIntInc'
> > > > > klass->magic = virAtomicIntInc();
> > > > >^~~
> > > > >
> > > > > Does that mean that gcc does optimize our prefetch trick away
> > > > > (considering I understood what that line is trying to do)?  Or should 
> > > > > we
> > > > > just turn the warning off for that header file?
> > > >
> > > > Yep, "-Wduplicated-branches" appears to be a new warning flag in gcc 7.1
> > > > which gnulib turns on. There's a similar hit with mingw
> > > >
> > > > ../../src/util/vircommand.c: In function 'virCommandWait':
> > > > ../../src/util/vircommand.c:2562:51: error: this condition has 
> > > > identical branches [-Werror=duplicated-branches]
> > > > *exitstatus = cmd->rawStatus ? status : WEXITSTATUS(status);
> > > >   ^
> > > > cc1: all warnings being treated as errors
> > > >
> > > >
> > > > because WEXITSTATUS(x) expands to 'x' on Win32.
> > > >
> > > > We could use a pragma to turn off selectively, but I'm more
> > > > inclined to just disable this new warning flag.
> > > >
> > > 
> > > Well, I'm not sure how that affects the line where we actually use it
> > > (with the atomic variables) or whether that line is not needed anymore
> > > (if that was a fix for older compilers or something similar).  But I
> > > can send a patch for removing that warning.  How about the other
> > > warning we get when we turn off the first one?  I just found out.  I
> > > think that could be turned off as well, either for some particular
> > > places or for the whole build:
> > > 
> > > util/virtime.c: In function 'virTimeStringThenRaw':
> > > util/virtime.c:215:9: error: '%02d' directive output may be truncated 
> > > writing between 2 and 11 bytes into a region of size between 5 and 21 
> > > [-Werror=format-truncation=]
> > > if (snprintf(buf, VIR_TIME_STRING_BUFLEN,
> > > ^
> > >  "%4d-%02d-%02d %02d:%02d:%02d.%03d+",
> > >  ~
> > >  fields.tm_year, fields.tm_mon, fields.tm_mday,
> > >  ~~
> > >  fields.tm_hour, fields.tm_min, fields.tm_sec,
> > >  ~
> > >  (int) (when % 1000)) >= VIR_TIME_STRING_BUFLEN) {
> > >  
> > > util/virtime.c:215:9: note: using the range [-2147483648, 2147483647] for 
> > > directive argument
> > > In file included from /usr/include/stdio.h:936:0,
> > > from ../gnulib/lib/stdio.h:43,
> > > from util/virtime.c:36:
> > > /usr/include/bits/stdio2.h:64:10: note: '__builtin___snprintf_chk' output 
> > > between 29 and 89 bytes into a destination of size 29
> > >   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
> > >  ^~~~
> > >__bos (__s), __fmt, __va_arg_pack ());
> > >~
> > 
> > I think we might just want to switch to asprintf here instead of trying to
> > optimize into a fixed stack allocated buffer.
> > 
> 
> I wanted to do that and started rewriting it, but I found out we use
> static buffers in lot of places and lot of them then use snprintf or
> similar.  In some cases it doesn't even make much of a sense, e.g.:
> 
>  snprintf(buf, 3, "%d", var)
> 
> even this can fail.  I get the reason for the warning, but I don't
> really agree that it's something that is necessary to avoid, so I'm
> inclining to ignoring that warning as well.

In that kind of scenario we should be 

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Martin Kletzander]

On Wed, Jun 14, 2017 at 03:35:39PM +0100, Daniel P. Berrange wrote:

On Wed, Jun 14, 2017 at 04:30:49PM +0200, Martin Kletzander wrote:

On Wed, Jun 14, 2017 at 02:32:41PM +0100, Daniel P. Berrange wrote:
> On Wed, Jun 14, 2017 at 03:27:25PM +0200, Martin Kletzander wrote:
> > On Wed, Jun 14, 2017 at 11:20:44AM +0100, Daniel P. Berrange wrote:
> > > This fixes an incompatibility with glibc 2.25.90
> > >
> > > Signed-off-by: Daniel P. Berrange 
> > > ---
> > >
> > > Pushed as a broken build fix to get CI back online
> > >
> >
> > After this update the build fails for me with gcc-7.1.0 with the
> > following error:
> >
> > In file included from util/virobject.c:28:0:
> > util/virobject.c: In function 'virClassNew':
> > util/viratomic.h:176:46: error: this condition has identical branches 
[-Werror=duplicated-branches]
> > (void)(0 ? *(atomic) ^ *(atomic) : 0);  \
> >  ^
> > util/virobject.c:144:20: note: in expansion of macro 'virAtomicIntInc'
> > klass->magic = virAtomicIntInc();
> >^~~
> >
> > Does that mean that gcc does optimize our prefetch trick away
> > (considering I understood what that line is trying to do)?  Or should we
> > just turn the warning off for that header file?
>
> Yep, "-Wduplicated-branches" appears to be a new warning flag in gcc 7.1
> which gnulib turns on. There's a similar hit with mingw
>
> ../../src/util/vircommand.c: In function 'virCommandWait':
> ../../src/util/vircommand.c:2562:51: error: this condition has identical 
branches [-Werror=duplicated-branches]
> *exitstatus = cmd->rawStatus ? status : WEXITSTATUS(status);
>   ^
> cc1: all warnings being treated as errors
>
>
> because WEXITSTATUS(x) expands to 'x' on Win32.
>
> We could use a pragma to turn off selectively, but I'm more
> inclined to just disable this new warning flag.
>

Well, I'm not sure how that affects the line where we actually use it
(with the atomic variables) or whether that line is not needed anymore
(if that was a fix for older compilers or something similar).  But I
can send a patch for removing that warning.  How about the other
warning we get when we turn off the first one?  I just found out.  I
think that could be turned off as well, either for some particular
places or for the whole build:

util/virtime.c: In function 'virTimeStringThenRaw':
util/virtime.c:215:9: error: '%02d' directive output may be truncated writing 
between 2 and 11 bytes into a region of size between 5 and 21 
[-Werror=format-truncation=]
if (snprintf(buf, VIR_TIME_STRING_BUFLEN,
^
 "%4d-%02d-%02d %02d:%02d:%02d.%03d+",
 ~
 fields.tm_year, fields.tm_mon, fields.tm_mday,
 ~~
 fields.tm_hour, fields.tm_min, fields.tm_sec,
 ~
 (int) (when % 1000)) >= VIR_TIME_STRING_BUFLEN) {
 
util/virtime.c:215:9: note: using the range [-2147483648, 2147483647] for 
directive argument
In file included from /usr/include/stdio.h:936:0,
from ../gnulib/lib/stdio.h:43,
from util/virtime.c:36:
/usr/include/bits/stdio2.h:64:10: note: '__builtin___snprintf_chk' output 
between 29 and 89 bytes into a destination of size 29
  return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
 ^~~~
   __bos (__s), __fmt, __va_arg_pack ());
   ~


I think we might just want to switch to asprintf here instead of trying to
optimize into a fixed stack allocated buffer.



I wanted to do that and started rewriting it, but I found out we use
static buffers in lot of places and lot of them then use snprintf or
similar.  In some cases it doesn't even make much of a sense, e.g.:

 snprintf(buf, 3, "%d", var)

even this can fail.  I get the reason for the warning, but I don't
really agree that it's something that is necessary to avoid, so I'm
inclining to ignoring that warning as well.



Regards,
Daniel
--
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Daniel P. Berrange]

On Wed, Jun 14, 2017 at 04:30:49PM +0200, Martin Kletzander wrote:
> On Wed, Jun 14, 2017 at 02:32:41PM +0100, Daniel P. Berrange wrote:
> > On Wed, Jun 14, 2017 at 03:27:25PM +0200, Martin Kletzander wrote:
> > > On Wed, Jun 14, 2017 at 11:20:44AM +0100, Daniel P. Berrange wrote:
> > > > This fixes an incompatibility with glibc 2.25.90
> > > >
> > > > Signed-off-by: Daniel P. Berrange 
> > > > ---
> > > >
> > > > Pushed as a broken build fix to get CI back online
> > > >
> > > 
> > > After this update the build fails for me with gcc-7.1.0 with the
> > > following error:
> > > 
> > > In file included from util/virobject.c:28:0:
> > > util/virobject.c: In function 'virClassNew':
> > > util/viratomic.h:176:46: error: this condition has identical branches 
> > > [-Werror=duplicated-branches]
> > > (void)(0 ? *(atomic) ^ *(atomic) : 0);  \
> > >  ^
> > > util/virobject.c:144:20: note: in expansion of macro 'virAtomicIntInc'
> > > klass->magic = virAtomicIntInc();
> > >^~~
> > > 
> > > Does that mean that gcc does optimize our prefetch trick away
> > > (considering I understood what that line is trying to do)?  Or should we
> > > just turn the warning off for that header file?
> > 
> > Yep, "-Wduplicated-branches" appears to be a new warning flag in gcc 7.1
> > which gnulib turns on. There's a similar hit with mingw
> > 
> > ../../src/util/vircommand.c: In function 'virCommandWait':
> > ../../src/util/vircommand.c:2562:51: error: this condition has identical 
> > branches [-Werror=duplicated-branches]
> > *exitstatus = cmd->rawStatus ? status : WEXITSTATUS(status);
> >   ^
> > cc1: all warnings being treated as errors
> > 
> > 
> > because WEXITSTATUS(x) expands to 'x' on Win32.
> > 
> > We could use a pragma to turn off selectively, but I'm more
> > inclined to just disable this new warning flag.
> > 
> 
> Well, I'm not sure how that affects the line where we actually use it
> (with the atomic variables) or whether that line is not needed anymore
> (if that was a fix for older compilers or something similar).  But I
> can send a patch for removing that warning.  How about the other
> warning we get when we turn off the first one?  I just found out.  I
> think that could be turned off as well, either for some particular
> places or for the whole build:
> 
> util/virtime.c: In function 'virTimeStringThenRaw':
> util/virtime.c:215:9: error: '%02d' directive output may be truncated writing 
> between 2 and 11 bytes into a region of size between 5 and 21 
> [-Werror=format-truncation=]
> if (snprintf(buf, VIR_TIME_STRING_BUFLEN,
> ^
>  "%4d-%02d-%02d %02d:%02d:%02d.%03d+",
>  ~
>  fields.tm_year, fields.tm_mon, fields.tm_mday,
>  ~~
>  fields.tm_hour, fields.tm_min, fields.tm_sec,
>  ~
>  (int) (when % 1000)) >= VIR_TIME_STRING_BUFLEN) {
>  
> util/virtime.c:215:9: note: using the range [-2147483648, 2147483647] for 
> directive argument
> In file included from /usr/include/stdio.h:936:0,
> from ../gnulib/lib/stdio.h:43,
> from util/virtime.c:36:
> /usr/include/bits/stdio2.h:64:10: note: '__builtin___snprintf_chk' output 
> between 29 and 89 bytes into a destination of size 29
>   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
>  ^~~~
>__bos (__s), __fmt, __va_arg_pack ());
>~

I think we might just want to switch to asprintf here instead of trying to
optimize into a fixed stack allocated buffer.


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Martin Kletzander]

On Wed, Jun 14, 2017 at 02:32:41PM +0100, Daniel P. Berrange wrote:

On Wed, Jun 14, 2017 at 03:27:25PM +0200, Martin Kletzander wrote:

On Wed, Jun 14, 2017 at 11:20:44AM +0100, Daniel P. Berrange wrote:
> This fixes an incompatibility with glibc 2.25.90
>
> Signed-off-by: Daniel P. Berrange 
> ---
>
> Pushed as a broken build fix to get CI back online
>

After this update the build fails for me with gcc-7.1.0 with the
following error:

In file included from util/virobject.c:28:0:
util/virobject.c: In function 'virClassNew':
util/viratomic.h:176:46: error: this condition has identical branches 
[-Werror=duplicated-branches]
(void)(0 ? *(atomic) ^ *(atomic) : 0);  \
 ^
util/virobject.c:144:20: note: in expansion of macro 'virAtomicIntInc'
klass->magic = virAtomicIntInc();
   ^~~

Does that mean that gcc does optimize our prefetch trick away
(considering I understood what that line is trying to do)?  Or should we
just turn the warning off for that header file?


Yep, "-Wduplicated-branches" appears to be a new warning flag in gcc 7.1
which gnulib turns on. There's a similar hit with mingw

../../src/util/vircommand.c: In function 'virCommandWait':
../../src/util/vircommand.c:2562:51: error: this condition has identical 
branches [-Werror=duplicated-branches]
*exitstatus = cmd->rawStatus ? status : WEXITSTATUS(status);
  ^
cc1: all warnings being treated as errors


because WEXITSTATUS(x) expands to 'x' on Win32.

We could use a pragma to turn off selectively, but I'm more
inclined to just disable this new warning flag.



Well, I'm not sure how that affects the line where we actually use it
(with the atomic variables) or whether that line is not needed anymore
(if that was a fix for older compilers or something similar).  But I
can send a patch for removing that warning.  How about the other
warning we get when we turn off the first one?  I just found out.  I
think that could be turned off as well, either for some particular
places or for the whole build:

util/virtime.c: In function 'virTimeStringThenRaw':
util/virtime.c:215:9: error: '%02d' directive output may be truncated writing 
between 2 and 11 bytes into a region of size between 5 and 21 
[-Werror=format-truncation=]
if (snprintf(buf, VIR_TIME_STRING_BUFLEN,
^
 "%4d-%02d-%02d %02d:%02d:%02d.%03d+",
 ~
 fields.tm_year, fields.tm_mon, fields.tm_mday,
 ~~
 fields.tm_hour, fields.tm_min, fields.tm_sec,
 ~
 (int) (when % 1000)) >= VIR_TIME_STRING_BUFLEN) {
 
util/virtime.c:215:9: note: using the range [-2147483648, 2147483647] for 
directive argument
In file included from /usr/include/stdio.h:936:0,
from ../gnulib/lib/stdio.h:43,
from util/virtime.c:36:
/usr/include/bits/stdio2.h:64:10: note: '__builtin___snprintf_chk' output 
between 29 and 89 bytes into a destination of size 29
  return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
 ^~~~
   __bos (__s), __fmt, __va_arg_pack ());
   ~





Regards,
Daniel
--
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Daniel P. Berrange]

On Wed, Jun 14, 2017 at 03:27:25PM +0200, Martin Kletzander wrote:
> On Wed, Jun 14, 2017 at 11:20:44AM +0100, Daniel P. Berrange wrote:
> > This fixes an incompatibility with glibc 2.25.90
> > 
> > Signed-off-by: Daniel P. Berrange 
> > ---
> > 
> > Pushed as a broken build fix to get CI back online
> > 
> 
> After this update the build fails for me with gcc-7.1.0 with the
> following error:
> 
> In file included from util/virobject.c:28:0:
> util/virobject.c: In function 'virClassNew':
> util/viratomic.h:176:46: error: this condition has identical branches 
> [-Werror=duplicated-branches]
> (void)(0 ? *(atomic) ^ *(atomic) : 0);  \
>  ^
> util/virobject.c:144:20: note: in expansion of macro 'virAtomicIntInc'
> klass->magic = virAtomicIntInc();
>^~~
> 
> Does that mean that gcc does optimize our prefetch trick away
> (considering I understood what that line is trying to do)?  Or should we
> just turn the warning off for that header file?

Yep, "-Wduplicated-branches" appears to be a new warning flag in gcc 7.1
which gnulib turns on. There's a similar hit with mingw

../../src/util/vircommand.c: In function 'virCommandWait':
../../src/util/vircommand.c:2562:51: error: this condition has identical 
branches [-Werror=duplicated-branches]
 *exitstatus = cmd->rawStatus ? status : WEXITSTATUS(status);
   ^
cc1: all warnings being treated as errors


because WEXITSTATUS(x) expands to 'x' on Win32.

We could use a pragma to turn off selectively, but I'm more
inclined to just disable this new warning flag. 




Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Martin Kletzander]

On Wed, Jun 14, 2017 at 11:20:44AM +0100, Daniel P. Berrange wrote:

This fixes an incompatibility with glibc 2.25.90

Signed-off-by: Daniel P. Berrange 
---

Pushed as a broken build fix to get CI back online



After this update the build fails for me with gcc-7.1.0 with the
following error:

In file included from util/virobject.c:28:0:
util/virobject.c: In function 'virClassNew':
util/viratomic.h:176:46: error: this condition has identical branches 
[-Werror=duplicated-branches]
(void)(0 ? *(atomic) ^ *(atomic) : 0);  \
 ^
util/virobject.c:144:20: note: in expansion of macro 'virAtomicIntInc'
klass->magic = virAtomicIntInc();
   ^~~

Does that mean that gcc does optimize our prefetch trick away
(considering I understood what that line is trying to do)?  Or should we
just turn the warning off for that header file?


.gnulib | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index da830b5..ce4ee4c 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit da830b5146cb553ac2a4bcfe76caeb57bda24cc3
+Subproject commit ce4ee4cbb596a9d7de2786cf8c48cf62a4edede7
--
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Daniel P. Berrange]

This fixes an incompatibility with glibc 2.25.90

Signed-off-by: Daniel P. Berrange 
---

Pushed as a broken build fix to get CI back online

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index da830b5..ce4ee4c 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit da830b5146cb553ac2a4bcfe76caeb57bda24cc3
+Subproject commit ce4ee4cbb596a9d7de2786cf8c48cf62a4edede7
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Andrea Bolognani]

On Mon, 2017-05-15 at 10:08 +0100, Daniel P. Berrange wrote:
> This pulls in the fixes for poll() on Win32 which finally
> makes the remote driver work again.
> 
> Signed-off-by: Daniel P. Berrange 
> ---
>  .gnulib | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gnulib b/.gnulib
> index 94386a1..da830b5 16
> --- a/.gnulib
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit 94386a13667c645fd42544a7fd302c39fcdf
> +Subproject commit da830b5146cb553ac2a4bcfe76caeb57bda24cc3

ACK

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Daniel P. Berrange]

This pulls in the fixes for poll() on Win32 which finally
makes the remote driver work again.

Signed-off-by: Daniel P. Berrange 
---
 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 94386a1..da830b5 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 94386a13667c645fd42544a7fd302c39fcdf
+Subproject commit da830b5146cb553ac2a4bcfe76caeb57bda24cc3
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Among other recent changes, this includes a workaround to avoid
Clang compiler bug https://llvm.org/bugs/show_bug.cgi?id=16404
having spurious link failures.

* .gnulib: Update.
* bootstrap: Synchronize to upstream.

Signed-off-by: Eric Blake 
---

I'm debating about re-enabling test-lock (right now, we explicitly
pass --avoid=lock-tests to gnulib-tool via our bootstrap.conf), now
that upstream is finally starting to fix the bugs in the test that
were causing extremely slow completion or outright hangs on
multi-processor setups.  But that's probably something better done
right after a libvirt release, not right before a release candidate.

Pushing under the gnulib maintenance rule; contains these gnulib patches:

* .gnulib e210a3c...94386a1 (38):
  > maint.mk: enforce spelling of "timestamp" (i.e., no space)
  > dfa: minor simplification with emptyset
  > dfa: shrink constraints from 4 bits to 3
  > dfa: omit unnecessary ptrdiff_t check
  > dfa: omit unnecessary allocation
  > dfa: omit unused local
  > maint: time stamp -> timestamp
  > maint: remove stray .texi files
  > getprogname: fix port to IRIX
  > dfa: melt down dfastate into build_state
  > dfa: simplify transition table allocation
  > dfa: fix reallocation bug when matching newlines
  > Avoid -Wundef warning about undefined WINDOWS_SOCKETS.
  > Avoid -Wundef warning about undefined __USE_FILE_OFFSET64.
  > stdioext: Port to Minix 3.2 and newer.
  > getprogname: port to IRIX
  > localename-tests: port to NetBSD 7
  > glob, intprops, xalloc: work around Clang bug
  > dfa: fix 'return' typo
  > lock tests: Prefer semaphore over mutex.
  > parse-datetime: fix generated paths for coverage files
  > maint.mk: support parallel execution of coverage
  > lock: Provide guarantee to avoid writer starvation for rwlocks.
  > thread: Fix pth port.
  > parse-datetime: fix debug message on lone year number
  > parse-datetime: fix local timezone debug messages
  > parse-datetime: add debug warning about DST changes
  > parse-datetime: add debug warning about date arithmetic
  > parse-datetime: fix debug message of relative part after timezone
  > parse-datetime: fix incorrect debug message on lone number
  > exec
  > build-aux/mdate-sh
  > doc: fix typo in previous change
  > Revert copyright-year change to synced files
  > doc: modernize for C11 etc.
  > dfa: prefer functions to FETCH_WC macro
  > dfa: narrow more local var scopes
  > dfa: remove duplicate assignment

 .gnulib   | 2 +-
 bootstrap | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.gnulib b/.gnulib
index e210a3c..94386a1 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit e210a3cbaec0ee82a67ff8fc427e21bdd64dba1b
+Subproject commit 94386a13667c645fd42544a7fd302c39fcdf
diff --git a/bootstrap b/bootstrap
index 26066b2..932ff85 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2016-11-03.18; # UTC
+scriptversion=2017-01-09.19; # UTC

 # Bootstrap this package from checked-out sources.

@@ -790,7 +790,7 @@ symlink_to_dir()
   # Leave any existing symlink alone, if it already points to the source,
   # so that broken build tools that care about symlink times
   # aren't confused into doing unnecessary builds.  Conversely, if the
-  # existing symlink's time stamp is older than the source, make it afresh,
+  # existing symlink's timestamp is older than the source, make it afresh,
   # so that broken tools aren't confused into skipping needed builds.  See
   # .
   test -h "$dst" &&
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Michal Privoznik]

Required for the copyright year bump to keep 'make syntax-check'
happy, and also pulls in several portability fixes.

* .gnulib: Update to latest.
* bootstrap: Resync from upstream.

Signed-off-by: Michal Privoznik 
---

Pushed under gnulib-free-to-push rule.

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index c3b131294..e210a3cba 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit c3b131294aa42b7997cc9b9a0bbb2934aa27fd6c
+Subproject commit e210a3cbaec0ee82a67ff8fc427e21bdd64dba1b
-- 
2.11.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: Update to latest gnulib

[Andrea Bolognani]

In particular, this fixes the

  ./.gnulib/lib/version-etc.c
  maint.mk: out of date copyright in ./.gnulib/lib/version-etc.c; update it
  maint.mk:1196: recipe for target 'sc_copyright_check' failed

error when running 'make syntax-check' in 2017.
---
 .gnulib   | 2 +-
 bootstrap | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.gnulib b/.gnulib
index c3b1312..e210a3c 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit c3b131294aa42b7997cc9b9a0bbb2934aa27fd6c
+Subproject commit e210a3cbaec0ee82a67ff8fc427e21bdd64dba1b
diff --git a/bootstrap b/bootstrap
index 5d3c289..26066b2 100755
--- a/bootstrap
+++ b/bootstrap
@@ -4,7 +4,7 @@ scriptversion=2016-11-03.18; # UTC
 
 # Bootstrap this package from checked-out sources.
 
-# Copyright (C) 2003-2016 Free Software Foundation, Inc.
+# Copyright (C) 2003-2017 Free Software Foundation, Inc.
 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Martin Kletzander]

Fix mingw build regarding rpl_{printf,scanf} symbols.

Signed-off-by: Martin Kletzander 
---
Pushed under gnulib maintenance (just guessing what that means) and
build-breaker rules.

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 246b3b28808e..68b6adebef05 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 246b3b28808ee5f4664be674dce573af9497fc7a
+Subproject commit 68b6adebef05670a312fb92b05e7bd089d2ed43a
--
2.9.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 05/27/2016 08:40 AM, Andrea Bolognani wrote:

>> Was this an incremental or a clean build? If incremental, I suspect that
>> it may just be stale files left behind as gnulib shuffles things between
>> normal use and testsuite use.  I'm trying to reproduce now...
> 
> I ran into the same error with a completely clean
> build[1] on my fully up-to-date Fedora 23 system.

That explains it. Incremental didn't see if if you reused config.cache
from an earlier run where realpath detection was correct, while a clean
build probed incorrectly due to the gnulib regression.  It's all sorted
now, though.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 05/27/2016 09:40 AM, Cole Robinson wrote:

> 
> FWIW On Fedora 24 I'm not getting the issue that others are reporting, but
> there's this new build warning/error after the gnulib update:
> 
> In file included from ../include/libvirt/libvirt.h:38:0,
>  from ./internal.h:58,
>  from util/virlog.h:25,
>  from util/virarch.c:26:
> ../include/libvirt/libvirt-domain.h:1881:57: error: result of '1 << 31'
> requires 33 bits to represent, but 'int' only has 32 bits
> [-Werror=shift-overflow=]
>  VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS = 1 << 31, /* enforce
> requested stats */

That's because the new gnulib enables new gcc warnings, if you have
bleeding edge gcc (the way F24 does).  In this particular case, a fix
would be using 1U << 31; but there may be other new warnings we need to
silence.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 05/27/2016 09:22 AM, Ján Tomko wrote:
> On Fri, May 27, 2016 at 08:24:36AM -0600, Eric Blake wrote:
>> On 05/27/2016 04:33 AM, Michal Privoznik wrote:
>>

 Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.

>>>
>>> Unfortunately, this breaks build on my system:

> I have bisected it to:
> 54615b95ff238e235e806855efc46a9abad09f2e is the first bad commit
> commit 54615b95ff238e235e806855efc46a9abad09f2e
> Author: Paul Eggert 
> Date:   Sat Feb 6 18:11:48 2016 -0800
> 
> misc: port better to gcc -fsanitize=address

Thanks; I independently came to the same conclusion, and have pushed the
new gnulib submodule.


>char *name2 = realpath ("conftest.d//./..", NULL);
> -  if (! (name1 && name2 && strcmp (name1, name2) != 0))
> +  if ((name1 && name2 && strcmp (name1, name2) != 0))

Not quite. Paul's (buggy) fix was trying to ensure that strcmp() can't
be called on NULL, but the correct fix is:

if (! (name1 && name2) && strcmp (name1, name2) != 0)

or, by deMorgan's law,

if (! name1 || ! name2 || strcmp (name1, name2))

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Fix a regression in checking for realpath (which caused link
failures regarding duplicate rpl_canonicalize_file_name), and
fix the mingw build regarding unsetenv.

* .gnulib: Update to latest.

Signed-off-by: Eric Blake 
---

Fixes the reported failure with canonicalize_file_name,
but there's still the issue of new gcc warnings enabled
which affect F24 with its newer gcc.

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

* .gnulib 8d807a9...246b3b2 (3):
> canonicalize: Fix broken probe for realpath.
> unsetenv: relax to LGPLv2+
> update from texinfo

diff --git a/.gnulib b/.gnulib
index 8d807a9..246b3b2 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 8d807a99c6e8eecd2a9cf7c7b5d48ec0b2c934f8
+Subproject commit 246b3b28808ee5f4664be674dce573af9497fc7a
-- 
2.5.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Cole Robinson]

On 05/26/2016 11:07 PM, Eric Blake wrote:
> On 05/26/2016 09:52 AM, Eric Blake wrote:
>> Pulls in several portability fixes, including the fact that gnulib
>> now only works on platforms with two's complement signed integers.
>> Also makes for a smaller delta on the next update (we are waiting
>> on a license change to unsetenv for the sake of mingw).
>>
>> * .gnulib: Update to latest.
>> * bootstrap: Resync from upstream.
>> * tests/virstringtest.c: Drop use of obsolete probes of integer
>> properties.
>>
>> Signed-off-by: Eric Blake 
>> ---
>>
>> I'd like to get this in now, before RC1 is cut, so that we maximize
>> the testing of the bulk of the gnulib changes (rather than waiting
>> for the unsetenv change needed for mingw to land, but forcing the
>> gnulib update to only get testing in RC2).
> 
> Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.
> 

FWIW On Fedora 24 I'm not getting the issue that others are reporting, but
there's this new build warning/error after the gnulib update:

In file included from ../include/libvirt/libvirt.h:38:0,
 from ./internal.h:58,
 from util/virlog.h:25,
 from util/virarch.c:26:
../include/libvirt/libvirt-domain.h:1881:57: error: result of '1 << 31'
requires 33 bits to represent, but 'int' only has 32 bits
[-Werror=shift-overflow=]
 VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS = 1 << 31, /* enforce
requested stats */

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Ján Tomko]

On Fri, May 27, 2016 at 08:24:36AM -0600, Eric Blake wrote:
> On 05/27/2016 04:33 AM, Michal Privoznik wrote:
> 
> >>
> >> Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.
> >>
> > 
> > Unfortunately, this breaks build on my system:
> > 
> > make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tests' 
> > CCLD virpcimock.la
> > ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function 
> > `rpl_canonicalize_file_name':
> > /home/zippy/work/libvirt/libvirt.git/gnulib/lib/canonicalize-lgpl.c:400: 
> > multiple definition of `rpl_canonicalize_file_name'
> > .libs/virpcimock_la-virpcimock.o:/home/zippy/work/libvirt/libvirt.git/tests/virpcimock.c:939:
> >  first defined here
> > collect2: error: ld returned 1 exit status
> > 
> > Worse, I have no idea how to fix this.
> 
> Was this an incremental or a clean build? If incremental, I suspect that
> it may just be stale files left behind as gnulib shuffles things between
> normal use and testsuite use.  I'm trying to reproduce now...

I have bisected it to:
54615b95ff238e235e806855efc46a9abad09f2e is the first bad commit
commit 54615b95ff238e235e806855efc46a9abad09f2e
Author: Paul Eggert 
Date:   Sat Feb 6 18:11:48 2016 -0800

misc: port better to gcc -fsanitize=address

Removing the stray negation fixes it for me:
diff --git a/m4/canonicalize.m4 b/m4/canonicalize.m4
index bfc9ebe..a1a4445 100644
--- a/m4/canonicalize.m4
+++ b/m4/canonicalize.m4
@@ -100,7 +100,7 @@ AC_DEFUN([gl_FUNC_REALPATH_WORKS],
 {
   char *name1 = realpath (".", NULL);
   char *name2 = realpath ("conftest.d//./..", NULL);
-  if (! (name1 && name2 && strcmp (name1, name2) != 0))
+  if ((name1 && name2 && strcmp (name1, name2) != 0))
 result |= 8;
   free (name1);
   free (name2);

Jan

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Michal Privoznik]

On 27.05.2016 16:24, Eric Blake wrote:
> On 05/27/2016 04:33 AM, Michal Privoznik wrote:
> 
>>>
>>> Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.
>>>
>>
>> Unfortunately, this breaks build on my system:
>>
>> make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tests' 
>> CCLD virpcimock.la
>> ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function 
>> `rpl_canonicalize_file_name':
>> /home/zippy/work/libvirt/libvirt.git/gnulib/lib/canonicalize-lgpl.c:400: 
>> multiple definition of `rpl_canonicalize_file_name'
>> .libs/virpcimock_la-virpcimock.o:/home/zippy/work/libvirt/libvirt.git/tests/virpcimock.c:939:
>>  first defined here
>> collect2: error: ld returned 1 exit status
>>
>> Worse, I have no idea how to fix this.
> 
> Was this an incremental or a clean build? If incremental, I suspect that
> it may just be stale files left behind as gnulib shuffles things between
> normal use and testsuite use.  I'm trying to reproduce now...
> 

Clean build here too.

And also here:
https://ci.centos.org/view/libvirt-project/job/libvirt-daemon-build/systems=libvirt-fedora-23/1377/console

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[John Ferlan]

On 05/27/2016 10:24 AM, Eric Blake wrote:
> On 05/27/2016 04:33 AM, Michal Privoznik wrote:
> 
>>>
>>> Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.
>>>
>>
>> Unfortunately, this breaks build on my system:
>>
>> make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tests' 
>> CCLD virpcimock.la
>> ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function 
>> `rpl_canonicalize_file_name':
>> /home/zippy/work/libvirt/libvirt.git/gnulib/lib/canonicalize-lgpl.c:400: 
>> multiple definition of `rpl_canonicalize_file_name'
>> .libs/virpcimock_la-virpcimock.o:/home/zippy/work/libvirt/libvirt.git/tests/virpcimock.c:939:
>>  first defined here
>> collect2: error: ld returned 1 exit status
>>
>> Worse, I have no idea how to fix this.
> 
> Was this an incremental or a clean build? If incremental, I suspect that
> it may just be stale files left behind as gnulib shuffles things between
> normal use and testsuite use.  I'm trying to reproduce now...
> 
> 

I'll pile on... me too...  F23

gcc version 5.3.1 20160406 (Red Hat 5.3.1-6) (GCC)

When the .gnulib is updated, I see autogen.sh being run - so what more
"cleanup" would be required?  A make clean doesn't help either. My setup
is essentially "./autogen.sh --system"...

John


$ make -j12 check syntax-check
INFO: gnulib update required; running ./autogen.sh first
./autogen.sh
running bootstrap...
./bootstrap: Bootstrapping from checked-out libvirt sources...
./bootstrap: consider installing git-merge-changelog from gnulib
./bootstrap: getting gnulib files...
Submodule path '.gnulib': checked out
'6cc32c63e80bc1a30c521b2f07f2b54909b59892'
./bootstrap: autopoint --force
running: libtoolize --install --copy
libtoolize:   error: 'build-aux/config.guess' is newer: use '--force' to
overwrite
libtoolize:   error: 'build-aux/config.sub' is newer: use '--force' to
overwrite
./bootstrap: .gnulib/gnulib-tool  --import --no-changelog --aux-dir
build-aux --doc-base doc --lib libgnu --m4-base m4/ --source-base
gnulib/lib/ --tests-base gnulib/tests --local-dir gnulib/local  --lgpl=2
--with-tests --makefile-name=gnulib.mk --avoid=pt_chown
--avoid=lock-tests --libtool --import ...
Module list with included dependencies (indented):
absolute-header
  accept
accept-tests
alloca
alloca-opt
alloca-opt-tests
allocator
...

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Andrea Bolognani]

On Fri, 2016-05-27 at 08:24 -0600, Eric Blake wrote:
> On 05/27/2016 04:33 AM, Michal Privoznik wrote:
> > 
> > > Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.
> > 
> > Unfortunately, this breaks build on my system:
> > 
> > make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tests' 
> > CCLD virpcimock.la
> > ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function 
> > `rpl_canonicalize_file_name':
> > /home/zippy/work/libvirt/libvirt.git/gnulib/lib/canonicalize-lgpl.c:400: 
> > multiple definition of
> > `rpl_canonicalize_file_name'
> > .libs/virpcimock_la-virpcimock.o:/home/zippy/work/libvirt/libvirt.git/tests/virpcimock.c:939:
> >  first defined here
> > collect2: error: ld returned 1 exit status
> > 
> > Worse, I have no idea how to fix this.
> 
> Was this an incremental or a clean build? If incremental, I suspect that
> it may just be stale files left behind as gnulib shuffles things between
> normal use and testsuite use.  I'm trying to reproduce now...

I ran into the same error with a completely clean
build[1] on my fully up-to-date Fedora 23 system.


[1] git clean -xdf && \
    git submodule foreach 'git clean -xdf'
-- 
Andrea Bolognani
Software Engineer - Virtualization Team

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 05/27/2016 04:33 AM, Michal Privoznik wrote:

>>
>> Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.
>>
> 
> Unfortunately, this breaks build on my system:
> 
> make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tests' CCLD 
> virpcimock.la
> ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function 
> `rpl_canonicalize_file_name':
> /home/zippy/work/libvirt/libvirt.git/gnulib/lib/canonicalize-lgpl.c:400: 
> multiple definition of `rpl_canonicalize_file_name'
> .libs/virpcimock_la-virpcimock.o:/home/zippy/work/libvirt/libvirt.git/tests/virpcimock.c:939:
>  first defined here
> collect2: error: ld returned 1 exit status
> 
> Worse, I have no idea how to fix this.

Was this an incremental or a clean build? If incremental, I suspect that
it may just be stale files left behind as gnulib shuffles things between
normal use and testsuite use.  I'm trying to reproduce now...

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Maxim Nestratov]

27.05.2016 13:33, Michal Privoznik пишет:


On 27.05.2016 05:07, Eric Blake wrote:

On 05/26/2016 09:52 AM, Eric Blake wrote:

Pulls in several portability fixes, including the fact that gnulib
now only works on platforms with two's complement signed integers.
Also makes for a smaller delta on the next update (we are waiting
on a license change to unsetenv for the sake of mingw).

* .gnulib: Update to latest.
* bootstrap: Resync from upstream.
* tests/virstringtest.c: Drop use of obsolete probes of integer
properties.

Signed-off-by: Eric Blake 
---

I'd like to get this in now, before RC1 is cut, so that we maximize
the testing of the bulk of the gnulib changes (rather than waiting
for the unsetenv change needed for mingw to land, but forcing the
gnulib update to only get testing in RC2).

Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.


Unfortunately, this breaks build on my system:

make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tests' CCLD   
  virpcimock.la
../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function 
`rpl_canonicalize_file_name':
/home/zippy/work/libvirt/libvirt.git/gnulib/lib/canonicalize-lgpl.c:400: 
multiple definition of `rpl_canonicalize_file_name'
.libs/virpcimock_la-virpcimock.o:/home/zippy/work/libvirt/libvirt.git/tests/virpcimock.c:939:
 first defined here
collect2: error: ld returned 1 exit status

Worse, I have no idea how to fix this.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Hmm, my build is broken too...

Maxim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Michal Privoznik]

On 27.05.2016 05:07, Eric Blake wrote:
> On 05/26/2016 09:52 AM, Eric Blake wrote:
>> Pulls in several portability fixes, including the fact that gnulib
>> now only works on platforms with two's complement signed integers.
>> Also makes for a smaller delta on the next update (we are waiting
>> on a license change to unsetenv for the sake of mingw).
>>
>> * .gnulib: Update to latest.
>> * bootstrap: Resync from upstream.
>> * tests/virstringtest.c: Drop use of obsolete probes of integer
>> properties.
>>
>> Signed-off-by: Eric Blake 
>> ---
>>
>> I'd like to get this in now, before RC1 is cut, so that we maximize
>> the testing of the bulk of the gnulib changes (rather than waiting
>> for the unsetenv change needed for mingw to land, but forcing the
>> gnulib update to only get testing in RC2).
> 
> Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.
> 

Unfortunately, this breaks build on my system:

make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tests' CCLD   
  virpcimock.la
../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function 
`rpl_canonicalize_file_name':
/home/zippy/work/libvirt/libvirt.git/gnulib/lib/canonicalize-lgpl.c:400: 
multiple definition of `rpl_canonicalize_file_name'
.libs/virpcimock_la-virpcimock.o:/home/zippy/work/libvirt/libvirt.git/tests/virpcimock.c:939:
 first defined here
collect2: error: ld returned 1 exit status

Worse, I have no idea how to fix this.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 05/26/2016 09:52 AM, Eric Blake wrote:
> Pulls in several portability fixes, including the fact that gnulib
> now only works on platforms with two's complement signed integers.
> Also makes for a smaller delta on the next update (we are waiting
> on a license change to unsetenv for the sake of mingw).
> 
> * .gnulib: Update to latest.
> * bootstrap: Resync from upstream.
> * tests/virstringtest.c: Drop use of obsolete probes of integer
> properties.
> 
> Signed-off-by: Eric Blake 
> ---
> 
> I'd like to get this in now, before RC1 is cut, so that we maximize
> the testing of the bulk of the gnulib changes (rather than waiting
> for the unsetenv change needed for mingw to land, but forcing the
> gnulib update to only get testing in RC2).

Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Pulls in several portability fixes, including the fact that gnulib
now only works on platforms with two's complement signed integers.
Also makes for a smaller delta on the next update (we are waiting
on a license change to unsetenv for the sake of mingw).

* .gnulib: Update to latest.
* bootstrap: Resync from upstream.
* tests/virstringtest.c: Drop use of obsolete probes of integer
properties.

Signed-off-by: Eric Blake 
---

I'd like to get this in now, before RC1 is cut, so that we maximize
the testing of the bulk of the gnulib changes (rather than waiting
for the unsetenv change needed for mingw to land, but forcing the
gnulib update to only get testing in RC2).

* .gnulib 6cc32c6...8d807a9 (127):
> gendocs.sh: Set default TOP_NODE_UP_URL in HTML output.
> manywarnings: update for GCC 6.1
> autoupdate
> intdiv0, memmem, nocrash, strcasestr, strstr: no exit
> glob: size_t overflow checks
> glob: don't assume INT_MAX < SIZE_MAX
> Fix undefined behaviour in gettext.h.
> autoupdate
> git-version-gen: avoid undefined shift
> update from texinfo
> glob: merge glibc changes into lib/glob.c
> mktime: spelling fix in comment
> mktime: port to stricter signed overflow checking
> mktime: speed up DEBUG_MKTIME benchmarks
> mktime: resurrect DEBUG_MKTIME testing
> mktime: simplify DEBUG_MKTIME
> Port mktime_internal offset to unsigned time_t
> xstrtol: prohibit monstrosities like "1bB"
> xstrtod: reinstate setting of *result upon ERANGE
> xstrtod: modify *result only if no errors
> btowc: document problems in C locale
> autoupdate
> update from texinfo
> mktime: improve integer overflow checking
> intprops: check two's complement assumption
> intprops, mktime, strtol: assume two's complement
> stdint: port to strict C11 left shift
> mbrtowc: work around glibc bug#19932
> update from texinfo
> autoupdate
> stdint: detect good enough pre-C++11 stdint.h in C++ mode
> argp: merge changes from glibc
> Prefer American spelling for "initialize"
> autoupdate
> stddef: support configuring with g++
> autoupdate
> autoupdate
> update from texinfo
> test-framework-sh: minor cleanups
> test-framework-sh: revert port to NetBSD 7.0
> autoupdate
> Port better to Alpine Linux
> test-framework-sh: port to NetBSD 7.0
> update from texinfo
> gitlog-to-changelog: suppress ignored chatter
> update from texinfo
> update from texinfo
> setlocale: add "sv" to Windows language table
> update from texinfo
> sys_select: port to new Cygwin
> test-userspec.c: do not trigger gcc's new -Wmisleading-indentation
> time_rz: port to clang -Wunused-const-variable
> std-gnu11: improve clang support
> select: port more to Intel 2016.1.150 compiler
> select: try to port to 2016.1.150 compiler
> localename-tests: memory allocation fixes
> intprops: make .h file license match module
> acl: fix missing return on Cygwin
> update from texinfo
> update from texinfo
> extern-inline: port to PGI CC
> update from texinfo
> update from texinfo
> signbit: port back to pre-C++11 GCC
> mountlist: recognize autofs-mounted remote file systems, too
> signbit: port to C++ with GCC 6
> regex: make it closer to libc
> regex: merge patches from libc
> update from texinfo
> update from texinfo
> autoupdate
> autoupdate
> stdalign: port to older HP and IBM cc
> stdalign: port to clang 3.7.0
> update from texinfo
> readdir_r: now obsolescent
> Use modern texinfo when syncing install.texi output from autoconf
> update from texinfo
> sync install.texi from autoconf
> misc: port better to gcc -fsanitize=address
> update from texinfo
> autoupdate
> verify-tests: also remove stray test-verify.Tpo
> std-gnu11: new module
> update from texinfo
> update from texinfo
> get-permissions, strftime: fix grammar in comments
> gettext: mark as obsolete
> gnulib-tool: don't give up on ln -s so easily
> closedir: fix OS/2-related typos
> openat_proc_name: fix that last '/' is overwritten on OS/2 kLIBC
> regex: treat [x] as x if x is a unibyte encoding error
> closedir, dirfd, opendir: port to OpenSolaris 5.10
> bootstrap: use American spelling
> @item needed inside @itemize
> hash-pjw-bare: fix comment
> wcwidth: Replace also on OpenBSD 5.8
> update from texinfo
> gnu-web-doc-update: fix addition of new files
> utimens-tests: avoid pulling gettext .m4 files
> regex: pacify static checkers
> regex: fix [ diagnostic
> regex: fix memory leaks
> fts: don't unconditionally use leaf optimization for NFS
> * gnulib-tool: fix stray debug line in previous patch
> gnulib-tool: don't assume ln -s works
> utimes: detect utimes() correctly on OS/2 kLIBC
> openat_proc_name: port to OS/2 kLIBC
> stdint: check _INTPTR_T_DECLARED for intptr_t etc.
> doc: mention unfixed issues with unsupported localtime() values
> Go back to gettext-0.19.7
> opendir, closedir, dirfd, fdopendir: port to OS/2 kLIBC
> dup, dup2, fcntl: support a directory fd on OS/2 kLIBC
> pipe_filter_ii_execute: port to OS/2 kLIBC
> wchar: fix "conflicting types" error for __wcwidth on OS/2 kLIBC
> w32spawn: clear 

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Required for the copyright year bump to keep 'make syntax-check'
happy, and also pulls in several portability fixes.

* .gnulib: Update to latest.
* bootstrap: Resync from upstream.
* gnulib/local/m4/ssize_t.m4.diff: Regenerate.

Signed-off-by: Eric Blake 
---

Pushing under the build-breaker rule.

 .gnulib | 2 +-
 bootstrap   | 2 +-
 gnulib/local/m4/ssize_t.m4.diff | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.gnulib b/.gnulib
index f39477d..6cc32c6 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit f39477dba778e99392948dd3dd19ec0d46aee932
+Subproject commit 6cc32c63e80bc1a30c521b2f07f2b54909b59892
diff --git a/bootstrap b/bootstrap
index e72894c..294c0bc 100755
--- a/bootstrap
+++ b/bootstrap
@@ -4,7 +4,7 @@ scriptversion=2014-12-08.12; # UTC

 # Bootstrap this package from checked-out sources.

-# Copyright (C) 2003-2015 Free Software Foundation, Inc.
+# Copyright (C) 2003-2016 Free Software Foundation, Inc.

 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
diff --git a/gnulib/local/m4/ssize_t.m4.diff b/gnulib/local/m4/ssize_t.m4.diff
index 12cff12..c4863b9 100644
--- a/gnulib/local/m4/ssize_t.m4.diff
+++ b/gnulib/local/m4/ssize_t.m4.diff
@@ -5,7 +5,7 @@ index 209d64c..5ea72a1 100644
 @@ -1,4 +1,4 @@
 -# ssize_t.m4 serial 5 (gettext-0.18.2)
 +# ssize_t.m4 serial 6 (gettext-0.18.2)
- dnl Copyright (C) 2001-2003, 2006, 2010-2015 Free Software Foundation, Inc.
+ dnl Copyright (C) 2001-2003, 2006, 2010-2016 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
 @@ -17,7 +17,21 @@ AC_DEFUN([gt_TYPE_SSIZE_T],
-- 
2.4.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 01/04/2016 01:47 PM, Eric Blake wrote:
> Required for the copyright year bump to keep 'make syntax-check'
> happy, and also pulls in several portability fixes.
> 
> * .gnulib: Update to latest.
> * bootstrap: Resync from upstream.
> * gnulib/local/m4/ssize_t.m4.diff: Regenerate.
> 
> Signed-off-by: Eric Blake 
> ---
> 
> Pushing under the build-breaker rule.
> 
>  .gnulib | 2 +-

For reference, this includes:

* .gnulib f39477d...6cc32c6 (193):
  > msvc-inval: fix problem with unset shell var
  > autoupdate
  > tests: for compare_(), use cmp -s where available
  > version-etc: new year
  > human: fix output buffer overrun by 1
  > autoupdate
  > maint: add missing ChangeLog entry for previous commit
  > maint: fix operator precedence in mbrtowc test
  > autoupdate
  > regexprops-generic: update from regex.h
  > strftime-tests: avoid false failure on OS X
  > update from texinfo
  > fts: ensure leaf optimization is used for NFS
  > fts: enable leaf optimization for XFS
  > non-recursive-gnulib-prefix-hack: preserve V_GPERF lines
  > intprops: comment fix
  > update from texinfo
  > intprops-test: work around GCC bug 68971
  > autoupdate
  > gnulib-tool: allow multiple --local-dir usage
  > fix freadptr to work with ungetc on all uClibc configs
  > update from texinfo
  > autoupdate
  > parse-datetime: relax license to LGPLv2+, for OSTree
  > update from texinfo
  > autoupdate
  > autoupdate
  > update from texinfo
  > xalloc-oversized: improve performance with GCC 5
  > intprops: new public macro EXPR_SIGNED
  > intprops: fix typo in clang port
  > test-timespec: fix typo in previous change
  > timespec-sub: fix overflow bug; add tests
  > intprops-test: suppress -Woverlength-strings
  > maint: add missing ChangeLog entry for previous commit
  > quotearg: add quotearg_n_style_colon()
  > intprops: revise _WRAPV macros, revert _OVERFLOW
  > intprops: add parentheses for when OP has precedence lower than "-"
  > quotearg: constify get_quoting_style parameters
  > quotearg: add support for $'' shell escaping
  > maint: use a more standard return from mbrtowc test
  > intprops: add WRAPV and const flavors for GCC 5
  > doc: use extended timezone format in iso-8601 example
  > update from texinfo
  > update from texinfo
  > update from texinfo
  > stdalign: port to Sun C 5.9
  > autoupdate
  > update from texinfo
  > autoupdate
  > time_rz: fix comment about tzalloc
  > update from texinfo
  > stdalign: work around pre-4.9 GCC x86 bug
  > maint.mk: sc_tight_scope: remove extraneous expressions
  > time_rz: return NULL if localtime_r fails
  > fts: port to C11 alignof
  > time_rz: avoid warning from bleeding-edge gcc's -Wnonnull
  > maint.mk: _gl_TS_function_match: fix "extern" name extracting regexp
  > maint.mk: sc_tight_scope: factor and support OS X
  > ChangeLog: fix typo: s/cound/count/
  > safe-alloc-tests: fix typo in license header
  > copy-file: fix mem leak in error case
  > localename: control langinfo.h inclusion
  > update from texinfo
  > binary-io, math, pthread, sys_socket, u64, unistd: port to strict C
  > accept4-tests: fix to avoid non portable flags
  > update from texinfo
  > update from texinfo
  > gnulib-tool: fix tests of 'extensions' module
  > unicase/locale-language: fix typo in utf-8 cookie
  > autoupdate
  > xalloc: do not worry about GCC 5 warning on 32 bit
  > xalloc: avoid GCC 5.1 warning on 32 bit
  > uniname/uniname-tests: avoid compiler warnings
  > autoupdate
  > mountlist: clean up of variable duplication
  > c-ctype: do not worry about EBCDIC + char signed
  > c-ctype: port better to z/OS EBCDIC
  > gnulib-common.m4: fix gl_PROG_AR_RANLIB/AM_PROG_AR clash
  > sockets: MS Windows initalization fixes
  > gc: fix detection of installed libgcrypt version
  > c-ctype: rewrite to use inline functions
  > fnmatch: add one more coding cookie
  > maint: add coding cookies to non-ASCII sources
  > gitlog-to-changelog: trim only trailing whitespaces
  > Test that c_iscntrl agrees with iscntrl, etc.
  > c-ctype: improve c_isascii testing
  > Fix ChangeLog typo
  > savewd: remove SAVEWD_CHDIR_READABLE
  > Update ChangeLog to match previous patch.
  > c-ctype: support EBCDIC-style c_isascii
  > c-ctype: assume EBCDIC 1047 for c_iscntrl
  > * modules/c-ctype (Depends-on): Add verify.
  > c-ctype: port better to EBCDIC
  > nanosleep: fix return code for interrupted replacement
  > autoupdate
  > Diagnose ERE '()|\1'
  > Revert previous patch, as it did not fix the bug after all.
  > regex: fix dangling-backreference bug
  > regex: merge patches from libc
  > autoupdate
  > autoupdate
  > autoupdate
  > autoupdate
  > ceill: detect buggy OpenBSD implementation
  > mountlist: add me_mntroot field on Linux machines
  > doc: Describe to use multiple instances of gnulib
  > autoupdate
  > autoupdate
  > base32: mark function as __attribute__ const
  > autoupdate
  > autoupdate
  > gnulib-tool: don't transform binary files with sed
  > autoupdate
  > 

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Incorporates fixes for cross-compiling to mingw on rawhide, where
gcc 5.1 changes detection of how to properly determine PRIdMAX.

* .gnulib: Update to latest, for mingw.

Signed-off-by: Eric Blake ebl...@redhat.com
---

I've missed the freeze for rc1, but confirmed that this update
is rather minimal and should only affect mingw (in particular, it
will fix cross-compilation failure under rawhide with gcc 5.1).

As such, I won't push without review, but I also argue that the
changeset is small enough that it should be safe if we agree to
take it before rc2.

* .gnulib 875ec93...c26527c (5):
   stdio: limit __gnu_printf__ witness to gcc 4.4+
   error: use correct printf attributes on mingw
   update from texinfo
   inttypes: force correct mingw PRIdMAX even without stdio.h
   stdio: fix probe on mingw under gcc 5.1

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 875ec93..c26527c 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 875ec93e1501d2d2a8bab1b64fa66b8ceb51dc67
+Subproject commit c26527cebbbf42ed1dbc50df0074861e0ebe33dc
-- 
2.1.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Time to update to new gnulib before a release.

gcc 5.1 introduced a new -Wformat-signedness, and new gnulib now
turns it on by default.  However, it is still rather lame at the
moment, because it warns for enums, even though there is no way
to control the signeness of an enum which does not use any members
that are negative or larger than INT_MAX, and even though such an
enum would always print the same for both %d and %u:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66249

In file included from ../../src/util/virarch.c:26:0:
../../src/util/virarch.c: In function 'virArchFromHost':
../../src/util/virarch.c:180:15: error: format '%d' expects argument of type 
'int', but argument 9 has type 'unsigned int' [-Werror=format=]
 VIR_DEBUG(Mapped %s to %d (%s),

So this patch turns off the new warning as part of enabling all
other new gcc 5.1 warnings that gnulib now enables.

* .gnulib: Update to latest, in part for gcc 5.1 interaction.
* m4/virt-compile-warnings.m4: Ignore -Wformat-signedness, for now.

Signed-off-by: Eric Blake ebl...@redhat.com
---

It looks like DV hasn't done the freeze yet, so I'll push this under
the gnulib rule. I still have a pending gnulib patch that helps the
build under rawhide mingw (where newer gcc broke how older gnulib
was probing for whether PRIdMAX was lld vs. I64d); that may miss
the freeze, but my goal in pushing this now is that if it is the only
gnulib change post-freeze, then we are minimizing the risk on other
platforms by getting the rest picked up now.

* .gnulib 106a386...875ec93 (34):
 autoupdate
 gitlog-to-changelog: parse Tiny-change
 update from texinfo
 doc: document glibc posix_fallocate() issues
 gendocs.sh: document new htmlarg default
 extern-inline: no need for workaround in GCC 5.1
 update from texinfo
 eealloc, pagealign_alloc, xalloc: avoid clang warnings
 tests: pacify GCC 5.1's stricter printf checking
 fts: port to GCC 5.1 with --enable-gcc-warnings
 file-has-acl: port to CentOS 6
 file-has-acl: always return false when ACLs aren't supported
 gettext: propagate po/Makefile.in.in too
 file-has-acl: new module, split from acl
 manywarnings: add GCC 5.1 warnings
 autoupdate
 doc: update FDL template to match FDL examples.
 lstat: fix cross-compilation 'ln -s' problem
 gendocs.sh: default to a common CSS style sheet for HTML output
 gnulib-tool: output bold attribute more portably
 qacl: Simplify HP-UX acl_nontrivial check
 acl: On Linux, check for acls without libacl
 acl, qacl: split off shared functions into separate object file
 git-version-gen: revert detect untagged revisions
 tempname: avoid unused parameter warnings
 git-version-gen: detect untagged revisions
 fseeko: fix build failure on NetBSD = 6
 gitlog-to-changelog: port to MS-Windows
 gendocs: new option --tex for texi2dvi options
 sync gettext .m4 files from gettext
 uniname/uniname-tests: fix failure due to alias
 hash: remove deprecated hash_insert0 function
 mountlist: remove dependency on libmount
 stddef: port to pre-C11 GCC on x86

 .gnulib | 2 +-
 m4/virt-compile-warnings.m4 | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 106a386..875ec93 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 106a3866d01f9dd57ab4f10dbeb0d5a8db73a9f7
+Subproject commit 875ec93e1501d2d2a8bab1b64fa66b8ceb51dc67
diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
index 8aebdb0..3dd0665 100644
--- a/m4/virt-compile-warnings.m4
+++ b/m4/virt-compile-warnings.m4
@@ -59,6 +59,8 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
 dontwarn=$dontwarn -Waggregate-return
 # gcc 4.4.6 complains this is C++ only; gcc 4.7.0 implies this from -Wall
 dontwarn=$dontwarn -Wenum-compare
+# gcc 5.1 -Wformat-signedness mishandles enums, not ready for prime time
+dontwarn=$dontwarn -Wformat-signedness

 # gcc 4.2 treats attribute(format) as an implicit attribute(nonnull),
 # which triggers spurious warnings for our usage
-- 
2.1.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 02/25/2015 06:13 AM, Daniel P. Berrange wrote:
 On Wed, Feb 25, 2015 at 06:09:42AM -0700, Eric Blake wrote:
 On 02/25/2015 12:20 AM, Martin Kletzander wrote:
 On Tue, Feb 24, 2015 at 09:04:00AM -0700, Eric Blake wrote:
 On 02/24/2015 09:00 AM, Eric Blake wrote:
 Needed to silence a valgrind detection of uninitialized memory:
 https://bugzilla.redhat.com/show_bug.cgi?id=1174147


 I've missed RC1, so I'll wait for a review on this one (are we sure
 that RC2 will be enough time to ensure the gnulib update doesn't
 cause regressions, basically).

From the list of changes I don't see any compelling reason to push it
 before release. ie, we're not waiting for any particular bug fix it
 includes.

We deferred for 1.2.13 because I had missed RC1.  But I'm in time for
1.2.14, so I'm pushing this now under the gnulib-maintenance rule.

Here's the final changeset to gnulib:

* .gnulib c27f1a3...106a386 (90):
   quotearg-simple-tests: add missing gl_FUNC_MMAP_ANON dependency
   yesno: make EOL optional in ENABLE_NLS case also
   fdopendir-tests: test it does not close its arg
   gitlog-to-changelog: trim trailing white space
   gitlog-to-changelog: new option --ignore-matching
   fdopendir: port better to MinGW
   fdopendir: fix typo in comment
   error: document all entry points provided
   autoupdate
   autoupdate
   autoupdate
   vasnprintf: pacify clang 3.5.0
   glob, etc.: port to MSVC v18 on MS-Windows 8.1
   poll: port to MSVC v18 on MS-Windows 8.1
   tests: support stderr verification with returns_()
   passfd: avoid valgrind uninitalised data warning
   uniwbrk/u32-wordbreaks-tests: fix copyright
   dup2: doc and test for Android bug
   Replace dup2() on Android
   Android doesn't define RLIM_SAVED_*
   autoupdate
   vasnprintf-posix-tests: use consistent test
   printf, isinf, etc.: noncanonical != NaN
   fts: remove redundant close() (trivial)
   getdtablesize: port better for Android
   poll: fixes for large fds
   fcntl: Fix cross compiling
   dup2, fcntl: cross-compiler better for Android
   getopt: give accurate ambiguity diagnostic on mem exhaustion
   getopt: don't crash on memory exhaustion
   tempname: allow compilation with C++ (trivial)
   dup2, fcntl: port to AIX
   getdtablesize, dup2, fcntl: port to Android
   localename: Implement gl_locale_name_thread_unsafe for Android
   More changelog fixes
   fts: avoid crash when a cycle is added while traversing
   uniname/uniname: support character alias
   Fix ChangeLog botches in my recent commits
   duplocale: Fix Android build of duplocale-tests
   signal_h: Fix Android build
   net_if: Handle content-free net/if.h system headers
   linkat_nofollow: Add fallback case for cross compiling
   euidaccess: Fix Android build
   getugroups: Fix Android build
   localename: Fix Android build
   getdtablesize: Fix Android build
   Assume unbroken ungetc() on Android
   Fix FILE struct compatibility with Android API level = 21
   tests: avoid recent -Werror=unused-variable regression in test-locale
   maint: various whitespace cleanups in tempname
   tests: provide returns_() to simplify exit status checking
   mountlist: only use libmount when specified
   uniname/unimame-tests: don't link with -lunistring
   fstrcmp: don't assume strlen  INT_MAX
   diffseq: prefer ptrdiff_t to ssize_t
   xalloc: fix typo that suppressed warnings
   full-read: fix license notice typo
   crypto/gc: fix a -Wswitch warning
   autoupdate
   update from texinfo
   tempname: new try_tempname function
   gnulib-tool: fix handling of patch(1) diagnostics
   bootstrap: exit immediately upon gnulib-tool failure
   symlinkat: include all required header files
   update from texinfo
   update from texinfo
   update from texinfo
   localename: support Solaris 12 and illumos
   locale: fix tests on illumos
   unictype: avoid undefined left-shift behavior
   libunistring: bump version of unitypes dependants
   unictype/category-none: fix link with libunistring
   unitypes: fix build with installed libunistring
   time: port to MinGW32 3.21
   update-copyright: apply to self
   libunistring: update to Unicode 7.0.0
   libunistring: update to Unicode 6.3.0
   libunistring: update to Unicode 6.2.0
   libunistring: update to Unicode 6.1.0
   uniwbrk/u32-wordbreaks-tests: add conformance test
   uniwbrk: ignore Extended/Format characters at BOL
   test-strstr.c: avoid a trivial leak
   update-copyright: recognize groff's \(co marker
   maint.mk: fix compatibility with OS X nm
   localcharset: improve charset detection on OS/2
   count-leading-zeros: use 64-bit intrinsics on 32-bit Windows
   count-leading-zeros: fix pragma typos
   autoupdate
   count-leading-zeros: avoid 64-bit intrinsics on 32-bit Windows
   uniname/uniname: update to Unicode 7.0.0



-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Daniel P. Berrange]

On Wed, Feb 25, 2015 at 06:09:42AM -0700, Eric Blake wrote:
 On 02/25/2015 12:20 AM, Martin Kletzander wrote:
  On Tue, Feb 24, 2015 at 09:04:00AM -0700, Eric Blake wrote:
  On 02/24/2015 09:00 AM, Eric Blake wrote:
  Needed to silence a valgrind detection of uninitialized memory:
  https://bugzilla.redhat.com/show_bug.cgi?id=1174147
 
  * .gnulib: Update to latest.
  * bootstrap: Resync to gnulib.
 
  Signed-off-by: Eric Blake ebl...@redhat.com
  ---
 
  I've missed RC1, so I'll wait for a review on this one (are we sure
  that RC2 will be enough time to ensure the gnulib update doesn't
  cause regressions, basically).
 
  
  Is it worth risking that due to one valgrind warning?  I don't
  remember more than maybe one time that gnulib caused a problem, but
  who knows.
 
 And the valgrind warning is harmless - it's complaining about passing
 uninitialized memory to a syscall, but that memory lives in the padding
 of a struct, and none of the code is actually acting on that memory
 (either on our side, or in the syscall).  If we want to just live with
 the warning until after the release, that would also be okay - we have
 up until the RC2 date to make the decision.
 
  
  Anyway, my limited testing didn't show any problems.
  
  The gnulib changelog:
 
 Most of the changes here are for Android, but I don't know of anyone
 building libvirt on that platform yet.  That said,...
 
 
  * .gnulib c27f1a3...8be5f2c (75):
passfd: avoid valgrind uninitalised data warning
 
 This one fixes the valgrind warning...
 
gnulib-tool: fix handling of patch(1) diagnostics
bootstrap: exit immediately upon gnulib-tool failure
 
 these two are useful to us as developers, but don't affect the code base...
 
count-leading-zeros: use 64-bit intrinsics on 32-bit Windows
count-leading-zeros: fix pragma typos
 
 and these might affect mingw builds.
 
 Any other opinions?

From the list of changes I don't see any compelling reason to push it
before release. ie, we're not waiting for any particular bug fix it
includes.

Regards,
Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Needed to silence a valgrind detection of uninitialized memory:
https://bugzilla.redhat.com/show_bug.cgi?id=1174147

* .gnulib: Update to latest.
* bootstrap: Resync to gnulib.

Signed-off-by: Eric Blake ebl...@redhat.com
---

I've missed RC1, so I'll wait for a review on this one (are we sure
that RC2 will be enough time to ensure the gnulib update doesn't
cause regressions, basically).

 .gnulib   | 2 +-
 bootstrap | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.gnulib b/.gnulib
index c27f1a3..8be5f2c 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit c27f1a356f2f321daa7f971ef276a1dbfa873bf8
+Subproject commit 8be5f2c10eeb05e52cc4a33cdcd37078742ff5db
diff --git a/bootstrap b/bootstrap
index 2fdf267..e72894c 100755
--- a/bootstrap
+++ b/bootstrap
@@ -915,7 +915,8 @@ if test $use_libtool = 1; then
   esac
 fi
 echo $0: $gnulib_tool $gnulib_tool_options --import ...
-$gnulib_tool $gnulib_tool_options --import $gnulib_modules 
+$gnulib_tool $gnulib_tool_options --import $gnulib_modules \
+  || die gnulib-tool failed

 for file in $gnulib_files; do
   symlink_to_dir $GNULIB_SRCDIR $file \
-- 
2.1.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 02/24/2015 09:00 AM, Eric Blake wrote:
 Needed to silence a valgrind detection of uninitialized memory:
 https://bugzilla.redhat.com/show_bug.cgi?id=1174147
 
 * .gnulib: Update to latest.
 * bootstrap: Resync to gnulib.
 
 Signed-off-by: Eric Blake ebl...@redhat.com
 ---
 
 I've missed RC1, so I'll wait for a review on this one (are we sure
 that RC2 will be enough time to ensure the gnulib update doesn't
 cause regressions, basically).

The gnulib changelog:

* .gnulib c27f1a3...8be5f2c (75):
   passfd: avoid valgrind uninitalised data warning
   uniwbrk/u32-wordbreaks-tests: fix copyright
   dup2: doc and test for Android bug
   Replace dup2() on Android
   Android doesn't define RLIM_SAVED_*
   autoupdate
   vasnprintf-posix-tests: use consistent test
   printf, isinf, etc.: noncanonical != NaN
   fts: remove redundant close() (trivial)
   getdtablesize: port better for Android
   poll: fixes for large fds
   fcntl: Fix cross compiling
   dup2, fcntl: cross-compiler better for Android
   getopt: give accurate ambiguity diagnostic on mem exhaustion
   getopt: don't crash on memory exhaustion
   tempname: allow compilation with C++ (trivial)
   dup2, fcntl: port to AIX
   getdtablesize, dup2, fcntl: port to Android
   localename: Implement gl_locale_name_thread_unsafe for Android
   More changelog fixes
   fts: avoid crash when a cycle is added while traversing
   uniname/uniname: support character alias
   Fix ChangeLog botches in my recent commits
   duplocale: Fix Android build of duplocale-tests
   signal_h: Fix Android build
   net_if: Handle content-free net/if.h system headers
   linkat_nofollow: Add fallback case for cross compiling
   euidaccess: Fix Android build
   getugroups: Fix Android build
   localename: Fix Android build
   getdtablesize: Fix Android build
   Assume unbroken ungetc() on Android
   Fix FILE struct compatibility with Android API level = 21
   tests: avoid recent -Werror=unused-variable regression in test-locale
   maint: various whitespace cleanups in tempname
   tests: provide returns_() to simplify exit status checking
   mountlist: only use libmount when specified
   uniname/unimame-tests: don't link with -lunistring
   fstrcmp: don't assume strlen  INT_MAX
   diffseq: prefer ptrdiff_t to ssize_t
   xalloc: fix typo that suppressed warnings
   full-read: fix license notice typo
   crypto/gc: fix a -Wswitch warning
   autoupdate
   update from texinfo
   tempname: new try_tempname function
   gnulib-tool: fix handling of patch(1) diagnostics
   bootstrap: exit immediately upon gnulib-tool failure
   symlinkat: include all required header files
   update from texinfo
   update from texinfo
   update from texinfo
   localename: support Solaris 12 and illumos
   locale: fix tests on illumos
   unictype: avoid undefined left-shift behavior
   libunistring: bump version of unitypes dependants
   unictype/category-none: fix link with libunistring
   unitypes: fix build with installed libunistring
   time: port to MinGW32 3.21
   update-copyright: apply to self
   libunistring: update to Unicode 7.0.0
   libunistring: update to Unicode 6.3.0
   libunistring: update to Unicode 6.2.0
   libunistring: update to Unicode 6.1.0
   uniwbrk/u32-wordbreaks-tests: add conformance test
   uniwbrk: ignore Extended/Format characters at BOL
   test-strstr.c: avoid a trivial leak
   update-copyright: recognize groff's \(co marker
   maint.mk: fix compatibility with OS X nm
   localcharset: improve charset detection on OS/2
   count-leading-zeros: use 64-bit intrinsics on 32-bit Windows
   count-leading-zeros: fix pragma typos
   autoupdate
   count-leading-zeros: avoid 64-bit intrinsics on 32-bit Windows
   uniname/uniname: update to Unicode 7.0.0

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Martin Kletzander]

On Tue, Feb 24, 2015 at 09:04:00AM -0700, Eric Blake wrote:

On 02/24/2015 09:00 AM, Eric Blake wrote:

Needed to silence a valgrind detection of uninitialized memory:
https://bugzilla.redhat.com/show_bug.cgi?id=1174147

* .gnulib: Update to latest.
* bootstrap: Resync to gnulib.

Signed-off-by: Eric Blake ebl...@redhat.com
---

I've missed RC1, so I'll wait for a review on this one (are we sure
that RC2 will be enough time to ensure the gnulib update doesn't
cause regressions, basically).




Is it worth risking that due to one valgrind warning?  I don't
remember more than maybe one time that gnulib caused a problem, but
who knows.

Anyway, my limited testing didn't show any problems.


The gnulib changelog:

* .gnulib c27f1a3...8be5f2c (75):
  passfd: avoid valgrind uninitalised data warning
  uniwbrk/u32-wordbreaks-tests: fix copyright
  dup2: doc and test for Android bug
  Replace dup2() on Android
  Android doesn't define RLIM_SAVED_*
  autoupdate
  vasnprintf-posix-tests: use consistent test
  printf, isinf, etc.: noncanonical != NaN
  fts: remove redundant close() (trivial)
  getdtablesize: port better for Android
  poll: fixes for large fds
  fcntl: Fix cross compiling
  dup2, fcntl: cross-compiler better for Android
  getopt: give accurate ambiguity diagnostic on mem exhaustion
  getopt: don't crash on memory exhaustion
  tempname: allow compilation with C++ (trivial)
  dup2, fcntl: port to AIX
  getdtablesize, dup2, fcntl: port to Android
  localename: Implement gl_locale_name_thread_unsafe for Android
  More changelog fixes
  fts: avoid crash when a cycle is added while traversing
  uniname/uniname: support character alias
  Fix ChangeLog botches in my recent commits
  duplocale: Fix Android build of duplocale-tests
  signal_h: Fix Android build
  net_if: Handle content-free net/if.h system headers
  linkat_nofollow: Add fallback case for cross compiling
  euidaccess: Fix Android build
  getugroups: Fix Android build
  localename: Fix Android build
  getdtablesize: Fix Android build
  Assume unbroken ungetc() on Android
  Fix FILE struct compatibility with Android API level = 21
  tests: avoid recent -Werror=unused-variable regression in test-locale
  maint: various whitespace cleanups in tempname
  tests: provide returns_() to simplify exit status checking
  mountlist: only use libmount when specified
  uniname/unimame-tests: don't link with -lunistring
  fstrcmp: don't assume strlen  INT_MAX
  diffseq: prefer ptrdiff_t to ssize_t
  xalloc: fix typo that suppressed warnings
  full-read: fix license notice typo
  crypto/gc: fix a -Wswitch warning
  autoupdate
  update from texinfo
  tempname: new try_tempname function
  gnulib-tool: fix handling of patch(1) diagnostics
  bootstrap: exit immediately upon gnulib-tool failure
  symlinkat: include all required header files
  update from texinfo
  update from texinfo
  update from texinfo
  localename: support Solaris 12 and illumos
  locale: fix tests on illumos
  unictype: avoid undefined left-shift behavior
  libunistring: bump version of unitypes dependants
  unictype/category-none: fix link with libunistring
  unitypes: fix build with installed libunistring
  time: port to MinGW32 3.21
  update-copyright: apply to self
  libunistring: update to Unicode 7.0.0
  libunistring: update to Unicode 6.3.0
  libunistring: update to Unicode 6.2.0
  libunistring: update to Unicode 6.1.0
  uniwbrk/u32-wordbreaks-tests: add conformance test
  uniwbrk: ignore Extended/Format characters at BOL
  test-strstr.c: avoid a trivial leak
  update-copyright: recognize groff's \(co marker
  maint.mk: fix compatibility with OS X nm
  localcharset: improve charset detection on OS/2
  count-leading-zeros: use 64-bit intrinsics on 32-bit Windows
  count-leading-zeros: fix pragma typos
  autoupdate
  count-leading-zeros: avoid 64-bit intrinsics on 32-bit Windows
  uniname/uniname: update to Unicode 7.0.0

--
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org






--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


pgp5hOxiXqNgU.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 01/05/2015 09:06 AM, Daniel P. Berrange wrote:
 Sync to latest gnulib to get files updated with 2015 copyright
 date to fix syntax-check
 
 * .gnulib: update to latest
 * bootstrap: Regenerate from upstream
 
 Signed-off-by: Daniel P. Berrange berra...@redhat.com
 ---
  .gnulib   | 2 +-
  bootstrap | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
 
 Pushed as build-breaker fix for 'make syntax-check' year check

Except that gnulib still has a broken issue that prevents mingw builds
from working due to an incorrect PRIdMAX definition.  I'll be working on
that, then push yet another gnulib update to libvirt once gnulib is fixed.

We probably also ought to patch all our standalone executables (such as
virsh) to output 2015 in their --version output.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Another update is required to pick up today's gnulib fix for mingw
builds (now that gnulib turns on mingw's replacement printf that
understands %lld, it must also tell the compiler to respect the
improved definition of PRIdMAX and friends).

* .gnulib: Update to latest.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under the build-breaker rule.

* .gnulib 498a1b6...c27f1a3 (3):
   doc: update INSTALL from autoconf
   stdio: fix use of PRIdMAX on modern mingw
   Fix check for pthreads.h pollution on Mingw64

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 498a1b6..c27f1a3 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 498a1b6bc7d70f944ca0f939e1bc470889fdce76
+Subproject commit c27f1a356f2f321daa7f971ef276a1dbfa873bf8
-- 
2.1.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Daniel P. Berrange]

Sync to latest gnulib to get files updated with 2015 copyright
date to fix syntax-check

* .gnulib: update to latest
* bootstrap: Regenerate from upstream

Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
 .gnulib   | 2 +-
 bootstrap | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Pushed as build-breaker fix for 'make syntax-check' year check

diff --git a/.gnulib b/.gnulib
index 3914f31..498a1b6 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 3914f3153576e9a5ba4002bde27de05211b5a79c
+Subproject commit 498a1b6bc7d70f944ca0f939e1bc470889fdce76
diff --git a/bootstrap b/bootstrap
index e0c4ec2..2fdf267 100755
--- a/bootstrap
+++ b/bootstrap
@@ -4,7 +4,7 @@ scriptversion=2014-12-08.12; # UTC
 
 # Bootstrap this package from checked-out sources.
 
-# Copyright (C) 2003-2014 Free Software Foundation, Inc.
+# Copyright (C) 2003-2015 Free Software Foundation, Inc.
 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
-- 
2.1.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Several portability changes, but the one we are most interested in
is the improvement to bootstrap to detect perl modules.

This patch doesn't actually change our bootstrap requirements
(that will be a separate patch), but sets the stage for it.

* .gnulib: Update to latest, for bootstrap improvements.
* bootstrap: Regenerate from upstream.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Upstream gnulib is still working out an issue with modern mingw
supporting %lld in printf by default; until that is sorted, we do
not want to pick up gnulib cf88e56 in isolation.

Pushing under the gnulib maintenance rule, before we freeze.

* .gnulib 9565c3b...3914f31 (67):
   bootstrap: Allow perl modules in $buildreq
   apply _GL_ATTRIBUTE_PURE to some inline functions
   vasnprintf: fix potential incorrect errno
   vasnprintf: fix potential use after free
   autoupdate
   filevercmp, posixtm: avoid compiler warnings with -O3
   Fix LDBL80_WORDS macro on big endian platforms.
   autoupdate
   git-version-gen: do not print new line characters
   gnulib-tool: recognize x:* as an absolute path
   argp: avoid extraneous translation and mem leak with empty pre doc
   autoupdate
   doc: mention that _BSD_SOURCE is deprecated for _DEFAULT_SOURCE
   uniname/uniname-tests: skip if system's libunistring is used
   printf: fix configure check on big endian systems
   pipe-filter-gi, pipe-filter-ii: port to AIX
   gitlog-to-changelog: add --until
   update from texinfo
   extern-inline: update commentary about GCC bugs
   gen-uni-tables: untabify
   gen-uni-tables: check out-of-range values added to 3-level tables
   gen-uni-tables: utilize 'assert'
   gen-uni-tables: cosmetic improvements
   fcntl-h-tests: port to PA-RISC GNU/Linux
   fts: port to C89
   unistd: port to iOS
   obstack: do not reject malloc-style obstack_chunkfun, obstack_freefun
   autoupdate
   update from texinfo
   obstack: avoid potentially-nonportable function casts
   obstack: fix macro return values
   obstack: do not assume system-supplied obstack is size_t safe
   obstack: port to platforms that #define __alignof__
   linkat: don't unconditionally replace on GNU/Linux
   linkat: wrap to handle symlinks on OS X 10.10
   open, openat: document nonstandard FreeBSD, NetBSD O_NOFOLLOW errno
   obstack: add NEWS entry for recent incompatible changes
   mountlist: don't use libmount to decide on dummy/remote
   maint: add missing ChangeLog entries for Modra's obstack changes
   obstack: prefer __alignof__ to alignof
   obstack: prefer alignof to calculating alignments by hand
   obstack: use size_t alignments and check for overflow
   obstack: 64-bit obstack support, part 3
   obstack: 64-bit obstack support, part 2
   obstack: 64-bit obstack support, part 1
   obstack: tidy part 2
   obstack: tidy part 1
   socketlib, sockets, sys_socket: Use AC_REQUIRE to pacify autoconf.
   iconv: avoid false detection of non-working iconv
   bootstrap: print more diagnostics for missing programs
   bootstrap: only update the gnulib submodule
   symlinkat: port to AIX 7.1
   readlinkat: port to AIX 7.1
   remove spurious {
   modules/fcntl: fix error reporting by dupfd
   basename, dirname: Improve documentation.
   exclude: declare exclude_patopts static
   autoupdate
   dirname: support compilation with C++
   qsort_r: include config.h
   avltree-list: avoid compiler warnings
   qsort_r: new module, for GNU-style qsort_r
   strerror_r-posix: support compilation with C++
   fcntl-h: fix compilation with Intel C++ compiler
   autoupdate
   mountlist: use /proc/self/mountinfo when available
   users.txt: add cmogstored

---
 .gnulib   |  2 +-
 bootstrap | 42 ++
 2 files changed, 35 insertions(+), 9 deletions(-)

diff --git a/.gnulib b/.gnulib
index 9565c3b..3914f31 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 9565c3be73eb6d76b7b42a21d68d2e00a62abb6d
+Subproject commit 3914f3153576e9a5ba4002bde27de05211b5a79c
diff --git a/bootstrap b/bootstrap
index ce90bc4..e0c4ec2 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2013-12-05.23; # UTC
+scriptversion=2014-12-08.12; # UTC

 # Bootstrap this package from checked-out sources.

@@ -42,6 +42,9 @@ export LC_ALL

 local_gl_dir=gl

+# Honour $PERL, but work even if there is none
+PERL=${PERL-perl}
+
 me=$0

 usage() {
@@ -210,7 +213,17 @@ bootstrap_sync=false
 use_git=true

 check_exists() {
-  ($1 --version /dev/null) /dev/null 21
+  if test $1 = --verbose; then
+($2 --version /dev/null) /dev/null 21
+if test $? -ge 126; then
+  # If not found, run with diagnostics as one may be
+  # presented with env variables to set to find the right version
+  ($2 --version /dev/null)
+fi
+  else
+($1 --version /dev/null) /dev/null 21
+  fi
+
   test $? -lt 126
 }

@@ -408,7 +421,7 @@ sort_ver() { # sort -V is not generally available
 get_version() {
   app=$1

-  $app --version /dev/null 21 || 

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

When run under an environment that inherits an ignored SIGPIPE
(hello, annoying buildbots), a syntax-check was producing quite
a bit of noise, such as:

 prohibit_argmatch_without_use
 grep: write error
 grep: write error
 /bin/sed: couldn't write 25 items to stdout: Broken pipe
 sed: couldn't write 1 item to stdout: Broken pipe
 0.46 prohibit_argmatch_without_use

This has been fixed upstream in gnulib.  There are several other
portability improvements in our regular submodule update.

* .gnulib: Update to latest, in part for quieter syntax-check.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under the gnulib maintenance rule.

* .gnulib d55899f...9d5efe7 (19):
   maint.mk: less syntax-check noise when SIGPIPE is ignored
   nl_langinfo: CODESET on MS-Windows and more items from localeconv
   Bruno Haible has stepped down as maintainer.
   mktime: merge #if/#ifdef usage from glibc
   git-version-gen: improve option descriptions
   regex: fix memory leak in compiler
   regex: merge patch from libc
   acl: port to gcc -Wredundant-decls
   parse-duration: eliminate 68-year duration limit
   pthread: don't assume AC_CANONICAL_HOST, port better to Solaris, etc.
   pthread: define thread-safe macros on some platforms
   regex: don't be multithreaded if USE_UNLOCKED_IO.
   gettext: update macros to version 0.19
   select,poll: fix console handle check on windows 8
   select: fix waiting on anonymous pipes on MS-Windows
   times: fix to return non constant value on MS-Windows
   isatty: fix to work on windows 8
   maint: fix typo in fdl.texi
   mountlist: avoid hasmntopt const type warning on solaris

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index d55899f..9d5efe7 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit d55899fd2c5794ac85ecb14d5e2f646a89e4b4dd
+Subproject commit 9d5efe7d61e1d96a6d7c97ffa4d21c5e33e9bd30
-- 
1.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Among other patches, Natanael Copa contributed a fix for
pyshmem_available when using musl libc that directly affects
libvirt.

* .gnulib: Update to latest, in part for musl libc compat.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under the gnulib rule, since we are not in release freeze.

* .gnulib ce457d6...e8e0eb6 (18):
   gitlog-to-changelog: revert inclusion of git-log-fix file
   maint.mk: Relax the copyright check to cater for non FSF projects
   physmem: use sysinfo if _SC_PHYS_PAGES unavailable
   exclude: port to strict C99
   regex: do not depend on malloc-gnu
   autoupdate
   expl: avoid incorrect expl(small_value) on OpenBSD 5.4
   xalloc: allow x2nrealloc (P, PN, S) where P  !*PN
   fts: avoid unnecessary strlen calls
   fts: avoid unnecessary strlen calls
   fts: avoid unnecessary strlen calls
   autoupdate
   autoupdate
   obstack: Remove ancient NeXTSTEP gcc support conditional
   obstack: merge with glibc changes
   strftime: wrap macros in do {...} while(0)
   modechange: avoid memory leaks for invalid octal modes
   autoupdate

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index ce457d6..e8e0eb6 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit ce457d622d947d8aa3e325d98a2818d097e7fec9
+Subproject commit e8e0eb6bfb728685ec8d5afd924e41b18e9d928d
-- 
1.9.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

While we aren't impacted by most of upstream's changes this
month, at least the regex improvement looks useful.

* gnulib: Synchronize to upstream.
---

Pushing under trivial rule before we go into freeze.

* .gnulib 72fb907...ce457d6 (16):
   gitlog-to-changelog: include a dummy git-log-fix file
   autoupdate
   update from texinfo
   gitlog-to-changelog: also include the file, git-log-fix
   autoupdate
   regex: port to OS X 10.8.5 en_US.UTF-8 locale
   maint: fix ChangeLog to match commit record
   stdint, read-file: fix missing SIZE_MAX on Android (tiny change)
   parse-datetime: fix crash or infloop in TZ= parsing
   * NEWS: Recent changes are not that important.
   savedir: new symbol for fast-read version
   unistd: port readlink to Mac OS X 10.3.9
   * NEWS: Document recent change to diffseq.
   diffseq: remove TOO_EXPENSIVE heuristic
   savedir: simplify by using stpcpy
   spawn: fix link error on uclibc

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 72fb907..ce457d6 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 72fb9075b2812765d2ce55a1a26c3764392377cb
+Subproject commit ce457d622d947d8aa3e325d98a2818d097e7fec9
-- 
1.8.5.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib, for older autoconf

[Eric Blake]

Based on a report from Pavel Hrdina, gnulib was fixed to support
AC_PROG_SED even when using ancient autoconf 2.59 of RHEL 5.

* .gnulib: Update to latest, to fix build on RHEL 5.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under the build-breaker rule.

* .gnulib 3f51bf4...72fb907 (3):
   m4: fix gl_TIMER_TIME() detection of threads on uClibc
   maintainer-makefiles: provide AC_PROG_SED for older autoconf
   exclude: add support for posix regexps

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 3f51bf4..72fb907 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 3f51bf41c8be8b310f57caff371377414701d5cc
+Subproject commit 72fb9075b2812765d2ce55a1a26c3764392377cb
-- 
1.8.5.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Among other things, gnulib now allows overriding of sed during
'make syntax-check'.

* .gnulib: Update to latest, for maint.mk improvements.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under the maintainer rule, before we freeze.  I still need
to revive Roman's work on using $(SED) and/or portable sed constructs
in our cfg.mk, but that can occur after freeze if necessary, while
the hard part of the gnulib submodule should be done before freeze.

* .gnulib d5fec6c...3f51bf4 (9):
   maintainer-makefiles: use $(SED) for syntax check
   update from texinfo
   savedir: add sorting arg to savedir, streamsavedir; remove fdsavedir
   autoupdate
   update from texinfo
   update from texinfo
   file-type: add support for doors and other less-common file types
   update from texinfo
   autoupdate

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index d5fec6c..3f51bf4 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit d5fec6c22f03c6a73d62260c9ce091c10c0a9cbd
+Subproject commit 3f51bf41c8be8b310f57caff371377414701d5cc
-- 
1.8.5.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib, for mingw improvements

[Eric Blake]

On Fedora 20, mingw-headers has switched over to winpthreads as
the provider for its pthread.h.  winpthreads is notorious for
providing a less-than-stellar header, and needs several workarounds
before it can be used in a project assuming POSIX semantics.  While
we still use Windows primitives rather than pthread when compiling
for mingw, this update will make it possible to switch to mingw
pthreads.

* .gnulib: Update to latest, for mingw fixes.

Signed-off-by: Eric Blake ebl...@redhat.com
---

We're in between releases, so I'm pushing this under the
gnulib/trivial rule.

* .gnulib d18d1b8...d5fec6c (15):
   pthread: work around winpthread header pollution on mingw
   qacl: check for fchmod
   Fix typo in ChangeLog.
   fdopen-tests: port to Tru64
   stdalign: port to HP-UX compilers
   strtoimax: port to platforms lacking 'long long'
   update from texinfo
   relocatable-maint.texi: escape braces
   maint: remove duplicate ChangeLog entry
   maint.mk: adapt openat.h-include-without-use test
   relocatable-perl: like relocatable-script, but for Perl scripts
   relocatable-shell: Update suggested usage in maintainer documentation.
   tests: fix export bug in previous patch
   tests: simplify porting to Solaris 10 /bin/sh
   update from texinfo

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index d18d1b8..d5fec6c 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit d18d1b802380bb8f0a079c7312a1adffdce0
+Subproject commit d5fec6c22f03c6a73d62260c9ce091c10c0a9cbd
-- 
1.8.5.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

'make syntax-check' wants a newer gnulib for 2014 copyright.

Also, a couple of fixes for bootstrap issues reported on IRC:
- on some older glibc systems, ./configure could deadlock due to
a glibc malloc bug
- on FreeBSD systems, a broken autom4te coupled with gettext
0.18.3 prevents bootstrap; we can't work around it, but can at
least inform the user why they have a problem

And as always, portability fixes in other modules, some of which
are used by libvirt.

* .gnulib: Update to latest, in part for bootstrap improvements,
and for the new year.
* bootstrap: Resync to gnulib.
* gnulib/local/m4/ssize_t.m4.diff: Regenerate.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under the build-breaker rule now that 'make syntax-check'
is impacted.

* .gnulib 831b84c...c7802e2 (33):
   doc: update main copyright year
   maint: update copyright
   version-etc: new year
   autoupdate
   passfd: give nicer error for recvfd at eof
   autoupdate
   gettimeofday: port recent C++ fix to Emacs
   gettimeofday: fix C++ crosscompilation
   qacl: port to Windows better
   md5, sha1, sha256, sha512: fix compile error in c++ mode
   open-tests: fix build failure with -Werror=old-style-declaration
   md5, sha1, sha256, sha512: fix link error with partial libcrypto
   md5, sha1, sha256, sha512: add gl_SET_CRYPTO_CHECK_DEFAULT
   md5, sha1, sha256, sha512: add 'auto', and a way to specify default
   autoupdate
   bootstrap: warn about BSD toolchain snafu
   open-tests: port to glibc with _FORTIFY_SOURCE and -O1
   include_next: minimize code duplication
   getcwd: fix compile error in configure check
   regex: suppress core dumps from detection code
   md5, sha1, sha256, sha512: support mandating use of openssl
   test-xvasprintf: disable some -Wformat-security diagnostics
   regex: avoid glibc deadlock during configure
   md5, sha1, sha256, sha512: use openssl routines if available
   base64: fix recent compilation regression on some compilers
   autoupdate
   autoupdate
   ignore-value: revert previous code change
   selinux-h: improve stub types and add more stub functions
   ignore-value: prefer GCC version back through 2.0
   pty: Activate the signature wrapper of forkpty.
   maint: fix gendocs.sh permissions
   autoupdate

 .gnulib |  2 +-
 bootstrap   | 12 ++--
 gnulib/local/m4/ssize_t.m4.diff |  2 +-
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/.gnulib b/.gnulib
index 831b84c..1276a2c 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 831b84c59ef413c57a36b67344467d66a8a2ba70
+Subproject commit 1276a2c5f24c0c932426aca9c899fa524d2443f2
diff --git a/bootstrap b/bootstrap
index e31d17d..ce90bc4 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,10 +1,10 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2013-08-15.22; # UTC
+scriptversion=2013-12-05.23; # UTC

 # Bootstrap this package from checked-out sources.

-# Copyright (C) 2003-2013 Free Software Foundation, Inc.
+# Copyright (C) 2003-2014 Free Software Foundation, Inc.

 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -551,6 +551,14 @@ if ! printf $buildreq | check_versions; then
   fi
 fi

+# Warn the user if autom4te appears to be broken; this causes known
+# issues with at least gettext 0.18.3.
+probe=$(echo 'm4_quote([hi])' | autom4te -l M4sugar -t 'm4_quote:$%' -)
+if test x$probe != xhi; then
+  warn_ WARNING: your autom4te wrapper eats stdin;
+  warn_ if bootstrap fails, consider upgrading your autotools
+fi
+
 echo $0: Bootstrapping from checked-out $package sources...

 # See if we can use gnulib's git-merge-changelog merge driver.
diff --git a/gnulib/local/m4/ssize_t.m4.diff b/gnulib/local/m4/ssize_t.m4.diff
index 93f8ad7..08c2b9c 100644
--- a/gnulib/local/m4/ssize_t.m4.diff
+++ b/gnulib/local/m4/ssize_t.m4.diff
@@ -5,7 +5,7 @@ index 209d64c..5ea72a1 100644
 @@ -1,4 +1,4 @@
 -# ssize_t.m4 serial 5 (gettext-0.18.2)
 +# ssize_t.m4 serial 6 (gettext-0.18.2)
- dnl Copyright (C) 2001-2003, 2006, 2010-2013 Free Software Foundation, Inc.
+ dnl Copyright (C) 2001-2003, 2006, 2010-2014 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
 @@ -17,7 +17,21 @@ AC_DEFUN([gt_TYPE_SSIZE_T],
-- 
1.8.4.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 12/06/2013 01:33 AM, Michal Privoznik wrote:
 On 06.12.2013 00:52, Eric Blake wrote:
 A couple of fixes for bootstrap issues reported on IRC:
 - on some older glibc systems, ./configure could deadlock due to
 a glibc malloc bug
 - on FreeBSD systems, a broken autom4te coupled with gettext
 0.18.3 prevents bootstrap; we can't work around it, but can at
 least inform the user why they have a problem

 And as always, portability fixes in other modules, some of which
 are used by libvirt.

 * .gnulib: Update to latest, in part for bootstrap improvements.
 * bootstrap: Resync to gnulib.

 Signed-off-by: Eric Blake ebl...@redhat.com
 ---

 Hmm, in reading this gnulib changelog, I'm not sure I want to
 push right away: the line about md5 being tweaked to use openssl
 makes me wonder if this update is dragging in a new library
 dependency; I'll have to do a bit more investigation.  But
 here's the patch, if anyone else also wants to investigate.


 
 I think openssl is widely available. And yet, libvirt is already
 dragging openssl in:
 
 $ ldd ./daemon/.libs/libvirtd | grep ssl
 libssl.so.1.0.0 = /usr/lib64/libssl.so.1.0.0 (0x7f7ceed3e000)

That's pulled in indirectly; as is libcrypto.so, also from openssl.
This gnulib patch only adds an optional dependency on libcrypto, not
libssl; and upstream gnulib has since tweaked things to further default
to avoiding openssl.  The official party line of Fedora is that openssl
is shipped as a system library, and therefore Fedora is okay if it uses
the configure option to pull in the library explicitly; but as openssl
is incompatible with GPL and is not present as a system library on all
platforms, the only safe default for upstream gnulib was to require
downstream users to explicitly request the use of the library.

As long as we don't change the spec file, we aren't changing behavior;
and while Fedora allows us to link to openssl, I'll leave such a spec
change for a later patch.

I'll go ahead and push a gnulib update on Jan 1 (which is when we have
to update anyways because of copyright year changes impacting 'make
syntax-check').

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Michal Privoznik]

On 06.12.2013 00:52, Eric Blake wrote:
 A couple of fixes for bootstrap issues reported on IRC:
 - on some older glibc systems, ./configure could deadlock due to
 a glibc malloc bug
 - on FreeBSD systems, a broken autom4te coupled with gettext
 0.18.3 prevents bootstrap; we can't work around it, but can at
 least inform the user why they have a problem
 
 And as always, portability fixes in other modules, some of which
 are used by libvirt.
 
 * .gnulib: Update to latest, in part for bootstrap improvements.
 * bootstrap: Resync to gnulib.
 
 Signed-off-by: Eric Blake ebl...@redhat.com
 ---
 
 Hmm, in reading this gnulib changelog, I'm not sure I want to
 push right away: the line about md5 being tweaked to use openssl
 makes me wonder if this update is dragging in a new library
 dependency; I'll have to do a bit more investigation.  But
 here's the patch, if anyone else also wants to investigate.
 
 * .gnulib 831b84c...fdfe96f (18):
bootstrap: warn about BSD toolchain snafu
open-tests: port to glibc with _FORTIFY_SOURCE and -O1
include_next: minimize code duplication
getcwd: fix compile error in configure check
regex: suppress core dumps from detection code
md5, sha1, sha256, sha512: support mandating use of openssl
test-xvasprintf: disable some -Wformat-security diagnostics
regex: avoid glibc deadlock during configure
md5, sha1, sha256, sha512: use openssl routines if available

I think openssl is widely available. And yet, libvirt is already
dragging openssl in:

$ ldd ./daemon/.libs/libvirtd | grep ssl
libssl.so.1.0.0 = /usr/lib64/libssl.so.1.0.0 (0x7f7ceed3e000)

I wonder where it got from:

libvirt.git $ grep -r \\-lssl .
grep: ./.git/objects/a1/sedRc8oQE: Permission denied

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

A couple of fixes for bootstrap issues reported on IRC:
- on some older glibc systems, ./configure could deadlock due to
a glibc malloc bug
- on FreeBSD systems, a broken autom4te coupled with gettext
0.18.3 prevents bootstrap; we can't work around it, but can at
least inform the user why they have a problem

And as always, portability fixes in other modules, some of which
are used by libvirt.

* .gnulib: Update to latest, in part for bootstrap improvements.
* bootstrap: Resync to gnulib.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Hmm, in reading this gnulib changelog, I'm not sure I want to
push right away: the line about md5 being tweaked to use openssl
makes me wonder if this update is dragging in a new library
dependency; I'll have to do a bit more investigation.  But
here's the patch, if anyone else also wants to investigate.

* .gnulib 831b84c...fdfe96f (18):
   bootstrap: warn about BSD toolchain snafu
   open-tests: port to glibc with _FORTIFY_SOURCE and -O1
   include_next: minimize code duplication
   getcwd: fix compile error in configure check
   regex: suppress core dumps from detection code
   md5, sha1, sha256, sha512: support mandating use of openssl
   test-xvasprintf: disable some -Wformat-security diagnostics
   regex: avoid glibc deadlock during configure
   md5, sha1, sha256, sha512: use openssl routines if available
   base64: fix recent compilation regression on some compilers
   autoupdate
   autoupdate
   ignore-value: revert previous code change
   selinux-h: improve stub types and add more stub functions
   ignore-value: prefer GCC version back through 2.0
   pty: Activate the signature wrapper of forkpty.
   maint: fix gendocs.sh permissions
   autoupdate

 .gnulib   |  2 +-
 bootstrap | 10 +-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/.gnulib b/.gnulib
index 831b84c..fdfe96f 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 831b84c59ef413c57a36b67344467d66a8a2ba70
+Subproject commit fdfe96fe43746d63364f823ab3032c8301d53d1f
diff --git a/bootstrap b/bootstrap
index e31d17d..5acbe5b 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2013-08-15.22; # UTC
+scriptversion=2013-12-05.23; # UTC

 # Bootstrap this package from checked-out sources.

@@ -551,6 +551,14 @@ if ! printf $buildreq | check_versions; then
   fi
 fi

+# Warn the user if autom4te appears to be broken; this causes known
+# issues with at least gettext 0.18.3.
+probe=$(echo 'm4_quote([hi])' | autom4te -l M4sugar -t 'm4_quote:$%' -)
+if test x$probe != xhi; then
+  warn_ WARNING: your autom4te wrapper eats stdin;
+  warn_ if bootstrap fails, consider upgrading your autotools
+fi
+
 echo $0: Bootstrapping from checked-out $package sources...

 # See if we can use gnulib's git-merge-changelog merge driver.
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Among others, this fixes getgroups for MacOS and fpending for Cygwin.

* .gnulib: Update to latest.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing prior to freeze under the gnulib rule.

* .gnulib 8f74258...831b84c (16):
   quotearg: don't attempt to store 1  31 into an int
   error: depend on stdio
   doc: Improve wording in relocatable-maint.texi.
   Fix indentation in previous patch.
   * lib/getgroups.c (posix_getgroups, getgroups) [__APPLE__]:
   base64: provide a fast path for encoding well sized buffers
   extern-inline: port better to OS X 10.9
   fpending: fix typo
   fpending: fix regression on DragonFly BSD
   hash: relax license to LGPLv2+, for libguestfs
   intprops: port to Oracle Studio c99
   obstack: pacify HP C
   maint.mk: prefer gpgv2 over gpgv
   isnan: port to VAX
   gnulib-tool: protect against CDPATH
   maint.mk: restore functionality removed by recent change

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 8f74258..831b84c 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 8f7425866463f994538584d1dd7211603b8b0550
+Subproject commit 831b84c59ef413c57a36b67344467d66a8a2ba70
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Martin Kletzander]

On Tue, Oct 29, 2013 at 02:12:00PM -0600, Eric Blake wrote:
 [adding bug-gnulib]
 
 On 10/29/2013 11:15 AM, Martin Kletzander wrote:
  On Mon, Oct 28, 2013 at 03:50:20PM -0600, Eric Blake wrote:
  Since we haven't quite frozen yet, it's time to pick up some
  fixes.  I know at least cygwin benefits from this update.
 
  * .gnulib: Update to latest, in part for cygwin compilation.
 
  
  Even though that's not your fault, this might interest you:
  
  root@freebsd9:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests
  # ./test-poll
  Unconnected socket test... passed
  Connected sockets test... failed (expecting POLLHUP after shutdown)
  General socket test with fork... failed (expecting POLLHUP after shutdown)
  Pipe test... passed
 
 Has that test been failing prior to my submodule update for libvirt?
 This is likely a latent bug in gnulib that has been manifesting itself
 on FreeBSD for a much longer time period than just the month's worth of
 patches I pulled in by updating; but you are right that it would be nice
 to fix it upstream.
 

I thought it did fail earlier, but now I see it didn't.  There was an
IP addresses misconfiguration, but trying that now, I can only find a
commit on which there were 2 errors instead of 3, but none which would
successfully survive 'make check'.

So sorry for the noise I made about that.

Martin

  
  And two other tests fail as well.  I, however, couldn't find a time to
  look at that, so I'm just sending this to you in case you'd like to go
  deeper with it.
  
  Martin
  
 
 -- 
 Eric Blake   eblake redhat com+1-919-301-3266
 Libvirt virtualization library http://libvirt.org
 




signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 10/31/2013 07:26 AM, Martin Kletzander wrote:

 root@freebsd9:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests
 # ./test-poll
 Unconnected socket test... passed
 Connected sockets test... failed (expecting POLLHUP after shutdown)
 General socket test with fork... failed (expecting POLLHUP after shutdown)
 Pipe test... passed

 Has that test been failing prior to my submodule update for libvirt?
 This is likely a latent bug in gnulib that has been manifesting itself
 on FreeBSD for a much longer time period than just the month's worth of
 patches I pulled in by updating; but you are right that it would be nice
 to fix it upstream.

 
 I thought it did fail earlier, but now I see it didn't.  There was an
 IP addresses misconfiguration, but trying that now, I can only find a
 commit on which there were 2 errors instead of 3, but none which would
 successfully survive 'make check'.
 
 So sorry for the noise I made about that.

Don't apologize - it's something that upstream gnulib needs to fix
someday, even if the downstream libvirt patch wasn't actually pointing
out a gnulib regression.  But I don't know how many active FreeBSD users
are on the gnulib list to help with the analysis effort, so it may be a
while before fixes appear (at any rate, a failed gnulib test is not
necessarily a reason to hold up a downstream release).

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Martin Kletzander]

On Mon, Oct 28, 2013 at 03:50:20PM -0600, Eric Blake wrote:
 Since we haven't quite frozen yet, it's time to pick up some
 fixes.  I know at least cygwin benefits from this update.
 
 * .gnulib: Update to latest, in part for cygwin compilation.
 

Even though that's not your fault, this might interest you:

root@freebsd9:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests
# ./test-poll
Unconnected socket test... passed
Connected sockets test... failed (expecting POLLHUP after shutdown)
General socket test with fork... failed (expecting POLLHUP after shutdown)
Pipe test... passed

And two other tests fail as well.  I, however, couldn't find a time to
look at that, so I'm just sending this to you in case you'd like to go
deeper with it.

Martin


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

[adding bug-gnulib]

On 10/29/2013 11:15 AM, Martin Kletzander wrote:
 On Mon, Oct 28, 2013 at 03:50:20PM -0600, Eric Blake wrote:
 Since we haven't quite frozen yet, it's time to pick up some
 fixes.  I know at least cygwin benefits from this update.

 * .gnulib: Update to latest, in part for cygwin compilation.

 
 Even though that's not your fault, this might interest you:
 
 root@freebsd9:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests
 # ./test-poll
 Unconnected socket test... passed
 Connected sockets test... failed (expecting POLLHUP after shutdown)
 General socket test with fork... failed (expecting POLLHUP after shutdown)
 Pipe test... passed

Has that test been failing prior to my submodule update for libvirt?
This is likely a latent bug in gnulib that has been manifesting itself
on FreeBSD for a much longer time period than just the month's worth of
patches I pulled in by updating; but you are right that it would be nice
to fix it upstream.

 
 And two other tests fail as well.  I, however, couldn't find a time to
 look at that, so I'm just sending this to you in case you'd like to go
 deeper with it.
 
 Martin
 

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Since we haven't quite frozen yet, it's time to pick up some
fixes.  I know at least cygwin benefits from this update.

* .gnulib: Update to latest, in part for cygwin compilation.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under the gnulib rule.

* .gnulib 4a5ee89...8f74258 (33):
   Revert error: make the module depend on vfprintf-posix
   maint.mk: fix release target to build _version
   maint.mk: get current gnulib revision correctly.
   install-reloc: Support multi-binary installation.
   selinux-h: really build without selinux when library is missing
   regex: also remove dependency on HAVE_WCSCOLL
   xfreopen: fix typo: s/frepoen/freopen/
   regex: don't depend on wcscoll
   error: add the printf attribute to a static function
   error: make the module depend on vfprintf-posix
   fpending, obstack, strerror-override: use pure+const function attrs
   extern-inline: make safe for -Wundef usage
   mkfifo-tests, etc.: allow HP-UX 11.11 bug
   acl: allow cross-compilation to Gentoo
   mgetgroups: remove dependency on realloc-gnu
   regex-tests: port to HP-UX 11.11
   verify: document some 'assume' pitfalls
   strtoumax: fix another typo in previous commit
   strtoumax: fix typo in previous commit.
   strtoumax: port to Solaris 8
   autoupdate
   strtoimax, strtoumax: port to HP-UX 11.11
   strtoimax: port to HP-UX 11.11
   New module 'count-trailing-zeros'.
   count-leading-zeros: port to MSC; support types wider than 64 bits
   count-one-bits: port to MSC; support types wider than 64 bits
   mountlist: fix resource leak with MOUNTED_INTERIX_STATVFS
   tests: improve diagnostic when an assertion fails
   verify: new macro 'assume'
   autoupdate
   dup2, dup3: work around another cygwin crasher
   getdtablesize: work around cygwin issue
   pmccabe2html: escaping of special characters

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 4a5ee89..8f74258 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 4a5ee89c8a8be7350a8fd8ca1bacb196a190e492
+Subproject commit 8f7425866463f994538584d1dd7211603b8b0550
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Since we're about to freeze, it's time to pick up the latest
upstream gnulib.  Among other changes, gnulib now guarantees the
use of some -f flags that we were previously manually adding.

* .gnulib: Update to latest, in part for warning improvements.
* m4/virt-compile-warnings.m4 (LIBVIRT_COMPILE_WARNINGS): Drop
flags that are now guaranteed by gnulib.
* bootstrap: Resync to gnulib.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under my gnulib maintenance rule.

* .gnulib 0ba0877...4a5ee89 (31):
   manywarnings: enable nicer gcc warning messages
   timespec: use the new TIMESPEC_RESOLUTION in a few more places
   warnings: port --enable-gcc-warnings to Solaris Studio 12.3
   configmake: support new --runstatedir option
   ctype, string: depend on extern-inline
   userspec: support optional parameters to parse_user_spec()
   timespec: new function make_timespec, and new constants
   stdio: OS X port of putc_unlocked + extern inline
   signal: OS X port of sigaddset etc. + extern inline
   extern-inline: do not always suppress extern inline on OS X
   extern-inline: document fixes for ctype and wctype macros
   fflush, freadahead, fseeko: Fix for Android
   pmccabe2html: fix portability issues
   getgroups: statement without effect
   autoupdate
   update from texinfo
   update from texinfo
   glob: fix compilation
   glob: fix build for platforms without __THROW
   autoupdate
   regex-quote: fix buffer access out of bounds
   glob: avoid -Wattribute warnings on glibc
   headers: check that _GL_INLINE_HEADER_BEGIN is defined
   bootstrap: remove the --version requirement from ancillary tools
   gc: support HMAC-SHA256 and HMAC-SHA512.
   gettext: update to version 0.18.3.1
   selinux-at: omit unnecessary include
   autoupdate
   d-ino: avoid false negative on symlink
   update from texinfo
   autoupdate

 .gnulib |  2 +-
 bootstrap   | 19 +++
 m4/virt-compile-warnings.m4 |  2 --
 3 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/.gnulib b/.gnulib
index 0ba0877..4a5ee89 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 0ba087759d2797c8f7d3c34bef6268ba3fd212cb
+Subproject commit 4a5ee89c8a8be7350a8fd8ca1bacb196a190e492
diff --git a/bootstrap b/bootstrap
index cc7fc1b..e31d17d 100755
--- a/bootstrap
+++ b/bootstrap
@@ -209,12 +209,16 @@ bootstrap_sync=false
 # Use git to update gnulib sources
 use_git=true

+check_exists() {
+  ($1 --version /dev/null) /dev/null 21
+  test $? -lt 126
+}
+
 # find_tool ENVVAR NAMES...
 # -
 # Search for a required program.  Use the value of ENVVAR, if set,
-# otherwise find the first of the NAMES that can be run (i.e.,
-# supports --version).  If found, set ENVVAR to the program name,
-# die otherwise.
+# otherwise find the first of the NAMES that can be run.
+# If found, set ENVVAR to the program name, die otherwise.
 #
 # FIXME: code duplication, see also gnu-web-doc-update.
 find_tool ()
@@ -225,7 +229,7 @@ find_tool ()
   eval find_tool_res=\$$find_tool_envvar
   if test x$find_tool_res = x; then
 for i; do
-  if ($i --version /dev/null) /dev/null 21; then
+  if check_exists $i; then
 find_tool_res=$i
 break
   fi
@@ -463,8 +467,7 @@ check_versions() {
 if [ $req_ver = - ]; then
   # Merely require app to exist; not all prereq apps are well-behaved
   # so we have to rely on $? rather than get_version.
-  $app --version /dev/null 21 /dev/null
-  if [ 126 -le $? ]; then
+  if ! check_exists $app; then
 warn_ Error: '$app' not found
 ret=1
   fi
@@ -551,10 +554,10 @@ fi
 echo $0: Bootstrapping from checked-out $package sources...

 # See if we can use gnulib's git-merge-changelog merge driver.
-if $use_git  test -d .git  (git --version) /dev/null 2/dev/null ; then
+if $use_git  test -d .git  check_exists git; then
   if git config merge.merge-changelog.driver /dev/null ; then
 :
-  elif (git-merge-changelog --version) /dev/null 2/dev/null ; then
+  elif check_exists git-merge-changelog; then
 echo $0: initializing git-merge-changelog driver
 git config merge.merge-changelog.name 'GNU-style ChangeLog merge driver'
 git config merge.merge-changelog.driver 'git-merge-changelog %O %A %B'
diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
index 938c8bb..8f905cc 100644
--- a/m4/virt-compile-warnings.m4
+++ b/m4/virt-compile-warnings.m4
@@ -187,8 +187,6 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
 esac
 wantwarn=$wantwarn -fexceptions
 wantwarn=$wantwarn -fasynchronous-unwind-tables
-wantwarn=$wantwarn -fdiagnostics-show-option
-wantwarn=$wantwarn -funit-at-a-time

 # Need -fipa-pure-const in order to make -Wsuggest-attribute=pure
 # fire even without -O.
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Upstream gnulib recently patched a bug in bootstrap, for projects
that use a different name than build-aux for a subdirectory.  We
don't, but it doesn't hurt to update.

* .gnulib: Update, for bootstrap fix.
* bootstrap: Sync to upstream.
* bootstrap.conf: Match upstream bug fix.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under the trivial gnulib rule.

* .gnulib da8d59e...644c404 (5):
   bootstrap: use correct source when copying build-aux files
   tmpdir: fix bug in VMS port
   tmpdir: fix typo in previous change
   * lib/tmpdir.c: Simplify code to add slash; no need for a loop.
   tmpdir: port to VMS, to // != /, and to long dirs


 .gnulib|  2 +-
 bootstrap  | 12 ++--
 bootstrap.conf |  8 
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/.gnulib b/.gnulib
index da8d59e..644c404 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit da8d59ee79138b85daee1ad5b22ea12e4fb6ce47
+Subproject commit 644c40496cf7d5a705a73c9dd32b035fcecc2ab1
diff --git a/bootstrap b/bootstrap
index 9c52204..a37fb8a 100755
--- a/bootstrap
+++ b/bootstrap
@@ -256,12 +256,12 @@ esac
 # Extra files from gnulib, which override files from other sources.
 test -z ${gnulib_extra_files}  \
   gnulib_extra_files=
-$build_aux/install-sh
-$build_aux/mdate-sh
-$build_aux/texinfo.tex
-$build_aux/depcomp
-$build_aux/config.guess
-$build_aux/config.sub
+build-aux/install-sh
+build-aux/mdate-sh
+build-aux/texinfo.tex
+build-aux/depcomp
+build-aux/config.guess
+build-aux/config.sub
 doc/INSTALL
 

diff --git a/bootstrap.conf b/bootstrap.conf
index 1c59c22..f166a53 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -233,10 +233,10 @@ touch AUTHORS ChangeLog || exit 1

 # Override bootstrap's list - we don't use mdate-sh or texinfo.tex.
 gnulib_extra_files=
-$build_aux/install-sh
-$build_aux/depcomp
-$build_aux/config.guess
-$build_aux/config.sub
+build-aux/install-sh
+build-aux/depcomp
+build-aux/config.guess
+build-aux/config.sub
 doc/INSTALL
 

-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Future patches need LGPLv2+ versions of some modules that had
recent license changes; but separating the gnulib update from
the actual use of the modules makes it easier to backport to
an older version while avoiding a submodule update (assuming,
of course, that the backport is to a system where glibc provides
adequate functionaliy without needing the gnulib module).

* .gnulib: Update to latest, for modules needed in later patches.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under the trivial gnulib rule.

* .gnulib b72ff2a...da8d59e (9):
   regex: port to --with-included-regex --enable-gcc-warnings non-threaded
   accept4, dup3, pipe2: port to Cygwin
   mountlist: add support for deallocating returned list entries
   stdalign, verify: port to FreeBSD 9.1, to C11, and to C++11
   fnmatch: don't goto over declaration
   pipe2: decouple from binary-io a bit
   mgetgroups: relax license to LGPLv2+
   xalloc-oversized: relax license to LGPLv2+
   nproc: relax license to LGPLv2+

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index b72ff2a..da8d59e 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit b72ff2a45efde544c406804186d37a3254728571
+Subproject commit da8d59ee79138b85daee1ad5b22ea12e4fb6ce47
-- 
1.8.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

The latest mingw headers on Fedora 19 fail to build with gnulib
without an update.

Meanwhile, now that upstream gnulib has better handling of -W
probing for clang, we can drop some of our own solutions in
favor of upstream; thus this reverts commit c1634100, Correctly
detect warning flags with clang.

* .gnulib: Update to latest, for mingw and clang.

Signed-off-by: Eric Blake ebl...@redhat.com
---

Pushing under the build-breaker rule.

* .gnulib a363f4e...f40e61e (41):
   update from texinfo
   ignore-value: port to gcc -pedantic
   extern-inline: port to gcc -std=c89
   doc: document extern-inline
   doc: chatter less
   fflush, fseeko: port to musl cross-compiles
   msvc-inval: port to mingw-w64
   getcwd-lgpl: port to Tru64
   autoupdate
   tests: port large-fd POSIX spawn tests to OS X
   autoupdate
   tests/nap.h: use an adaptive delay to avoid ctime update issues
   sig2str: port to C++
   docs: mention cygwin shortcoming in sys/un.h
   vasnprintf: silence mingw compiler warning
   c-ctype, regex, verify: port to gcc -std=c90 -pedantic
   regex: adapt to locking regime instead of depending on pthread
   getgroups: document portability issues
   test-lchown, test-chown: also skip test if lchown/chown fails with EPERM
   regex: fix dfa race in multithreaded uses
   malloca: port to compilers that reject size-zero arrays
   parse-datetime, tests: don't use string + int
   argmatch: port to C++
   argp: typo fix
   autoupdate
   manywarnings: update for GCC 4.8.0
   spawn-tests, sys_socket-tests, sys_wait-tests: port to clang
   getaddrinfo-tests: port --enable-gcc-warnings to clang
   thread: port --enable-gcc-warnings to clang
   stdio: use __REDIRECT for fwrite, fwrite_unlocked
   stdio: port --enable-gcc-warnings to clang
   sig2str: port --enable-gcc-warnings to clang
   obstack: port --enable-gcc-warnings to clang
   memchr2: port --enable-gcc-warnings to clang
   mbsstr: port --enable-gcc-warnings to clang
   malloca: port --enable-gcc-warnings to clang
   inttostr: port --enable-gcc-warnings to clang
   warnings: port to clang
   quotearg: do not read beyond end of buffer
   lock: work around pthread recursive mutexes bug in Mac OS X 10.6
   mkdir-p: remove assumptions about umask and mode

 .gnulib |  2 +-
 m4/virt-compile-warnings.m4 | 22 --
 2 files changed, 1 insertion(+), 23 deletions(-)

diff --git a/.gnulib b/.gnulib
index a363f4e..f40e61e 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit a363f4ed4a0e69187c97686ac44502c49c7f4b3d
+Subproject commit f40e61ea0c4940b027aade7dd48948aa93f133a4
diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
index ce4e244..c6794b7 100644
--- a/m4/virt-compile-warnings.m4
+++ b/m4/virt-compile-warnings.m4
@@ -60,18 +60,6 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
 # gcc 4.4.6 complains this is C++ only; gcc 4.7.0 implies this from -Wall
 dontwarn=$dontwarn -Wenum-compare

-# clang rather horribly ignores unknown warning flags by
-# default. Thus to get gl_WARN_ADD to reliably detect
-# flags, we need to set '-Werror -Wunknown-warning-option'
-# in CFLAGS while probing support
-WARN_CFLAGS=
-orig_CFLAGS=$CFLAGS
-gl_WARN_ADD([-Wunknown-warning-option])
-if test -n $WARN_CFLAGS ; then
-WARN_CFLAGS=
-CFLAGS=-Werror -Wunknown-warning-option $CFLAGS
-fi
-
 # gcc 4.2 treats attribute(format) as an implicit attribute(nonnull),
 # which triggers spurious warnings for our usage
 AC_CACHE_CHECK([whether gcc -Wformat allows NULL strings],
@@ -197,13 +185,6 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
dnl gl_WARN_ADD([-fstack-protector])
gl_WARN_ADD([-fstack-protector-all])
gl_WARN_ADD([--param=ssp-buffer-size=4])
-   dnl Even though it supports it, clang complains about
-   dnl use of --param=ssp-buffer-size=4 unless used with
-   dnl the -c arg. It doesn't like it when used with args
-   dnl that just link together .o files. Unfortunately
-   dnl we can't avoid that with automake, so we must turn
-   dnl off the following clang specific warning
-   gl_WARN_ADD([-Wno-unused-command-line-argument])
;;
*-*-freebsd*)
dnl FreeBSD ships old gcc 4.2.1 which doesn't handle
@@ -244,7 +225,4 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
   AC_DEFINE_UNQUOTED([BROKEN_GCC_WLOGICALOP], 1,
[Define to 1 if gcc -Wlogical-op reports false positives on strchr])
 fi
-
-# Remove stuff we set for clang
-CFLAGS=$orig_CFLAGS
 ])
-- 
1.8.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Among others, this fixes a cosmetic bug where bootstrap stated:

./bootstrap: Bootstrapping from checked-out http://libvirt.org sources...

instead of the intended:

./bootstrap: Bootstrapping from checked-out libvirt sources...

* .gnulib: Update to latest, for bootstrap improvement.
* bootstrap: Resync from gnulib.
---

Pushing under the trivial rule (or rather, under the general
agreement that gnulib updates are fair game outside of libvirt freeze).

* .gnulib 92f3a4c...0f8ddbf (17):
   bootstrap: AC_INIT may have more than four parameters
   ChangeLog: whitespace cleanup
   qacl: port to MS-Windows port of GNU Emacs
   acl: include quote.h
   fchownat, renameat, unlinkat: update statat dependencies
   Assume gnulib is checked out from Git, not CVS
   utimensat-tests, etc.: try to fix some races
   utimens, utimensat: work around Solaris UTIME_OMIT bug
   gettext: now it's your responsibility to add -I$(top_builddir)/intl
   acl: include errno.h to get errno
   tests: don't assume getdtablesize () = 1000
   extern-inline: work around bug in Sun c99
   autoupdate
   qacl: new module, broken out from the acl module
   alignof, intprops, malloca: port better to IBM's C compiler
   wctype-h: fix gettext link error on mingw
   autoupdate

 .gnulib   |  2 +-
 bootstrap | 19 ++-
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/.gnulib b/.gnulib
index 92f3a4c..0f8ddbf 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 92f3a4c8e52e64c233e260431d095dbf88554c14
+Subproject commit 0f8ddbf1a13a93a4584afdd82f0f87e498a0db6f
diff --git a/bootstrap b/bootstrap
index 96f1e76..0cbea66 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2013-03-08.16; # UTC
+scriptversion=2013-05-08.20; # UTC

 # Bootstrap this package from checked-out sources.

@@ -140,20 +140,21 @@ po_download_command_format2=\
 wget --mirror -nd -q -np -A.po -P '%s' \
  http://translationproject.org/latest/%s/;

+# Prefer a non-empty tarname (4th argument of AC_INIT if given), else
+# fall back to the package name (1st argument with munging)
 extract_package_name='
-  /^AC_INIT(/{
- /.*,.*,.*, */{
-   s///
-   s/[][]//g
-   s/)$//
+  /^AC_INIT(\[*/{
+ s///
+ /^[^,]*,[^,]*,[^,]*,[ []*\([^][ ,)]\)/{
+   s//\1/
+   s/[],)].*//
p
q
  }
- s/AC_INIT(\[*//
- s/]*,.*//
+ s/[],)].*//
  s/^GNU //
  y/ABCDEFGHIJKLMNOPQRSTUVWXYZ/abcdefghijklmnopqrstuvwxyz/
- s/[^A-Za-z0-9_]/-/g
+ s/[^abcdefghijklmnopqrstuvwxyz0123456789_]/-/g
  p
   }
 '
-- 
1.8.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

Upstream gnulib determined that we were needlessly compiling in
gnulib's regex instead of glibc's when targetting new-enough glibc,
because the m4 test was being too strict in requiring a particular
answer to undefined behavior.
https://lists.gnu.org/archive/html/bug-gnulib/2013-04/msg00032.html

* .gnulib: Update to latest, for regex.
---

I verified that on F18, the final size of libvirtd shrinks after
applying this patch, because of this change to config.cache:
-gl_cv_func_re_compile_pattern_working=${gl_cv_func_re_compile_pattern_working=no}
+gl_cv_func_re_compile_pattern_working=${gl_cv_func_re_compile_pattern_working=yes}

Pushing under the agreement that gnulib fixes outside of freeze
are generally trivial.

* .gnulib 076ac82...92f3a4c (1):
   regex-tests, regex: allow glibc re_search behavior

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 076ac82..92f3a4c 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 076ac82d1d7f4df54630f1b4917b3c14f227f032
+Subproject commit 92f3a4c8e52e64c233e260431d095dbf88554c14
-- 
1.8.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 04/05/2013 02:34 AM, Daniel P. Berrange wrote:
 On Thu, Apr 04, 2013 at 08:33:16PM -0600, Eric Blake wrote:
 On 04/01/2013 12:55 PM, Eric Blake wrote:
 While this update doesn't address any reported problems in libvirt,
 doing a post-release update to latest gnulib makes it easier to
 stay in sync with best upstream practices.

 * .gnulib: Update to latest.
 * bootstrap: Resynchronize.
 ---

 Ping.
 
 ACK, I thought we'd previously agreed that you'd just push
 gnulib updates without needing ACKs, as long as we're not in
 freeze :-)

Okay, I'll remember that in the future :)  Pushed now.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Daniel P. Berrange]

On Thu, Apr 04, 2013 at 08:33:16PM -0600, Eric Blake wrote:
 On 04/01/2013 12:55 PM, Eric Blake wrote:
  While this update doesn't address any reported problems in libvirt,
  doing a post-release update to latest gnulib makes it easier to
  stay in sync with best upstream practices.
  
  * .gnulib: Update to latest.
  * bootstrap: Resynchronize.
  ---
 
 Ping.

ACK, I thought we'd previously agreed that you'd just push
gnulib updates without needing ACKs, as long as we're not in
freeze :-)

Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 04/01/2013 12:55 PM, Eric Blake wrote:
 While this update doesn't address any reported problems in libvirt,
 doing a post-release update to latest gnulib makes it easier to
 stay in sync with best upstream practices.
 
 * .gnulib: Update to latest.
 * bootstrap: Resynchronize.
 ---

Ping.

 
 Here's what changed in gnulib:
 
 * .gnulib 819b1c3...076ac82 (58):
stdalign: doc fix
stdalign: port to stricter ISO C11
sys_select, sys_time: port 2013-01-30 Solaris 2.6 fix to Cygwin
check for (erroneous) ftp-upload.gnu.org
copy-file, rpmatch: fix problems found by cppcheck
prefix-gnulib-mk: give better diagnostics
putenv: port to Solaris 10
mktime: fix configure typo
regex-tests: skip UTF-8 test on mingw
tests: make it easier to bypass alarm time in debugger
regex: port to mingw's recent addition of undeclared alarm
putenv: avoid compilation warning on mingw
unistd: don't prevent Tru64 Unix from using gnulib strtod.
autoupdate
vasprintf-posix-tests: allow rounding 1.51 to 1.
vasprintf-posix-tests: allow rounding 1.5 to 1.
autoupdate
vasnprintf-posix-tests: allow rounding 1.5 to 1
bootstrap: port to FreeBSD
regex: rename remaining __attribute calls to __attribute__.
execute: Revert last change, but use a different condition.
execute: drop dead code
non-recursive-gnulib-prefix-hack: port coreutils 8.21 to HP NonStop
test-getsockopt: avoid compiler warning
sys_types: Avoid autoconf warning about gl_SYS_TYPES_H.
gettext: Update to version 0.18.2.
maint: restore gendocs.sh execute bit
regex: merge patches from libc
putenv: port better to native Windows
regex: ignore old-style-definition warnings
getcwd: support coreutils better
* lib/strtod.c (HAVE_RAW_DECL_STRTOD): Remove; no longer used.
strtod: support coreutils better
mountlist: port to HP NonStop
Fix typo in stdnoreturn documentation.
extern-inline: avoid compilation error with HP-UX cc
putenv: fix heap corruption with mixed putenv/_putenv
autoupdate
autoupdate
unsetenv etc.: port to Solaris 11 + GNU Emacs
secure_getenv: fix C++ declaration typo
careadlinkat: stop exporting careadlinkatcwd
extensions: port better to HP-UX
openpty: fix bug where HAVE_OPENPTY is mistakenly 1
maint: fix misspelling of MINIX in ChangeLog
secure_getenv: fix include typo
secure_getenv: port better to FreeBSD and Solaris
extensions: port better to MINUX 3, HP-UX, autoheader 2.62
unistd: avoid namespace pollution on non-glibc systems
autoupdate
tmpdir: use secure_getenv
tempname: use secure_getenv
secure_getenv: new module
autoupdate
getcwd: break fdopendir + save_cwd recursive loop (Bug#13516)
regex-tests, regex: fix bug: memset undeclared
regex-tests: fix link errors on older Solaris
update from texinfo
 
  .gnulib   | 2 +-
  bootstrap | 8 ++--
  2 files changed, 7 insertions(+), 3 deletions(-)
 
 diff --git a/.gnulib b/.gnulib
 index 819b1c3..076ac82 16
 --- a/.gnulib
 +++ b/.gnulib
 @@ -1 +1 @@
 -Subproject commit 819b1c38b9abd94d7d1ca2a77bbe16053b75029c
 +Subproject commit 076ac82d1d7f4df54630f1b4917b3c14f227f032
 diff --git a/bootstrap b/bootstrap
 index bee7765..96f1e76 100755
 --- a/bootstrap
 +++ b/bootstrap
 @@ -1,6 +1,6 @@
  #! /bin/sh
  # Print a version string.
 -scriptversion=2013-01-20.16; # UTC
 +scriptversion=2013-03-08.16; # UTC
 
  # Bootstrap this package from checked-out sources.
 
 @@ -630,9 +630,13 @@ esac
  if $bootstrap_sync; then
cmp -s $0 $GNULIB_SRCDIR/build-aux/bootstrap || {
  echo $0: updating bootstrap and restarting...
 +case $(sh -c 'echo $1' -- a) in
 +  a) ignored=--;;
 +  *) ignored=ignored;;
 +esac
  exec sh -c \
'cp $1 $2  shift  exec ${CONFIG_SHELL-/bin/sh} $@' \
 -  -- $GNULIB_SRCDIR/build-aux/bootstrap \
 +  $ignored $GNULIB_SRCDIR/build-aux/bootstrap \
$0 $@ --no-bootstrap-sync
}
  fi
 

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

While this update doesn't address any reported problems in libvirt,
doing a post-release update to latest gnulib makes it easier to
stay in sync with best upstream practices.

* .gnulib: Update to latest.
* bootstrap: Resynchronize.
---

Here's what changed in gnulib:

* .gnulib 819b1c3...076ac82 (58):
   stdalign: doc fix
   stdalign: port to stricter ISO C11
   sys_select, sys_time: port 2013-01-30 Solaris 2.6 fix to Cygwin
   check for (erroneous) ftp-upload.gnu.org
   copy-file, rpmatch: fix problems found by cppcheck
   prefix-gnulib-mk: give better diagnostics
   putenv: port to Solaris 10
   mktime: fix configure typo
   regex-tests: skip UTF-8 test on mingw
   tests: make it easier to bypass alarm time in debugger
   regex: port to mingw's recent addition of undeclared alarm
   putenv: avoid compilation warning on mingw
   unistd: don't prevent Tru64 Unix from using gnulib strtod.
   autoupdate
   vasprintf-posix-tests: allow rounding 1.51 to 1.
   vasprintf-posix-tests: allow rounding 1.5 to 1.
   autoupdate
   vasnprintf-posix-tests: allow rounding 1.5 to 1
   bootstrap: port to FreeBSD
   regex: rename remaining __attribute calls to __attribute__.
   execute: Revert last change, but use a different condition.
   execute: drop dead code
   non-recursive-gnulib-prefix-hack: port coreutils 8.21 to HP NonStop
   test-getsockopt: avoid compiler warning
   sys_types: Avoid autoconf warning about gl_SYS_TYPES_H.
   gettext: Update to version 0.18.2.
   maint: restore gendocs.sh execute bit
   regex: merge patches from libc
   putenv: port better to native Windows
   regex: ignore old-style-definition warnings
   getcwd: support coreutils better
   * lib/strtod.c (HAVE_RAW_DECL_STRTOD): Remove; no longer used.
   strtod: support coreutils better
   mountlist: port to HP NonStop
   Fix typo in stdnoreturn documentation.
   extern-inline: avoid compilation error with HP-UX cc
   putenv: fix heap corruption with mixed putenv/_putenv
   autoupdate
   autoupdate
   unsetenv etc.: port to Solaris 11 + GNU Emacs
   secure_getenv: fix C++ declaration typo
   careadlinkat: stop exporting careadlinkatcwd
   extensions: port better to HP-UX
   openpty: fix bug where HAVE_OPENPTY is mistakenly 1
   maint: fix misspelling of MINIX in ChangeLog
   secure_getenv: fix include typo
   secure_getenv: port better to FreeBSD and Solaris
   extensions: port better to MINUX 3, HP-UX, autoheader 2.62
   unistd: avoid namespace pollution on non-glibc systems
   autoupdate
   tmpdir: use secure_getenv
   tempname: use secure_getenv
   secure_getenv: new module
   autoupdate
   getcwd: break fdopendir + save_cwd recursive loop (Bug#13516)
   regex-tests, regex: fix bug: memset undeclared
   regex-tests: fix link errors on older Solaris
   update from texinfo

 .gnulib   | 2 +-
 bootstrap | 8 ++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/.gnulib b/.gnulib
index 819b1c3..076ac82 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 819b1c38b9abd94d7d1ca2a77bbe16053b75029c
+Subproject commit 076ac82d1d7f4df54630f1b4917b3c14f227f032
diff --git a/bootstrap b/bootstrap
index bee7765..96f1e76 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2013-01-20.16; # UTC
+scriptversion=2013-03-08.16; # UTC

 # Bootstrap this package from checked-out sources.

@@ -630,9 +630,13 @@ esac
 if $bootstrap_sync; then
   cmp -s $0 $GNULIB_SRCDIR/build-aux/bootstrap || {
 echo $0: updating bootstrap and restarting...
+case $(sh -c 'echo $1' -- a) in
+  a) ignored=--;;
+  *) ignored=ignored;;
+esac
 exec sh -c \
   'cp $1 $2  shift  exec ${CONFIG_SHELL-/bin/sh} $@' \
-  -- $GNULIB_SRCDIR/build-aux/bootstrap \
+  $ignored $GNULIB_SRCDIR/build-aux/bootstrap \
   $0 $@ --no-bootstrap-sync
   }
 fi
-- 
1.8.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 02/01/2013 12:16 AM, Jiri Denemark wrote:
 On Thu, Jan 31, 2013 at 16:34:24 -0700, Eric Blake wrote:
 CVE-2013-0242 in glibc's regex() can cause a DoS in any daemon
 that runs a regex search on user input while in a multibyte locale.
 I'm not sure how hard it would be to trigger such a setup for
 libvirtd, but rather than risk things, we can avoid the issue:
 gnulib has worked around the problem, and by updating to the latest
 gnulib, we can avoid the bug even on platforms where glibc has yet
 to be patched.

 * .gnulib: Update to latest, for various fixes, including regex.
 * bootstrap: Resync from upstream.
 
 ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

CVE-2013-0242 in glibc's regex() can cause a DoS in any daemon
that runs a regex search on user input while in a multibyte locale.
I'm not sure how hard it would be to trigger such a setup for
libvirtd, but rather than risk things, we can avoid the issue:
gnulib has worked around the problem, and by updating to the latest
gnulib, we can avoid the bug even on platforms where glibc has yet
to be patched.

* .gnulib: Update to latest, for various fixes, including regex.
* bootstrap: Resync from upstream.
---

* .gnulib 61c7b1e...a0b25da (45):
   regex: avoid infinite configure test
   openpty: fix bug where HAVE_OPENPTY wasn't defined
   sys_time: port to Solaris 2.6
   regex: test for buffer overrun
   regex: fix buffer overrun in regexp matcher
   mountlist: don't consider devtmpfs as dummy
   futimens-tests, utimens-tests: Depend on gettext.
   test-getpeername: fix typo
   bootstrap: remove the need for a sorted .gitignore
   readlinkat: don't depend on gl_FUNC_OPENAT
   statat: new module, split out from fstatat
   autoupdate
   Fix typo in previous change, by including unistd.h.
   tests: don't assume fd 99 is closed
   Fix ChangeLog typo.
   stpncpy: port to OS X 10.8
   In intro, say only latest mingw is tested.
   unistd: port to recent mingw
   Fix typo in comment.
   largefile: port better to Mac OS X 10.5
   doc: clarify -Werror
   stdint: fix build with Android's Bionic fox x86
   net_if-tests: port to Solaris 7 + GCC 3.4.6
   net_if-tests: port to older Solaris
   system-quote-tests: port to older Solaris
   c-xvasprintf etc.: fix link errors on older Solaris
   locale: port to Solaris 2.6 and 7 + GNU gettext
   autoupdate
   stdlib: port to Solaris 2.6
   Fix misspellings of occurred.
   autoupdate
   autoupdate
   doc: update main copyright year
   doc: improve ISO 8601 discussion
   doc: avoid small caps
   regex: conform to strict C
   gnulib-tool: fix incompatibility with autopoint 0.18.2
   autoupdate
   fprintftime: bring back and reword fwrite comment
   autoupdate
   stdio: remove now-unnecessary stdio.c
   unicodeio: depend on stdio, not ignore-value
   fprintftime: depend on stdio, not ignore-value
   stdint-tests: Fix expanded-before-required-warning. * modules/stdint-tests 
(Depends-on): Use AC_REQUIRE.
   fwrite: silence __wur only for older glibc versions

 .gnulib   |  2 +-
 bootstrap | 44 ++--
 2 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/.gnulib b/.gnulib
index 61c7b1e..a0b25da 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 61c7b1e32e11e9e40b4d59ab888a807620befcd3
+Subproject commit a0b25daf001cb1a0352f329e2b5e1640acc88541
diff --git a/bootstrap b/bootstrap
index 012907a..bee7765 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2012-12-28.10; # UTC
+scriptversion=2013-01-20.16; # UTC

 # Bootstrap this package from checked-out sources.

@@ -306,34 +306,34 @@ if test -n $checkout_only_file  test ! -r 
$checkout_only_file; then
   die Bootstrapping from a non-checked-out distribution is risky.
 fi

-# Ensure that lines starting with ! sort last, per gitignore conventions
-# for whitelisting exceptions after a more generic blacklist pattern.
-sort_patterns() {
-  sort -u $@ | sed '/^!/ {
-H
-d
-  }
-  $ {
-P
-x
-s/^\n//
-  }' | sed '/^$/d'
+# Strip blank and comment lines to leave significant entries.
+gitignore_entries() {
+  sed '/^#/d; /^$/d' $@
 }

-# If $STR is not already on a line by itself in $FILE, insert it,
-# sorting the new contents of the file and replacing $FILE with the result.
-insert_sorted_if_absent() {
+# If $STR is not already on a line by itself in $FILE, insert it at the start.
+# Entries are inserted at the start of the ignore list to ensure existing
+# entries starting with ! are not overridden.  Such entries support
+# whitelisting exceptions after a more generic blacklist pattern.
+insert_if_absent() {
   file=$1
   str=$2
   test -f $file || touch $file
-  echo $str | sort_patterns - $file | cmp -s - $file  /dev/null \
-|| { echo $str | sort_patterns - $file  $file.bak \
-   mv $file.bak $file; } \
-|| die insert_sorted_if_absent $file $str: failed
+  test -r $file || die Error: failed to read ignore file: $file
+  duplicate_entries=$(gitignore_entries $file | sort | uniq -d)
+  if [ $duplicate_entries ] ; then
+die Error: Duplicate entries in $file:  $duplicate_entries
+  fi
+  linesold=$(gitignore_entries $file | wc -l)
+  linesnew=$(echo $str | gitignore_entries - $file | sort -u | wc -l)
+  if [ $linesold != $linesnew ] ; then
+{ echo $str | cat - $file  $file.bak  mv $file.bak $file; } \
+  || die insert_if_absent $file $str: failed
+  fi
 }

 # Adjust $PATTERN for $VC_IGNORE_FILE and insert it with
-# insert_sorted_if_absent.
+# insert_if_absent.
 insert_vc_ignore() {
   vc_ignore_file=$1
   pattern=$2
@@ -344,7 +344,7 @@ insert_vc_ignore() {
 # .gitignore entry.

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Jiri Denemark]

On Thu, Jan 31, 2013 at 16:34:24 -0700, Eric Blake wrote:
 CVE-2013-0242 in glibc's regex() can cause a DoS in any daemon
 that runs a regex search on user input while in a multibyte locale.
 I'm not sure how hard it would be to trigger such a setup for
 libvirtd, but rather than risk things, we can avoid the issue:
 gnulib has worked around the problem, and by updating to the latest
 gnulib, we can avoid the bug even on platforms where glibc has yet
 to be patched.
 
 * .gnulib: Update to latest, for various fixes, including regex.
 * bootstrap: Resync from upstream.

ACK

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Michal Privoznik]

The update results in bootstrap being updated as well.
---
 .gnulib   |  2 +-
 bootstrap | 15 ---
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/.gnulib b/.gnulib
index d245e6d..964bbc2 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit d245e6ddd6ab2624d0d83acd8f111454f984f50f
+Subproject commit 964bbc2d419584e93fe629ddbc40595612f62083
diff --git a/bootstrap b/bootstrap
index e3e270b..c84d249 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2012-07-19.14; # UTC
+scriptversion=2012-12-28.10; # UTC
 
 # Bootstrap this package from checked-out sources.
 
@@ -889,20 +889,21 @@ find $m4_base $source_base \
   -depth \( -name '*.m4' -o -name '*.[ch]' \) \
   -type l -xtype l -delete  /dev/null 21
 
+# Invoke autoreconf with --force --install to ensure upgrades of tools
+# such as ylwrap.
+AUTORECONFFLAGS=--verbose --install --force -I $m4_base $ACLOCAL_FLAGS
+
 # Some systems (RHEL 5) are using ancient autotools, for which the
 # --no-recursive option had not been invented.  Detect that lack and
 # omit the option when it's not supported.  FIXME in 2017: remove this
 # hack when RHEL 5 autotools are updated, or when they become irrelevant.
-no_recursive=
 case $($AUTORECONF --help) in
-  *--no-recursive*) no_recursive=--no-recursive;;
+  *--no-recursive*) AUTORECONFFLAGS=$AUTORECONFFLAGS --no-recursive;;
 esac
 
 # Tell autoreconf not to invoke autopoint or libtoolize; they were run above.
-echo running: AUTOPOINT=true LIBTOOLIZE=true  \
-$AUTORECONF --verbose --install $no_recursive -I $m4_base $ACLOCAL_FLAGS
-AUTOPOINT=true LIBTOOLIZE=true \
-$AUTORECONF --verbose --install $no_recursive -I $m4_base $ACLOCAL_FLAGS \
+echo running: AUTOPOINT=true LIBTOOLIZE=true $AUTORECONF $AUTORECONFFLAGS
+AUTOPOINT=true LIBTOOLIZE=true $AUTORECONF $AUTORECONFFLAGS \
   || die autoreconf failed
 
 # Get some extra files from gnulib, overriding existing files.
-- 
1.8.0.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 01/02/2013 08:39 AM, Michal Privoznik wrote:
 The update results in bootstrap being updated as well.
 ---
  .gnulib   |  2 +-
  bootstrap | 15 ---
  2 files changed, 9 insertions(+), 8 deletions(-)

Phooey, when trying this, I see:

configure.ac:126: warning: gl_INLINE is m4_require'd but not m4_defun'd
gnulib/m4/xalloc.m4:14: gl_PREREQ_XALLOC is expanded from...
gnulib/m4/xalloc.m4:7: gl_XALLOC is expanded from...
gnulib/m4/gnulib-comp.m4:501: gl_INIT is expanded from...
configure.ac:126: the top level

which looks like a gnulib bug.  I'm investigating what it would take to
fix gnulib; but agree that we need something soon to fix the 'make
syntax-check' failures now that gnulib has changed copyright year to 2013.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

'make syntax-check' warned that gnulib's copyright is now out of date.

* .gnulib: Update to latest, for copyright year bump.
* gnulib/local/m4/ssize_t.m4.diff: Regenerate.
* bootstrap: Synchronize from upstream.
---

 configure.ac:126: warning: gl_INLINE is m4_require'd but not m4_defun'd

Turns out it wasn't an upstream gnulib problem, but a problem with
our gnulib-local patch not applying which in turn killed gnulib-tool
and failed to pull in the needed updates.

I'm pushing this under the build-breaker rule.

 .gnulib |  2 +-
 bootstrap   | 17 +
 gnulib/local/m4/ssize_t.m4.diff |  2 +-
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/.gnulib b/.gnulib
index d245e6d..964bbc2 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit d245e6ddd6ab2624d0d83acd8f111454f984f50f
+Subproject commit 964bbc2d419584e93fe629ddbc40595612f62083
diff --git a/bootstrap b/bootstrap
index e3e270b..012907a 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,10 +1,10 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2012-07-19.14; # UTC
+scriptversion=2012-12-28.10; # UTC

 # Bootstrap this package from checked-out sources.

-# Copyright (C) 2003-2012 Free Software Foundation, Inc.
+# Copyright (C) 2003-2013 Free Software Foundation, Inc.

 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -889,20 +889,21 @@ find $m4_base $source_base \
   -depth \( -name '*.m4' -o -name '*.[ch]' \) \
   -type l -xtype l -delete  /dev/null 21

+# Invoke autoreconf with --force --install to ensure upgrades of tools
+# such as ylwrap.
+AUTORECONFFLAGS=--verbose --install --force -I $m4_base $ACLOCAL_FLAGS
+
 # Some systems (RHEL 5) are using ancient autotools, for which the
 # --no-recursive option had not been invented.  Detect that lack and
 # omit the option when it's not supported.  FIXME in 2017: remove this
 # hack when RHEL 5 autotools are updated, or when they become irrelevant.
-no_recursive=
 case $($AUTORECONF --help) in
-  *--no-recursive*) no_recursive=--no-recursive;;
+  *--no-recursive*) AUTORECONFFLAGS=$AUTORECONFFLAGS --no-recursive;;
 esac

 # Tell autoreconf not to invoke autopoint or libtoolize; they were run above.
-echo running: AUTOPOINT=true LIBTOOLIZE=true  \
-$AUTORECONF --verbose --install $no_recursive -I $m4_base $ACLOCAL_FLAGS
-AUTOPOINT=true LIBTOOLIZE=true \
-$AUTORECONF --verbose --install $no_recursive -I $m4_base $ACLOCAL_FLAGS \
+echo running: AUTOPOINT=true LIBTOOLIZE=true $AUTORECONF $AUTORECONFFLAGS
+AUTOPOINT=true LIBTOOLIZE=true $AUTORECONF $AUTORECONFFLAGS \
   || die autoreconf failed

 # Get some extra files from gnulib, overriding existing files.
diff --git a/gnulib/local/m4/ssize_t.m4.diff b/gnulib/local/m4/ssize_t.m4.diff
index d0ae286..93f8ad7 100644
--- a/gnulib/local/m4/ssize_t.m4.diff
+++ b/gnulib/local/m4/ssize_t.m4.diff
@@ -5,7 +5,7 @@ index 209d64c..5ea72a1 100644
 @@ -1,4 +1,4 @@
 -# ssize_t.m4 serial 5 (gettext-0.18.2)
 +# ssize_t.m4 serial 6 (gettext-0.18.2)
- dnl Copyright (C) 2001-2003, 2006, 2010-2012 Free Software Foundation, Inc.
+ dnl Copyright (C) 2001-2003, 2006, 2010-2013 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
 @@ -17,7 +17,21 @@ AC_DEFUN([gt_TYPE_SSIZE_T],
-- 
1.8.0.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

* .gnulib: Update to latest, prior to freeze.
---

Gnulib has been relatively quiet since our last update, and I'm not
sure whether any of these patches directly impact us, but it can't
hurt to have the latest going into a freeze for 1.0.0.

* .gnulib 2a9edc6...d245e6d (14):
   euidaccess: speed up 'configure' on GNU hosts
   * lib/regexec.c (re_search_internal): Fix grammar in comment.
   fchmodat, fchownat, fstatat: port to non-inlining compilers
   fchmodat.c, fchownat.c: fix compile-impeding typos
   fcntl-h: support GNU flags like O_IGNORE_CTTY
   faccessat, etc.: support AT_FDCWD-only use
   faccessat: speed up 'configure' on mainstream hosts
   faccessat: port to Solaris 10
   canonicalize: fix C89 compilation
   autoupdate
   group-member: omit unnecessary dependencies
   gethrxtime: port to C++
   ptsname: fix macro-name typo
   inttostr: Relax license.

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 2a9edc6..d245e6d 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 2a9edc6f2b02a05553d266117ddee80b3e0a3749
+Subproject commit d245e6ddd6ab2624d0d83acd8f111454f984f50f
-- 
1.7.11.7

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Peter Krempa]

On 10/22/12 23:04, Eric Blake wrote:

* .gnulib: Update to latest, prior to freeze.
---

Gnulib has been relatively quiet since our last update, and I'm not
sure whether any of these patches directly impact us, but it can't
hurt to have the latest going into a freeze for 1.0.0.



Shouldn't hurt.

ACK.

Peter

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 10/22/2012 03:48 PM, Peter Krempa wrote:
 On 10/22/12 23:04, Eric Blake wrote:
 * .gnulib: Update to latest, prior to freeze.
 ---

 Gnulib has been relatively quiet since our last update, and I'm not
 sure whether any of these patches directly impact us, but it can't
 hurt to have the latest going into a freeze for 1.0.0.

 
 Shouldn't hurt.
 
 ACK.

Thanks; pushed.

-- 
Eric Blake   ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

* .gnulib: Update to latest.
---

I'm not sure if any of these are essential for libvirt, but it's
probably nicer to pick up these fixes before the release than to
find out after the release that we wish we had them.

* .gnulib a6b16b6...da1717b (63):
   Doc about crypt functions.
   gc: Fix copyright header.
   pthread: Determine $(LIB_PTHREAD) correctly on OSF/1 5.1.
   openat: Work around compilation error with OSF/1 5.1 DTK cc.
   Revert last commit.
   openat: Work around compilation error with OSF/1 5.1 DTK cc.
   parse-datetime: document the newly accepted format
   autoupdate
   acl: Fix a test failure on newer Solaris 10 with ZFS.
   acl: Update for AIX = 5.3 with NFS.
   acl: Fix a test failure on AIX = 5.3 with NFS.
   acl: Fix a test failure on IRIX 6.5 with NFS.
   openat: port to AIX 7.1 with large files
   acl: Avoid errors on NonStop Kernel.
   acl: Clean up Solaris code.
   acl: Fix a bug with NFSv4 ACLs on Solaris 10 (newer version).
   acl: Improve support of NFSv4 ACLs on Solaris 10 (newer version).
   copy-file: Try unit tests on more file systems.
   acl: Try unit tests on more file systems.
   acl: Remove unused code in last commit.
   acl: Improve support of NFSv4 ACLs on Solaris 10 (newer version).
   openat: test for fstatat (..., 0) bug
   openat: test for fstatat (AT_FDCWD, ..., 0) bug
   avoid literal : in index entries
   Allow the user to override the choice of AR, ARFLAGS, RANLIB.
   Find 'ar' program that fits with --host argument.
   tests: init.sh: Support any non-GNU diff.
   tests: init.sh: work also with any non-GNU diff that supports -u
   strtoimax, strtoumax: Document problem on HP-UX 11.
   strtoumax: Avoid link error on OSF/1 with DTK cc.
   strtoimax: Avoid link error on OSF/1 with DTK cc.
   imaxdiv: Avoid link error on OSF/1 with DTK cc.
   imaxabs: Avoid link error on OSF/1 with DTK cc.
   Tests for module 'strtoumax'.
   Tests for module 'strtoimax'.
   Tests for module 'imaxdiv'.
   Tests for module 'imaxabs'.
   pthread: Determine $(LIB_PTHREAD) correctly on IRIX 6.5.
   * lib/fstatat.c: Include sys/types.h before sys/stat.h.
   openat: work around AIX 7.1 fstatat issue
   sys_select: Avoid a syntax error regarding timespec_t on IRIX 6.5.
   tests: avoid spurious assertion failure in test-float.c on ppc64
   maint: indent with spaces, not TABs
   test-parse-datetime.c: accommodate a relatively strict gcc warning
   parse-datetime: accept ISO 8601 date and time rep with T separator
   freopen: Documentation.
   freopen: Don't crash if the filename argument is NULL.
   openat: work around AIX 7.1 fstatat bug
   Avoid endless recursions if config.h includes some header files.
   autoupdate ylwrap
   autoupdate ylwrap
   autoupdate
   tmpdir: Use a good default directory on native Windows.
   autoupdate
   doc: fix typo in README-release
   fts: do not exhaust memory when processing million-entry directories
   maint: fts: move decl of `dp' down into while loop; split a long line
   fts: add/use new struct member, fts_dirp
   maint: fts: give __opendir2 a new parameter and rename
   maint: fts.c: remove __opendir2's now-unused parameter, oflag
   maint: fts.c: correct off-by-one indentation
   maint: fts.c: move __opendir2 #define up out of function body
   maint: fts.c: remove #if-0'd FTS_WHITEOUT code

 .gnulib |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/.gnulib b/.gnulib
index a6b16b6..da1717b 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit a6b16b69fe1cad695b270dd5bf3deb2850fc4dd1
+Subproject commit da1717b7f93b77469f980ea5e13178e4e9e7ae09
-- 
1.7.4.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Daniel Veillard]

On Thu, Sep 08, 2011 at 01:59:54PM +0100, Eric Blake wrote:
 * .gnulib: Update to latest.
 ---
 
 I'm not sure if any of these are essential for libvirt, but it's
 probably nicer to pick up these fixes before the release than to
 find out after the release that we wish we had them.

 yes definitely,

 ACK,

Daniel

-- 
Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 09/08/2011 02:23 PM, Daniel Veillard wrote:

On Thu, Sep 08, 2011 at 01:59:54PM +0100, Eric Blake wrote:

* .gnulib: Update to latest.
---

I'm not sure if any of these are essential for libvirt, but it's
probably nicer to pick up these fixes before the release than to
find out after the release that we wish we had them.


  yes definitely,

  ACK,


Pushed.

--
Eric Blake   ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

* .gnulib: Update to latest, for at least a stdint.h fix
* src/storage/storage_driver.c (storageVolumeZeroSparseFile)
(storageWipeExtent): Use better type, although it still triggers
spurious -Wformat warning on MacOS's gcc.
---

* .gnulib 48b1a1a...6491120 (47):
   unistr/u8-strcmp: Avoid collision with libc function on Solaris 11.
   Update internal documentation.
   Put more information about failed tests into the test return codes.
   Update for Solaris 11 2010-11.
   nproc: Relax license.
   maint: restore executable bit
   utimecmp: fine-grained src to nearby coarse-grained dest
   strerror_r-posix: Fix autoconf test.
   Tests for module 'getdomainname'.
   getdomainname: Use the system function when possible.
   sys_socket: Ensure ss_family field on AIX.
   readline: Improve configure output.
   *printf-posix: Detect a bug on Solaris 10/x86.
   Fix link error when module libunistring-optional is in use.
   regex: Mention link dependencies.
   ftoastr: Fix compilation error on Solaris.
   Oops, fix typo in last commit.
   autoupdate
   autoupdate
   getloadavg: Update documentation.
   sys_socket: Fix test whether the functions are declared.
   getpass: Make sure to get system declaration on some platforms.
   iconv-h: Fix test-iconv-h-c++ failure on Solaris 11 2010-11.
   ftoastr: comment fix
   stdint: port to GCC 4.3 + OSX + Octave
   doc: Corrections regarding MacOS X 10.4 and 10.5.
   autoupdate
   Uninstall .bin files installed by relocwrapper.
   Update for NetBSD 5.0.
   Update for HP-UX 11.23 and HP-UX 11.31.
   Update for MacOS X 10.5.
   bootstrap: add bootstrap_sync option.
   Oops, fix incomplete ChangeLog entry.
   Ensure that features.h is included before __GLIBC__ is tested.
   memmem: Fix autoconf test.
   Port to uClibc.
   nproc: Fix condition.
   Fix a comment. * lib/vasnprintf.c (VASNPRINTF): Fix comment.
   ftoastr: don't assume snprintf
   test-rename.h: fix compilation failure
   maint.mk: add a URL discussing the n...@acronym policy
   ftoastr: depend on snprintf, improve comments
   ftoastr: port to hosts lacking strtof and strtold
   c-strtold: Avoid link error on AIX 7.
   intprops: new macro INT_BITS_STRLEN_BOUND
   ftoastr: new module, for lossless conversion of floats to short strings
   autoupdate

 .gnulib  |2 +-
 src/storage/storage_driver.c |6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.gnulib b/.gnulib
index 48b1a1a..6491120 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 48b1a1ae7d5b0f1494aabd4c8a02fbfcec531026
+Subproject commit 64911207854610668b480939469282fdaeb96f74
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 0f099f0..67d043b 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -1575,7 +1575,7 @@ storageVolumeZeroSparseFile(virStorageVolDefPtr vol,
 virReportSystemError(errno,
  _(Failed to truncate volume with 
path '%s' to %ju bytes),
- vol-target.path, (intmax_t)size);
+ vol-target.path, (uintmax_t)size);
 }

 out:
@@ -1597,13 +1597,13 @@ storageWipeExtent(virStorageVolDefPtr vol,
 size_t write_size = 0;

 VIR_DEBUG(extent logical start: %ju len: %ju,
-  (intmax_t)extent_start, (intmax_t)extent_length);
+  (uintmax_t)extent_start, (uintmax_t)extent_length);

 if ((ret = lseek(fd, extent_start, SEEK_SET))  0) {
 virReportSystemError(errno,
  _(Failed to seek to position %ju in volume 
with path '%s'),
- (intmax_t)extent_start, vol-target.path);
+ (uintmax_t)extent_start, vol-target.path);
 goto out;
 }

-- 
1.7.3.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Justin Clift]

On 08/12/2010, at 11:32 AM, Eric Blake wrote:
 * .gnulib: Update to latest, for at least a stdint.h fix

Thanks for spending the time on this Eric.

ACK to this.

snip
 diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
 index 0f099f0..67d043b 100644
 --- a/src/storage/storage_driver.c
 +++ b/src/storage/storage_driver.c
 @@ -1575,7 +1575,7 @@ storageVolumeZeroSparseFile(virStorageVolDefPtr vol,
 virReportSystemError(errno,
  _(Failed to truncate volume with 
path '%s' to %ju bytes),
 - vol-target.path, (intmax_t)size);
 + vol-target.path, (uintmax_t)size);
 }
 
 out:
 @@ -1597,13 +1597,13 @@ storageWipeExtent(virStorageVolDefPtr vol,
 size_t write_size = 0;
 
 VIR_DEBUG(extent logical start: %ju len: %ju,
 -  (intmax_t)extent_start, (intmax_t)extent_length);
 +  (uintmax_t)extent_start, (uintmax_t)extent_length);
 
 if ((ret = lseek(fd, extent_start, SEEK_SET))  0) {
 virReportSystemError(errno,
  _(Failed to seek to position %ju in volume 
with path '%s'),
 - (intmax_t)extent_start, vol-target.path);
 + (uintmax_t)extent_start, vol-target.path);
 goto out;
 }

This seems safe too.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 12/07/2010 06:01 PM, Justin Clift wrote:
 On 08/12/2010, at 11:32 AM, Eric Blake wrote:
 * .gnulib: Update to latest, for at least a stdint.h fix
 
 Thanks for spending the time on this Eric.
 
 ACK to this.

Thanks; pushed.

-- 
Eric Blake   ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

* cfg.mk (gnulib_dir): Override default in maint.mk.
* .gnulib: Update to latest.
Reported by Jim Meyering.
---

Update to the latest gnulib for some portability fixes.  Thankfully,
we already pass all of the new syntax checks, but Jim did note (on
the gnulib list) that we failed to define $(gnulib_dir) correctly.

 .gnulib |2 +-
 cfg.mk  |3 +++
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/.gnulib b/.gnulib
index 7c1b995..411e141 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 7c1b995a7041ea366acafeb8632e1080f349f03f
+Subproject commit 411e141164861435385bb9bbb10012da28a077c0
diff --git a/cfg.mk b/cfg.mk
index 105b625..9e8909b 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -24,6 +24,9 @@ gnu_rel_host = $(gnu_ftp_host-$(RELEASE_TYPE))
 url_dir_list = \
   ftp://$(gnu_rel_host)/gnu/coreutils

+# We use .gnulib, not gnulib.
+gnulib_dir = $(srcdir)/.gnulib
+
 # Tests not to run as part of make distcheck.
 local-checks-to-skip = \
   changelog-check  \
-- 
1.6.6.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list