Re: [libvirt] [PATCH] news: Add TLS non-shared storage migration
On Thu, 2018-05-24 at 07:26 +0200, Peter Krempa wrote: > On Wed, May 23, 2018 at 18:40:00 +0200, Andrea Bolognani wrote: > > This would be more consistent with the rest of the entries, and > > easier to quickly scan over, written as > > > > qemu: Add support for migration of VMs with non-shared storage > > over TLS > > I must say I don't like the lazy format that is usually just copypasted > series heading. In some cases it is not informative enough for > non-developers. Using this format which looks awfully close to the > convention on the mailing list encourages this laziness. I see your point; however, using that format is helpful for users for the same reasons it's helpful for developers, so moving away from it would be a big step backwards IMHO. What we can do is point out, during review, if a release notes item goes into implementation details which are not relevant to users or require too much in-depth knowledge to be understood. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: Add TLS non-shared storage migration
On Wed, May 23, 2018 at 18:40:00 +0200, Andrea Bolognani wrote: > On Wed, 2018-05-23 at 16:59 +0200, Peter Krempa wrote: > > Signed-off-by: Peter Krempa> > --- > > docs/news.xml | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/docs/news.xml b/docs/news.xml > > index 8f2c7d5dff..329b1c7129 100644 > > --- a/docs/news.xml > > +++ b/docs/news.xml > > @@ -54,6 +54,16 @@ > >a QEMU virtual machine. > > > > > > + > > + > > + Add support for migration of QEMU VMs with non-shared > storage over TLS > > This would be more consistent with the rest of the entries, and > easier to quickly scan over, written as > > qemu: Add support for migration of VMs with non-shared storage > over TLS > > With that changed, I must say I don't like the lazy format that is usually just copypasted series heading. In some cases it is not informative enough for non-developers. Using this format which looks awfully close to the convention on the mailing list encourages this laziness. I'll change it for the sake of consistency though. > > Reviewed-by: Andrea Bolognani > > -- > Andrea Bolognani / Red Hat / Virtualization > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: Add TLS non-shared storage migration
On Wed, 2018-05-23 at 16:59 +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa> --- > docs/news.xml | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 8f2c7d5dff..329b1c7129 100644 > --- a/docs/news.xml > +++ b/docs/news.xml > @@ -54,6 +54,16 @@ >a QEMU virtual machine. > > > + > + > + Add support for migration of QEMU VMs with non-shared storage over TLS This would be more consistent with the rest of the entries, and easier to quickly scan over, written as qemu: Add support for migration of VMs with non-shared storage over TLS With that changed, Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] news: Add TLS non-shared storage migration
Signed-off-by: Peter Krempa--- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 8f2c7d5dff..329b1c7129 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -54,6 +54,16 @@ a QEMU virtual machine. + + + Add support for migration of QEMU VMs with non-shared storage over TLS + + + It's now possible to use the VIR_MIGRATE_TLS flag together with + VIR_MIGRATE_NON_SHARED_DISK. The connection is then secured using the + TLS environment which is setup for the migration connection. + + -- 2.16.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list